1. 19 Jun, 2019 4 commits
    • Benjamin Tissoires's avatar
      HID: input: fix assignment of .value · 0e3b0666
      Benjamin Tissoires authored
      commit 39b3c3a5 upstream.
      
      The value field is actually an array of .maxfield. We should assign the
      correct number to the correct usage.
      
      Not that we never encounter a device that requires this ATM, but better
      have the proper code path.
      
      Fixes: 2dc702c9 ("HID: input: use the Resolution Multiplier for
             high-resolution scrolling")
      Cc: stable@vger.kernel.org  # v5.0+
      Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      0e3b0666
    • Benjamin Tissoires's avatar
      HID: input: make sure the wheel high resolution multiplier is set · 76f693f0
      Benjamin Tissoires authored
      commit d43c17ea upstream.
      
      Some old mice have a tendency to not accept the high resolution multiplier.
      They reply with a -EPIPE which was previously ignored.
      
      Force the call to resolution multiplier to be synchronous and actually
      check for the answer. If this fails, consider the mouse like a normal one.
      
      Fixes: 2dc702c9 ("HID: input: use the Resolution Multiplier for
             high-resolution scrolling")
      Link: https://bugzilla.redhat.com/show_bug.cgi?id=1700071Reported-and-tested-by: default avatarJames Feeney <james@nurealm.net>
      Cc: stable@vger.kernel.org  # v5.0+
      Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      76f693f0
    • Thomas Backlund's avatar
      nouveau: Fix build with CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT disabled · 2bf61c27
      Thomas Backlund authored
      Not-entirely-upstream-sha1-but-equivalent: bed2dd84
      ("drm/ttm: Quick-test mmap offset in ttm_bo_mmap()")
      
      Setting CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT=n (added by commit: b30a43ac)
      causes the build to fail with:
      
      ERROR: "drm_legacy_mmap" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
      
      This does not happend upstream as the offending code got removed in:
      bed2dd84 ("drm/ttm: Quick-test mmap offset in ttm_bo_mmap()")
      
      Fix that by adding check for CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT around
      the drm_legacy_mmap() call.
      
      Also, as Sven Joachim pointed out, we need to make the check in
      CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT=n case return -EINVAL as its done
      for basically all other gpu drivers, especially in upstream kernels
      drivers/gpu/drm/ttm/ttm_bo_vm.c as of the upstream commit bed2dd84.
      
      NOTE. This is a minimal stable-only fix for trees where b30a43ac is
      backported as the build error affects nouveau only.
      
      Fixes: b30a43ac ("drm/nouveau: add kconfig option to turn off nouveau
             legacy contexts. (v3)")
      Signed-off-by: default avatarThomas Backlund <tmb@mageia.org>
      Cc: stable@vger.kernel.org
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Cc: Sven Joachim <svenjoac@gmx.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2bf61c27
    • Dave Airlie's avatar
      drm/nouveau: add kconfig option to turn off nouveau legacy contexts. (v3) · 3b0a591c
      Dave Airlie authored
      commit b30a43ac upstream.
      
      There was a nouveau DDX that relied on legacy context ioctls to work,
      but we fixed it years ago, give distros that have a modern DDX the
      option to break the uAPI and close the mess of holes that legacy
      context support is.
      
      Full context of the story:
      
      commit 0e975980
      Author: Peter Antoine <peter.antoine@intel.com>
      Date:   Tue Jun 23 08:18:49 2015 +0100
      
          drm: Turn off Legacy Context Functions
      
          The context functions are not used by the i915 driver and should not
          be used by modeset drivers. These driver functions contain several bugs
          and security holes. This change makes these functions optional can be
          turned on by a setting, they are turned off by default for modeset
          driver with the exception of the nouvea driver that may require them with
          an old version of libdrm.
      
          The previous attempt was
      
          commit 7c510133
          Author: Daniel Vetter <daniel.vetter@ffwll.ch>
          Date:   Thu Aug 8 15:41:21 2013 +0200
      
              drm: mark context support as a legacy subsystem
      
          but this had to be reverted
      
          commit c21eb21c
          Author: Dave Airlie <airlied@redhat.com>
          Date:   Fri Sep 20 08:32:59 2013 +1000
      
              Revert "drm: mark context support as a legacy subsystem"
      
          v2: remove returns from void function, and formatting (Daniel Vetter)
      
          v3:
          - s/Nova/nouveau/ in the commit message, and add references to the
            previous attempts
          - drop the part touching the drm hw lock, that should be a separate
            patch.
      
          Signed-off-by: Peter Antoine <peter.antoine@intel.com> (v2)
          Cc: Peter Antoine <peter.antoine@intel.com> (v2)
      Reviewed-by: default avatarPeter Antoine <peter.antoine@intel.com>
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      
      v2: move DRM_VM dependency into legacy config.
      v3: fix missing dep (kbuild robot)
      
      Cc: stable@vger.kernel.org
      Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      3b0a591c
  2. 17 Jun, 2019 5 commits
  3. 15 Jun, 2019 31 commits