1. 24 Mar, 2023 2 commits
    • Liam R. Howlett's avatar
      maple_tree: fix mas_skip_node() end slot detection · 0fa99fdf
      Liam R. Howlett authored
      Patch series "Fix mas_skip_node() for mas_empty_area()", v2.
      
      mas_empty_area() was incorrectly returning an error when there was room. 
      The issue was tracked down to mas_skip_node() using the incorrect
      end-of-slot count.  Instead of using the nodes hard limit, the limit of
      data should be used.
      
      mas_skip_node() was also setting the min and max to that of the child
      node, which was unnecessary.  Within these limits being set, there was
      also a bug that corrupted the maple state's max if the offset was set to
      the maximum node pivot.  The bug was without consequence unless there was
      a sufficient gap in the next child node which would cause an error to be
      returned.
      
      This patch set fixes these errors by removing the limit setting from
      mas_skip_node() and uses the mas_data_end() for slot limits, and adds
      tests for all failures discovered.
      
      
      This patch (of 2):
      
      mas_skip_node() is used to move the maple state to the node with a higher
      limit.  It does this by walking up the tree and increasing the slot count.
      Since slot count may not be able to be increased, it may need to walk up
      multiple times to find room to walk right to a higher limit node.  The
      limit of slots that was being used was the node limit and not the last
      location of data in the node.  This would cause the maple state to be
      shifted outside actual data and enter an error state, thus returning
      -EBUSY.
      
      The result of the incorrect error state means that mas_awalk() would
      return an error instead of finding the allocation space.
      
      The fix is to use mas_data_end() in mas_skip_node() to detect the nodes
      data end point and continue walking the tree up until it is safe to move
      to a node with a higher limit.
      
      The walk up the tree also sets the maple state limits so remove the buggy
      code from mas_skip_node().  Setting the limits had the unfortunate side
      effect of triggering another bug if the parent node was full and the there
      was no suitable gap in the second last child, but room in the next child.
      
      mas_skip_node() may also be passed a maple state in an error state from
      mas_anode_descend() when no allocations are available.  Return on such an
      error state immediately.
      
      Link: https://lkml.kernel.org/r/20230307180247.2220303-1-Liam.Howlett@oracle.com
      Link: https://lkml.kernel.org/r/20230307180247.2220303-2-Liam.Howlett@oracle.com
      Fixes: 54a611b6 ("Maple Tree: add new data structure")
      Signed-off-by: default avatarLiam R. Howlett <Liam.Howlett@oracle.com>
      Reported-by: default avatarSnild Dolkow <snild@sony.com>
        Link: https://lore.kernel.org/linux-mm/cb8dc31a-fef2-1d09-f133-e9f7b9f9e77a@sony.com/Tested-by: default avatarSnild Dolkow <snild@sony.com>
      Cc: Peng Zhang <zhangpeng.00@bytedance.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      0fa99fdf
    • Michal Hocko's avatar
      mm, vmalloc: fix high order __GFP_NOFAIL allocations · e9c3cda4
      Michal Hocko authored
      Gao Xiang has reported that the page allocator complains about high order
      __GFP_NOFAIL request coming from the vmalloc core:
      
       __alloc_pages+0x1cb/0x5b0 mm/page_alloc.c:5549
       alloc_pages+0x1aa/0x270 mm/mempolicy.c:2286
       vm_area_alloc_pages mm/vmalloc.c:2989 [inline]
       __vmalloc_area_node mm/vmalloc.c:3057 [inline]
       __vmalloc_node_range+0x978/0x13c0 mm/vmalloc.c:3227
       kvmalloc_node+0x156/0x1a0 mm/util.c:606
       kvmalloc include/linux/slab.h:737 [inline]
       kvmalloc_array include/linux/slab.h:755 [inline]
       kvcalloc include/linux/slab.h:760 [inline]
      
      it seems that I have completely missed high order allocation backing
      vmalloc areas case when implementing __GFP_NOFAIL support.  This means
      that [k]vmalloc at al.  can allocate higher order allocations with
      __GFP_NOFAIL which can trigger OOM killer for non-costly orders easily or
      cause a lot of reclaim/compaction activity if those requests cannot be
      satisfied.
      
      Fix the issue by falling back to zero order allocations for __GFP_NOFAIL
      requests if the high order request fails.
      
      Link: https://lkml.kernel.org/r/ZAXynvdNqcI0f6Us@dhcp22.suse.cz
      Fixes: 9376130c ("mm/vmalloc: add support for __GFP_NOFAIL")
      Reported-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
        Link: https://lkml.kernel.org/r/20230305053035.1911-1-hsiangkao@linux.alibaba.comSigned-off-by: default avatarMichal Hocko <mhocko@suse.com>
      Reviewed-by: default avatarUladzislau Rezki (Sony) <urezki@gmail.com>
      Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
      Cc: Baoquan He <bhe@redhat.com>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: Mel Gorman <mgorman@techsingularity.net>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      e9c3cda4
  2. 23 Mar, 2023 3 commits
  3. 22 Mar, 2023 3 commits
  4. 21 Mar, 2023 7 commits
  5. 20 Mar, 2023 6 commits
  6. 19 Mar, 2023 18 commits
  7. 18 Mar, 2023 1 commit
    • Linus Torvalds's avatar
      Merge tag 'fbdev-for-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev · a3671bd8
      Linus Torvalds authored
      Pull fbdev fixes from Helge Deller:
       "The majority of lines changed is due to a code style cleanup in the
        pnmtologo helper program.
      
        Arnd removed the omap1 osk driver and the SIS fb driver is now
        orphaned.
      
        Other than that it's the usual bunch of small fixes and cleanups, e.g.
        prevent possible divide-by-zero in various fb drivers if the pixclock
        is zero and various conversions to devm_platform*() and of_property*()
        functions:
      
         - Drop omap1 osk driver
      
         - Various potential divide by zero pixclock fixes
      
         - Add pixelclock and fb_check_var() to stifb
      
         - Code style cleanups and indenting fixes"
      
      * tag 'fbdev-for-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev:
        fbdev: Use of_property_present() for testing DT property presence
        fbdev: au1200fb: Fix potential divide by zero
        fbdev: lxfb: Fix potential divide by zero
        fbdev: intelfb: Fix potential divide by zero
        fbdev: nvidia: Fix potential divide by zero
        fbdev: stifb: Provide valid pixelclock and add fb_check_var() checks
        fbdev: omapfb: remove omap1 osk driver
        fbdev: xilinxfb: Use devm_platform_get_and_ioremap_resource()
        fbdev: wm8505fb: Use devm_platform_ioremap_resource()
        fbdev: pxa3xx-gcu: Use devm_platform_get_and_ioremap_resource()
        fbdev: Use of_property_read_bool() for boolean properties
        fbdev: clps711x-fb: Use devm_platform_get_and_ioremap_resource()
        fbdev: tgafb: Fix potential divide by zero
        MAINTAINERS: orphan SIS FRAMEBUFFER DRIVER
        fbdev: omapfb: cleanup inconsistent indentation
        drivers: video: logo: add SPDX comment, remove GPL notice in pnmtologo.c
        drivers: video: logo: fix code style issues in pnmtologo.c
      a3671bd8