- 30 Jul, 2020 1 commit
-
-
YueHaibing authored
If CONFIG_SERIAL_EARLYCON is not set, gcc warns this: drivers/soc/qcom/qcom-geni-se.c: In function 'geni_se_probe' drivers/soc/qcom/qcom-geni-se.c:914:1: warning: label 'exit' defined but not used [-Wunused-label] exit: ^~~~ Fixes: 048eb908 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash") Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Link: https://lore.kernel.org/r/20200722020619.25988-1-yuehaibing@huawei.comSigned-off-by:
Bjorn Andersson <bjorn.andersson@linaro.org>
-
- 29 Jul, 2020 1 commit
-
-
Krzysztof Kozlowski authored
Fix W=1 compile warnings (invalid kerneldoc): drivers/soc/qcom/smd-rpm.c:35: warning: Function parameter or member 'dev' not described in 'qcom_smd_rpm' drivers/soc/qcom/smd-rpm.c:99: warning: Function parameter or member 'state' not described in 'qcom_rpm_smd_write' Signed-off-by:Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20200729074415.28393-2-krzk@kernel.orgSigned-off-by:
-
- 28 Jul, 2020 1 commit
-
-
Sibi Sankar authored
The Protection Domains (PD) have a mechanism to keep its resources enabled until the PD down indication is acked. Reorder the PD state indication ack so that clients get to release the relevant resources before the PD goes down. Reviewed-by:
Rishabh Bhatnagar <rishabhb@codeaurora.org> Fixes: fbe639b4 ("soc: qcom: Introduce Protection Domain Restart helpers") Reported-by:
Sibi Sankar <sibis@codeaurora.org> Link: https://lore.kernel.org/r/20200701195954.9007-1-sibis@codeaurora.orgSigned-off-by:
-
- 22 Jul, 2020 3 commits
-
-
Kathiravan T authored
Convert the qcom,smd-rpm.txt document to YAML schema Reviewed-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Kathiravan T <kathirav@codeaurora.org> Link: https://lore.kernel.org/r/1595225543-12127-4-git-send-email-kathirav@codeaurora.orgSigned-off-by:
-
Kathiravan T authored
This patch adds a compatible for the rpm on the Qualcomm IPQ6018 platform. Signed-off-by:
-
Kathiravan T authored
This patch adds the dt-binding for the rpm on the Qualcomm IPQ6018 platform. Signed-off-by:
-
- 20 Jul, 2020 1 commit
-
-
Akash Asthana authored
pdev struct doesn't exits for the devices whose status are disabled from DT node, in such cases NULL is returned from 'of_find_device_by_node' Later when we try to get drvdata from pdev struct NULL pointer dereference is triggered. Add a NULL check for return values to fix the issue. We were hitting this issue when one of QUP is disabled. Reviewed-by:
Matthias Kaehlcke <mka@chromium.org> Reviewed-by:
Sai Prakash Ranjan <saipraka@codeaurora.org> Signed-off-by:
Akash Asthana <akashast@codeaurora.org> Link: https://lore.kernel.org/r/1594996342-26964-1-git-send-email-akashast@codeaurora.org [bjorn: s/wrapper_pdev/pdev/] Signed-off-by:
-
- 14 Jul, 2020 1 commit
-
-
Rajendra Nayak authored
When using the geni-serial as console, its important to be able to hit the lowest possible power state in suspend, even with no_console_suspend. The only thing that prevents it today on platforms like the sc7180 is the interconnect BW votes, which we certainly don't need when the system is in suspend. So in the suspend handler mark them as ACTIVE_ONLY (0x3) and on resume switch them back to the ALWAYS tag (0x7) Signed-off-by:
Rajendra Nayak <rnayak@codeaurora.org> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://lore.kernel.org/r/1594704709-26072-1-git-send-email-rnayak@codeaurora.orgSigned-off-by:
-
- 13 Jul, 2020 10 commits
-
-
Douglas Anderson authored
The geni serial driver had a rule that we'd only use 1 byte per FIFO word for the TX FIFO if we were being used for the serial console. This is ugly and a bit of a pain. It's not too hard to fix, so fix it. Acked-by:
Evan Green <evgreen@chromium.org> Signed-off-by:
Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/20200626125844.2.Iabd56347670b9e4e916422773aba5b27943d19ee@changeidSigned-off-by:
-
Douglas Anderson authored
The geni serial driver had the rather sketchy hack in it where it would adjust the number of bytes per RX FIFO word from 4 down to 1 if it detected that CONFIG_CONSOLE_POLL was enabled (for kgdb) and this was a console port (defined by the kernel directing output to this port via the "console=" command line argument). The problem with that sketchy hack is that it's possible to run kgdb over a serial port even if it isn't used for console. Let's avoid the hack by simply handling the 4-bytes-per-FIFO word case for kdb. We'll have to have a (very small) cache but that should be fine. A nice side effect of this patch is that an agetty (or similar) running on this port is less likely to drop characters. We'll have roughly 4 times the RX FIFO depth than we used to now. NOTE: the character cache here isn't shared between the polling API and the non-polling API. That means that, technically, the polling API could eat a few extra bytes. This doesn't seem to pose a huge problem in reality because we'll only get several characters per FIFO word if those characters are all received at nearly the same time and we don't really expect non-kgdb characters to be sent to the same port as kgdb at the exact same time we're exiting kgdb. ALSO NOTE: we still have the sketchy hack for setting the number of bytes per TX FIFO word in place, but that one is less bad. kgdb doesn't have any problem with this because it always just sends 1 byte at a time and waits for it to finish. The TX FIFO hack is only really needed for console output. In any case, a future patch will remove that hack, too. Acked-by:
-
Douglas Anderson authored
There's a bunch of overhead in spi-geni-qcom's prepare_message. Get rid of it. Before this change spi_geni_prepare_message() took around 14.5 us. After this change, spi_geni_prepare_message() takes about 1.75 us (as measured by ftrace). What's here: * We're always in FIFO mode, so no need to call it for every transfer. This avoids a whole ton of readl/writel calls. * We don't need to write a whole pile of config registers if the mode isn't changing. Cache the last mode and only do the work if needed. * For several registers we were trying to do read/modify/write, but there was no reason. The registers only have one thing in them, so just write them. Acked-by:
Mark Brown <broonie@kernel.org> Reviewed-by:
-
Douglas Anderson authored
In the patch ("spi: spi-geni-qcom: Avoid clock setting if not needed") we avoid a whole pile of clock code. As part of that, we should have restored the clock at runtime resume. Do that. It turns out that, at least with today's configurations, this doesn't actually matter. That's because none of the current device trees have an OPP table for geni SPI yet. That makes dev_pm_opp_set_rate(dev, 0) a no-op. This is why it wasn't noticed in the testing of the original patch. It's still a good idea to fix, though. Reviewed-by: -
Douglas Anderson authored
Every SPI transfer could have a different clock rate. The spi-geni-qcom controller code to deal with this was never very well optimized and has always had a lot of code plus some calls into the clk framework which, at the very least, would grab a mutex. However, until recently, the overhead wasn't _too_ much. That changed with commit 0e3b8a81 ("spi: spi-geni-qcom: Add interconnect support") we're now calling geni_icc_set_bw(), which leads to a bunch of math plus: geni_icc_set_bw() icc_set_bw() apply_constraints() qcom_icc_set() qcom_icc_bcm_voter_commit() rpmh_invalidate() rpmh_write_batch() ...and those rpmh commands can be a bit beefy if you call them too often. We already know what speed we were running at before, so if we see that nothing has changed let's avoid the whole pile of code. On my hardware, this made spi_geni_prepare_message() drop down from ~145 us down to ~14 us. NOTE: Potentially it might also make sense to add some code into the interconnect framework to avoid executing so much code when bandwidth isn't changing, but even if we did that we still want to short circuit here to save the extra math / clock calls. Acked-by:
-
Douglas Anderson authored
In commit cff80645 ("spi: spi-qcom-qspi: Add interconnect support") the spi_geni_runtime_suspend() and spi_geni_runtime_resume() became a bit slower. Measuring on my hardware I see numbers in the hundreds of microseconds now. Let's use autosuspend to help avoid some of the overhead. Now if we're doing a bunch of transfers we won't need to be constantly chruning. The number 250 ms for the autosuspend delay was picked a bit arbitrarily, so if someone has measurements showing a better value we could easily change this. Fixes: cff80645 ("spi: spi-qcom-qspi: Add interconnect support") Signed-off-by:
Mukesh Kumar Savaliya <msavaliy@codeaurora.org> Reviewed-by:
-
Douglas Anderson authored
As per recent changes to the spi-qcom-qspi, now when we set the clock we'll call into the interconnect framework and also call the OPP API. Those are expensive operations. Let's avoid calling them if possible. This has a big impact on getting transfer rates back up to where they were (or maybe slightly better) before those patches landed. Fixes: cff80645 ("spi: spi-qcom-qspi: Add interconnect support") Signed-off-by:
-
Rajendra Nayak authored
QSPI needs to vote on a performance state of a power domain depending on the clock rate. Add support for it by specifying the perf state/clock rate as an OPP table in device tree. Signed-off-by:
-
Konrad Dybcio authored
This change adds a compatible for msm8994, which requires no additional clocks for scm to probe correctly. Acked-by:
Konrad Dybcio <konradybcio@gmail.com> Link: https://lore.kernel.org/r/20200624150107.76234-2-konradybcio@gmail.comSigned-off-by:
-
Jonathan McDowell authored
The move to a combined driver for the QCOM SCM hardware changed the io_writel and io_readl helpers to use non-atomic calls, despite the commit message saying that atomic was a better option. This breaks these helpers on hardware that uses the old legacy convention (access fails with a -95 return code). Switch back to using the atomic calls. Observed as a failure routing GPIO interrupts to the Apps processor on an IPQ8064; fix is confirmed as correctly allowing the interrupts to be routed and observed. Reviewed-by:
Elliot Berman <eberman@codeaurora.org> Fixes: 57d3b816 ("firmware: qcom_scm: Remove thin wrappers") Cc: stable@vger.kernel.org Signed-off-by:
Jonathan McDowell <noodles@earth.li> Link: https://lore.kernel.org/r/20200704172334.GA759@earth.liSigned-off-by:
-
- 11 Jul, 2020 1 commit
-
-
Randy Dunlap authored
Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled by adding a stub for of_get_next_parent(). ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration] ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion] Fixes: 048eb908 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash") Acked-by:
Randy Dunlap <rdunlap@infradead.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Frank Rowand <frowand.list@gmail.com> Cc: devicetree@vger.kernel.org Cc: Andy Gross <agross@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: linux-arm-msm@vger.kernel.org Link: https://lore.kernel.org/r/ce0d7561-ff93-d267-b57a-6505014c728c@infradead.orgSigned-off-by:
-
- 02 Jul, 2020 1 commit
-
-
Gokul Sriram Palanisamy authored
Add compatible for IPQ8074 support. This does not need clocks for scm calls. Signed-off-by:
Gokul Sriram Palanisamy <gokulsri@codeaurora.org> Signed-off-by:
Sricharan R <sricharan@codeaurora.org> Reviewed-by:
-
- 25 Jun, 2020 9 commits
-
-
Rajendra Nayak authored
geni spi needs to express a perforamnce state requirement on CX depending on the frequency of the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by:
-
Rajendra Nayak authored
geni serial needs to express a perforamnce state requirement on CX powerdomain depending on the frequency of the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by:
-
Akash Asthana authored
Get the interconnect paths for QSPI device and vote according to the current bus speed of the driver. Acked-by:
-
Akash Asthana authored
Get the interconnect paths for SPI based Serial Engine device and vote according to the current bus speed of the driver. Acked-by:
-
Douglas Anderson authored
There is code for adjusting the clock both in setup_fifo_params() (called from prepare_message()) and in setup_fifo_xfer() (called from transfer_one()). The code is the same. Abstract it out to a shared function. This is a no-op cleanup patch. The only change is to the error string if we fail to set the clock. Since the two paths has marginally different error messages I picked the clean one. Acked-by:
-
Akash Asthana authored
Get the interconnect paths for Uart based Serial Engine device and vote according to the baud rate requirement of the driver. Signed-off-by:
-
Akash Asthana authored
Get the interconnect paths for I2C based Serial Engine device and vote according to the bus speed of the driver. Signed-off-by:
Wolfram Sang <wsa@kernel.org> Link: https://lore.kernel.org/r/1592908737-7068-4-git-send-email-akashast@codeaurora.orgSigned-off-by:
-
Akash Asthana authored
QUP core clock is shared among all the SE drivers present on particular QUP wrapper, the system will reset(unclocked access) if earlycon used after QUP core clock is put to 0 from other SE drivers before real console comes up. As earlycon can't vote for it's QUP core need, to fix this add ICC support to common/QUP wrapper driver and put vote for QUP core from probe on behalf of earlycon and remove vote during earlycon exit call. Signed-off-by:
-
Akash Asthana authored
Add necessary macros and structure variables to support ICC BW voting from individual SE drivers. Signed-off-by:
-
- 24 Jun, 2020 1 commit
-
-
Douglas Anderson authored
The write_tcs_reg_sync() may be called after timekeeping is suspended so it's not OK to use ktime. The readl_poll_timeout_atomic() macro implicitly uses ktime. This was causing a warning at suspend time. Change to just loop 1000000 times with a delay of 1 us between loops. This may give a timeout of more than 1 second but never less and is safe even if timekeeping is suspended. NOTE: I don't have any actual evidence that we need to loop here. It's possibly that all we really need to do is just read the value back to ensure that the pipes are cleaned and the looping/comparing is totally not needed. I never saw the loop being needed in my tests. However, the loop shouldn't hurt. Reviewed-by:
Stephen Boyd <sboyd@kernel.org> Reviewed-by:
Maulik Shah <mkshah@codeaurora.org> Fixes: 91160150 ("soc: qcom: rpmh-rsc: Timeout after 1 second in write_tcs_reg_sync()") Reported-by:
-
- 23 Jun, 2020 7 commits
-
-
Konrad Dybcio authored
Add the compatible for the RPM in msm8994. Acked-by:
-
Dmitry Baryshkov authored
Add an entry for SM8250 SoC. Reviewed-by:
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20200525164817.2938638-4-dmitry.baryshkov@linaro.orgSigned-off-by:
-
Dmitry Baryshkov authored
To ease debugging socinfo driver for newer chips add debugfs file returning SoC info format version. Reviewed-by:
-
Dmitry Baryshkov authored
Print sensible string instead of just "(null)" for unknown PMIC models. Also as we are at it, do not let debugfs handler access past pmic_models array. Reviewed-by:
-
Dmitry Baryshkov authored
Add support for newer Qualcomm SoC info structures (up to version 0.15). Reviewed-by:
-
Vincent Knecht authored
Acked-by:
Vincent Knecht <vincent.knecht@mailoo.org> Link: https://lore.kernel.org/r/20200613072745.1249003-5-vincent.knecht@mailoo.orgSigned-off-by:
-
Konrad Dybcio authored
Signed-off-by:
-
- 22 Jun, 2020 3 commits
-
-
Maulik Shah authored
Currently rpmh_invalidate() always returns success. Update its return type to void. Reviewed-by:
Lina Iyer <ilina@codeaurora.org> Reviewed-by:
Stephen Boyd <swboyd@chromium.org> Suggested-by:
-
Lina Iyer authored
Remove config restriction for RPMH on ARM64 platforms only. Signed-off-by:
-
Maulik Shah authored
rpmh-rsc driver is fairly core to system and should not be removable once its probed. However it allows to unbind driver from sysfs using below command which results into a crash on sc7180. echo 18200000.rsc > /sys/bus/platform/drivers/rpmh/unbind Lets prevent unbind at runtime by setting suppress_bind_attrs flag. Reviewed-by:
-
