- 06 Jun, 2022 40 commits
-
-
Martin Kaiser authored
Replace the driver-specific defines for back action codes with the defines from ieee80211.h. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Tested-by:
Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/20220602194807.281115-2-martin@kaiser.cxSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Adrien Thierry authored
Remove global 'vchiq_states' array, which is not used anymore. This is part of an effort to address TODO item "Get rid of all non essential global structures and create a proper per device structure" Tested-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
Adrien Thierry <athierry@redhat.com> Link: https://lore.kernel.org/r/20220518191126.60396-10-athierry@redhat.comSigned-off-by:
-
Adrien Thierry authored
In 'handle_to_service', access the vchiq state from the vchiq instance instead of the global 'vchiq_states' array. This will allow getting rid of the global 'vchiq_states' array. Tested-by:
-
Adrien Thierry authored
In order to remove the 'vchiq_states' global array, we need to pass the vchiq_instance reference to the 'handle_to_service' function. This will allow accessing the vchiq state through the vchiq instance instead of through the global array. Tested-by:
-
Adrien Thierry authored
In order to remove the 'vchiq_states' global array, we need to pass the vchiq_instance reference to the 'handle_to_service' function, as well as to all functions that call 'handle_to_service'. This will allow accessing the vchiq state through the vchiq instance instead of through the global array. 'handle_to_service' is called by 'vchiq_get_service_userdata'. Therefore, pass the vchiq instance reference to it. Tested-by:
-
Adrien Thierry authored
In order to remove the 'vchiq_states' global array, we need to pass the vchiq_instance reference to the 'handle_to_service' function, as well as to all functions that call 'handle_to_service'. This will allow accessing the vchiq state through the vchiq instance instead of through the global array. 'handle_to_service' is called by 'vchiq_get_client_id'. Therefore, pass the vchiq instance reference to it. Tested-by:
-
Adrien Thierry authored
In order to remove the 'vchiq_states' global array, we need to pass the vchiq_instance reference to the 'handle_to_service' function, as well as to all functions that call 'handle_to_service'. This will allow accessing the vchiq state through the vchiq instance instead of through the global array. 'handle_to_service' is called by 'find_service_by_handle'. Therefore, pass the vchiq instance reference to 'find_service_by_handle' and to its callers. Tested-by:
-
Adrien Thierry authored
In order to remove the 'vchiq_states' global array, we need to pass the vchiq_instance reference to the 'handle_to_service' function, as well as to all functions that call 'handle_to_service'. This will allow accessing the vchiq state through the vchiq instance instead of through the global array. 'handle_to_service' is called by 'service_callback'. Therefore, pass the vchiq instance reference to 'service_callback'. This also requires adding the vchiq instance reference to the service callbacks prototype, and update all other callbacks accordingly. Tested-by:
-
Adrien Thierry authored
Get rid of the global g_dev structure. This is part of an effort to address TODO item "Get rid of all non essential global structures and create a proper per device structure" I chose to pass the vchiq_instance around instead of the device reference because in order to get rid of the 'vchiq_states' global array in the future, we will need another way to access the vchiq_state in the 'handle_to_service' function. Therefore, we will need to pass the vchiq_instance to it (or the vchiq_state), and also pass it to functions higher up in the caller chain, such as 'vchiq_bulk_transmit' and friends which are used in the bcm2835-audio consumer. Tested-by:
-
Adrien Thierry authored
Add a reference to the vchiq device in the vchiq_state structure. This allows the device structure to be passed around, which will be useful in order to get rid of the global g_dev structure. This change will also make it possible to use standard kernel logging macros instead of the custom ones. Tested-by:
-
Xiang wangx authored
Delete the redundant word 'tx'. Signed-off-by:
Xiang wangx <wangxiang@cdjrlc.com> Link: https://lore.kernel.org/r/20220603130702.6926-1-wangxiang@cdjrlc.comSigned-off-by:
-
Nam Cao authored
The function vt6655_get_current_tsf has been updated while its description has not. Update the description to correctly reflect what it does. Signed-off-by:
Nam Cao <namcaov@gmail.com> Link: https://lore.kernel.org/r/20220529160211.GA5805@nam-dellSigned-off-by:
-
Hannes Braun authored
This patch should eliminate the following errors/warnings emitted by checkpatch.pl: - that open brace { should be on the previous line - else should follow close brace '}' - braces {} are not necessary for single statement blocks Signed-off-by:Hannes Braun <hannesbraun@mail.de> Link: https://lore.kernel.org/r/20220528123115.13024-1-hannesbraun@mail.deSigned-off-by:
-
Martin Kaiser authored
When issue_action_BA compiles an addba request, it does not add any extensions. start_seq_num is the last field of the addba request. The length of the request is the offset of the end of start_seq_num in the struct ieee80211_mgmt that defines the message. Use offsetofend to calculate this offset and drop the intermediate pktlen increments as we add addba request components. (We have to keep the increments for other message types until we use offsetofend for them as well.) Signed-off-by:
-
Martin Kaiser authored
Use the mgmt structure in issue_action_BA to set the start sequence number. Signed-off-by:
-
Martin Kaiser authored
Use the mgmt structure and defines from ieee80211.h to set the capabilities field of an addba request. If issue_action_BA is called with action == WLAN_ACTION_ADDBA_REQ, the status parameter contains the tid. Signed-off-by:
-
Martin Kaiser authored
Use the mgmt structure in issue_action_BA to set the timeout in the outgoing frame. Signed-off-by:
-
Martin Kaiser authored
Use the mgmt structure in issue_action_BA to set the dialog token. Signed-off-by:
-
Martin Kaiser authored
Use the mgmt structure in issue_action_BA to set the action codes. We have to distinguish between the different message types. We also have to increment the packet length manually as we're no longer calling rtw_set_fixed_ie, which increments the length. Signed-off-by:
-
Martin Kaiser authored
Use the mgmt structure in issue_action_BA to set the category of the outgoing frame. Remove the rtw_set_fixed_ie call. We can now use the define directly, the category variable can be removed. rtw_set_fixed_ie increments pattrib->pktlen, we have to do this ourselves now (until we use a proper way to calculate the packet length). Signed-off-by:
-
Martin Kaiser authored
Use the mgmt structure in issue_action_BA to set the sequence number of the outgoing frame. pwlanhdr is now unused, it can be removed. Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
Martin Kaiser authored
Use the mgmt structure in issue_action_BA to set the three addresses of the outgoing frame. Signed-off-by:
-
Martin Kaiser authored
Define a struct ieee80211_mgmt variable in issue_action_BA, this will make it much simpler to populate the fields of the outoing frame. Use the new mgmt variable to set the type and subtype of the frame. Signed-off-by:
-
Martin Kaiser authored
Replace the numeric values for the block action codes in issue_action_BA with the defines from ieee80211.h. Signed-off-by:
-
Martin Kaiser authored
Remove the unnecessary category check in issue_action_BA. category is initialised to 3 (WLAN_CATEGORY_BACK) and never updated. The rtw_set_fixed_ie call gets a pointer to category but it doesn't update the value. Signed-off-by:
-
Philipp Hortmann authored
Delete upc.h as all macros have been removed from upc.h. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/b553095c618e7885af5c3e42f9b9b39d95127a44.1653203927.git.philipp.g.hortmann@gmail.comSigned-off-by:
-
Philipp Hortmann authored
Add missing big-endian support when using two times iowrite32 to write 64 Bit. Signed-off-by:
-
Philipp Hortmann authored
Replace macro VNSvOutPortD with iowrite32 because it replaces just one line. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvRx1PerPktMode with VNSvOutPortD and as it was the only user, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvRx0PerPktMode with VNSvOutPortD and as it was the only user, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvSetCurrBCNTxDescAddr with VNSvOutPortD and as it was only used twice, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvIntDisable with VNSvOutPortD and as it was only used twice, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvIntEnable with VNSvOutPortD and as it was only used twice, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvWriteISR with VNSvOutPortD and as it was the only user, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro VNSvOutPortW with iowrite16 because it replaces just one line. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvSetCurrBCNLength with VNSvOutPortW and as it was the only user, it can now be removed. Signed-off-by:
-
Uri Arev authored
Reported by Checkpatch: CHECK: Alignment should match open parenthesis Signed-off-by:
Uri Arev <me@wantyapps.xyz> Link: https://lore.kernel.org/r/20220523182226.405159-1-me@wantyapps.xyzSigned-off-by:
-
Nam Cao authored
Change camelCase function name sii164GetVendorID to sii164_get_vendor_id as suggested by checkpatch.pl Signed-off-by:
-
Srivathsan Sivakumar authored
reduce number of spaces in dev_dbg() code format the commit and changelog more clearly Signed-off-by:
Srivathsan Sivakumar <sri.skumar05@gmail.com> Link: https://lore.kernel.org/r/Yo3HOPPKnWHez7ES@SassySigned-off-by:
-
Phillip Potter authored
Convert pr_info_once call in core/rtw_fw.c to a dev_info_once call, as ultimately, this results in the printing of the driver name anyway (r8188eu) which is equally clear and removes the need for the "R8188EU: " part of the format string. Suggested-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20220520220953.11840-1-phil@philpotter.co.ukSigned-off-by:
-
