- 29 Sep, 2015 40 commits
-
-
Malcolm Priestley authored
Presently the TX buffer stops while filling the buffer. However, this does not make use of the available buffer space, it also lags the speed of the TX troughtput. Only stop the queue when the buffer becomes full. The Interupt handler will start the queue again when a buffer is available. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tillmann Heidsieck authored
The result variable is not set anywhere beyond its initialization, therefore it can be remove. Signed-off-by:
Tillmann Heidsieck <theidsieck@leenox.de> Signed-off-by:
-
Tillmann Heidsieck authored
We exit the above loop either if curroff >= (HFA384x_PDA_LEN_MAX / 2 - 1) or if we found the END marker in the element beyond the current one. The first case is checked for in the preceding if statement, therefore the second if statement is redundant and can be removed. Signed-off-by:
-
Tillmann Heidsieck authored
We test for an END marker in the element beyond the current one, this effectively limits the size of the array to be HFA384x_PDA_LEN_MAX/2 - 1 not HFA384x_PDR_END_OF_PDA/2. This patch fixes a possible buffer overflow in case there was no END marker. Signed-off-by:
-
Mike Rapoport authored
The function twoToPowerOfx that iteratively calculates the power of 2 may be replaced with shift operator Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
-
Mike Rapoport authored
The MB(x) and KB(x) macros are not used and therefore they can be removed Signed-off-by:
-
Mike Rapoport authored
Use SZ_xM defined in linux/sizes.h instead of custom MB(x) macro Signed-off-by:
-
Mike Rapoport authored
Add space between '#include' keyword and the header name Signed-off-by:
-
Mike Rapoport authored
Remove unnecessary space in sm750_help.h to fix the following checkpatch.pl error: drivers/staging/sm750fb/sm750_help.h:46: space prohibited after that '~' (ctx:ExW) Signed-off-by:
-
Javier Martinez Canillas authored
The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Since the error number is propagated, the caller will get a -EPERM which is the wrong error condition. Also, the smatch tool complains with the following warning: dgap_parsefile() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by:
Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by:
-
Javier Martinez Canillas authored
The IEEE80211_STYPE_PROBE_REQ flag appears twice in the expression and coccicheck complains with: wilc_wfi_cfgoperations.h:80:3-38: duplicated argument to & or | Signed-off-by:
-
David Kershner authored
This driver create a host bus adapter device when s-Par sends a device create message to create a storage adapter on the visorbus. When the message is received by visorbus, the visorhba_probe function is called and the hba device is created and managed by the visorhba driver. Signed-off-by:
Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
David Kershner <david.kershner@unisys.com> Signed-off-by:
-
Arnd Bergmann authored
Here, we actually have a problem in 2038 or at the latest in 2106 when the lc_expiry variable on the wire protocol overflows, including on 64-bit architectures. Now that the actual code was removed, only on-the wire structure is left so we add in a y2038 warning to remind whoever gets to implement it again about this problem. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Oleg Drokin authored
Client capabilities is an outdated feature that never worked properly, so let's get rid of the client support since modern servers don't have this support either. The patch is big, but since it just removes one large feature, so it's hopefully easy to verify. Signed-off-by:
-
Oleg Drokin authored
These particular helpers are unused so let's get rid of them: ldebugfs_add_symlink, lprocfs_rd_u64, lprocfs_rd_atomic, lprocfs_wr_atomic, lprocfs_rd_name, lprocfs_seq_read_frac_helper Signed-off-by:
-
Oleg Drokin authored
This is unused anywhere in the client code. Signed-off-by:
-
Oleg Drokin authored
This code is not called anywhere in the current client code, so we can remove it. Also remove a helper function lprocfs_init_mps_stats Signed-off-by:
-
Oleg Drokin authored
obd_stats in the form present were only used on the server, so let's remove them from the client code This also removes lprocfs_init_ops_stats helper. Signed-off-by:
-
Arnd Bergmann authored
Nothing uses dt_object now, so we can kill the implementation and the stale references. Signed-off-by:
-
Arnd Bergmann authored
Most of the code in llog.c and llog_cat.c is completely unused on the client and can be removed, as a preparation for removing the dt_object code. Two tricky parts are: - In llog_cat_close(), we rely on the fact that llh_flags never contains LLOG_F_ZAP_WHEN_EMPTY, because nobody ever sets that flag. - In llog_read_header(), we check the return value of the lpi_cb callback, and again we know that it cannot be LLOG_PROC_BREAK or LLOG_DEL_RECORD and can remove the respective code path. Signed-off-by:
-
Oleg Drokin authored
These functions only make sense on the server. Signed-off-by:
-
Oleg Drokin authored
This is only used on the servers to evict clients. Signed-off-by:
-
Arnd Bergmann authored
The CFS_TIME_T macro serves no real purpose as we stopped using time_t and changed over to time64_t, so we can remove the last remaining uses of this. Two uses of this macro are incorrect and refer to jiffies values rather than time_t, and one refers to an inode timespec that gets changed separately. Signed-off-by:
-
Oleg Drokin authored
This is only used on the server to keep track of alive clients and feeds into ping evictor (that was removed from the client code). Also remove struct obd's obd_exports_timed and struct obd_export's exp_obd_chain_timed used to keep track of that Signed-off-by:
-
Arnd Bergmann authored
More code that makes no sense on the client and that can be removed without replacement. Signed-off-by:
-
Arnd Bergmann authored
A bunch of API functions deal with time values but are now completely unused in lustre. This removes them in order to remove all references to time_t from the header files. Signed-off-by:
-
Arnd Bergmann authored
This is a simple cleanup that I did after noticing that the abstraction for the timer functions in completely pointless, and the one user (ptlrpc) can just as well call the native Linux functions. For good measure, this also removes the empty libcfs_arch_init() and libcfs_arch_cleanup() functions that are defined in the same file. Signed-off-by:
-
Arnd Bergmann authored
lov_stripe_md_cmp lov_lum_lsm_cmp lov_lum_swab_if_needed functions have not been in used for a long time, so lets just remove them. Signed-off-by:
-
Arnd Bergmann authored
This code is never used on the client and can simply be removed. Signed-off-by:
-
Arnd Bergmann authored
All request timestamps and deadlines in lustre are recorded in time_t and timeval units, which overflow in 2038 on 32-bit systems. In this patch, I'm converting them to time64_t and timespec64, respectively. Unfortunately, this makes a relatively large patch, but I could not find an obvious way to split it up some more without breaking atomicity of the change. Also unfortunately, this introduces two instances of div_u64_rem() in the request path, which can be slow on 32-bit architectures. This can probably be avoided by a larger restructuring of the code, but it is unlikely that lustre is used in performance critical setups on 32-bit architectures, so it seems better to optimize for correctness rather than speed here. Signed-off-by:
-
Arnd Bergmann authored
Here we use an unsigned long to store the timeout for gc, which is probably safe until 2106, but this patch converts it to use ktime_get_real_seconds() and time64_t for consistency. Signed-off-by:
-
Arnd Bergmann authored
The exp_flvr_expire and imp_sec_expire are defined as 'unsigned long', which doesn't overflow until 2106, but to be on the safe side, this changes the code to use time64_t like we do everywhere else. Signed-off-by:
-
Arnd Bergmann authored
These three are timestamps that are sent over the wire in mdc_lib and the obd logging 64-bit values, but are generated using the 32-bit get_seconds() function, which will eventually overflow. Changing them to use 64-bit ktime_get_real_seconds() solves the problem. Signed-off-by:
-
Arnd Bergmann authored
The ll_setattr_raw() function prints the new inode timestamps along with the current time using '%lu', which overflows in 2106. This changes the printing of the current time for now, the other two will change when we migrate the VFS code to use 64-bit timestamps. Signed-off-by:
-
Arnd Bergmann authored
This adapts the format string and get_seconds() call to not overflow in 2038 in the libcfs_debug_dumplog_internal() function. Signed-off-by:
-
Arnd Bergmann authored
ptlrpc_enc_page_pool computes time deltas using 'long' values from get_seconds(). This is probably safe beyond y2038, but it's better to go use monotonic times and 64-bit here for consistency. Signed-off-by:
-
Arnd Bergmann authored
The lustre selftest code has multiple time stamps that are kept as 'time_t' or 'unsigned long' and can therefore overflow on 32-bit systems. This changes the code to use time64_t instead. Signed-off-by:
-
Arnd Bergmann authored
The ni_last_alive member of lnet_ni uses a 'long' to store a timestamp, which breaks on 32-bit systems in 2038. This changes it to use time64_t and the respective functions for it. Signed-off-by:
-
Arnd Bergmann authored
The connection starting/failing time stamps will overflow in 2038 on 32-bit machines, so we need to use time64_t and ktime_get_real_seconds() instead. Signed-off-by:
-
Arnd Bergmann authored
The llite debugfs interface contains timestamps that are computed from timeval, which overflows in 2038 on 32-bit systems. This changes the output to use a timespec64 type to avoid the overflow. I also change the format to print the sub-second portion as 9 digits (nanoseconds) for clarity, rather than printing six digits without leading zeroes. Signed-off-by:
-
