- 24 Apr, 2017 40 commits
-
-
Heiner Kallweit authored
Use GENMASK consistently for all bit masks and switch to using the bitfield macros FIELD_GET and FIELD_PREP. This hides parts of the complexity of dealing with bit fields. Signed-off-by:
Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by:
Kevin Hilman <khilman@baylibre.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Shawn Lin authored
Currently the get_timeout_clock callback doesn't clearly have a statement that it needs the variant drivers to return the timeout clock rate in kHz if the SDHCI_TIMEOUT_CLK_UNIT isn't present, otherwise the variant drivers should return it in MHz. It's also very likely that further variant drivers which are going to use this callback will be confused by this situation. Given the fact that moderm sdhci variant hosts are very prone to get the timeout clock from common clock framework (actually the only three users did that), it's more natural to return the value in Hz and we make an explicit comment there. Then we put the unit conversion inside the sdhci core. Thus will improve the code and prevent further misuses. Reported-by:
Anssi Hannula <anssi.hannula@bitwise.fi> Signed-off-by:
Shawn Lin <shawn.lin@rock-chips.com> Acked-by:
Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by:
Adrian Hunter <adrian.hunter@intel.com> Signed-off-by:
-
Icenowy Zheng authored
The controller's errors are usually normal (for example, for MMC or SDIO cards, some errors are expected to happen; and for boards without a dedicated card detect pin the error info will even flood console and hide other normal messages) and hard to understand. Change their print level to debug, thus it won't be shown to generic users. Signed-off-by:
Icenowy Zheng <icenowy@aosc.xyz> Acked-by:
Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by:
-
Heiner Kallweit authored
We don't need variable cmd_cfg_timeout, so remove it and simplify the code a little. Signed-off-by:
-
Heiner Kallweit authored
Centralize setting data->bytes_xfered in one place and make sure that the number of transfererd bytes is set only if we receive the end-of-chain interrupt and there was no error. Signed-off-by:
-
Heiner Kallweit authored
Response reading can be slightly improved by doing it in just one place. Signed-off-by:
-
Heiner Kallweit authored
Simplify the code by using two variables instead of a struct sd_emmc_desc. Signed-off-by:
-
Heiner Kallweit authored
Replace cmd->data with a local variable to simplify code a little. Signed-off-by:
-
Heiner Kallweit authored
The variables holding the configuration bits are zero-initialized. So we can remove all bit resets. Signed-off-by:
-
yong mao authored
If we don't select a set of better parameters for our emmc host, It may easily occur CMD response CRC error. And also it may cause cannot boot up issue. Fot getting a set of better parameters, our emmc host supports data tune mechanism.Therefore, our emmc driver also should change to use data tune for CMD line. Because our emmc host use the different clock source to sample the CMD signal between HS200 and HS400 mode, the parameters are also different between these two modes. Separate cmd internal delay for HS200/HS400 mode. This change can fix "System can not boot up" issue. Signed-off-by:
Yong Mao <yong.mao@mediatek.com> Signed-off-by:
Chaotian Jing <chaotian.jing@mediatek.com> Signed-off-by:
-
yong mao authored
Add description for mediatek,hs200-cmd-int-delay Add description for mediatek,hs400-cmd-int-delay Add description for mediatek,hs400-cmd-resp-sel-rising Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Heiner Kallweit authored
Improve mmc_io_rw_extended a little: - using DIV_ROUND_UP achieves the same but is better readable - simplify code by using sg_set_buf - simplify one statement by using -= operator Signed-off-by:
-
Chris Brandt authored
Signed-off-by:
Chris Brandt <chris.brandt@renesas.com> Reviewed-by:
Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by:
Simon Horman <horms+renesas@verge.net.au> Acked-by:
-
Masaharu Hayakawa authored
Current code gets number of taps only once and keeps the value. This is not correct, we need to obtain it every time before executing tuning, so remove the outer if-block. Signed-off-by:
Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> [wsa: extracted from a larger patch and reworded commit message] Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by:
-
Wolfram Sang authored
In the (maybe academical) case, we don't get a DATAEND interrupt after DMA completed, we will wait endlessly for the completion to complete. This is not bad per se, since we have a more generic completion tracking a timeout. In that rare case, however, the DMA buffer will not get unmapped and we have a leak. Reorder the code, so unmapping will always take place. Signed-off-by:
-
Adrian Hunter authored
Move a function to avoid having to forward declare it in a subsequent patch. Signed-off-by:
Ludovic Desroches <ludovic.desroches@microchip.com>
-
Adrian Hunter authored
Add runtime suspend/resume callbacks to match suspend/resume callbacks. Signed-off-by:
-
Adrian Hunter authored
The suspend / resume callbacks lack the flexibility to allow a device to specify a different function entirely. Change them around so that device functions are called directly and they in turn can call the default implementations if needed. Signed-off-by:
-
Adrian Hunter authored
It is confusing to have some parts of suspend / resume under conditional compilation and some parts not. Use conditional compilation everywhere. Signed-off-by:
-
Adrian Hunter authored
Do not use suspend/resume callbacks with runtime pm. It doesn't make sense and isn't being used, so remove. Signed-off-by:
-
Adrian Hunter authored
SDHCI provides more flexibility than simply calling sdhci_add_host(). Make that available by allowing devices to specify their own ->add_host() function. Signed-off-by:
-
Adrian Hunter authored
Add an interrupt hook and helper functions for enabling, disabling and delivering interrupts to a CQE. Signed-off-by:
-
Adrian Hunter authored
Factor out sdhci_set_default_irqs(). Signed-off-by:
-
Adrian Hunter authored
Add sdhci_cleanup_host() to cleanup __sdhci_add_host(). Signed-off-by:
-
Adrian Hunter authored
Get rid of unnecessary 'extern' in header file. Signed-off-by:
-
Adrian Hunter authored
Export sdhci_dumpregs so that it can be called by drivers. Signed-off-by:
-
Adrian Hunter authored
Ensure all prints start with the mmc host name, and the text all lines up. Signed-off-by:
-
Adrian Hunter authored
Use sdhci io wrappers consistently. Signed-off-by:
-
Adrian Hunter authored
Add response register to register dump. Signed-off-by:
-
Adrian Hunter authored
Ensure all debug prints start with the mmc host name. Signed-off-by:
-
Adrian Hunter authored
Tuning execution is already synchronized with respect to other host operations by upper layers "claiming" the host, which also takes care of runtime pm. There can be no requests in progress. Retain the spin lock usage only for ensuring that sending tuning commands is synchronized with respect to the interrupt handler. Signed-off-by:
-
Adrian Hunter authored
The spin lock is not necessary in set_ios. Anything that is racing with changes to the I/O state is already broken. The mmc core already provides synchronization via "claiming" the host. So remove spin_lock and friends from sdhci_set_ios and related callbacks. Signed-off-by:
-
Adrian Hunter authored
Drivers can use the host operation directly, so remove this now unused callback. Signed-off-by:
-
Adrian Hunter authored
Make use of an Intel ACPI _DSM that provides eMMC driver strength. Signed-off-by:
-
Adrian Hunter authored
Make use of an Intel ACPI _DSM that indicates if re-tuning is needed after D3. Signed-off-by:
-
Adrian Hunter authored
Let devices define their own private data to facilitate device-specific operations. The size of the private structure is specified in the sdhci_pci_fixes structure, then sdhci_pci_probe_slot() will allocate extra space for it, and sdhci_pci_priv() can be used to get a reference to it. Signed-off-by:
-
Adrian Hunter authored
Devices might save and restore tuning values so that re-tuning might not be needed after a pm transition. Let drivers decide by pushing the mmc_retune_needed() logic down to them. Signed-off-by:
-
Adrian Hunter authored
The delay loops for reset and clock enable always take at least 1 ms because they use mdelay(1). However they can take a lot less time e.g. less than 50us. Use ktime and reduce the delay to 10 microseconds per loop. Signed-off-by:
-
Eric Anholt authored
The 2835 has two SD controllers: The Arasan sdhci controller (supported by the iproc driver) and a custom sdhost controller. This patch adds a driver for the latter. The sdhci controller supports both sdcard and sdio. The sdhost controller supports the sdcard only, but has better performance. Also note that the rpi3 has sdio wifi, so driving the sdcard with the sdhost controller allows to use the sdhci controller for wifi support. The configuration is done by devicetree via pin muxing. Both SD controller are available on the same pins (2 pin groups = pin 22 to 27 + pin 48 to 53). So it's possible to use both SD controllers at the same time with different pin groups. The code was originally written by Phil Elwell in the downstream Rasbperry Pi tree. In preparation for the upstream merge it was cleaned up and the code base was moderized by Eric Anholt, Stefan Wahren and Gerd Hoffmann. Signed-off-by:
Eric Anholt <eric@anholt.net> Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
Gerd Hoffmann <kraxel@redhat.com> Signed-off-by:
-
Eric Anholt authored
This is the other SD controller on the platform, which can be swapped to the role of SD card host using pin muxing. Signed-off-by:
-
