- 14 Sep, 2021 18 commits
-
-
Jérôme Pouiller authored
Checking if a skb_queue is empty is not an atomic operation. We should take some precautions to do it. Signed-off-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20210913130203.1903622-8-Jerome.Pouiller@silabs.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jérôme Pouiller authored
It is no more necessary to compute the expected duration of the scan request. Signed-off-by:
-
Jérôme Pouiller authored
If the environment is noisy, the device may take time to send scan requests. Thus, scan requests durations > 5s have already been observed. During the scan, traffic is neither received, neither sent. From the user point-of-view, the traffic is frozen for a long time. This patch reworks the scan processing. It gives to the device a smaller time budget than previously. However, it does not expect the scan to be complete and it is able to send another scan request to finish the work. A big part of the patch aims to avoid an infinite loop if the device goes crazy. Signed-off-by:
-
Jérôme Pouiller authored
When the device has finished a scan request, it send a scan complete ("SCAN_COMPL") indication. It is also possible to abort a scan request with a "SCAN_STOP" message. A SCAN_COMPL is also send in this case. The driver limits the delay to make a scan request. A timeout happens almost never but is theoretically possible. Currently, if it happens the driver does not wait for the SCAN_COMPL. Then, when the driver starts the next scan request, the device may return -EBUSY (scan requests often occur back-to-back). This patch give a chance to the device to send a SCAN_COMPL after a scan timeout. Signed-off-by: -
Jérôme Pouiller authored
When multiple interface are in use. One is always AP while the other is always station. When the two interface use the same channel, it makes no sense to enabled Power Saving (PS) on the station. Indeed, because of the AP, the device will be kept awake on this channel anyway. In add, when multiple interface are in use, mac80211 does not update the PS information and delegate to the driver responsibility to do the right thing. Thus, in the current code, when the user enable PS in this configuration, the driver finally enable PS-Poll which is probably not what the user expected. This patch detect this case and applies a sane configuration in all cases. Signed-off-by:
-
Jérôme Pouiller authored
During the scan requests, the Tx traffic is suspended. This lock is shared by all the network interfaces. So, a scan request on one interface will block the traffic on a second interface. This causes trouble when the queued traffic contains CAB (Content After DTIM Beacon) since this traffic cannot be delayed. It could be possible to make the lock local to each interface. But It would only push the problem further. The device won't be able to send the CAB before the end of the scan. So, this patch just ignore the DTIM indication when a scan is in progress. The firmware will send another indication on the next DTIM and this time the system will be able to send the traffic just behind the beacon. The only drawback of this solution is that the stations connected to the AP will wait for traffic after the DTIM for nothing. But since the case is really rare it is not a big deal. Signed-off-by:
-
Jérôme Pouiller authored
The wfx driver checks carefully the coherency of of the DTIM notifications. We have noticed several times some small inconsistencies from the firmware on these notification. They have never been critical. However on the driver side they lead to big fat warnings. Worse, if these warning are displayed on UART console, they can be long to display (several hundreds of millisecs). Since, this warning is generated from a work queue, it can delay all the workqueue users. Especially, it can drastically slow down the frame management of the driver and then generate errors that are serious this time (eg. an overflow of the indication queue of the device). Signed-off-by:
-
Michael Straube authored
Including basic_types.h is not needed in odm_types.h. Remove the include. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210913192043.26527-4-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Remove unused defines from odm_types.h. This compiles without introducing any new warnings. Signed-off-by:
-
Michael Straube authored
The enum RT_SPINLOCK_TYPE is not used in the driver, remove it. Signed-off-by:
-
Martin Kaiser authored
b_hw_radio_off in struct pwrctrl_priv is not used. Remove it. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20210913185110.3065-9-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
cpwm_tog in struct pwrctrl_priv is not used. Remove it. Signed-off-by:
-
Martin Kaiser authored
Remove the rtw_set_ips_deny function since it's not used. Signed-off-by:
-
Martin Kaiser authored
PS_BBRegBackup in struct pwrctrl_priv is not used. Remove this component and the related enum _PS_BBRegBackup_. Signed-off-by:
-
Martin Kaiser authored
Remove a bunch of unused defines and macros and an unused struct from rtw_pwrctrl.h. Signed-off-by:
-
Martin Kaiser authored
Remove the empty _free_pwrlock function and rtw_free_pwrctrl_priv, which is just a wrapper around _free_pwrlock. Signed-off-by:
-
Martin Kaiser authored
Remove some unused defines and macros related to power states. Signed-off-by:
-
Martin Kaiser authored
After we dropped the call to set HW_VAR_SET_RPWM, the rtw_set_rpwm function doesn't do anything useful. Remove the function and the rpwm component of struct pwrctrl_priv, which is not used outside of rtw_set_rpwm. Signed-off-by:
-
- 13 Sep, 2021 22 commits
-
-
Gaston Gonzalez authored
Fix code alignment issues. Reported by checkpatch.pl Signed-off-by:
Gaston Gonzalez <gascoar@gmail.com> Link: https://lore.kernel.org/r/20210912133751.269885-2-gascoar@gmail.comSigned-off-by:
-
Gaston Gonzalez authored
Remove unnecessary braces from if block. Reported by checkpatch.pl Signed-off-by:
-
Michael Straube authored
After removing unused register definitions from odm_reg.h there are only two definitions left. Move them into odm.h and remove odm_reg.h. Signed-off-by:
-
Michael Straube authored
Remove unused register definitions from odm_reg.h. Signed-off-by:
-
Saurav Girepunje authored
Remove unused function rtw_set_tx_chksum_offload. Signed-off-by:
Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YT4xcJvvlPSIS+T6@userSigned-off-by:
-
Michael Straube authored
Replace and remove the macro GET_EEPROM_EFUSE_PRIV to get one step closer to remove hal_intf.h. Signed-off-by:
-
Michael Straube authored
The header file HalHWImg8188E_FW.h is not used in the driver. Remove it. Signed-off-by:
-
Martin Kaiser authored
The bHWPwrPindetect cleanup removed the only call to rtw_hw_suspend. Signed-off-by:
-
Martin Kaiser authored
The bHWPwrPindetect component of struct pwrctrl_priv is never initialised explicitly, it remains at its default value 0. Remove bHWPwrPindetect itself and code that depends on bHWPwrPindetect != 0. Signed-off-by:
-
Martin Kaiser authored
tog in struct pwrctrl_priv is never read. Remove it. Signed-off-by:
-
Martin Kaiser authored
cpwm in struct pwrctrl_priv is never read. Remove it. Signed-off-by:
-
Martin Kaiser authored
Setting the HW_VAR_SET_RPWM "hardware variable" is an empty operation. Remove the call to set HW_VAR_SET_RPWM, the calculation of the value to be set and the definition of HW_VAR_SET_RPWM itself. Signed-off-by:
-
Martin Kaiser authored
btcoex_rfon is always false in this driver. Remove the variable and code that will never be executed. Signed-off-by:
-
Pavel Skripkin authored
While testing latest updates I hit lockdep warning: [ 42.694425] ============================================ [ 42.694785] WARNING: possible recursive locking detected [ 42.695120] 5.14.0+ #25 Tainted: G C [ 42.695422] -------------------------------------------- [ 42.695747] RTW_CMD_THREAD/317 is trying to acquire lock: [ 42.696078] ffffc900006c90b0 (&pqueue->lock){+.-.}-{3:3}, at: _rtw_alloc_network+0x1e/0x321 [r8188eu] [ 42.696686] [ 42.696686] but task is already holding lock: [ 42.697148] ffffc900006c9100 (&pqueue->lock){+.-.}-{3:3}, at: rtw_update_scanned_network+0x31/0x76b [r8188eu] [ 42.697758] [ 42.697758] other info that might help us debug this: [ 42.698326] Possible unsafe locking scenario: [ 42.698326] [ 42.698696] CPU0 [ 42.698847] ---- [ 42.698997] lock(&pqueue->lock); [ 42.699209] lock(&pqueue->lock); [ 42.699418] [ 42.699418] *** DEADLOCK *** [ 42.699418] [ 42.699768] May be due to missing lock nesting notation It's false positive, since all queue spinlocks are initialized via private API which has pqueue as agrument. Fix it by making _rtw_init_queue a macro instead of function + removed unneeded _ prefix. Signed-off-by:Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/20210908194309.9086-1-paskripkin@gmail.comSigned-off-by:
-
Ojaswin Mujoo authored
Replace function typedefs with the equivalent declarations to better align with the linux kenel coding style The following typedefs were changed: * VCHIQ_CONNECTED_CALLBACK_T * vchiq_userdata_term Signed-off-by:
Ojaswin Mujoo <ojaswin98@gmail.com> Link: https://lore.kernel.org/r/a8e4e0457b5fcc88c7f297f9d669dfb7e7d91ed5.1631366317.git.ojaswin98@gmail.comSigned-off-by:
-
Michael Straube authored
After the removal of some pointers from struct hal_ops the function rtl8188e_set_hal_ops() is empty now. Remove it. Acked-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Signed-off-by:
-
Michael Straube authored
Remove write_rfreg from struct hal_ops and its wrapper rtw_hal_write_rfreg(). Call rtl8188e_PHY_SetRFReg() directly instead. Acked-by:
-
Michael Straube authored
Remove read_rfreg from struct hal_ops and its wrapper rtw_hal_read_rfreg(). Call rtl8188e_PHY_QueryRFReg() directly instead. Acked-by:
-
Michael Straube authored
Remove write_bbreg from struct hal_ops and its wrapper rtw_hal_write_bbreg(). Call rtl8188e_PHY_SetBBReg() directly instead. Acked-by:
-
Michael Straube authored
Remove read_bbreg from struct hal_ops and its wrapper rtw_hal_read_bbreg(). Call rtl8188e_PHY_QueryBBReg() directly instead. Acked-by:
-
Michael Straube authored
Remove hal_xmit from struct hal_ops and its wrapper rtw_hal_xmit(). Call rtl8188eu_hal_xmit() directly instead. Acked-by:
-
Michael Straube authored
Remove mgnt_xmit from struct hal_ops and its wrapper rtw_hal_mgnt_xmit(). Call rtl8188eu_mgnt_xmit() directly instead. Acked-by:
-
