- 28 Jun, 2021 9 commits
-
-
Namjae Jeon authored
Move fs/cifsd to fs/ksmbd and rename the remaining cifsd name to ksmbd. Reviewed-by:
Christoph Hellwig <hch@lst.de> Signed-off-by:
Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by:
Steve French <stfrench@microsoft.com>
-
Namjae Jeon authored
Use f_bsize in FS_SECTOR_SIZE_INFORMATION to avoid the access the block layer. Signed-off-by:
-
Namjae Jeon authored
Remove unneeded NULL check in the list iterator. And use list_for_each_entry_safe instead of list_for_each_safe. Signed-off-by:
-
Namjae Jeon authored
Use f_bsize instead of q->limits.logical_block_size. Reviewed-by:
-
Namjae Jeon authored
Change stream type macro to enumeration and move it to vfs.h. Reviewed-by:
-
Namjae Jeon authored
Add select FS_POSIX_ACL in Kconfig and then opencode posix acl functions instead of wrappers Reviewed-by:
-
Namjae Jeon authored
Factor out a self-contained helper to find sub file/dir in use. Reviewed-by:
-
Namjae Jeon authored
Opencode to avoid trivial wrappers that just make the code hard to follow. Reviewed-by:
-
Namjae Jeon authored
Use the pr_fmt built into pr_*. and use pr_err/info after removing wrapper ksmbd_err/info. Reviewed-by:
-
- 22 Jun, 2021 9 commits
-
-
Namjae Jeon authored
replace KSMBD_SHARE_CONFIG_PATH with inline function. Reviewed-by:
-
Namjae Jeon authored
None of structures needs the attribute. So remove ____ksmbd_align in ksmbd_server.h. Reviewed-by:
-
Namjae Jeon authored
Remove unneeded FIXME comment. Reviewed-by:
-
Namjae Jeon authored
Fix overly long line. Reviewed-by:
-
Namjae Jeon authored
Use goto instead of duplicating the resoure cleanup in ksmbd_open_fd. Reviewed-by:
-
Namjae Jeon authored
Use list_for_each_entry instead of list_for_each. Reviewed-by:
-
Namjae Jeon authored
vfs_copy_file_range and cifs client already does this type of fallback, so this is dead code. Reviewed-by:
-
Namjae Jeon authored
Initialize variables on the declaration. Reviewed-by:
-
Namjae Jeon authored
As vmalloc performance improvement patch for big allocation is merged into linux kernel, This feature is no longer not needed. Reviewed-by:
-
- 18 Jun, 2021 2 commits
-
-
Namjae Jeon authored
Add support for SMB3 multichannel. It will be enable by setting 'server multi channel support = yes' in smb.conf. Signed-off-by:
-
Colin Ian King authored
Currently function ksmbd_neg_token_init_mech_type can kfree an uninitialized pointer oid when the call to asn1_oid_decode fails when vlen is out of range. All the other failure cases in function asn1_oid_decode set *oid to NULL on an error, so fix the issue by ensuring the vlen out of range error also nullifies the pointer. Addresses-Coverity: ("Uninitialized pointer read") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
- 09 Jun, 2021 1 commit
-
-
Hyunchul Lee authored
Because functions and variables generated from ASN1 compiler aren't static, append ksmbd prefix into thoses to avoid link errors. Signed-off-by:
Hyunchul Lee <hyc.lee@gmail.com> Signed-off-by:
-
- 07 Jun, 2021 4 commits
-
-
Wan Jiabing authored
Fix the following coccicheck warning: ./fs/cifsd/smb2pdu.c:1713:27-41: duplicated argument to & or | FILE_DELETE_LE is duplicated. Remove one and reorder argument to make coding style reasonable. Signed-off-by:
Wan Jiabing <wanjiabing@vivo.com> Signed-off-by:
-
Hyunchul Lee authored
spnego_negtokeninit.asn1.h and spnego_negtokentarg.asn1.h have to be generated before asn1.o is compiled. Because of parallel build, the dependency could be broken, we need to specify the dependency in Makefile. Signed-off-by:
-
Namjae Jeon authored
When running generic/591 after smb2 leases is enable, all smb2 lease ack requests failed in ksmbd. because cifs client seems to support only smb2 v2 lease. So cifs doesn't update lease state in ack request if epoch is not set in smb2 lease break request from ksmbd. epoch is used for smb2 v2 leases. So this patch add smb2 create v2 lease context and set increased epoch in smb2 lease break response. Signed-off-by:
-
Namjae Jeon authored
BUG_ON trap is coming when running xfstests generic/591 and smb2 leases = yes in smb.conf. [ 597.224978] list_add double add: new=ffff9110d292bb20, prev=ffff9110d292bb20, next=ffff9110d6c389e8. [ 597.225073] ------------[ cut here ]------------ [ 597.225077] kernel BUG at lib/list_debug.c:31! [ 597.225090] invalid opcode: 0000 [#1] SMP PTI [ 597.225095] CPU: 2 PID: 501 Comm: kworker/2:3 Tainted: G OE 5.13.0-rc1+ #2 [ 597.225099] Hardware name: SAMSUNG ELECTRONICS CO., LTD. Samsung DeskTop System/SAMSUNG_DT1234567890, BIOS P04KBM.022.121023.SK 10/23/2012 [ 597.225102] Workqueue: ksmbd-io handle_ksmbd_work [ksmbd] [ 597.225125] RIP: 0010:__list_add_valid+0x66/0x70 [ 597.225132] Code: 0b 48 89 c1 4c 89 c6 48 c7 c7 c8 08 c0 95 e8 fd 54 66 00 0f 0b 48 89 f2 4c 89 c1 48 89 fe 48 c7 c7 20 09 c0 95 e8 e6 54 66 00 <0f> 0b 0f 1f 84 00 00 00 00 00 55 48 8b 07 48 b9 00 01 00 00 00 00 [ 597.225136] RSP: 0018:ffffb9c9408dbac0 EFLAGS: 00010282 [ 597.225139] RAX: 0000000000000058 RBX: ffff9110d292ba40 RCX: 0000000000000000 [ 597.225142] RDX: 0000000000000000 RSI: ffff9111da328c30 RDI: ffff9111da328c30 [ 597.225144] RBP: ffffb9c9408dbac0 R08: 0000000000000001 R09: 0000000000000001 [ 597.225147] R10: 0000000003dd35ed R11: ffffb9c9408db888 R12: ffff9110d6c38998 [ 597.225149] R13: ffff9110d6c38800 R14: ffff9110d292bb20 R15: ffff9110d292bb20 [ 597.225152] FS: 0000000000000000(0000) GS:ffff9111da300000(0000) knlGS:0000000000000000 [ 597.225155] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 597.225157] CR2: 00007fd1629f84d0 CR3: 00000000c9a12006 CR4: 00000000001706e0 [ 597.225160] Call Trace: [ 597.225163] setup_async_work+0xa2/0x120 [ksmbd] [ 597.225191] oplock_break+0x396/0x5d0 [ksmbd] [ 597.225206] smb_grant_oplock+0x7a1/0x900 [ksmbd] [ 597.225218] ? smb_grant_oplock+0x7a1/0x900 [ksmbd] [ 597.225231] smb2_open+0xbbb/0x2960 [ksmbd] [ 597.225243] ? smb2_open+0xbbb/0x2960 [ksmbd] [ 597.225257] ? find_held_lock+0x35/0xa0 [ 597.225261] ? xa_load+0xaf/0x160 [ 597.225268] handle_ksmbd_work+0x2e0/0x420 [ksmbd] [ 597.225280] ? handle_ksmbd_work+0x2e0/0x420 [ksmbd] [ 597.225292] process_one_work+0x25a/0x5d0 [ 597.225298] worker_thread+0x3f/0x3a0 [ 597.225302] ? __kthread_parkme+0x6f/0xa0 [ 597.225306] ? process_one_work+0x5d0/0x5d0 [ 597.225309] kthread+0x142/0x160 [ 597.225313] ? kthread_park+0x90/0x90 [ 597.225316] ret_from_fork+0x22/0x30 same work struct can be add to list in smb_break_all_write_oplock() and smb_grant_oplock(). If client send invalid lease break ack to server, This issue can occur by calling both functions. Signed-off-by:
-
- 01 Jun, 2021 3 commits
-
-
Namjae Jeon authored
Fix additional warnings from checkpatch.pl --strict. Signed-off-by:
-
Namjae Jeon authored
If *pos or *pos + count is greater than v_len, It will read beyond the stream_buf buffer. This patch add the check and cut down count with size of the buffer. Signed-off-by:
-
Yang Yingliang authored
If ksmbd_vfs_getcasexattr() returns -ENOMEM, stream_buf is NULL, it will cause null-ptr-deref when using it to copy memory. So we need check the return value of ksmbd_vfs_getcasexattr() by comparing with 0. Signed-off-by:
Yang Yingliang <yangyingliang@huawei.com> Signed-off-by:
-
- 31 May, 2021 4 commits
-
-
Yang Yingliang authored
Before ksmbd_vfs_stream_read() return, memory allocate in ksmbd_vfs_getcasexattr() need be freed. Signed-off-by:
-
Yang Yingliang authored
Before assigning wbuf to stream_buf, memory allocate in ksmbd_vfs_getcasexattr() need be freed. Signed-off-by:
-
Hyunchul Lee authored
checkpatch.pl complains as the following: Alignment should match open parenthesis. Signed-off-by:
-
Hyunchul Lee authored
checkpatch.pl complains as the following: CHECK: Macro argument 'fp' may be better as '(fp)' to avoid precedence issues. Signed-off-by:
-
- 28 May, 2021 1 commit
-
-
Namjae Jeon authored
Fix a defect reported by Coverity Scan. *** CID 1504970: Control flow issues (NO_EFFECT) /fs/cifsd/auth.c: 622 in ksmbd_build_ntlmssp_challenge_blob() 616 name = kmalloc(2 + UNICODE_LEN(len), GFP_KERNEL); 617 if (!name) 618 return -ENOMEM; 619 620 conv_len = smb_strtoUTF16((__le16 *)name, ksmbd_netbios_name(), len, 621 sess->conn->local_nls); >>> CID 1504970: Control flow issues (NO_EFFECT) >>> This less-than-zero comparison of an unsigned value is never true. 622 if (conv_len < 0 || conv_len > len) { 623 kfree(name); 624 return -EINVAL; 625 } 626 627 uni_len = UNICODE_LEN(conv_len); Reported-by:Coverity Scan <scan-admin@coverity.com> Signed-off-by:
-
- 26 May, 2021 7 commits
-
-
Hyunchul Lee authored
Some vfs help functions lookup a file with LOOKUP_FOLLOW regardless of the "follow symlinks" option. Signed-off-by:
-
Namjae Jeon authored
Fix a warning from checkpatch.pl --strict: CHECK: Prefer kernel type 'u16' over 'uint16_t' #112: FILE: server.c:112: + uint16_t command; Signed-off-by:
-
Namjae Jeon authored
Fix warnings from checkpatch.pl --strict : CHECK: Unnecessary parentheses around 'brk_op->o_lease->new_state == SMB2_LEASE_NONE_LE' #1511: FILE: oplock.c:1511: + if (brk_op->is_lease && + (brk_op->o_lease->new_state == SMB2_LEASE_NONE_LE) && + atomic_read(&brk_op->breaking_cnt)) Signed-off-by:
-
Namjae Jeon authored
Fix warnings "Alignment should match open parenthesis" from checkpatch.pl --strict. Signed-off-by:
-
Namjae Jeon authored
Blank lines aren't necessary after an open brace '{'. Signed-off-by: -
Namjae Jeon authored
No space is necessary after a cast. Signed-off-by:
-
Namjae Jeon authored
don't use multiple blank lines. Signed-off-by:
-
