An error occurred fetching the project authors.
- 07 Mar, 2012 6 commits
-
-
Johannes Berg authored
The transport doesn't need to include iwl-core.h any more. Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
Wey-Yi Guy <wey-yi.w.guy@intel.com> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Johannes Berg authored
Tracing used the priv pointer as an identifier, which has the problem that we don't have it in all code, and also some people say no pointers should be "leaked" to userspace. Use the device name instead, it is more useful anyway. Signed-off-by:
-
Johannes Berg authored
There's no need to copy shadow_reg_enable into hw_params since it is a pure hardware parameter that will never change, we can access it from the config directly. Signed-off-by:
-
Johannes Berg authored
The transport layer should only check the hardware RF kill status, not impose any policy or reaction based on it, so move that out of it into the op_mode. For now keep the restriction on loading firmware, that will have to be removed later. Signed-off-by:
-
Johannes Berg authored
This file was recently introduced, but then directly abused -- it contained private data that shouldn't have been used by anything but the implementation of firmware requests and some very core code. Now that it is no longer accessed by any code but the code in iwl-drv.c, we can dissolve it. Also rename the iwl_nic struct to iwl_drv to better reflect where and how it is used. Signed-off-by:
-
Johannes Berg authored
Through the driver, struct iwl_fw will store the firmware. Split this out into a separate file, iwl-fw.h, and make all other code use it. To do this, also move the log pointers into it, and remove the knowledge of "nic" from everything. Now the op_mode has a fw pointer, and (unfortunately) for now the shared data also needs to keep one for the transport to access dump the error log -- I think that will move later. Since I wanted to constify the firmware pointers, some more changes were needed. Signed-off-by:
-
- 06 Mar, 2012 3 commits
-
-
Johannes Berg authored
Just make the code easier to read with less indentation. Signed-off-by:
-
Johannes Berg authored
struct iwl_rx_mem_buffer implementation details (DMA address, list pointers) that the upper layers don't need. Introduce iwl_rx_cmd_buffer that is passed upstream and only contains the needed data (the page). Additionally, access this data only via accessor functions, allowing us to change the implementation in the future. These accessors are rxb_addr() (as before) and rxb_steal_page() to take ownership of the data. Signed-off-by:
-
Johannes Berg authored
There's no need for the per-device debug level that we expose in debugfs since the module parameter is writable in sysfs. At the same time, simplify code by changing iwl_get_debug_level(shrd) & IWL_DL_ISR) to iwl_have_debug_level(IWL_DL_ISR) Signed-off-by:
-
- 27 Feb, 2012 5 commits
-
-
Emmanuel Grumbach authored
It is op_mode related Signed-off-by:
Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by:
-
Emmanuel Grumbach authored
The transport should not dereference the iwl_priv pointer. Remove a few of those. Signed-off-by:
-
Emmanuel Grumbach authored
Export it as "nic_error" notification, the error handling will be in the op_mode. Signed-off-by:
-
Emmanuel Grumbach authored
Export it as "hw_rf_kill" notification. Signed-off-by:
-
Emmanuel Grumbach authored
This is the op_mode's Rx handler. Signed-off-by:
-
- 17 Feb, 2012 3 commits
-
-
Don Fry authored
Move the ucode offset pointers to the iwl_nic as they are nic related. Signed-off-by:
Don Fry <donald.h.fry@intel.com> Signed-off-by:
-
Johannes Berg authored
Instead of using a global lock, the PCIe transport can use an own lock for its IRQ. This will make it possible to not disable IRQs for the shared lock. The lock is currently used throughout the code but this can be improved even further by splitting up the locking for the queues. Signed-off-by:
-
Johannes Berg authored
In order to separate the different parts of the driver better, we are reducing the shared data. This moves the workqueue to "priv", and removes it from the transport. To do this, simply use schedule_work() in the transport. Signed-off-by:
-
- 02 Feb, 2012 5 commits
-
-
Emmanuel Grumbach authored
This trans_ops->stop_hw leaves the RFKILL interrupt enabled, we can call that one instead of enable_rfkill_int. By that, we reduce the numbers of acceesses to the NIC from the upper layers. Signed-off-by:
-
Emmanuel Grumbach authored
Now there is only one transport function that launch a specific fw: trans_ops->start_fw. This one replaces trans_ops->start_device and trans_ops->kick_nic. The code that actually loads the fw to the device has been moved to the transport specific code. Signed-off-by:
-
Emmanuel Grumbach authored
From now on, the transport layer in charge of providing access to the device. So change all the driver to give a pointer to the transport to all the low level functions that actually access the device. Signed-off-by:
-
Gregory Greenman authored
This patch connects IDI transport to driver. It does so by using a number of ifdefs at this stage. IDI is a new transport that is under development. Signed-off-by:
Gregory Greenman <gregory.greenman@intel.com> Signed-off-by:
-
Emmanuel Grumbach authored
Define a new handler in the transport layer API: fw_alive. Move iwl_reset_ict to this new handler, and move the content of tx_start to this handler. Signed-off-by:
-
- 24 Jan, 2012 2 commits
-
-
Johannes Berg authored
When an interrupt comes in, we read the reason bits and collect them into "trans_pcie->inta". This happens with the spinlock held. However, there's a bug resetting this variable -- that happens after the spinlock has been released. This means that it is possible for interrupts to be missed if the reset happens after some other interrupt reasons were already added to the variable. I found this by code inspection, looking for a reason that we sometimes see random commands time out. It seems possible that this causes such behaviour, but I can't say for sure right now since it happens extremely infrequently on my test systems. Cc: stable@vger.kernel.org [3.2] Signed-off-by:
-
Wey-Yi Guy authored
Update Copyright to 2012 Signed-off-by:
-
- 06 Jan, 2012 1 commit
-
-
Wey-Yi Guy authored
Update Copyright to 2012 Signed-off-by:
-
- 21 Dec, 2011 1 commit
-
-
Johannes Berg authored
The ICT code erroneously uses PAGE_SIZE. The bug is that PAGE_SIZE isn't necessarily 4096, so on such platforms this code will not work correctly as we'll try to attempt to read an index in the table that the device never wrote, it always has 4096-byte pages. Additionally, the manual alignment code here is unnecessary -- Documentation/DMA-API-HOWTO.txt states: The cpu return address and the DMA bus master address are both guaranteed to be aligned to the smallest PAGE_SIZE order which is greater than or equal to the requested size. This invariant exists (for example) to guarantee that if you allocate a chunk which is smaller than or equal to 64 kilobytes, the extent of the buffer you receive will not cross a 64K boundary. Just use appropriate new constants and get rid of the alignment code. Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Cc: stable@vger.kernel.org Signed-off-by:
-
- 19 Dec, 2011 1 commit
-
-
Johannes Berg authored
The legacy IRQs could be read from a trace by their IO accesses, but reading the ICT doesn't leave any trace (pun intended ;-) ) so in order to see what input they get we need to add specific tracepoints. While at it, fix whitespace in two related places. Signed-off-by:
-
- 16 Dec, 2011 1 commit
-
-
Don Fry authored
Move the configuration pointer from the upper level iwl_priv to the lower level iwl_shared structure, with associated code fixes. Signed-off-by:
-
- 08 Dec, 2011 2 commits
-
-
Don Fry authored
Move the low level ucode device_pointers structure to iwl_shared. Signed-off-by:
-
Wey-Yi Guy authored
When uCode encounter problem, it pass a lot of debug data to help debugging the issue. We only show partial data before, why not display all of those. Signed-off-by:
-
- 06 Dec, 2011 1 commit
-
-
Don Fry authored
Move the ucode_type variable from the iwl_priv to the iwl_shared structure with associated code changes. Signed-off-by:
-
- 02 Dec, 2011 1 commit
-
-
Don Fry authored
Move the ucode_type variable from the iwl_priv to the iwl_shared structure with associated code changes. Signed-off-by:
-
- 11 Nov, 2011 1 commit
-
-
Don Fry authored
ucode_write_complete is used for ucode loading. Move it as part of restructuring work out of the priv structure. Signed-off-by:
-
- 14 Oct, 2011 1 commit
-
-
Emmanuel Grumbach authored
Move iwl_enable_rfkill_int to iwl-core.h, and remove the empty iwl-helpers.h Signed-off-by:
-
- 27 Sep, 2011 1 commit
-
-
Emmanuel Grumbach authored
Txid was used without being initialized. Signed-off-by:
-
- 21 Sep, 2011 1 commit
-
-
Emmanuel Grumbach authored
Before this patch, the upper layer could register a callback for each host command. This mechanism allowed the upper layer to have different callbacks for the same command ID. In fact, it wasn't used and the rx_handlers is enough: same callback for all the command with a specific command ID. The iwl_send_add_station needs the access the command that was sent while handling the response (regardless if the command was sent in SYNC or ASYNC mode). So now, all the handlers receive the host command that was sent. This implies a change in the handler signature. Signed-off-by:
-
- 19 Sep, 2011 3 commits
-
-
Johannes Berg authored
Since the dawn of its time, iwlwifi has used interruptible waits to wait for synchronous commands and firmware loading. This leads to "interesting" bugs, because it can't actually handle the interruptions; for example when a command sending is interrupted it will assume the command completed fully, and then leave it pending, which leads to all kinds of trouble when the command finishes later. Since there's no easy way to gracefully deal with interruptions, fix the driver to not use interruptible waits. This at least fixes the error iwlagn 0000:02:00.0: Error: Response NULL in 'REPLY_SCAN_ABORT_CMD' I have seen in P2P testing, but it is likely that there are other errors caused by this. Cc: Stanislaw Gruszka <sgruszka@redhat.com> Cc: stable@kernel.org [2.6.24+] Signed-off-by:
-
Johannes Berg authored
Move all the PCI-E specific transport files to be iwl-trans-pcie*; specifically iwl-trans.c which is really iwl-trans-pcie.c. Signed-off-by:
-
Emmanuel Grumbach authored
The way we check if there is host command that should be reclaimed is way too complicated. We should have a clear indication from the fw. The fw is expected to set the SEQ_RX_FRAME bit if the frame was originated by the fw which indicates to the driver that there is no host command to free. Somehow, there seem to have been buggy fw out there, hence the very old comment. This code checks if we have still buggy fw out there. Signed-off-by:
-
- 14 Sep, 2011 1 commit
-
-
Wey-Yi Guy authored
Few lines for program bt_ch_announce being place in the wrong place. Remove those. Signed-off-by:
-
