1. 26 Mar, 2007 9 commits
    • Michael Chan's avatar
      [TG3]: Eliminate the unused TG3_FLAG_SPLIT_MODE flag. · 1c46ae05
      Michael Chan authored
      This flag to support multiple PCIX split completions was never used
      because of hardware bugs.  This will make room for a new flag.
      Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1c46ae05
    • David S. Miller's avatar
      [IPV6]: Fix routing round-robin locking. · f11e6659
      David S. Miller authored
      As per RFC2461, section 6.3.6, item #2, when no routers on the
      matching list are known to be reachable or probably reachable we
      do round robin on those available routes so that we make sure
      to probe as many of them as possible to detect when one becomes
      reachable faster.
      
      Each routing table has a rwlock protecting the tree and the linked
      list of routes at each leaf.  The round robin code executes during
      lookup and thus with the rwlock taken as a reader.  A small local
      spinlock tries to provide protection but this does not work at all
      for two reasons:
      
      1) The round-robin list manipulation, as coded, goes like this (with
         read lock held):
      
      	walk routes finding head and tail
      
      	spin_lock();
      	rotate list using head and tail
      	spin_unlock();
      
         While one thread is rotating the list, another thread can
         end up with stale values of head and tail and then proceed
         to corrupt the list when it gets the lock.  This ends up causing
         the OOPS in fib6_add() later onthat many people have been hitting.
      
      2) All the other code paths that run with the rwlock held as
         a reader do not expect the list to change on them, they
         expect it to remain completely fixed while they hold the
         lock in that way.
      
      So, simply stated, it is impossible to implement this correctly using
      a manipulation of the list without violating the rwlock locking
      semantics.
      
      Reimplement using a per-fib6_node round-robin pointer.  This way we
      don't need to manipulate the list at all, and since the round-robin
      pointer can only ever point to real existing entries we don't need
      to perform any locking on the changing of the round-robin pointer
      itself.  We only need to reset the round-robin pointer to NULL when
      the entry it is pointing to is removed.
      
      The idea is from Thomas Graf and it is very similar to how this
      was implemented before the advanced router selection code when in.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f11e6659
    • Thomas Graf's avatar
      [DECNet] fib: Fix out of bound access of dn_fib_props[] · a9791011
      Thomas Graf authored
      Fixes a typo which caused fib_props[] to have the wrong size
      and makes sure the value used to index the array which is
      provided by userspace via netlink is checked to avoid out of
      bound access.
      Signed-off-by: default avatarThomas Graf <tgraf@suug.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a9791011
    • Thomas Graf's avatar
      [IPv4] fib: Fix out of bound access of fib_props[] · a0ee18b9
      Thomas Graf authored
      Fixes a typo which caused fib_props[] to have the wrong size
      and makes sure the value used to index the array which is
      provided by userspace via netlink is checked to avoid out of
      bound access.
      Signed-off-by: default avatarThomas Graf <tgraf@suug.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a0ee18b9
    • Ralf Baechle's avatar
      [NET] AX.25 Kconfig and docs updates and fixes · 954b2e7f
      Ralf Baechle authored
       o The AX.25 Howto is unmaintained since several years.  I've replaced it
         with a wiki at http://www.linux-ax25.org which provides more uptodate
         information.
       o Change default for AX25_DAMA_SLAVE to Y.  AX25_DAMA_SLAVE only compiles
         in support for DAMA but doesn't activate it.  I hope this gets Linux
         distributions to ship their AX.25 kernels with AX25_DAMA_SLAVE enabled.
         The price for this would be very small.
       o Delete historic changelog from comments, that's what SCM systems are
         meant to do.
       o ---help--- in Kconfig looks so yellingly eye insulting.  Use just help.
       o Rewrite the commented out piece of old Linux 2.4 configuration language
         to Kconfig for consistency.
       o Fixup dependencies.
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      954b2e7f
    • Alexey Kuznetsov's avatar
      [NET]: Fix neighbour destructor handling. · ecbb4169
      Alexey Kuznetsov authored
      ->neigh_destructor() is killed (not used), replaced with
      ->neigh_cleanup(), which is called when neighbor entry goes to dead
      state. At this point everything is still valid: neigh->dev,
      neigh->parms etc.
      
      The device should guarantee that dead neighbor entries (neigh->dead !=
      0) do not get private part initialized, otherwise nobody will cleanup
      it.
      
      I think this is enough for ipoib which is the only user of this thing.
      Initialization private part of neighbor entries happens in ipib
      start_xmit routine, which is not reached when device is down.  But it
      would be better to add explicit test for neigh->dead in any case.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ecbb4169
    • Thomas Graf's avatar
      [NET]: Fix fib_rules compatibility breakage · e1701c68
      Thomas Graf authored
      Based upon a patch from Patrick McHardy.
      
      The fib_rules netlink attribute policy introduced in 2.6.19 broke
      userspace compatibilty. When specifying a rule with "from all"
      or "to all", iproute adds a zero byte long netlink attribute,
      but the policy requires all addresses to have a size equal to
      sizeof(struct in_addr)/sizeof(struct in6_addr), resulting in a
      validation error.
      
      Check attribute length of FRA_SRC/FRA_DST in the generic framework
      by letting the family specific rules implementation provide the
      length of an address. Report an error if address length is non
      zero but no address attribute is provided. Fix actual bug by
      checking address length for non-zero instead of relying on
      availability of attribute.
      Signed-off-by: default avatarThomas Graf <tgraf@suug.ch>
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e1701c68
    • Sridhar Samudrala's avatar
      [SCTP]: Update SCTP Maintainers entry · 5f85813c
      Sridhar Samudrala authored
      Add Vlad Yasevich as the primary maintainer of SCTP and add a
      link to the project website.
      Signed-off-by: default avatarSridhar Samudrala <sri@us.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5f85813c
    • Robert P. J. Day's avatar
      [NET]: remove unused header file: drivers/net/wan/lmc/lmc_media.h · ea3d0d77
      Robert P. J. Day authored
      Signed-off-by: default avatarRobert P. J. Day <rpjday@mindspring.com>
      Cc: Krzysztof Halasa <khc@pm.waw.pl>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ea3d0d77
  2. 25 Mar, 2007 4 commits
  3. 24 Mar, 2007 15 commits
  4. 23 Mar, 2007 12 commits