1. 26 Jun, 2004 1 commit
    • Randy Dunlap's avatar
      [PATCH] fdomain screwup · 1dd040ff
      Randy Dunlap authored
      | From: Andrew Morton
      | To: linux-scsi@vger.kernel.org
      | Subject: fdomain screwup
      |
      | - fdomain_setup() is marked __init, but is called from non-__init
      |   fdomain_16x0_detect()
      |
      | - fdomain_setup() is declared in drivers/scsi/pcmcia/fdomain_stub.c as
      |   taking two arguments, but is implemented in fdomain_setup() taking a
      |   single argument.
      |
      |   Please, never ever ever put extern function declarations in .c files.
      |   Put it in a header file which is visible to the definition and to all
      |   callsites.
      |
      | - fdomain_setup() is declared static, hence the linkage fails.
      |
      | - fdomain_16x0_bus_reset() is implemented in drivers/scsi/fdomain.c but
      |   has static scope, so the call from drivers/scsi/pcmcia/fdomain_stub.c
      |   doesn't work.
      
      [I didn't find this to be the case, so I didn't fix it.]
      
      | - fdomain_16x0_bus_reset() has an extern declaration in
      |   drivers/scsi/pcmcia/fdomain_stub.c.  This should be moved to a header
      |   file which is visible to etc...
      
      Builds and loads.  No hardware to test.
      Signed-off-by: default avatarRandy Dunlap <rddunlap@osdl.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      1dd040ff
  2. 18 Jun, 2004 39 commits