1. 02 Aug, 2009 2 commits
    • Henrique de Moraes Holschuh's avatar
      thinkpad-acpi: remove dock and bay subdrivers · 1f6fc2de
      Henrique de Moraes Holschuh authored
      The standard ACPI dock driver can handle the hotplug bays and docks of
      the ThinkPads just fine (including batteries) as of 2.6.27, and the
      code in thinkpad-acpi for the dock and bay subdrivers is currently
      broken anyway...
      
      Userspace needs some love to support the two-stage ejection nicely,
      but it is simple enough to do through udev rules (you don't even need
      HAL) so this wouldn't justify fixing the dock and bay subdrivers,
      either.
      
      That leaves warm-swap bays (_EJ3) support for thinkpad-acpi, as well
      as support for the weird dock of the model 570, but since such support
      has never left the "experimental" stage, it is also not a strong
      enough reason to find a way to fix this code.
      
      Users of ThinkPads with warm-swap bays are urged to request that _EJ3
      support be added to the regular ACPI dock driver, if such feature is
      indeed useful for them.
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      1f6fc2de
    • Henrique de Moraes Holschuh's avatar
      thinkpad-acpi: disable broken bay and dock subdrivers · 550e7fd8
      Henrique de Moraes Holschuh authored
      Currently, the ThinkPad-ACPI bay and dock drivers are completely
      broken, and cause a NULL pointer derreference in kernel mode (and,
      therefore, an OOPS) when they try to issue events (i.e. on dock,
      undock, bay ejection, etc).
      
      OTOH, the standard ACPI dock driver can handle the hotplug bays and
      docks of the ThinkPads just fine (including batteries) as of 2.6.27.
      In fact, it does a much better job of it than thinkpad-acpi ever did.
      
      It is just not worth the hassle to find a way to fix this crap without
      breaking the (deprecated) thinkpad-acpi dock/bay ABI.  This is old,
      deprecated code that sees little testing or use.
      
      As a quick fix suitable for -stable backports, mark the thinkpad-acpi
      bay and dock subdrivers as BROKEN in Kconfig.  The dead code will be
      removed by a later patch.
      
      This fixes bugzilla #13669, and should be applied to 2.6.27 and later.
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Reported-by: default avatarJoerg Platte <jplatte@naasa.net>
      Cc: stable@kernel.org
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      550e7fd8
  2. 01 Aug, 2009 1 commit
  3. 31 Jul, 2009 19 commits
  4. 30 Jul, 2009 18 commits