- 15 Jun, 2021 38 commits
-
-
Sergio Paracuellos authored
PCI_IOBASE is used to create VM maps for PCI I/O ports, it is required by generic PCI drivers to make memory mapped I/O range work. Hence define it for ralink architectures to be able to avoid parsing manually IO ranges in PCI generic driver code. Function 'plat_mem_setup' for ralink is using 'set_io_port_base' call using '0xa0000000' as address, so use the same address in the definition to align things. Acked-by:
Thomas Bogendoerfer <tsbogend@alpha.franken.de> Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Link: https://lore.kernel.org/r/20210614100617.28753-2-sergio.paracuellos@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Fabio Aiuto authored
remove unused files from tree, for they are excluded by the build process. Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Fabio Aiuto <fabioaiuto83@gmail.com> Link: https://lore.kernel.org/r/ef7c21270ccaa2ee3d48b93d0a16fa55911c6cce.1623756906.git.fabioaiuto83@gmail.comSigned-off-by:
-
Fabio Aiuto authored
remove include/autoconf.h header file from tree. It just contains a compiler configuration check which is not needed. Reviewed-by:
-
Fabio Aiuto authored
move LPS_RPWM_WAIT_MS macro from include/autoconf.h to include/hal_btcoex.h in order to empty unneeded autoconf.h. Reviewed-by:
-
Fabio Aiuto authored
remove HAL_{BB,MAC,RF,FW}_ENABLE macros. They are used to turn on/off by hand some core capabilities we want to be always 'on'. So remove usages and definitions. Reviewed-by: -
Fabio Aiuto authored
remove unneeded DISABLE_BB_RF macro. This is just a symbolic constant used to disable by hand-edit some core hardware capabilities which we want to be always enabled. So just remove it. Reviewed-by:
-
Fabio Aiuto authored
remove unused WAKEUP_GPIO_IDX macro definition. Reviewed-by:
-
Fabio Aiuto authored
remove unneeded comments in include/autoconf.h Reviewed-by:
-
Fabio Aiuto authored
remove unused debug macro definition in include/autoconf.h Reviewed-by:
-
Phillip Potter authored
As all callers have now been removed, remove the definition of the DBG_88E macro itself. It is no longer required and is dead code. Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20210615001507.1171-29-phil@philpotter.co.ukSigned-off-by:
-
Phillip Potter authored
Remove core/rtw_debug.c as all the functions contained within it are entirely unused, and modify the Makefile to remove it as a build requirement. Also remove the function declarations from include/rtw_debug.h - this is part of an ongoing effort to purge dead/unused code and cleanup this driver. This has the helpful side effect of removing all DBG_88E macro calls within this file as well. Signed-off-by:
-
Phillip Potter authored
Remove all previously converted netdev_dbg calls from core/rtw_sta_mgt.c, as these were originally DBG_88E macro calls, and therefore of dubious necessity to begin with. Signed-off-by:
-
Phillip Potter authored
Remove all previously converted netdev_dbg calls from core/rtw_recv.c, as these were originally DBG_88E macro calls, and therefore of dubious necessity to begin with. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from hal/rtl8188eu_xmit.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from hal/rtl8188eu_recv.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from hal/usb_halinit.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Also remove unused jiffies variable from the start of rtl8188eu_hal_init. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from hal/rtl8188e_xmit.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from hal/rtl8188e_hal_init.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from hal/pwrseqcmd.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from hal/rtl8188e_cmd.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from hal/hal_intf.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from os_dep/rtw_android.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from os_dep/xmit_linux.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from os_dep/mlme_linux.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from os_dep/os_intfs.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Also remove variable declarations for variables which now go unused as a result of this change with os_dep/os_intfs.c Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from os_dep/usb_intf.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from os_dep/ioctl_linux.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_mlme.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_ioctl_set.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_security.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_ieee80211.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_pwrctrl.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Also remove pmlmepriv declaration from within rtw_ps_processor as it is now no longer used. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_ap.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_wlan_util.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_mlme_ext.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Also remove variable declarations for variables which now go unused as a result of this change with core/rtw_mlme_ext.c Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_xmit.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Also remove static rtw_sctx_chk_warning_status function, as it no longer has any callers. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E calls from core/rtw_efuse.c as this macro is unnecessary, and many of these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Fabio M. De Francesco authored
Converted visorhba from IDR to XArray. The abstract data type XArray is more memory-efficient, parallelizable, and cache friendly. It takes advantage of RCU to perform lookups without locking. Furthermore, IDR is deprecated because XArray has a better (cleaner and more consistent) API. Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Link: https://lore.kernel.org/r/20210514081112.19542-1-fmdefrancesco@gmail.comSigned-off-by:
-
- 14 Jun, 2021 2 commits
-
-
Pavel Skripkin authored
There is a leak in rtl8712 driver. The problem was in non-freed adapter data if firmware load failed. This leak can be reproduced with this code: https://syzkaller.appspot.com/text?tag=ReproC&x=16612f02d00000, Autoload must fail (to not hit memory leak reported by syzkaller) There are 2 possible ways how rtl871x_load_fw_cb() and r871xu_dev_remove() can be called (in case of fw load error). 1st case: r871xu_dev_remove() then rtl871x_load_fw_cb() In this case r871xu_dev_remove() will wait for completion and then will jump to the end, because rtl871x_load_fw_cb() set intfdata to NULL: if (pnetdev) { struct _adapter *padapter = netdev_priv(pnetdev); /* never exit with a firmware callback pending */ wait_for_completion(&padapter->rtl8712_fw_ready); pnetdev = usb_get_intfdata(pusb_intf); usb_set_intfdata(pusb_intf, NULL); if (!pnetdev) goto firmware_load_fail; ... clean up code here ... } 2nd case: rtl871x_load_fw_cb() then r871xu_dev_remove() In this case pnetdev (from code snippet above) will be zero (because rtl871x_load_fw_cb() set it to NULL) And clean up code won't be executed again. So, in all cases we need to free adapted data in rtl871x_load_fw_cb(), because disconnect function cannot take care of it. And there won't be any race conditions, because complete() call happens after setting intfdata to NULL. In previous patch I moved out free_netdev() from r8712_free_drv_sw() and that's why now it's possible to free adapter data and then call complete. Fixes: 8c213fa5 ("staging: r8712u: Use asynchronous firmware loading") Signed-off-by:
Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/81e68fe0194499cc2e7692d35bc4dcf167827d8f.1623620630.git.paskripkin@gmail.comSigned-off-by:
-
Pavel Skripkin authored
Previous error handling path was unique for all possible errors and there was unnecessary branching. Also, one step for freeing drv_sw was missing. All these problems was fixed by restructuring error handling path. Also, moved out free_netdev() from r8712_free_drv_sw() for correct error handling. Fixes: 2865d42c ("staging: r8712u: Add the new driver to the mainline kernel") Signed-off-by:
-
