- 20 Jun, 2019 3 commits
-
-
Enric Balletbo i Serra authored
On many boards, communication between the kernel and the Embedded Controller happens over an LPC bus. In these cases, the kernel config CONFIG_CROS_EC_LPC is enabled. Some of these LPC boards contain a Microchip Embedded Controller (MEC) that is different from the regular EC. On these devices, the same LPC bus is used, but the protocol is a little different. In these cases, the CONFIG_CROS_EC_LPC_MEC kernel config is enabled. Currently, the kernel decides at compile-time whether or not to use the MEC variant, and, when that kernel option is selected it breaks the other boards. We would like a kind of runtime detection to avoid this. This patch adds that detection mechanism by probing the protocol at runtime, first we assume that a MEC variant is connected, and if the protocol fails it fallbacks to the regular EC. This adds a bit of overload because we try to read twice on those LPC boards that doesn't contain a MEC variant, but is a better solution than having to select the EC variant at compile-time. While here also fix the alignment in Kconfig file for this config option replacing the spaces by tabs. Signed-off-by:
Enric Balletbo i Serra <enric.balletbo@collabora.com> Reviewed-by:
Ezequiel Garcia <ezequiel@collabora.com> Tested-by:
Nick Crews <ncrews@chromium.org> Reviewed-by:
-
Enric Balletbo i Serra authored
The cros_ec_lpc_reg files are only used by the cros_ec_lpc core and there isn't logical separation between them. So, merge those files into the cros_ec_lpc also allowing us to drop the header file used for the interface between the two. Signed-off-by:
-
Ting Shen authored
http://crosreview.com/1341159 added a EC_MKBP_HAS_MORE_EVENTS flag to the event_type field, the receiver side should mask out this extra bit when processing the event. Signed-off-by:
Ting Shen <phoenixshen@chromium.org> Reviewed-by:
Enrico Granata <egranata@google.com> Acked-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by:
Benson Leung <bleung@chromium.org> Signed-off-by:
-
- 18 Jun, 2019 5 commits
-
-
Nick Crews authored
When copying an event to userspace failed, the event queue lock was never released. This fixes that. Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
kbuild test robot authored
Fixes: 909447f683b3 ("platform/chrome: cros_ec_debugfs: Add debugfs entry to retrieve EC uptime") Signed-off-by:kbuild test robot <lkp@intel.com> Signed-off-by:
-
Enric Balletbo i Serra authored
Add the missing ABI documentation for the already available debugfs entries: console_log, panicinfo and pdinfo. Signed-off-by: -
Enric Balletbo i Serra authored
kernel-doc comments have a prescribed format. To be _particularly_ correct we should also capitalise the brief description and terminate it with a period. Signed-off-by: -
Tim Wawrzynczak authored
The new debugfs entry 'uptime' is being made available to userspace so that a userspace daemon can synchronize EC logs with host time. Signed-off-by:
Tim Wawrzynczak <twawrzynczak@chromium.org> [rework based on Tim's first approach] Signed-off-by:
-
- 12 Jun, 2019 1 commit
-
-
Enric Balletbo i Serra authored
Immutable branch between MFD and chrome-platform for driver changes to allow picking patches that depends on the cros_ec_commands.h file update. Signed-off-by:
-
- 10 Jun, 2019 30 commits
-
-
Gwendal Grignou authored
Improve I2S API. Rename ec_response_codec_gain into ec_codec_i2s_gain, update caller accordlingly. Signed-off-by:
Gwendal Grignou <gwendal@chromium.org> Acked-by:
Fabien Lahoudere <fabien.lahoudere@collabora.com> Signed-off-by:
Lee Jones <lee.jones@linaro.org>
-
Gwendal Grignou authored
Add commands for test and management. Add command space for future development. Signed-off-by:
-
Gwendal Grignou authored
Add API to store SKU, Cros board information in EC flash memory. Add API to store security data in EC. Signed-off-by:
-
Gwendal Grignou authored
Add command to retrieve signature of image stored in the RW memory slot(s). Signed-off-by:
-
Gwendal Grignou authored
Add API for fingerprint sensor presented by embedded controller. Signed-off-by:
-
Gwendal Grignou authored
Add API to control touchpad presented by Embedded Controller. Signed-off-by:
-
Gwendal Grignou authored
Allow EC to talk to other ECs that are not presented to the host. Neeed when EC are present in detachable keyboard. Signed-off-by:
-
Gwendal Grignou authored
Prevent direct i2c access to device behind EC when not in development mode. Signed-off-by:
-
Gwendal Grignou authored
Add API to update battery firmware. Signed-off-by:
-
Gwendal Grignou authored
Add support for controlling hibernation of the Embedded Controller. Signed-off-by:
-
Gwendal Grignou authored
Add command to allow keyboard testing in factory. Signed-off-by:
-
Gwendal Grignou authored
Improve API for USB Powe delivery and power management. Signed-off-by:
-
Gwendal Grignou authored
Improve API to retrieve temperature information. Signed-off-by:
-
Gwendal Grignou authored
Add support for fingerprint sensors managed by embedded controller. Signed-off-by:
-
Gwendal Grignou authored
Improve API between EC and Host to report events. Signed-off-by:
-
Gwendal Grignou authored
Add new command for batched mode, add support for more sensors. Signed-off-by:
-
Gwendal Grignou authored
Introduce a new transport procotol between EC and host. Signed-off-by:
-
Gwendal Grignou authored
Improve API to verify EC image signature. Signed-off-by:
-
Gwendal Grignou authored
New API split commands, improve EC command latency. Signed-off-by:
-
Gwendal Grignou authored
Add API for fan control. Signed-off-by:
-
Gwendal Grignou authored
Added for supporting larger embedded controller flash. Signed-off-by:
-
Gwendal Grignou authored
Empty structure size is different between C and C++. To prevent clang warning when compiling this include file in C++ programs, remove empty structures. Signed-off-by:
-
Gwendal Grignou authored
Move near the end of file. Signed-off-by:
-
Gwendal Grignou authored
Add more fields and improve API when EC presents data through ACPI memory space. Signed-off-by:
-
Gwendal Grignou authored
Replace (1 << ...) with BIT(). Signed-off-by:
-
Gwendal Grignou authored
This change is required for compilation of embedded controller firmware to work properly (See CONFIG_HOSTCMD_SECTION_SORTED). Signed-off-by:
-
Gwendal Grignou authored
To reduce code and improve performance of the embedded controller firmware, pragma __aligned(2) or __aligned(4) are used when alignment to 16 or 32 bit boundary is expected. Define all ec_align to packed when compiling kernel. Signed-off-by:
-
Gwendal Grignou authored
Fix comments syntax and spelling errors. Signed-off-by:
-
Gwendal Grignou authored
Defined out build macro used when compiling embedded controller firmware. Signed-off-by:
-
Gwendal Grignou authored
Update to SPDX-License-Identifier, GPL-2.0 Signed-off-by:
-
- 05 Jun, 2019 1 commit
-
-
YueHaibing authored
Fix sparse warning: drivers/platform/chrome/cros_ec_debugfs.c:256:30: warning: symbol 'cros_ec_console_log_fops' was not declared. Should it be static? drivers/platform/chrome/cros_ec_debugfs.c:265:30: warning: symbol 'cros_ec_pdinfo_fops' was not declared. Should it be static? drivers/platform/chrome/cros_ec_lightbar.c:550:24: warning: symbol 'cros_ec_lightbar_attr_group' was not declared. Should it be static? drivers/platform/chrome/cros_ec_sysfs.c:338:24: warning: symbol 'cros_ec_attr_group' was not declared. Should it be static? drivers/platform/chrome/cros_ec_vbc.c:104:24: warning: symbol 'cros_ec_vbc_attr_group' was not declared. Should it be static? drivers/platform/chrome/cros_ec_lpc.c:408:25: warning: symbol 'cros_ec_lpc_pm_ops' was not declared. Should it be static? Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Reviewed-by:
-
