1. 01 Nov, 2016 16 commits
  2. 31 Oct, 2016 24 commits
    • Filip Sadowski's avatar
      i40e: removed unreachable code · 3aa7b74d
      Filip Sadowski authored
      Removed some of unnecessary if statements and unreachable code found by
      static code analysis tool.
      The return value of i40e_vsi_control_rings(..., false) is always 0. So,
      test for non-zero will never be true. The function has been split into
      "int i40e_vsi_start_rings()" and "void i40e_vsi_stop_rings()" for better
      understanding.
      Similarly, the function i40e_vsi_kill_vlan() never fails. So, checking
      for return value is also unnecessary. Function definition changed to void.
      The i40e_loopback_test() function is not implemented. The function and
      all references to loopback testing were removed.
      
      Change-ID: Id45cf66f6689ce2bc4e887de13f073e30e8431bd
      Signed-off-by: default avatarFilip Sadowski <filip.sadowski@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      3aa7b74d
    • Maciej Sosin's avatar
      i40e: Implementation of ERROR state for NVM update state machine · 81fa7c97
      Maciej Sosin authored
      This patch adds I40E_NVMUPD_STATE_ERROR state for NVM update.
      Without this patch driver has no possibility to return NVM image write
      failure.This state is being set when ARQ rises error.
      arq_last_status is also updated every time when ARQ event comes,
      not only on error cases.
      
      Change-ID: I67ce43ba22a240773c2821b436e96054db0b7c81
      Signed-off-by: default avatarMaciej Sosin <maciej.sosin@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      81fa7c97
    • Michal Kosiarz's avatar
      i40e: Fix for division by zero · 999b315d
      Michal Kosiarz authored
      For some cases when reading from device are incorrect or image is
      incorrect, this part of code causes crash due to division by zero.
      
      Change-ID: I8961029a7a87b0a479995823ef8fcbf6471405e1
      Signed-off-by: default avatarMichal Kosiarz <michal.kosiarz@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      999b315d
    • Mitch Williams's avatar
      i40e: clear mac filter count on reset · 13fd3f9c
      Mitch Williams authored
      When a VF is reset, it gets a new VSI, so all of its MAC filters go
      away. Correctly set the number of filters to 0 when freeing VF
      resources. This corrects a problem with failure to add filters when the
      VF driver is reloaded.
      
      Change-ID: I2acbecf734287b67473bb225293e14b5096acbef
      Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      13fd3f9c
    • Alexander Duyck's avatar
      i40e: Reorder logic for coalescing RS bits · 1dc8b538
      Alexander Duyck authored
      This patch reorders the logic at the end of i40e_tx_map to address the
      fact that the logic was rather convoluted and much larger than it needed
      to be.
      
      In order to try and coalesce the code paths I have updated some of the
      comments and repurposed some of the variables in order to reduce
      unnecessary overhead.
      
      This patch does the following:
      1.  Quit tracking skb->xmit_more with a flag, just max out packet_stride
      2.  Drop tail_bump and do_rs and instead just use desc_count and td_cmd
      3.  Pull comments from ixgbe that make need for wmb() more explicit.
      
      Change-ID: Ic7da85ec75043c634e87fef958109789bcc6317c
      Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      1dc8b538
    • Alexander Duyck's avatar
      i40e: Add common function for finding VSI by type · 4b816446
      Alexander Duyck authored
      This patch adds a common method for finding a VSI by type.  The main
      motivation for doing this is that the Flow Director path actually had two
      ways of handling this, one stopped on first match and one did not.  This
      patch makes it so that all callers of this function will get the same
      approach for finding a VSI.
      
      Change-ID: Ibf25de8acd8466582520694424aa87da66965fbd
      Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
      Signed-off-by: default avatarBimmy Pujari <bimmy.pujari@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      4b816446
    • Jacob Keller's avatar
      i40evf: avoid an extra msleep while · 7d3f04af
      Jacob Keller authored
      Remove the second call to msleep outside the loop, and move the msleep
      within the loop as the first step. This guarantees that a single loop
      will wait the minimum time first, and then after the reset finishes we
      no longer need an extra msleep.
      
      Change-ID: Ib2086f0a142402b614f67846bc091754203a0b9a
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      7d3f04af
    • Jacob Keller's avatar
      i40e: replace PTP Rx timestamp hang logic · 12490501
      Jacob Keller authored
      The current Rx timestamp hang logic is not very robust because it does
      not notice a register is hung until all four timestamps have been
      latched and we wait a full 5 seconds. Replace this logic with a newer Rx
      hang detection based on storing the jiffies when we first notice
      a receive timestamp event. We store each register's time separately,
      along with a flag indicating if it is currently latched. Upon first
      transitioning to latch, we will update the latch_events[i] jiffies
      value. This indicates the time we first noticed this event. The watchdog
      routine will simply check that the either the flag has been cleared, or
      we have passed at least one second. In this case, it is able to clear
      the Rx timestamp register under the assumption that it was for a dropped
      frame. The benefit if this strategy is that we should be able to
      detect and clear out stalled RXTIME_H registers before we exhaust the
      supply of 4, and avoid complete stall of Rx timestamp events.
      
      Change-ID: Id55458c0cd7a5dd0c951ff2b8ac0b2509364131f
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      12490501
    • Jacob Keller's avatar
      i40e: use a mutex instead of spinlock in PTP user entry points · 19551262
      Jacob Keller authored
      We need a locking mechanism to protect the hardware SYSTIME register
      which is split over 2 values, and has internal hardware latching. We
      can't allow multiple accesses at the same time. However....
      
      The spinlock_t is overkill here, especially use of spin_lock_irqsave,
      since every PTP access will halt hardirqs. Notice that the only places
      which need the SYSTIME value are user context and are capable of sleeping.
      Thus, it is safe to use a mutex here instead of the spinlock.
      
      Change-ID: I971761a89b58c6aad953590162e85a327fbba232
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      19551262
    • Jacob Keller's avatar
      i40e: correct check for reading TSYNINDX from the receive descriptor · 144ed176
      Jacob Keller authored
      When hardware has taken a timestamp for a received packet, it indicates
      which RXTIME register the timestamp was placed in by some bits in the
      receive descriptor. It uses 3 bits, one to indicate if the descriptor
      index is valid (ie: there was a timestamp) and 2 bits to indicate which
      of the 4 registers to read. However, the driver currently does not check
      the TSYNVALID bit and only checks the index. It assumes a zero index
      means no timestamp, and a non zero index means a timestamp occurred.
      While this appears to be true, it prevents ever reading a timestamp in
      RXTIME[0], and causes the first timestamp the device captures to be
      ignored.
      
      Fix this by using the TSYNVALID bit correctly as the true indicator of
      whether the packet has an associated timestamp.
      
      Also rename the variable rsyn to tsyn as this is more descriptive and
      matches the register names.
      
      Change-ID: I4437e8f3a3df2c2ddb458b0fb61420f3dafc4c12
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      144ed176
    • Jacob Keller's avatar
      i40e: remove duplicate add/delete adminq command code for filters · 00936319
      Jacob Keller authored
      We duplicate some code around adding and deleting filters using the
      adminq interface. This is prone to errors in case there are bugs. Use
      functions which extract the logic to their own portion so that we don't
      duplicate it twice in code.
      
      Change-ID: I60d68aeb887976787dec00b23ab386a106e61465
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      00936319
    • Jacob Keller's avatar
      i40e: avoid looping to check whether we're in VLAN mode · cbebb85f
      Jacob Keller authored
      We determine that a VSI is in vlan_mode whenever it has any filters
      with a VLAN other than -1 (I40E_VLAN_ALL). The previous method of doing
      so was to perform a loop whenever we needed the check. However, we can
      notice that only place where filters are added (i40e_add_filter) can
      change the condition from false to true, and the only place we can
      return to false is in i40e_vsi_sync_filters_subtask. Thus, we can remove
      the loop and use a boolean directly.
      
      Doing this avoids looping over filters repeatedly especially while we're
      already inside a loop over all the filters. This should reduce the
      latency of filter operations throughout the driver.
      
      Change-ID: Iafde08df588da2a2ea666997d05e11fad8edc338
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      cbebb85f
    • Alan Brady's avatar
      i40e: fix MAC filters when removing VLANs · 84f5ca6c
      Alan Brady authored
      Currently there exists a bug where adding at least one VLAN and then
      removing all VLANs leaves the mac filters for the VSI with an incorrect
      value for 'vid' which indicates the mac filter's VLAN status.
      
      The current implementation for handling the removal of VLANs is wrong
      for a couple reasons. The first is that when i40e_vsi_kill_vlan
      iterates through the MAC filters, it fails to account for the MAC filter
      status; i.e. it's not accommodating for filters that are about to be
      deleted. The second problem is that MAC filters can be deleted in other
      places (specifically i40e_set_rx_mode). Thus if it occurs that all the
      VLAN MAC filters get deleted we need to switch out of VLAN mode, but the
      code path through i40e_vsi_kill_vlan has already been executed and we're
      now stuck in VLAN mode.
      
      This patch fixes the issue by removing the check from i40e_vsi_kill_vlan
      and puts the check instead in i40e_sync_vsi_filters where we're
      guaranteed to see all filter deletions and can properly detect when we
      need to switch out of VLAN mode.
      
      Change-ID: Ib38fe6034b356eee9a0e20b8a9eeed5ff2debcd9
      Signed-off-by: default avatarAlan Brady <alan.brady@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      84f5ca6c
    • Jacob Keller's avatar
      i40e: properly cleanup on allocation failure in i40e_sync_vsi_filters · 4a2ce27b
      Jacob Keller authored
      Currently, we fail to correctly restore filters on the temporary add
      list when we fail to allocate memory either for deletion or addition.
      Replace calls to "goto out;" with calls to a new location that correctly
      handles memory allocation failures.
      
      Note that it is safe for us to call i40e_undo_filter_entries on the
      tmp_del_list even after we've deleted filters because at this point it
      will be empty, so we don't need to separate the logic for add and
      delete failure.
      
      Change-Id: Iee107fd219c6e03e2fd9645c2debf8e8384a8521
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      4a2ce27b
    • Jacob Keller's avatar
      i40e: store MAC/VLAN filters in a hash with the MAC Address as key · 278e7d0b
      Jacob Keller authored
      Replace the mac_filter_list with a static size hash table of 8bits. The
      primary advantage of this is a decrease in latency of operations related
      to searching for specific MAC filters, including .set_rx_mode. Using
      a linked list resulted in several locations which were O(n^2). Using
      a hash table should give us latency growth closer to O(n*log(n)).
      
      Change-ID: I5330bd04053b880e670210933e35830b95948ebb
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      278e7d0b
    • Jacob Keller's avatar
      i40e: implement __i40e_del_filter and use where applicable · 290d2557
      Jacob Keller authored
      When inside a loop where we call i40e_del_filter we use an O(n^2)
      pattern where i40e_del_filter calls i40e_find_filter for us. We can
      avoid this O(n^2) logic by factoring a function, __i40e_del_filter() out
      from the i40e_del_filter code. This allows us to re-use the delete logic
      where appropriate without having to search for the filter twice.
      
      This new function benefits several functions including i40e_vsi_add_vlan,
      i40e_vsi_kill_vlan, i40e_del_mac_vlan_all, and i40e_vsi_release.
      
      Change-ID: I75fabe0f53bf73f56b80d342e5fdcfcc28f4d3eb
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      290d2557
    • Jacob Keller's avatar
      i40e: When searching all MAC/VLAN filters, ignore removed filters · 57b341d6
      Jacob Keller authored
      When adding new MAC address filters, the driver determines if it should
      behave in VLAN mode (where all MAC addresses get assigned to every
      existing VLAN) or in non-VLAN mode where MAC addresses get assigned the
      VLAN_ANY identifier. Under some circumstances it is possible that a VLAN
      has been marked for removal (such that all filters of that VLAN are set
      to I40E_FILTER_REMOVE), and a subsequent call to i40e_put_mac_in_vlan
      may occur prior to the driver subtask that syncs filters to the
      hardware.
      
      In this case, we may add filters to the new removed VLAN, even though it
      should have been removed. This is most obvious when first adding a new
      VLAN. We will delete all filters which are in I40E_VLAN_ANY (-1) and
      then re-add them as in VLAN 0 (untagged). Then before we sync filters,
      we will add new MAC address filter, which will be added to every VLAN
      that exists. Unfortunately, this will include I40E_VLAN_ANY, so we will
      end up incorrectly adding filters to the -1 VLAN. This can be fixed by
      simply skipping all filters which are marked for removal.
      
      A similar check is not necessary in i40e_del_mac_all_vlan, since we are
      deleting, and any filter which we find already marked for removal would
      simply be deleted again, which doesn't cause any issues.
      
      Change-Id: I7962154013ce02fe950584690aeeb3ed853d0086
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      57b341d6
    • Jacob Keller's avatar
      i40e: refactor i40e_put_mac_in_vlan to avoid changing f->vlan · 5feb3d7b
      Jacob Keller authored
      When a PVID has been assigned to a VSI, the function
      i40e_put_mac_in_vlan arbitrarily modifies all filters
      to have the same VLAN. This is obviously incorrect
      because it could be modifying active filters without
      putting them into the NEW state. The correct method
      is to remove then re-add filters which is already done
      in the code where we assign the PVID.
      
      Fix this issue and a few other minor nits at the same
      time. First, when we have a PVID don't even bother
      looping and simply add the filter with the PVID immediately.
      
      In the case of the loop, we now can remove several checks.
      We also don't need to use i40e_find_filter first before
      calling i40e_add_filter, since i40e_add_filter implicitly
      does a lookup already.
      
      Finally, update the return semantics of this function so
      that on failure to add a filter it returns NULL, but on
      success, it returns the last filter added. Otherwise,
      we're just returning the last filter in the list. An
      alternative fix might be to return 0 or an error code,
      but this is pretty invasive to every call site.
      
      Change-ID: I2325dfd843aec76d89fb0d7cb0e7c4f290a34840
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      5feb3d7b
    • Jacob Keller's avatar
      i40e: move i40e_put_mac_in_vlan and i40e_del_mac_all_vlan · 35ec2ff3
      Jacob Keller authored
      A future patch will be modifying these functions and making a call to
      a static function which currently is defined after these functions. Move
      them in a separate patch to ease review and ensure the moved code is
      correct.
      
      Change-ID: I2ca7fd4e10c0c07ed2291db1ea41bf5987fc6474
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      35ec2ff3
    • Jacob Keller's avatar
      i40e: make use of __dev_uc_sync and __dev_mc_sync · 6622f5cd
      Jacob Keller authored
      The kernel provides __dev_uc_sync and __dev_mc_sync in order for drivers
      which need individual notification of add and delete for each filter.
      These functions allow us to vastly simplify our .set_rx_mode handler. We
      need to implement two functions for sync and unsync which add and remove
      filters respectively.
      
      This change avoids a very complex and inefficient algorithm which
      resulted in an abnormal latency for the .set_rx_mode NDO operation. The
      resulting code after this change is more readable, more efficient, and
      less code.
      
      Due to the callback signature used by these functions we also must
      update several other functions to take a const u8 * pointer.
      
      Change-Id: I2ca7fd4e10c0c07ed2291db1ea41bf5987fc6474
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      6622f5cd
    • Jacob Keller's avatar
      i40e: drop is_vf and is_netdev fields in struct i40e_mac_filter · 1bc87e80
      Jacob Keller authored
      Originally the is_vf and is_netdev fields were added in order to
      distinguish between VF and netdev filters in a single VSI. However, it
      can be noted that we use separate VSI for SRIOV VFs and for netdev VSI.
      Thus, since a single VSI should only ever have one type of filter, we
      can simply remove the checks and remove the typing.
      
      In a similar fashion, we can note that the only remaining way to get
      multiple filters of a single type is through a debug command that was
      added to debugfs. This command is useless in practice, and results in
      causing bugs if we keep counter tracking but lose the is_vf and
      is_netdev protections as desired above.
      
      Since the only time we'd actually have a counter value besides 0 and
      1 is through use of this debugfs hook, we can remove this unnecessary
      command, and the entire counter logic it required.
      
      We vastly simplify mac filters by removing
      
      (a) the distinction between VF and netdev filters
      (b) counting logic
      (c) the ability to add and remove filters bypassing the stack via debugfs
      
      Change-ID: Idf916dd2a1159b1188ddbab5bef6b85ea6bf27d9
      Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      1bc87e80
    • Colin Ian King's avatar
      i40e: Add missing \n to end of dev_err message · ff00f3a9
      Colin Ian King authored
      Trival fix, dev_err message is missing a \n, so add it.
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      ff00f3a9
    • David S. Miller's avatar
      Merge branch 'bridge-PIM-hello' · 17a032b7
      David S. Miller authored
      Nikolay Aleksandrov says:
      
      ====================
      bridge: add support for PIM hello router ports
      
      The first 3 patches of this set do minor cleanups and add some helpers to
      the PIM header file. Patch 4 adds a way to detect mcast router ports via
      PIM hello messages, they're marked as temporary and are not considered for
      querier. There's more detailed information in patch 4's commit message.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      17a032b7
    • Nikolay Aleksandrov's avatar
      bridge: mcast: add router port on PIM hello message · 91b02d3d
      Nikolay Aleksandrov authored
      When we receive a PIM Hello message on a port we can consider that it
      has a multicast router attached, thus it is correct to add it to the
      router list. The only catch is it shouldn't be considered for a querier.
      
      Using Daniel's description:
      leaf-11  leaf-12  leaf-13
             \   |    /
              bridge-1
               /    \
          host-11  host-12
      
       - all ports in bridge-1 are in a single vlan aware bridge
       - leaf-11 is the IGMP querier
       - leaf-13 is the PIM DR
       - host-11 TXes packets to 226.10.10.10
       - bridge-1 only forwards the 226.10.10.10 traffic out the port to
         leaf-11, it should also forward this traffic out the port to leaf-13
      Suggested-by: default avatarDaniel Walton <dwalton@cumulusnetworks.com>
      Signed-off-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      91b02d3d