- 28 Sep, 2021 2 commits
-
-
Mauro Carvalho Chehab authored
As described at Documentation/ABI/README doesn't contain an Attribute: field. The way sysfs ABI is supposed to work is that each different attribute would have a separate file. So, the right way to map this would be like: /sys/.../dell_privacy_supported_type/mic_mute /sys/.../dell_privacy_supported_type/camera_shutter /sys/.../dell_privacy_current_state/mic_mute /sys/.../dell_privacy_current_state/camera_shutter However, it seems to late to fix that, as this was merged already on Kernel 5.13, and a change right now would be a regression. So, instead, let's at least fix the entry to match the expected format. While here, fix the format of the contact, which is not a valid e-mail URL. This should also fix the current warnings produced when building the docs: Documentation/ABI/testing/sysfs-platform-dell-privacy-wmi:35: WARNING: Unexpected indentation. Documentation/ABI/testing/sysfs-platform-dell-privacy-wmi:2: WARNING: Unexpected indentation. Fixes: 8af9fa37 ("platform/x86: dell-privacy: Add support for Dell hardware privacy") Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Link: https://lore.kernel.org/r/42846621fdf2bf206feb114d06b14cbc47475fb5.1632740376.git.mchehab+huawei@kernel.orgSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mauro Carvalho Chehab authored
As warned, /sys/bus/iio/devices/iio:deviceX/fault_ovuv is defined 2 times: Warning: /sys/bus/iio/devices/iio:deviceX/fault_ovuv is defined 2 times: ./Documentation/ABI/testing/sysfs-bus-iio-temperature-max31856:14 ./Documentation/ABI/testing/sysfs-bus-iio-temperature-max31865:0 The logic with joins the two entries is just places the paragraph for the second entry after the previous one. That could cause more warnings, as the produced ReST may become invalid, as in the case of this specific symbol, which ends with a table: /new_devel/v4l/docs/Documentation/ABI/testing/sysfs-bus-iio-temperature-max31856:2: WARNING: Malformed table. No bottom table border found or no blank line after table bottom. === ======================================================= '1' The input voltage is negative or greater than VDD. '0' The input voltage is positive and less than VDD (normal state). === ======================================================= /new_devel/v4l/docs/Documentation/ABI/testing/sysfs-bus-iio-temperature-max31856:2: WARNING: Blank line required after table. Address it by adding two blank lines before joining duplicated symbols. Signed-off-by:
-
- 23 Sep, 2021 8 commits
-
-
Mauro Carvalho Chehab authored
The way the search algorithm works is that reduces the number of regex expressions that will be checked for a given file entry at sysfs. It does that by looking at the devnode name. For instance, when it checks for this file: /sys/bus/pci/drivers/iosf_mbi_pci/bind The logic will seek only the "What:" expressions that end with "bind". Currently, there are just a couple of What expressions that matches it: What: /sys/bus/fsl\-mc/drivers/.*/bind What: /sys/bus/pci/drivers/.*/bind It will then run an O(n²) algorithm to seek, which runs quickly when there are few regexs to seek. There are, however, some What: expressions that end with a wildcard. Those are harder to process. Right now, they're all grouped together at the "others" group. As those don't depend on the basename of the node, add an extra loop to ensure that those will be processed at the end, if not done yet. Signed-off-by:
-
Mauro Carvalho Chehab authored
In order to earn some time during matches, pre-compile regexes. Before this patch: $ time ./scripts/get_abi.pl undefined |wc -l 6970 real 0m54,751s user 0m54,022s sys 0m0,592s Afterwards: $ time ./scripts/get_abi.pl undefined |wc -l 6970 real 0m5,888s user 0m5,310s sys 0m0,562s Signed-off-by:
-
Mauro Carvalho Chehab authored
Right now, there are two loops used to seek for a regex. Make sure that both will be skip when a match is found. While here, drop the unused $defined variable. Signed-off-by:
-
Mauro Carvalho Chehab authored
When checking for undefined symbols, some nodes aren't easy or don't make sense to be checked right now. Prevent allocating memory for those, as they'll be ignored anyway. Signed-off-by:
-
Mauro Carvalho Chehab authored
When the the leaf of a regex ends with a wildcard, the speedup algorithm to reduce the number of regexes to seek won't work. So, when those are found, place at the "others" exception. That slows down the search from 0.14s to 1 minute on my machine, but the results are a lot more consistent. Signed-off-by:
-
Mauro Carvalho Chehab authored
Add a level for debug, in order to allow it to be extended to debug other parts of the script. Signed-off-by:
-
Mauro Carvalho Chehab authored
The $what conversions need to replace some characters to avoid breaking regex expressions found on some What:. only after replacing them back, the script should get the $leave devnode. Fixes: ca8e055c ("scripts: get_abi.pl: add a graph to speedup the undefined algorithm") Signed-off-by:
-
Mauro Carvalho Chehab authored
Currently, the get_abi.pl will print an invalid symbol (\xac character). Fix it. Fixes: ab9c1480 ("scripts: get_abi.pl: Better handle multiple What parameters") Signed-off-by:
-
- 21 Sep, 2021 30 commits
-
-
Mauro Carvalho Chehab authored
Searching for symlinks is an expensive operation with the current logic, as it is at the order of O(n^3). In practice, running the check spends 2-3 minutes to check all symbols. Fix it by storing the directory tree into a graph, and using a Breadth First Search (BFS) to find the links for each sysfs node. With such improvement, it can now report issues with ~11 seconds on my machine. It comes with a price, though: there are more symbols reported as undefined after this change. I suspect it is due to some sysfs circular loops that are dropped by BFS. Despite such increase, it seems that the reports are now more coherent. Signed-off-by:
-
Mauro Carvalho Chehab authored
In order to speedup the parser and store less data, handle fs/cgroup exceptions a lot earlier. Signed-off-by:
-
Mauro Carvalho Chehab authored
The search algorithm used inside check_undefined_symbols has an optimization: it seeks only whats that have the same leave name. This helps not only to speedup the search, but it also allows providing a hint about a partial match. There's a drawback, however: when "what:" finishes with a wildcard, the logic will skip the what, reporting it as "not found". Fix it by grouping the remaining cases altogether, and disabing any hints for such cases. Signed-off-by:
-
Mauro Carvalho Chehab authored
The output of this script can be too big. Add an option to filter out results, in order to help finding issues at the ABI files. Signed-off-by:
-
Mauro Carvalho Chehab authored
The way sysfs works is that the same leave may be present under /sys/devices, /sys/bus and /sys/class, etc, linked via soft symlinks. To make it harder to parse, the ABI definition usually refers only to one of those locations. So, improve the logic in order to retrieve the symlinks. Signed-off-by:
-
Mauro Carvalho Chehab authored
Check for the symbols that exists under /sys but aren't defined at Documentation/ABI. Signed-off-by:
-
Mauro Carvalho Chehab authored
Using a comma here is problematic, as some What: expressions may already contain a comma. So, use \xac character instead. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Richard Cochran <richardcochran@gmail.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
%x is not a valid wildcard. Use <x> instead, as this allows script/get_abi.pl to convert it into a regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Peter Rosin <peda@axentia.se> Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Johan Hovold <johan@kernel.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Reviewed-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex. Acked-by:
Jason Gunthorpe <jgg@nvidia.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
In order to let script/get_abi.pl to convert it into a Regex, replace the three "..." at the end, meaning a wildcard to a real filesystem wildcard. Signed-off-by:
-
Mauro Carvalho Chehab authored
This what: /sys/class/typec/<port>-partner>/identity/ Contains an extra ">" character. Remove it. Reviewed-by:
Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
If both /sys/fs/pstore/... and /dev/pstore/... are possible, it should use, instead, two What: fields. Acked-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
On most ABI files, the wildcards are used as <x>, instead of (x). Replace it to make it using a more standard wildcard. That helps get_abi.pl to convert it into a regex. Signed-off-by:
-
Mauro Carvalho Chehab authored
On most ABI files, the wildcards are used as <x>, instead of (x). Replace it to make it using a more standard wildcard. That helps get_abi.pl to convert it into a regex. Signed-off-by:
-
