- 21 Mar, 2017 11 commits
-
-
David Binder authored
Removes unused #defines pertaining to visorchannel UUIDs. Signed-off-by:
David Binder <david.binder@unisys.com> Signed-off-by:
David Kershner <david.kershner@unisys.com> Reviewed-by:
Tim Sell <timothy.sell@unisys.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
David Binder authored
Addresses checkpatch check by wrapping macro argument in parenthesis. Signed-off-by:
-
Sameer Wadgaonkar authored
Removed inline keyword from functions sig_read_data and sig_write_data in visorchannel.c Signed-off-by:
Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com> Signed-off-by:
-
Sameer Wadgaonkar authored
Removed inline keyword from the functions in visorchipset: * issue_vmcall_io_controlvm_addr() Signed-off-by:
-
Sameer Wadgaonkar authored
Removed inline keyword from the function complete_taskmgmt_command in visorhba_main.c Signed-off-by:
-
Sameer Wadgaonkar authored
Removed unused functions issue_vmcall_update_physical_time() and issue_vmcall_query_guest_virtual_time_offset() from visorchipset.c Signed-off-by:
-
Sameer Wadgaonkar authored
Removed unused macro spar_signal_init from channel.h Signed-off-by:
-
Sameer Wadgaonkar authored
Removed unused function spar_check_channel_server from channel.h Signed-off-by:
-
Sameer Wadgaonkar authored
Removed unused structure pci_id from controlvmchannel.h Signed-off-by:
-
Alexander Curtin authored
The comment referencing virtpci was irrelevant. Signed-off-by:
Alexander Curtin <alexander.curtin@unisys.com> Signed-off-by:
-
Alexander Curtin authored
COVERQ is functionally equivalent to DIV_ROUND_UP and was only used to define the COVER macro. Signed-off-by:
-
- 17 Mar, 2017 7 commits
-
-
Dylan Leggio authored
GAS_INTIAL_REQ should be GAS_INITIAL_REQ. GAS_INTIAL_RSP should be GAS_INITIAL_RSP. Improves readability of code. Signed-off-by:
Dylan Leggio <dleggio1@binghamton.edu> Signed-off-by:
-
Colin Ian King authored
The pmkid data is meant be be copied to the previous item in the pmkidlist, however the code is just copying the data to itself because the src index into pmkidlist is the same as the dst index into pmkidlist. Fix this with i + 1 instead of i. Detected by CoverityScan,CID#13339465 ("Overlapping buffer in memory copy") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Jérémy Lefaure authored
To use IO functions like writel, readl, ioremap_nocache and iounmap, linux/io.h should be included. Signed-off-by:
Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> Signed-off-by:
-
sayli karnik authored
The patch removes unused function definition ll_get_user_pages(). The use of ll_get_user_pages() was replaced with iov_iter_get_pages_alloc() in commit 91f79c43. Signed-off-by:
sayli karnik <karniksayli1995@gmail.com> Signed-off-by:
-
Okash Khawaja authored
This moves spk_synth_immediate and spk_serial_synth_probe functions into serialio.c. These functions do outgoing serial comms. The move is a step towards collecting all serial comms in serialio.c. This also renames spk_synth_immediate to spk_serial_synth_immediate. Code inside those functions has not been changed. Along the way, this patch also fixes a couple of spots which were calling spk_synth_immediate directly, so that the calls now happen via the spk_syth struct. Signed-off-by:
Okash Khawaja <okash.khawaja@gmail.com> Reviewed-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
-
Mohsin Shan authored
Embedded function names are less appropriate to use when refactoring, can cause function renaming. Prefer the use of "%s", __func__ to embedded function names Signed-off-by:
Mohsin Shan <mohsinshan1k@gmail.com> Signed-off-by:
-
Jérémy Lefaure authored
This reverts commit fde46970. Adding a preprocessor condition is not the best solution to fix this issue. Let's revert this commit before fixing this problem in a more appropriate way. Signed-off-by:
-
- 16 Mar, 2017 22 commits
-
-
Aya Mahfouz authored
Fixes the checkpatch.pl warning: Avoid CamelCase Signed-off-by:
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by:
-
Tuomo Rinne authored
staging: vt6655: Copy argument names from function definition to declaration to fix checkpatch warnings Copied function argument names from definition to delcaration. This fixes some checkpatch warnings. Signed-off-by:
Tuomo Rinne <tuomo.rinne@gmail.com> Signed-off-by:
-
Tahia Khan authored
Removes unused variable opSign from sm750_hw_copyarea. Identified using coccinelle script 'unused.cocci'. Signed-off-by:
Tahia Khan <tahia.khan@gmail.com> Signed-off-by:
-
Tamara Diaconita authored
Remove unnecessary brackets and correspondingly unindent code. Signed-off-by:
Tamara Diaconita <diaconita.tamara@gmail.com> Signed-off-by:
-
Tamara Diaconita authored
Correct misspelled variables: 'happended' to 'happened' to make the code grammatically correct. Signed-off-by:
-
Tamara Diaconita authored
Move declaration of variables to top of function to make the code more readable. Signed-off-by:
-
Tobin C. Harding authored
Return code from tty_check_change() should be being preserved. Preserve return code from call to tty_check_change(). Signed-off-by:
Tobin C. Harding <me@tobin.cc> Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits WARNING and CHECK for prototype declarations. WARNING: function definition argument 'void *' should also have an identifier name CHECK: Alignment should match open parenthesis Also prototype parameters wrap more than is necessary. Tidy up function prototypes. Fix 5 error/warning instances. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits WARNING: Block comments use a trailing */ on a separate line. Move comments to (kernel doc format) struct comment. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits WARNING: Unnecessary space before function pointer arguments. Remove unnecessary space before function pointer. Signed-off-by:
-
Tobin C. Harding authored
Driver has dead code compiled out using preprocessor directives. TODO file asks for these not to be removed - ignore this. Remove dead code. Remove 'do not remove #if 0/1 ...' from TODO file. Signed-off-by:
-
Tobin C. Harding authored
Driver uses custom function comment format. These comments are on functions with internal likage. Comment string /*--------/* adds nothing to the driver. Comment 'Wireless Handler' does not have allot of meaning. Remove superfluous function comments. Leave comments that add meaning. Signed-off-by:
-
Tobin C. Harding authored
Driver code uses custom return values (often positive) to signal error condition instead of using standard kernel error codes. Replace custom return values with standard kernel error codes. Signed-off-by:
-
Tobin C. Harding authored
Bug introduced in commit 7676b724 by Tobin C. Harding. Remove equals sign from comparison, fixing off by one error. Fixes: 7676b724 ("staging: ks7010: move comparison to right hand side") Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
It's a post-op loop so we timeout with "max_wait" set to -1, not 0. Fixes: a49d2536 ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by:
-
Gargi Sharma authored
This patch removes multiple assignments by factorizing them. This was done with Coccinelle for the if branch. For the else part the change was done manually since Coccinelle only detects constants. Braces were also added to the else part to remove the checkpatch warning, "braces should be on all arms of if-else statements". @@ identifier i1,i2; constant c; @@ - i1=i2=c; + i1=c; + i2=c; Signed-off-by:
Gargi Sharma <gs051095@gmail.com> Signed-off-by:
-
Andrii Vladyka authored
Fix 'multiple blank lines' coding style problem reported by checkpatch.pl. Signed-off-by:
Andrii Vladyka <tulup@mail.ru> Signed-off-by:
-
Dan Carpenter authored
We converted these conditions from == NULL and != NULL but messed up and inverted some. Fixes: e31447f9 ("staging: rtl8188eu: Replace x==NULL by !x") Signed-off-by:
-
Gargi Sharma authored
Using typedef for a structure type and upper case struct names is not suggested in Linux kernel coding style guidelines. Hence, occurences of typedefs have been removed and struct names converted to lowercase in the file. Grep was also used to ensure that all occurence of the typedefs have been removed. The module compiles without any warnings or errors. Script 1: @r1@ type T; @@ typedef struct { ... } T; @script:python c1@ T2; T << r1.T; @@ if T[-2:] =="_T": coccinelle.T2 = T[:-2].lower(); print T else: coccinelle.T2=T.lower(); @r2@ type r1.T; identifier c1.T2; @@ -typedef struct + T2 { ... } -T ; @r3@ type r1.T; identifier c1.T2; @@ - T + struct T2 Script 2: @@ typedef VCHIQ_ELEMENT_T; @@ ( - VCHIQ_ELEMENT_T + struct vchiq_element ) Signed-off-by: -
Gargi Sharma authored
The function prototype is for a function that is not even in the kernel, and hence has been removed. The type VCHIQ_SHARED_MEM_INFO_T is not used anywhere in the kernel as well. Signed-off-by:
-
Jean-Baptiste Abbadie authored
These four functions are not used and report errors with sparse. Signed-off-by:
Jean-Baptiste Abbadie <jb@abbadie.fr> Acked-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
-
Jérémy Lefaure authored
These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by:
-
