1. 06 Feb, 2008 9 commits
    • Bartlomiej Zolnierkiewicz's avatar
      ide: remove ide_setup_ports() · 29dd5975
      Bartlomiej Zolnierkiewicz authored
      ide-cris.c:
      * Add cris_setup_ports() helper and use it instead of ide_setup_ports()
        (fixes random value being set in ->io_ports[IDE_IRQ_OFFSET]).
      
      buddha.c:
      * Add buddha_setup_ports() helper and use it instead of ide_setup_ports().
      
      falconide.c:
      * Add falconide_setup_ports() helper and use it instead of ide_setup_ports(),
        also fix return value of falconide_init() while at it.
      
      gayle.c:
      * Add gayle_setup_ports() helper and use it instead of ide_setup_ports().
      
      macide.c:
      * Add macide_setup_ports() helper and use it instead of ide_setup_ports()
        (fixes incorrect value being set in ->io_ports[IDE_IRQ_OFFSET]).
      
      q40ide.c:
      * Fix q40_ide_setup_ports() comments.
      
      ide.c:
      * Remove no longer needed ide_setup_ports().
      
      Cc: Mikael Starvik <starvik@axis.com>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      29dd5975
    • Bartlomiej Zolnierkiewicz's avatar
      ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc() · f2694b7e
      Bartlomiej Zolnierkiewicz authored
      Same BUG_ON() is present inside ide_set_handler().
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      f2694b7e
    • Bartlomiej Zolnierkiewicz's avatar
      ide: remove write-only ->sata_misc[] from ide_hwif_t · afdd360c
      Bartlomiej Zolnierkiewicz authored
      * Remove write-only ->sata_misc[] from ide_hwif_t.
      
      * Remove no longer used SATA_{MISC,PHY,IEN}_OFFSET defines.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      afdd360c
    • Bartlomiej Zolnierkiewicz's avatar
      ppc: fix #ifdef-s in mediabay driver (take 2) · 34394e45
      Bartlomiej Zolnierkiewicz authored
      * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef in
        check_media_bay() by CONFIG_MAC_FLOPPY one.
      
      * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef-s by
        CONFIG_BLK_DEV_IDE_PMAC ones.
      
      * check_media_bay() is used only by drivers/block/swim3.c
        so make this function available only if CONFIG_MAC_FLOPPY
        is defined.
      
      * check_media_bay_by_base() and media_bay_set_ide_infos()
        are used only by drivers/ide/ppc/pmac.c so so make these
        functions available only if CONFIG_MAC_FLOPPY is defined.
      
      v2:
      * Remove ifdefs from function prototypes. (Andrew Morton)
      
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      34394e45
    • Denis Cheng's avatar
      ide-pci-generic: kill the unused ifdef/endif/MODULE code · 594765a7
      Denis Cheng authored
      with module_param macro, the __setup code can be killed now:
      	const __setup("all-generic-ide", ide_generic_all_on);
      
      and the module name "generic.ko" is not descriptive to its functionality,
      can be changed in Makefile, the "ide-pci-generic.ko" is better.
      
      the ide-pci-generic.all-generic-ide parameter also documented
      in Documentation/kernel-parameters.txt
      Signed-off-by: default avatarDenis Cheng <crquan@gmail.com>
      Cc: Greg Kroah-Hartman <gregkh@suse.de>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      594765a7
    • Andrew Morton's avatar
      drivers/ide/legacy/hd.c: fix uninitialized var warning · b004223d
      Andrew Morton authored
      drivers/ide/legacy/hd.c: In function 'hd_request':
      drivers/ide/legacy/hd.c:424: warning: 'stat' may be used uninitialized in this function
      
      gcc is being stupid.
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      b004223d
    • Andrew Morton's avatar
      drivers/ide/ide-acpi.c: fix uninitialized var warning · 1dcfdf93
      Andrew Morton authored
      drivers/ide/ide-acpi.c: In function 'ide_acpi_init':
      drivers/ide/ide-acpi.c:175: warning: 'dev_handle' may be used uninitialized in this function
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      1dcfdf93
    • Anton Salnikov's avatar
      Palmchip BK3710 IDE driver · 7c7e92a9
      Anton Salnikov authored
      This is Palmchip BK3710 IDE controller support.
      
      The IDE controller logic supports PIO, MultiWord-DMA and Ultra-DMA modes.
      Supports interface to Compact Flash (CF) configured in True-IDE mode.
      
      Bart:
      - remove dead code
      - fix ide_hwif_setup_dma() build problem
      Signed-off-by: default avatarAnton Salnikov <asalnikov@ru.mvista.com>
      Reviewed-by: default avatarAlan Cox <alan@lxorguk.ukuu.org.uk>
      Reviewed-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      7c7e92a9
    • Bartlomiej Zolnierkiewicz's avatar
      ide-generic: probing bugfix · b2a53bc6
      Bartlomiej Zolnierkiewicz authored
      On Tuesday 05 February 2008, Linus Torvalds wrote:
      > 
      > On Sat, 2 Feb 2008, Bartlomiej Zolnierkiewicz wrote:
      > > 
      > > * next part of IDE probing code re-organization saga
      > >   (that would be me)
      > 
      > This seems to cause very irritating and bogus messages for me:
      > 
      >       Probing IDE interface ide0...
      >       Probing IDE interface ide1...
      >       ide2: I/O resource 0x0-0x7 not free.
      >       ide2: ports already in use, skipping probe
      >       ide3: I/O resource 0x0-0x7 not free.
      >       ide3: ports already in use, skipping probe
      >       ide4: I/O resource 0x0-0x7 not free.
      >       ide4: ports already in use, skipping probe
      >       ide5: I/O resource 0x0-0x7 not free.
      >       ide5: ports already in use, skipping probe
      >       ide6: I/O resource 0x0-0x7 not free.
      >       ide6: ports already in use, skipping probe
      >       ide7: I/O resource 0x0-0x7 not free.
      >       ide7: ports already in use, skipping probe
      >       ide8: I/O resource 0x0-0x7 not free.
      >       ide8: ports already in use, skipping probe
      >       ide9: I/O resource 0x0-0x7 not free.
      >       ide9: ports already in use, skipping probe
      > 
      > and that's just totally bogus. It shouldn't even request that region, 
      > since it's not been allocated!
      
      The commit 139ddfca ("ide: move handling of
      I/O resources out of ide_probe_port()") changed the ordering of hwif->noprobe
      check vs ide_hwif_request_regions() call (so that we now reserve I/O regions
      before checking for hwif->noprobe).  However ide-generic host driver depended
      on hwif->noprobe to be set for skipping probing of empty ide_hwifs[] slots.
      
      Fix it by passing only indexes of non-empty slots to ide_device_add_all()
      from ide_generic_init().
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      b2a53bc6
  2. 05 Feb, 2008 31 commits