- 20 Jul, 2016 2 commits
-
-
Joe Thornber authored
The discard passdown was being issued after the block was unmapped, which meant the block could be reprovisioned whilst the passdown discard was still in flight. We can only identify unshared blocks (safe to do a passdown a discard to) once they're unmapped and their ref count hits zero. Block ref counts are now used to guard against concurrent allocation of these blocks that are being discarded. So now we unmap the block, issue passdown discards, and the immediately increment ref counts for regions that have been discarded via passed down (this is safe because allocation occurs within the same thread). We then decrement ref counts once the passdown discard IO is complete -- signaling these blocks may now be allocated. This fixes the potential for corruption that was reported here: https://www.redhat.com/archives/dm-devel/2016-June/msg00311.htmlReported-by:
Dennis Yang <dennisyang@qnap.com> Signed-off-by:
Joe Thornber <ejt@redhat.com> Signed-off-by:
Mike Snitzer <snitzer@redhat.com>
-
Joe Thornber authored
dm_btree_find_next_single() can short-circuit the search for a block with a return of -ENODATA if all entries are higher than the search key passed to lower_bound(). This hasn't been a problem because of the way the btree has been used by DM thinp. But it must be fixed now in preparation for fixing the race in DM thinp's handling of simultaneous block discard vs allocation. Otherwise, once that fix is in place, some of the blocks in a discard would not be unmapped as expected. Signed-off-by:
-
- 19 Jul, 2016 2 commits
-
-
Heinz Mauelshagen authored
raid_io_hints() was retrieving the number of data stripes used for the calculation of io_opt from struct r5conf, which is not defined for raid0 mappings. Base the calculation on the in-core raid_set structure instead. Also, adjust to use to_bytes() for the sector -> bytes conversion throughout. Signed-off-by:
Heinz Mauelshagen <heinzm@redhat.com> Signed-off-by:
-
Heinz Mauelshagen authored
Use 'unsigned int' where appropriate. Return negative errors. Correct an indentation. Signed-off-by:
-
- 18 Jul, 2016 28 commits
-
-
Christoph Hellwig authored
So far we tried to rely on the SCSI 'all target ports' bit to register all path, but for many setups this didn't work properly as the different paths are seen as separate initiators to the target instead of multiple ports of the same initiator. Because of that we'll stop setting the 'all target ports' bit in SCSI, and let device mapper handle iterating over the device for each path and register them manually. Signed-off-by:
Christoph Hellwig <hch@lst.de> Reviewed-by:
Mike Christie <mchristi@redhat.com> Signed-off-by:
-
Christoph Hellwig authored
These only work if the we use the same initiator ID for all path, which might not be true if we use different protocols, or even just different HBAs. Instead dm-mpath will grow support to register all path manually later in this series. Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by:
-
Tahsin Erdogan authored
Commit d548b34b ("dm: reduce the queue delay used in dm_request_fn from 100ms to 10ms") always intended the value to be 10 msecs -- it just expressed it in jiffies because earlier commit 7eaceacc ("block: remove per-queue plugging") did. Signed-off-by:
Tahsin Erdogan <tahsin@google.com> Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Also makes code more consistent throughout. Signed-off-by:
-
Heinz Mauelshagen authored
Add "delta_disks" constructor argument support to raid1 to allow for consistent userspace disk addition/removal handling. Fix raid_status() to report all raid disks with status and table output on disk adding reshapes, not just the ones listed on the mddev; optimize its rebuild and writemostly output. Signed-off-by:
-
Heinz Mauelshagen authored
Enhance rs_reshape_requested() check function to be more transparent and fix its raid10 check. Streamline the constructor by factoring out reshaping preparation into fucntion rs_prepare_reshape(). Signed-off-by:
-
Heinz Mauelshagen authored
Resizing a RAID set during recovery can be allowed, because the MD resynchronization thread will either stop any ongoing recovery in case of shrinking below the current recovery position or carry on recovery to the new size if the set is growing. Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Add function rs_setup_recovery() to allow for defined setup of RAID set recovery in the constructor. Will be called with dev_sectors={0, rdev->sectors, MaxSectors} to recover a new or enforced sync, grown or not to be synhronized RAID set respectively. Prevents recovery on raid0, which doesn't support it. Enforces recovery on raid6 to ensure properly defined Syndromes mandatory for that MD personality are being created. Signed-off-by: -
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
- 06 Jul, 2016 1 commit
-
-
Mike Snitzer authored
Check return value of kthread_run() in dm_old_init_request_queue(). Reported-by:
Minfei Huang <mnghuan@gmail.com> Signed-off-by:
-
- 02 Jul, 2016 1 commit
-
-
Sami Tolvanen authored
do_div was replaced with div64_u64 at some point, causing a bug with block calculation due to incompatible semantics of the two functions. Signed-off-by:
Sami Tolvanen <samitolvanen@google.com> Fixes: a739ff3f ("dm verity: add support for forward error correction") Cc: stable@vger.kernel.org # v4.5+ Signed-off-by:
-
- 01 Jul, 2016 2 commits
-
-
Bart Van Assche authored
Merge the two DM_PARAMS_[KV]MALLOC flags into a single flag. Doing so avoids the crashes seen with previous attempts to consolidate buffer management to use kvfree() without first flagging that memory had actually been allocated. Signed-off-by:
Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by:
-
Bart Van Assche authored
Avoid that sparse complains about assigning a __le64 value to a u64 variable. Remove the (u64) casts since these are superfluous. This patch does not change the behavior of the source code. Signed-off-by:
-
- 16 Jun, 2016 1 commit
-
-
Arnd Bergmann authored
A newly introduced function has 'const int' as the return type, but as "make W=1" reports, that has no meaning: drivers/md/dm-raid.c:510:18: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers] This changes the return type to plain 'int'. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Fixes: 33e53f06 ("dm raid: introduce extended superblock and new raid types to support takeover/reshaping") Signed-off-by:
-
- 14 Jun, 2016 3 commits
-
-
Heinz Mauelshagen authored
Superblock updates where bogus causing some takovers/reshapes to fail. Introduce new runtime flag (RT_FLAG_KEEP_RS_FROZEN) to keep a raid set frozen when a layout change was requested. Userpace will immediately reload the table w/o the flags requesting such change once they made it to the superblocks and any change of recovery/reshape offsets has to be avoided until after read. Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
Heinz Mauelshagen authored
Signed-off-by:
-
