- 01 Jun, 2021 2 commits
-
-
Namjae Jeon authored
If *pos or *pos + count is greater than v_len, It will read beyond the stream_buf buffer. This patch add the check and cut down count with size of the buffer. Signed-off-by:
Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by:
Steve French <stfrench@microsoft.com>
-
Yang Yingliang authored
If ksmbd_vfs_getcasexattr() returns -ENOMEM, stream_buf is NULL, it will cause null-ptr-deref when using it to copy memory. So we need check the return value of ksmbd_vfs_getcasexattr() by comparing with 0. Signed-off-by:
Yang Yingliang <yangyingliang@huawei.com> Signed-off-by:
-
- 31 May, 2021 4 commits
-
-
Yang Yingliang authored
Before ksmbd_vfs_stream_read() return, memory allocate in ksmbd_vfs_getcasexattr() need be freed. Signed-off-by:
-
Yang Yingliang authored
Before assigning wbuf to stream_buf, memory allocate in ksmbd_vfs_getcasexattr() need be freed. Signed-off-by:
-
Hyunchul Lee authored
checkpatch.pl complains as the following: Alignment should match open parenthesis. Signed-off-by:
Hyunchul Lee <hyc.lee@gmail.com> Signed-off-by:
-
Hyunchul Lee authored
checkpatch.pl complains as the following: CHECK: Macro argument 'fp' may be better as '(fp)' to avoid precedence issues. Signed-off-by:
-
- 28 May, 2021 1 commit
-
-
Namjae Jeon authored
Fix a defect reported by Coverity Scan. *** CID 1504970: Control flow issues (NO_EFFECT) /fs/cifsd/auth.c: 622 in ksmbd_build_ntlmssp_challenge_blob() 616 name = kmalloc(2 + UNICODE_LEN(len), GFP_KERNEL); 617 if (!name) 618 return -ENOMEM; 619 620 conv_len = smb_strtoUTF16((__le16 *)name, ksmbd_netbios_name(), len, 621 sess->conn->local_nls); >>> CID 1504970: Control flow issues (NO_EFFECT) >>> This less-than-zero comparison of an unsigned value is never true. 622 if (conv_len < 0 || conv_len > len) { 623 kfree(name); 624 return -EINVAL; 625 } 626 627 uni_len = UNICODE_LEN(conv_len); Reported-by:Coverity Scan <scan-admin@coverity.com> Signed-off-by:
-
- 26 May, 2021 31 commits
-
-
Hyunchul Lee authored
Some vfs help functions lookup a file with LOOKUP_FOLLOW regardless of the "follow symlinks" option. Signed-off-by:
-
Namjae Jeon authored
Fix a warning from checkpatch.pl --strict: CHECK: Prefer kernel type 'u16' over 'uint16_t' #112: FILE: server.c:112: + uint16_t command; Signed-off-by:
-
Namjae Jeon authored
Fix warnings from checkpatch.pl --strict : CHECK: Unnecessary parentheses around 'brk_op->o_lease->new_state == SMB2_LEASE_NONE_LE' #1511: FILE: oplock.c:1511: + if (brk_op->is_lease && + (brk_op->o_lease->new_state == SMB2_LEASE_NONE_LE) && + atomic_read(&brk_op->breaking_cnt)) Signed-off-by:
-
Namjae Jeon authored
Fix warnings "Alignment should match open parenthesis" from checkpatch.pl --strict. Signed-off-by:
-
Namjae Jeon authored
Blank lines aren't necessary after an open brace '{'. Signed-off-by: -
Namjae Jeon authored
No space is necessary after a cast. Signed-off-by:
-
Namjae Jeon authored
don't use multiple blank lines. Signed-off-by:
-
Namjae Jeon authored
Fix "CHECK: paces preferred around that '/' from checkpatch.pl --strict. Signed-off-by:
-
Namjae Jeon authored
Fix "CHECK: braces {} should be used on all arms of this statement" from checkpatch.pl --strict. Signed-off-by: -
Namjae Jeon authored
Add the check to prevent potential overflow with smb_strtoUTF16() and UNICODE_LEN(). Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Namjae Jeon authored
Alignment match open parenthesis. Reviewed-by:
-
Namjae Jeon authored
Return -ENOMEM about error from ksmbd_crypto_ctx_find_xxx calls. And remove unneeded return value print in debug message. Reviewed-by:
-
Namjae Jeon authored
Simplify error handling in ksmbd_gen_preauth_integrity_hash(). Reviewed-by:
-
Namjae Jeon authored
Call kzalloc() directly instead of wrapper function. Reviewed-by:
-
Namjae Jeon authored
Add default case in switch statment in alloc_shash_desc(). Reviewed-by:
-
Namjae Jeon authored
Change success handling to failure handling in ksmbd_crypt_message(). Reviewed-by:
-
Namjae Jeon authored
Change error return instead of returning always success return. Reviewed-by:
-
Namjae Jeon authored
Remove unneeded initialization of rc variable in ksmbd_crypt_message(). Reviewed-by:
-
Namjae Jeon authored
Dan pointed out len can not be negative. This patch remove unneeded negative check in loop. Reviewed-by:
-
Namjae Jeon authored
Dan Carpenter pointed out that memory can be corrupted when nvec is zero. This patch add the check to prevent it. Reviewed-by:
-
Namjae Jeon authored
Never return 1 on failure. Reviewed-by:
-
Namjae Jeon authored
Return zero in always success case. Reviewed-by:
-
Namjae Jeon authored
Set error return value for memcmp() difference. Reviewed-by:
-
Namjae Jeon authored
Remove unneeded type casting. Reviewed-by:
-
Namjae Jeon authored
simplify error handling in ksmbd_auth_ntlm(). Reviewed-by:
-
Namjae Jeon authored
Move ret check before the out label. Reviewed-by:
-
Namjae Jeon authored
Just return smbhash() instead of using rc return value. Reviewed-by:
-
Namjae Jeon authored
Move fips_enabled check before the str_to_key(). Reviewed-by:
-
Namjae Jeon authored
Add goto fail in neg_token_init_mech_type(). Reviewed-by:
-
Namjae Jeon authored
Use memcmp instead of for loop check in oid_eq(). Reviewed-by:
-
Namjae Jeon authored
Add goto fail in asn1_oid_decode() to clean-up exception handling code. Reviewed-by:
-
- 21 May, 2021 1 commit
-
-
Wei Yongjun authored
Fix build error when CONFIG_OID_REGISTRY is not set: mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech': asn1.c:(.text+0xaa0): undefined reference to `sprint_oid' mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type': asn1.c:(.text+0xbec): undefined reference to `sprint_oid' Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by:
-
- 18 May, 2021 1 commit
-
-
Namjae Jeon authored
Add support for FSCTL_DUPLICATE_EXTENTS_TO_FILE in smb2 ioctl. Reviewed-by:
-
