Use set_current_state (TASK_RUNNING); schedule(); instead.

This patch touches the most significant places in usbcore
that need to respond to configuration change events:

  - set_interface changes altsettings; affects endpoints
    in both new and old settings (but not other endpoints).

  - set_configuration; affects every endpoint

The endpoints get disabled, flushing hardware state
reliably.  This resolves two FIXMEs here, part of one
in OHCI (ed_get) and all of one in EHCI (qh_append_tds).

Not many drivers currently use these code paths, but
now they should start to work properly.

Stefano Barbato wrote:
> Dual PIII
> kernel 2.4.21-rc2 (w/ SMP)  (2.5.69 below)
> ...
>
> I put a few printk before the BUG() and I found that the offending if() is
> this:
>         if(qh->qh_state != QH_STATE_LINKED
>                                 && qh->qh_state != QH_STATE_UNLINK_WAIT)
>
> because qh_state were QH_STATE_COMPLETING.

I got a similar SMP report recently, but without info about
which clause was failing -- which is a key clue, thanks!!

The COMPLETING state is used only while a QH is being
scanned for completed TDs.  (Think CPU-0 irq handler.)
Looking at the handful of places that call the routine
reporting the BUG(), a couple seem like they could make
trouble with multiple CPUs in the driver.

Alan Stern wrote:
> I suggest you just forget about acquiring the lock in status_dequeue() and
> simply leave it as
>
> 	del_timer_sync (&hcd->rh_timer);
> 	hcd->rh_timer.data = 0;

Hmm, so if some other URB gets queued in that window,
it'll get trashed?  Unlikely .. the clean fix would be
making the status endpoint have a real URB queue.

I combined your suggested change with two others:
(a) protect the status-unlink and control completion
    handlers against IRQs [ the cases Duncan noted]
(b) use mod_timer to retrigger the timer, instead of the
    heavy weight path.

into kroah.com:/home/linux/linux/BK/gregkh-2.5

Update ppc for mingo's do_fork changes.  Together with the pmac compile
fixes this allows me to stay at the bleeding edge with my my ibook..

This updates ppc64 for the do_fork() semantics change.

I completely misread this code and there was no bug.  In fact yesterday's fix
broke it.  Revert.

struct page is undefined in this file without this on Alpha.

From: Andi Kleen <ak@suse.de>

There is some assembly code in setup.c which doesn't explicitly set its
section.  It comes after a C function which is marked __init.  The compiler
does not reset the section after such C functions.  The assembly code is
going into .text.init.

That's the wrong section.  We get oopses modprobing sctp and, with Manfred's
unmap-free-pages debug patch we get oopses modprobing e100.ko.  In
apply_alternatives().

into nuts.ninka.net:/home/davem/src/BK/net-2.5

into nuts.ninka.net:/home/davem/src/BK/net-2.5

into nuts.ninka.net:/home/davem/src/BK/net-2.5

Support more chips and split out all the complex PHY
handling into a seperate file.

Revert the rtnl_lock API change, it is totally unneeded.
Instead we manage the todo work inside of net/core/dev.c

Also, we have to move sbin hotplug invocation outside of
the RTNL semaphore as well, both for register and unregister.

into home.transmeta.com:/home/torvalds/v2.5/linux

into tetrachloride.(none):/mnt/raid/src/kernel/2.5/agpgart

The AMD K8 GART driver is really for the on-CPU GART not the chipset as the Kconfig described.
Also fix up some grammar elsewhere.

We had two major issues when unregistering networking devices.
1) Even trying to run hotplug asynchronously could deadlock
   if keventd was currently trying to get the RTNL semaphore
   in order to process linkwatch events.
2) Unregister needs to wait for the last reference to go away
   before the finalization of the unregister can execute.  This
   cannot occur under the RTNL semaphore as this is deadlock
   prone as well.

The solution is to do all of this stuff after dropping the
RTNL semaphore.  rtnl_lock, if it is about to protect a region
of code that could unregister network devices, registers a list
to which unregistered netdevs are attached.  At rtnl_unlock time
this list is processed to wait for refcounts to drop to zero and
then finalize the unregister.

into nuts.ninka.net:/home/davem/src/BK/sparc-2.5

into nuts.ninka.net:/home/davem/src/BK/net-2.5

into kroah.com:/home/greg/linux/BK/gregkh-2.5

Alan Stern wrote:
> I finally got tired of my computer locking up when I tried to rmmod the
> low-level host controller driver.  It turns out the problem lies in the
> root-hub status urb code in core/hcd.c -- primarily a result of
> rh_report_status() not calling hcd_giveback_urb()...

Or in short:  your patch removes some old logic for the "automagic
interrupt transfer" special casing ... which recently started to
break that rmmod path.

With automagic, the only time an interrupt urb (like the root hub
status urb) could legitimately be given back was for unlink.  But
that unlink doesn't seem to be issued in the same way lately during
the rmmod paths.  (If they're less bizarre lately, that's good!)


> If this patch seems all right, will you please let Greg know it's okay to
> apply it?

I changed a couple minor things below ... basically (a) fixing the
issue Duncan Sands pointed out (always call completions with irqs
disabled, even if hub driver currently doesn't care), (b) better
logic to avoid retriggering the timer during shutdown, (c) not
doing del_timer_sync() while holding that lock, plus (d) a minor
linewrap fix.