- 23 May, 2014 40 commits
-
-
Matthias Beyer authored
Signed-off-by:
Matthias Beyer <mail@beyermatthias.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Matthias Beyer authored
This patch outsources the code from the IsFlash2x() check in bcm_char_ioctl_nvm_rw() function to shorten it. Signed-off-by:
-
Matthias Beyer authored
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command handling to shorten the bcm_char_ioctl_nvm_rw() function. Signed-off-by:
-
Matthias Beyer authored
Signed-off-by:
-
Daeseok Youn authored
Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Christian Engelmayer authored
Fix the error path when a cookie mismatch is detected. In that case the function jumps to the exit label without setting the uninitialized, local variable 'return_error'. Detected by Coverity - CID 201453. Signed-off-by:
Christian Engelmayer <cengelma@gmx.at> Acked-by:
Arve <arve@android.com> Signed-off-by:
-
Jerry Snitselaar authored
Clean up sparse warnings for cred struct dereference. Signed-off-by:
Jerry Snitselaar <dev@snitselaar.org> Signed-off-by:
-
Greg Kroah-Hartman authored
Roger writes: Since all patches have been applied and the device is now supported by the new driver, would you remove the former staging one at drivers/staging/rts5139? Cc: Roger Tseng <rogerable@realtek.com> Signed-off-by: -
Fabio Estevam authored
WARNING: Missing a blank line after declarations #160: FILE: drivers/staging/imx-drm/imx-hdmi.c:160: + u8 val = hdmi_readb(hdmi, reg) & ~mask; + val |= data & mask; WARNING: Missing a blank line after declarations #1609: FILE: drivers/staging/imx-drm/imx-hdmi.c:1609: + const struct platform_device_id *device_id = of_id->data; + hdmi->dev_type = device_id->driver_data; total: 0 errors, 2 warnings, 1767 lines checked drivers/staging/imx-drm/imx-hdmi.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Signed-off-by:
Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by:
-
Daniele Forsi authored
It was added by commit e0349d5b (staging: et131x: Remove unused rcv_pend_lock spinlock) Signed-off-by:
Daniele Forsi <dforsi@gmail.com> Acked-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Maarten de Jonge authored
Signed-off-by:
Maarten de Jonge <mdejonge1990@gmail.com> Acked-by:
-
Peter Senna Tschudin authored
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by:
Peter Senna Tschudin <peter.senna@gmail.com> Acked-by:
-
Christian Engelmayer authored
Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove it. With the last variable declaration gone, there is no more need for an own block. Remove it and adapt the indenting accordingly. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Christian Engelmayer authored
Remove a needless pointer initialisation and call to get_status_port_fn() in functions remove_bypass_tpl_auto() and set_tpl_fn(). Variable 'pbpctl_dev_b' is set correctly later in the function before first use. Signed-off-by:
-
Fernando Apesteguia authored
Add blank line after declarations and delete extra blank line at the beginning of the function Signed-off-by:
Fernando Apesteguia <fernando.apesteguia@gmail.com> Signed-off-by:
-
Daeseok Youn authored
cleanup checkpatch.pl error: ERROR: do not initialise statics to 0 or NULL Signed-off-by:
-
Daeseok Youn authored
clean up checkpatch.pl warning: WARNING: Line length over 80 characters Signed-off-by:
-
Daeseok Youn authored
Signed-off-by:
-
Daeseok Youn authored
Removes "#if 0" blocks. And the musycc_dump_rxbuffer_ring(ch, 0) which is commented out puts in RLD_DEBUG block and uncommented. Because this function may be used for debugging. Signed-off-by:
-
Daeseok Youn authored
clean up checkpatch.pl warning: WARNING: please no spaces at the start of a line in Signed-off-by:
-
Dominique van den Broeck authored
Style-only modifications to comply with checkpatch.pl --strict --file. . Correctly realigns the lines that needed to be ; . Suppress useless blank rows ; . Fix sizeof() issues in various -malloc() functions. Signed-off-by:
Dominique van den Broeck <domdevlin@free.fr> Signed-off-by:
-
Dominique van den Broeck authored
Style-only modifications to comply with checkpatch.pl --strict --file. . Adds every missing brace in condition statements. Signed-off-by:
-
Bastien Armand authored
This patch fix a regression in lcd_write caused by commit 70a8c3ebSigned-off-by:
Bastien Armand <armand.bastien@laposte.net> Signed-off-by:
-
Rusty Russell authored
In line with practice for module parameters, we're adding a build-time check that sysfs files aren't world-writable. Cc: Christopher Brannon <chris@the-brannons.com> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
Rusty Russell <rusty@rustcorp.com.au> Signed-off-by:
-
Dominique van den Broeck authored
. userspace pointer dereference ; These issues have been fixed by a concurrent patch: . missing inclusions of needed header files (fixed by concurrent patch); . unrequired static function declaration (confusing another *.c file). Signed-off-by:
-
Kim Nylund authored
This is a new device supported by this driver. Signed-off-by:
Kim Nylund <kim@pratsam.com> Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Cc: stable <stable@vger.kernel.org> Signed-off-by:
-
Larry Finger authored
In a patch entitles "staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0" (commit ID unknown), I introduce an endian error. This patch fixes that, and removes two additional sparse warnings. drivers/staging/rtl8188eu/core/rtw_recv.c:653:6: warning: symbol 'process_pwrbit_data' was not declared. Should it be static? drivers/staging/rtl8188eu/core/rtw_recv.c:1828:5: warning: symbol 'enqueue_reorder_recvframe' was not declared. Should it be static? Reported-by:
-
Ken Cox authored
There is not any code using the functionality in filexfer.c so I removed it and filexfer.h. Signed-off-by:
Ken Cox <jkc@redhat.com> Signed-off-by:
-
Ken Cox authored
Fixed the usage of the following so they don't try to dereference pointers to iomem. CHANNEL_U64_MISMATCH CHANNEL_U32_MISMATCH wait_for_valid_guid Signed-off-by:
-
Ken Cox authored
VISORCHANNEL_CHANGE_SERVER_STATE and VISORCHANNEL_CHANGE_CLIENT_STATE are never used in any of the source so they have been removed. VISORCHANNEL_CHANGE_CLIENT_STATE would have caused a broken kernel build after commit a8d7f21d, but since it was never used the kernel continued to build. Reported-by:
-
Ken Cox authored
virthba_queue_command() is only used inside virthba.c so declare it static. Signed-off-by:
-
Ken Cox authored
Fix sparse warnings caused by incorrect references to IO space. Signed-off-by:
-
David Matlack authored
slic_config_get() can fail. Change the return type from void to int and handle the error in slic_card_init(). So now, instead of silently failing (and then timing out waiting for the config data), the driver will fail loudly at request time. Signed-off-by:
David Matlack <matlackdavid@gmail.com> Signed-off-by:
-
David Matlack authored
Remove fail_on_bad_eeprom, which was always 0 and thus being used to ignore incorrect checksumming. This means devices with corrupt eeprom will now cause the driver to fail. Since fail_on_bad_eeprom was the last member in use of struct slic_reg_params, remove that struct altogether. Signed-off-by:
-
David Matlack authored
Rewrite slic_eeprom_cksum() to fix bugs and make readable. This patch technically has no effect on the user as failed eeprom checksums are ignored anyway. The original implementation had the following issues: 1. 2 of the 3 unrolled loops had the following bug: while ((len -= 32) >= 0) { [...] sum += w[15]; w = (u16 *)((ulong) w + 16); /* verify */ } This processes 32-bytes of data but only increments the word pointer by 16 bytes. Fixing both of these bugs seems to fix slic_eeprom_cksum(). 2. Non-descriptive variable names, use of unions, and macros that change local state make the code difficult to read. 3. The checksum loop is unrolled which makes the code harder to reason about while providing small performance improvement: - max eeprom length is 0x80 bytes (MAX_EECODE_SIZE), that's only 0x40 iterations - checksum is only computed during pci probe(), so not very often Tested on Mojave card Signed-off-by: -
David Matlack authored
This patch fixes a use-after-free bug that causes a null pointer dereference in slic_entry_halt. Since unregister_netdev() will ultimately call slic_entry_halt (the net_device ndo_stop() virtual function for this device), we should call it before freeing the memory used by slic_entry_halt. Signed-off-by:
David Matlack <dmatlack@google.com> Signed-off-by:
-
David Matlack authored
This patch fixes a bug that only manifests when the physical address of the interrupt status register is >4GB. Specifically, the driver was only telling the device about the lower 32 bits of the ISR. This patch adds the upper 32 bits. Signed-off-by:
-
David Matlack authored
This patch fixes a memory leak in slic_card_init. If the driver fails to poll for an interrupt after requesting config data from the device the dma memory is never freed. Signed-off-by:
-
David Matlack authored
As per the TODO file, this patch removes the gratuitous debug infrastructure. As an extra incentive for removing this code, the debugfs files are not cleaned up properly. For example, if register_netdev() fails in slic_entry_probe() then all debugfs files get left behind, even after the driver module is unloaded. Touching these files quickly leads to an oops. Signed-off-by:
-
David Matlack authored
This patch removes two fields from the private "struct adapter". Specifically, memorybase duplicate of slic_regs memorylength written once and never read. This field is trivially computed with pci_resource_len if it's ever needed in the future. Signed-off-by:
-
