- 23 Jul, 2021 2 commits
-
-
Fabio Aiuto authored
simplify function Hal_GetChnlGroup8723B(). It returns an unused and unnecessary bool value telling which band the device works on. Since we work only on 2.4Ghz band and the useful return value is the second function argument we convert the return type to void. remove 5Ghz dead code either (for channel > 14). Signed-off-by:
Fabio Aiuto <fabioaiuto83@gmail.com> Link: https://lore.kernel.org/r/a5536788004c44fe819c0eab0d19504824af46cd.1626874164.git.fabioaiuto83@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mauro Carvalho Chehab authored
This driver is ready for mainstream. So, move it out of staging. Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Link: https://lore.kernel.org/r/dd150f3ffa19c2dda0171f7dbe1dd63cce2a7af5.1627025657.git.mchehab+huawei@kernel.orgSigned-off-by:
-
- 21 Jul, 2021 38 commits
-
-
Mauro Carvalho Chehab authored
The regex at the patternProperties is wrong, although this was not reported as the DT schema was not enforcing properties. Fix it. Signed-off-by:
-
Mauro Carvalho Chehab authored
Per MFD subsystem requirements, split the IRQ part of the driver into a separate one with just the IRQ handling code and the powerkey support. Signed-off-by:
-
Mauro Carvalho Chehab authored
The Huawei's copyright is missing a dot at the end. Add it, in order to make it similar to the other two copyrights. Signed-off-by:
-
Mauro Carvalho Chehab authored
Instead of using the standard name ("gpios"), use "interrupts". Suggested-by:Rob Herring <robh@kernel.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
Let's not call a pointer to spmi_device as pdev, as it is something else. Signed-off-by:
-
Diego Roux authored
This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by:
Diego Roux <me@diegoroux04.dynv6.net> Link: https://lore.kernel.org/r/20210716024909.39411-1-me@diegoroux04.dynv6.netSigned-off-by:
-
Geert Uytterhoeven authored
On Armadillo-800-EVA with CONFIG_DEBUG_SPINLOCK=y: BUG: spinlock bad magic on CPU#0, swapper/1 lock: lcdc0_device+0x10c/0x308, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 CPU: 0 PID: 1 Comm: swapper Not tainted 5.11.0-rc5-armadillo-00036-gbbca04be7a80-dirty #287 Hardware name: Generic R8A7740 (Flattened Device Tree) [<c010c3c8>] (unwind_backtrace) from [<c010a49c>] (show_stack+0x10/0x14) [<c010a49c>] (show_stack) from [<c0159534>] (do_raw_spin_lock+0x20/0x94) [<c0159534>] (do_raw_spin_lock) from [<c040858c>] (dev_pm_get_subsys_data+0x8c/0x11c) [<c040858c>] (dev_pm_get_subsys_data) from [<c05fbcac>] (genpd_add_device+0x78/0x2b8) [<c05fbcac>] (genpd_add_device) from [<c0412db4>] (of_genpd_add_device+0x34/0x4c) [<c0412db4>] (of_genpd_add_device) from [<c0a1ea74>] (board_staging_register_device+0x11c/0x148) [<c0a1ea74>] (board_staging_register_device) from [<c0a1eac4>] (board_staging_register_devices+0x24/0x28) of_genpd_add_device() is called before platform_device_register(), as it needs to attach the genpd before the device is probed. But the spinlock is only initialized when the device is registered. Fix this by open-coding the spinlock initialization, cfr. device_pm_init_common() in the internal drivers/base code, and in the SuperH early platform code. Signed-off-by:Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/57783ece7ddae55f2bda2f59f452180bff744ea0.1626257398.git.geert+renesas@glider.beSigned-off-by:
-
Len Baker authored
strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy(). Signed-off-by:
Len Baker <len.baker@gmx.com> Link: https://lore.kernel.org/r/20210717155145.15041-1-len.baker@gmx.comSigned-off-by:
-
Alexander Greyling authored
This patch fixes the checkpatch.pl issue: CHECK: Alignment should match open parenthesis. Signed-off-by:
Alexander Greyling <alexandergreyling5@gmail.com> Link: https://lore.kernel.org/r/20210710220815.GA1654486@alexlaptopSigned-off-by:
-
Christophe JAILLET authored
These #define and the enum WIFI_REG_DOMAIN are unused. They can be removed. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/6d5b505e7de20fdaba1831557baee1daf4656845.1625470822.git.christophe.jaillet@wanadoo.frSigned-off-by:
-
Jan Gruber authored
This commit fixes the following checkpatch.pl issues: + pr_debug("===> %s\n", __func__); WARNING: Unnecessary ftrace-like logging - prefer using ftrace 158: FILE: drivers/staging/rtl8188eu/os_dep/usb_intf.c:158: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 177: FILE: drivers/staging/rtl8188eu/os_dep/usb_intf.c:177: + pr_debug("<=== %s\n", __func__); and removes another line of unnecessary logging, which was not identified by checkpatch.pl in an automated manner. Signed-off-by:Jan Gruber <j4n6ru@gmail.com> Link: https://lore.kernel.org/r/20210705172101.239899-1-j4n6ru@gmail.comSigned-off-by:
-
Nishal Kulkarni authored
This patch fixes checkpatch.pl warning: CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header Signed-off-by:
Nishal Kulkarni <nishalkulkarni@gmail.com> Link: https://lore.kernel.org/r/YNcPzWXkKkmip95x@nishal-pcSigned-off-by:
-
Martin Kaiser authored
We're no longer matching power transitions and commands against a power cut version mask. The cut_mask field from struct wl_pwr_cfg can be removed. It was set to PWR_CUT_ALL_MSK for all remaining commands. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20210718173610.894-10-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
None of the power flows and transitions includes a read command. PWR_CMD_READ can be removed. Signed-off-by:
-
Martin Kaiser authored
The rtl88eu_pwrseqcmdparsing function takes a parameter to restrict commands to certain power cut versions of the rtl8188eu chipset. This mechanism is not used, the callers always select all versions. Remove the power cut parameter. Signed-off-by:
-
Martin Kaiser authored
The driver defines a couple of "flows" to move the chip into a certain power state. Each flow is a sequence of "transitions". This patch removes flows and transitions which are not used. Signed-off-by:
-
Martin Kaiser authored
This driver does not need write access to the rtl1888eu chip's efuses. Remove the code to set the voltages for writing the efuses. Signed-off-by:
-
Martin Kaiser authored
This setting is used only in one place. There's no need to store it in a global struct. While at it, merge the two-line Hal_InitPGData88E function and its only caller. Signed-off-by:
-
Martin Kaiser authored
This enum is not used and can be removed. Signed-off-by:
-
Martin Kaiser authored
This enum is not used and can be removed. Signed-off-by:
-
Martin Kaiser authored
The hal variable to trigger gpio 0 seems to be a leftover from debugging code that was removed. An empty function is called when this variable is written to. Remove the empty function and the variable itself. It should be safe to remove an entry from the hw_variables enum as this enum is used only within the rtl8188eu driver. Signed-off-by:
-
Martin Kaiser authored
All that rtw_hal_read_chip_info does is call _ReadPROMContent. Merge the two functions. Signed-off-by:
-
Phillip Potter authored
Move source file hal/mac_cfg.c to the 'core' driver directory, and also rename its array from array_MAC_REG_8188E to array_MAC_REG, as well as renaming the function rtl88eu_phy_mac_config to phy_mac_config. Also modify single call-site for this function to reflect new name. This file contains no code which touches the adapter's HalData structure, and is a good candidate for therefore moving out of 'hal'. Also, no need for these signatures to include the model number as this driver only supports RTL8188eu. Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20210720225826.454516-1-phil@philpotter.co.ukSigned-off-by:
-
Fabio Aiuto authored
fix camel case argument name in is_supported_tx_cck Signed-off-by:
-
Fabio Aiuto authored
fix camel case name in macro IsSupportedTxCCK Signed-off-by:
-
Fabio Aiuto authored
remove unused macros in include/ieee80211.h Signed-off-by:
-
Fabio Aiuto authored
fix the following post-commit camel case issues: CHECK: Avoid CamelCase: <Adapter> 33: FILE: drivers/staging/rtl8723bs/hal/hal_com.c:152: + if (is_supported_24g(Adapter-> registrypriv.wireless_mode) == false) CHECK: Avoid CamelCase: <NetType> 46: FILE: drivers/staging/rtl8723bs/include/ieee80211.h:159: +#define is_supported_24g(NetType) ((NetType) & SUPPORTED_24G_NETTYPE_MSK ? true : false) CHECK: Avoid CamelCase: <IsEnableHWCCK> 49: FILE: drivers/staging/rtl8723bs/include/ieee80211.h:161: +#define IsEnableHWCCK(NetType) is_supported_24g(NetType) Signed-off-by:
-
Fabio Aiuto authored
fix camel case name in macro IsSupported24G Signed-off-by:
-
Fabio Aiuto authored
fix camel case in argument of macro is_legacy_only Signed-off-by:
-
Fabio Aiuto authored
fix camel case name in macro IsLegacyOnly() Signed-off-by:
-
Fabio Aiuto authored
fix following post commit hook checkpatch issue: CHECK: Avoid CamelCase: <NetType> 45: FILE: drivers/staging/rtl8723bs/include/ieee80211.h:170: +#define is_supported_ht(NetType) (((NetType) & (WIRELESS_11_24N)) ? true : false) Signed-off-by:
-
Fabio Aiuto authored
convert IsSupportedHT to snake case is_supported_ht. Signed-off-by:
-
Fabio Aiuto authored
add get_channel cfg80211 implementation to let userspace programs rely on nl80211 protocol to display channel information. Old iw dev output: phy#0 Interface wlan0 ifindex 2 wdev 0x1 addr 34:c3:d2:73:eb:c7 ssid Fabio type managed txpower 12.00 dBm Fixed output: phy#0 Interface wlan0 ifindex 2 wdev 0x1 addr 34:c3:d2:73:eb:c7 ssid Fabio type managed new--> channel 11 (2462 MHz), width: 20 MHz, center1: 2462 Mhz txpower 12.00 dBm Signed-off-by:
-
Fabio Aiuto authored
fix authentication algorithm constants. wpa_set_auth_algs() function contains some conditional statements masking the checked value with the wrong constants. This produces some unintentional dead code. Mask the value with the right macros. Fixes: 5befa937 ("staging: rtl8723bs: Fix IEEE80211 authentication algorithm constants.") Reported-by:
Colin Ian King <colin.king@canonical.com> Tested-on: Lenovo Ideapad MiiX 300-10IBY Signed-off-by:
-
Bryan Brattlof authored
The rtw_cpu_to_leXX() and rtw_leXX_to_cpu() family of macros are unnecessary and should be removed. Signed-off-by:
Bryan Brattlof <hello@bryanbrattlof.com> Link: https://lore.kernel.org/r/20210629135824.47749-1-hello@bryanbrattlof.comSigned-off-by:
-
Colin Ian King authored
The while-loop only iterates once becase the post increment test of count being non-zero is false on the first iteration because count is zero. Fix this by using a for-loop instead. Static analysis found the issue on the count > POLLING_LLT_THRESHOLD check always being false since the loop currently just iterates once. Thanks to David Laight for suggesting using for-loop instead to improve the readability of the fix. Signed-off-by:
-
Jan Gruber authored
This commit fixes the following checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Phillip Potter authored
Remove rtw_wx_set_rate handler function, which currently handles the SIOCSIWRATE wext ioctl. This function (although containing a lot of code) set nothing outside its own local variables, and did nothing other than call a now removed debugging statement repeatedly. Removing it and leaving its associated entry in rtw_handlers as NULL is therefore the better option. Removing this function also fixes a kernel test robot warning. Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
