1. 22 Jun, 2017 3 commits
    • Arnd Bergmann's avatar
      net: phy: smsc: fix buffer overflow in memcpy · 2da55390
      Arnd Bergmann authored
      The memcpy annotation triggers for a fixed-length buffer copy:
      
      In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0,
                       from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21,
                       from /git/arm-soc/include/linux/spinlock.h:87,
                       from /git/arm-soc/include/linux/seqlock.h:35,
                       from /git/arm-soc/include/linux/time.h:5,
                       from /git/arm-soc/include/linux/stat.h:21,
                       from /git/arm-soc/include/linux/module.h:10,
                       from /git/arm-soc/drivers/net/phy/smsc.c:20:
      In function 'memcpy',
          inlined from 'smsc_get_strings' at /git/arm-soc/drivers/net/phy/smsc.c:166:3:
      /git/arm-soc/include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
      
      Using strncpy instead of memcpy should do the right thing here.
      
      Fixes: 030a8902 ("net: phy: smsc: Implement PHY statistics")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2da55390
    • Myron Stowe's avatar
      net/mlx5e: Use device ID defines · bbad7c21
      Myron Stowe authored
      Use Mellanox device ID definitions in the driver's mlx5 ID table so tools
      such as 'grep' and 'cscope' can be used to help find correlated material
      (such as INTx Masking quirks: d76d2fe0 PCI: Convert Mellanox broken
      INTx quirks to be for listed devices only).
      
      No functional change intended.
      Signed-off-by: default avatarMyron Stowe <myron.stowe@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bbad7c21
    • Denys Vlasenko's avatar
      liquidio: stop using huge static buffer, save 4096k in .data · b381f783
      Denys Vlasenko authored
      Only compile-tested - I don't have the hardware.
      
      >From code inspection, octeon_pci_write_core_mem() appears to be safe wrt
      unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned
      anyway.
      Signed-off-by: default avatarDenys Vlasenko <dvlasenk@redhat.com>
      CC: Felix Manlunas <felix.manlunas@cavium.com>
      CC: Prasad Kanneganti <prasad.kanneganti@cavium.com>
      CC: Derek Chickles <derek.chickles@cavium.com>
      CC: David Miller <davem@davemloft.net>
      CC: netdev@vger.kernel.org
      CC: linux-kernel@vger.kernel.org
      Acked-by: default avatarFelix Manlunas <felix.manlunas@cavium.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b381f783
  2. 21 Jun, 2017 37 commits