Commits · 2f1e48d670dc755d40f7bd926d02713d90b378ea · Kirill Smelkov / linux

03 Sep, 2014 40 commits

[media] siano: just return 0 instead of using a var · 2f1e48d6

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

2f1e48d6

[media] s5p-tv: Simplify the return logic · d8e8b40c

Mauro Carvalho Chehab authored Sep 03, 2014

Make sure pm_runtime_* calls does not use unnecessary
IS_ERR_VALUE().

Reported by scripts/coccinelle/api/pm_runtime.cocci script.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

d8e8b40c

[media] e4000: simplify boolean tests · a04557a2

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using if (foo == false), just use
if (!foo).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

a04557a2

[media] via-camera: simplify boolean tests · b2617dc3

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using if (foo == false), just use
if (!foo).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

b2617dc3

[media] omap: simplify test logic · 160ac0ba

Mauro Carvalho Chehab authored Sep 03, 2014

instead of testing bools if they are false or true, just use
if (!foo) or if (foo). That makes the code easier to
read and shorter.

Also, properly initialize booleans with true or false.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

160ac0ba

[media] lm3560: simplify a boolean test · 1b21e218

Mauro Carvalho Chehab authored Sep 03, 2014

lml33dpatch is boolean. So, the possible values are
true or false.

Instead of using if (lml33dpath), just use
if (!lml33dpath).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

1b21e218

[media] lm3560: simplify boolean tests · afb666d1

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using if (on == true), just use
if (on).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

afb666d1

[media] drxk_hard: simplify test logic · 5a7f7b79

Mauro Carvalho Chehab authored Sep 03, 2014

instead of testing if it is false or true, just use
if (!foo) or if (foo). That makes the code easier to
read and shorter.

Also, properly initialize booleans with true or false.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

5a7f7b79

[media] msi2500: simplify boolean tests · ad7b8c02

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using if (foo == false), just use
if (!foo).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

ad7b8c02

[media] af9005: use true/false for boolean vars · 61f6a056

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

61f6a056

[media] lmedm04: use true/false for boolean vars · 235d89ec

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

235d89ec

[media] au0828-dvb: use true/false for boolean vars · f6b83c3e

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

f6b83c3e

[media] ene_ir: use true/false for boolean vars · 2816cc31

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

2816cc31

[media] radio: use true/false for boolean vars · 8b4b6818

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

8b4b6818

[media] vivid-tpg: use true/false for boolean vars · 6c515a44

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

6c515a44

[media] ti-vpe: use true/false for boolean vars · 68bbbd79

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

68bbbd79

[media] omap3isp: use true/false for boolean vars · 11b4c175

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

11b4c175

[media] ov9740: use true/false for boolean vars · cdde1a9b

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

cdde1a9b

[media] smiapp-core: use true/false for boolean vars · 06e916b7

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

06e916b7

[media] tda10071: use true/false for boolean vars · 79a5ee78

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

79a5ee78

[media] af9013: use true/false for boolean vars · 2fe15e20

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.

Also, instead of testing foo == false, just use the
simplified notation if(!foo).
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

2fe15e20

[media] m88ds3103: use true/false for boolean vars · afbd6eb4

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

afbd6eb4

[media] cxd2820r: use true/false for boolean vars · 285c0b00

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

285c0b00

[media] af9013: use true/false for boolean vars · 6a5e7fde

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

6a5e7fde

[media] tuner-core: use true/false for boolean vars · 22bf3deb

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

22bf3deb

[media] em28xx: use true/false for boolean vars · 7e6c8c19

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

7e6c8c19

[media] stv0900_core: don't allocate a temporary var · 49bc8962

Mauro Carvalho Chehab authored Sep 03, 2014

The error return code STV0900_NO_ERROR happens only once, at
the end of the functions. So, just return it directly.

This driver should actually be fixed to return standard
Linux error codes, instead of its own macros, but this
should be done on a separate patchset.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

49bc8962

[media] soc_camera: remove uneeded semicolons · c611c908

Mauro Carvalho Chehab authored Sep 03, 2014

We don't use semicolons after curly braces in the middle of the
code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

c611c908

[media] bttv-driver: remove an uneeded semicolon · c3142a61

Mauro Carvalho Chehab authored Sep 03, 2014

We don't use semicolons after curly braces in the middle of the
code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

c3142a61

[media] s5k5baf: remove an uneeded semicolon · bc39d69a

Mauro Carvalho Chehab authored Sep 03, 2014

We don't use semicolons after curly braces in the middle of the
code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

bc39d69a

[media] vivid-vid-out: use memdup_user() · 02829691

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of allocating and coping from __user, do it using
one atomic call. That makes the code simpler.

Found by coccinelle.
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

02829691

[media] soc_camera: use kmemdup() · 93623c87

Mauro Carvalho Chehab authored Sep 03, 2014

Instead of calling kzalloc and then copying, use kmemdup(). That
avoids zeroing the data structure before copying.

Found by coccinelle.
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

93623c87

[media] marvel-ccic: don't initialize static vars with 0 · a7459a9d

Mauro Carvalho Chehab authored Sep 03, 2014

alloc_bufs_at_read is static. No need to initialize with
zero, as the Kernel will cleanup the data memory already.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

a7459a9d

[media] dmxdev: don't use before checking file->private_data · 313ddec4

Mauro Carvalho Chehab authored Sep 03, 2014

As reported by smatch:
	drivers/media/dvb-core/dmxdev.c:1091 dvb_demux_poll() warn: variable dereferenced before check 'dmxdevfilter' (see line 1088)

This was introduced by changeset d102cac8.

We need to test before using it.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

313ddec4

[media] mt2063: fix sparse warnings · fe10b84e

Hans Verkuil authored Aug 21, 2014

drivers/media/tuners/mt2063.c:1238:56: warning: cast truncates bits from constant value (ffffff0f becomes f)
drivers/media/tuners/mt2063.c:1313:62: warning: cast truncates bits from constant value (ffffff7f becomes 7f)
drivers/media/tuners/mt2063.c:1321:62: warning: cast truncates bits from constant value (ffffff7f becomes 7f)

Cast to u8 is unnecessary.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

fe10b84e

[media] v4l2-compat-ioctl32: fix sparse warnings · 8ae632b1

Hans Verkuil authored Aug 21, 2014

A lot of these warnings are caused by the fact that we don't generally use
__user in videodev2.h. Normally the video_usercopy function will copy anything
pointed to by pointers into kernel space, so having __user in the struct will only
cause lots of warnings in the drivers. But the flip side of that is that you
need to add __force casts here.

drivers/media/v4l2-core/v4l2-compat-ioctl32.c:337:26: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:337:30: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:338:31: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:338:49: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:343:21: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:346:21: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:349:35: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:349:46: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:352:35: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:352:54: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:363:26: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:363:32: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:364:31: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:364:51: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:371:35: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:371:56: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:376:35: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:376:48: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:430:30: warning: incorrect type in assignment (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:433:48: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:433:56: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:501:24: warning: incorrect type in assignment (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:507:48: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:507:56: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:565:18: warning: incorrect type in assignment (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:670:22: warning: incorrect type in assignment (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:680:29: warning: incorrect type in assignment (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:692:55: warning: incorrect type in initializer (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:773:18: warning: incorrect type in assignment (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:786:30: warning: incorrect type in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:786:44: warning: incorrect type in argument 2 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:674:37: warning: dereference of noderef expression
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:718:37: warning: dereference of noderef expression
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

8ae632b1

[media] videodev2.h: add __user to v4l2_ext_control pointers · eadf9e26

Hans Verkuil authored Aug 21, 2014

These are not copied to kernel space by video_usercopy, so mark them
as __user.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

eadf9e26

[media] em28xx: fix sparse warnings · 4a9e512a

Hans Verkuil authored Aug 21, 2014

drivers/media/usb/em28xx/em28xx-core.c:297:16: warning: cast to restricted __le16
drivers/media/usb/em28xx/em28xx-cards.c:2249:20: warning: symbol 'em28xx_bcount' was not declared. Should it be static?
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

4a9e512a

[media] cx18: fix sparse warnings · 39fd4460

Hans Verkuil authored Aug 21, 2014

/home/hans/work/build/media-git/drivers/media/pci/cx18/cx18-firmware.c:169:32: warning: cast to restricted __le32
/home/hans/work/build/media-git/drivers/media/pci/cx18/cx18-firmware.c:170:32: warning: cast to restricted __le32
/home/hans/work/build/media-git/drivers/media/pci/cx18/cx18-firmware.c:171:31: warning: cast to restricted __le32
/home/hans/work/build/media-git/drivers/media/pci/cx18/cx18-firmware.c:172:31: warning: cast to restricted __le32
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

39fd4460

[media] ivtv: fix sparse warnings · 3efb8ab6

Hans Verkuil authored Aug 21, 2014

drivers/media/pci/ivtv/ivtv-irq.c:195:25: warning: incorrect type in argument 1 (different base types)
drivers/media/pci/ivtv/ivtv-irq.c:199:25: warning: incorrect type in argument 1 (different base types)
drivers/media/pci/ivtv/ivtv-irq.c:278:35: warning: restricted __le32 degrades to integer
drivers/media/pci/ivtv/ivtv-irq.c:281:51: warning: restricted __le32 degrades to integer
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

3efb8ab6