Commits · 2f4e7abe5175cd17d74e41b9f4e8e04cd73342fb · Kirill Smelkov / linux

08 Nov, 2012 22 commits

drbd: drbd_send_sr_reply(): Return void: the result is never used · 2f4e7abe
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
2f4e7abe
drbd: drbd_send_state_req(): Return 0 upon success and an error code otherwise · d24ae219
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
d24ae219
drbd: conn_send_state_req(): Return 0 upon success and an error code otherwise · caee1c3a
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
caee1c3a
drbd: _conn_send_state_req(): Return 0 upon success and an error code otherwise · 758970c8
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
758970c8
drbd: drbd_send_sizes(): Return 0 upon success and an error code otherwise · f02d4d0a
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
f02d4d0a
drbd: drbd_gen_and_send_sync_uuid(): Return void: the result is never used · 9c1b7f72
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
9c1b7f72
drbd: drbd_send_uuids() and its variants: Return 0 upon success and an error code otherwise · 2ae5f95b
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
2ae5f95b
drbd: drbd_send_protocol(): Return 0 upon success and an error code otherwise · 387eb308
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
387eb308
drbd: drbd_send_handshake(): Return 0 upon success and an error code otherwise · e8d17b01
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
e8d17b01
drbd: drbd_send_state(): Return 0 upon success and an error code otherwise · 927036f9
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
927036f9
drbd: drbd_send_sync_param(): Return 0 upon success and an error code otherwise · 103ea275
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
103ea275
drbd: drbd_send_cmd(): Return 0 upon success and an error code otherwise · f7254463
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
f7254463

drbd: Get rid of USE_DATA_SOCKET and USE_META_SOCKET · 7d168ed3

Andreas Gruenbacher authored Mar 16, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

7d168ed3

drbd: conn_send_cmd(): Return 0 upon success and an error code otherwise · 596a37f9
Andreas Gruenbacher authored Mar 15, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
596a37f9
drbd: _drbd_send_cmd(): Return 0 upon success and an error code otherwise · 04dfa137
Andreas Gruenbacher authored Mar 15, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
04dfa137
drbd: _conn_send_cmd(): Return 0 upon success and an error code otherwise · ecf2363c
Andreas Gruenbacher authored Mar 15, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
ecf2363c
drbd: conn_send_cmd2(): Return 0 upon success and an error code otherwise · ce9879cb
Andreas Gruenbacher authored Mar 15, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
ce9879cb

drbd: Add drbd_send_all(): Send an entire buffer · fb708e40

Andreas Gruenbacher authored Dec 15, 2010

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

fb708e40

drbd: drbd_get_data_sock(): Return 0 upon success and an error code otherwise · 11b0be28
Andreas Gruenbacher authored Mar 15, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
11b0be28

drbd: drbd_send(): Return a "real" error code if we have no socket · c0d42c8e

Andreas Gruenbacher authored Dec 09, 2010

Q: Can this case even trigger?  Is failing this way any better than one
that causes a NULL pointer access?
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

c0d42c8e

drbd: Fixed conn_lowest_minor · e90285e0

Philipp Reisner authored Mar 22, 2011

It actually returned the lowest volume number. While doing that
renamed a few wrongly named variables.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

e90285e0

drbd: distribute former syncer_conf settings to disk, connection, and resource level · f399002e

Lars Ellenberg authored Mar 23, 2011

This commit breaks the API again.

Move per-volume former syncer options into disk_conf.
Move per-connection former syncer options into net_conf.
Renamed the remainign sync_conf to res_opts

Syncer settings have been changeable at runtime, so we need to prepare
for these settings to be runtime-changeable in their new home as well.

Introduce new configuration operations, and share the netlink attribute
between "attach" (create new disk) and "disk-opts" (change options).
Same for "connect" and "net-opts".

Some fields cannot be changed at runtime, however.
Introduce a new flag GENLA_F_INVARIANT to be able to trigger on that in
the generated validation and assignment functions.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

f399002e

03 Nov, 2012 18 commits

drbd: conn_khelper() for user mode callbacks for connections · 6b75dced

Philipp Reisner authored Mar 16, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

6b75dced

drbd: Allow volumes to become primary only on one side · 047e95e2

Philipp Reisner authored Mar 16, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

047e95e2

drbd: fix conn_reconfig_start without conn_reconfig_done in drbd_adm_attach · 40cbf085

Lars Ellenberg authored Mar 16, 2011

If drbd_adm_attach failed early, it left the CONFIG_PENDING bit on,
blocking any further conn_reconfig_start on that connection.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

40cbf085

drbd: Separate connection state changes from minor dev state changes #2 · e4f78ede

Philipp Reisner authored Mar 16, 2011

New function got_conn_RqSReply()
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

e4f78ede

drbd: Converted got_Ping() and got_PingAck() from mdev to tconn · f19e4f8b

Philipp Reisner authored Mar 16, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

f19e4f8b

drbd: Allow packet handler functions that take a connection (meta connection) · a4fbda8e
Philipp Reisner authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
a4fbda8e
drbd: Separate connection state changes from minor dev state changes #1 · dfafcc8a
Philipp Reisner authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
dfafcc8a

drbd: Converted receive_protocol() from mdev to tconn · 7204624c

Philipp Reisner authored Mar 15, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

7204624c

drbd: Allow packet handler functions that take a connection · d9ae84e7

Philipp Reisner authored Mar 15, 2011

That is necessary in case a connection does not have a volume 0
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

d9ae84e7

drbd: Moved CONN_DRY_RUN to the per connection (tconn) flags · 8169e41b

Philipp Reisner authored Mar 15, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

8169e41b

drbd: Do not modify the connection state with something else that conn_request_state() · 38fa9988
Philipp Reisner authored Mar 15, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
38fa9988

drbd: Allow two diskless minors to be connected · 34f646bd

Philipp Reisner authored Mar 15, 2011

In the context of drbd-8.4 it no longer makes sense to
dissalow that.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

34f646bd

drbd: New minors have to intherit the connection state form their connection · 2325eb66
Philipp Reisner authored Mar 15, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
2325eb66

drbd: process_done_ee() has to handle unconfigured devices now · 082a3439

Philipp Reisner authored Mar 15, 2011

Took the chance and converted tconn_process_done_ee() to use
idr_for_each_entry()
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

082a3439

drbd: Ignore packets for non existing volumes · 2de876ef

Philipp Reisner authored Mar 15, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

2de876ef

drbd: introduce in-kernel "down" command · 85f75dd7

Lars Ellenberg authored Mar 15, 2011

This greatly simplifies deconfiguration of whole resources.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

85f75dd7

drbd: add forgotten spin_unlock · 3c5e5f6a

Lars Ellenberg authored Mar 15, 2011

somehow a "goto abort" was introduced with commit
  drbd: Extracted is_valid_transition() out of sanitize_state()
which left drbd_req_state still holding the spin lock.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

3c5e5f6a

drbd: bail out if a config requrest is over-determined, and not matching · 527f4b24

Lars Ellenberg authored Mar 14, 2011

We have resources resp. connections, volumes, and minor numbers.
A config request may specifies all three of them.
If it turns out that the minor belongs to a different connection, or a
different volume number in the same connection, that configuration
request is invalid.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

527f4b24