- 26 May, 2021 25 commits
-
-
Namjae Jeon authored
don't use multiple blank lines. Signed-off-by:
Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by:
Steve French <stfrench@microsoft.com>
-
Namjae Jeon authored
Fix "CHECK: paces preferred around that '/' from checkpatch.pl --strict. Signed-off-by:
-
Namjae Jeon authored
Fix "CHECK: braces {} should be used on all arms of this statement" from checkpatch.pl --strict. Signed-off-by: -
Namjae Jeon authored
Add the check to prevent potential overflow with smb_strtoUTF16() and UNICODE_LEN(). Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Namjae Jeon authored
Alignment match open parenthesis. Reviewed-by:
-
Namjae Jeon authored
Return -ENOMEM about error from ksmbd_crypto_ctx_find_xxx calls. And remove unneeded return value print in debug message. Reviewed-by:
-
Namjae Jeon authored
Simplify error handling in ksmbd_gen_preauth_integrity_hash(). Reviewed-by:
-
Namjae Jeon authored
Call kzalloc() directly instead of wrapper function. Reviewed-by:
-
Namjae Jeon authored
Add default case in switch statment in alloc_shash_desc(). Reviewed-by:
-
Namjae Jeon authored
Change success handling to failure handling in ksmbd_crypt_message(). Reviewed-by:
-
Namjae Jeon authored
Change error return instead of returning always success return. Reviewed-by:
-
Namjae Jeon authored
Remove unneeded initialization of rc variable in ksmbd_crypt_message(). Reviewed-by:
-
Namjae Jeon authored
Dan pointed out len can not be negative. This patch remove unneeded negative check in loop. Reviewed-by:
-
Namjae Jeon authored
Dan Carpenter pointed out that memory can be corrupted when nvec is zero. This patch add the check to prevent it. Reviewed-by:
-
Namjae Jeon authored
Never return 1 on failure. Reviewed-by:
-
Namjae Jeon authored
Return zero in always success case. Reviewed-by:
-
Namjae Jeon authored
Set error return value for memcmp() difference. Reviewed-by:
-
Namjae Jeon authored
Remove unneeded type casting. Reviewed-by:
-
Namjae Jeon authored
simplify error handling in ksmbd_auth_ntlm(). Reviewed-by:
-
Namjae Jeon authored
Move ret check before the out label. Reviewed-by:
-
Namjae Jeon authored
Just return smbhash() instead of using rc return value. Reviewed-by:
-
Namjae Jeon authored
Move fips_enabled check before the str_to_key(). Reviewed-by:
-
Namjae Jeon authored
Add goto fail in neg_token_init_mech_type(). Reviewed-by:
-
Namjae Jeon authored
Use memcmp instead of for loop check in oid_eq(). Reviewed-by:
-
Namjae Jeon authored
Add goto fail in asn1_oid_decode() to clean-up exception handling code. Reviewed-by:
-
- 21 May, 2021 1 commit
-
-
Wei Yongjun authored
Fix build error when CONFIG_OID_REGISTRY is not set: mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech': asn1.c:(.text+0xaa0): undefined reference to `sprint_oid' mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type': asn1.c:(.text+0xbec): undefined reference to `sprint_oid' Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by:
-
- 18 May, 2021 2 commits
-
-
Namjae Jeon authored
Add support for FSCTL_DUPLICATE_EXTENTS_TO_FILE in smb2 ioctl. Reviewed-by:
Hyunchul Lee <hyc.lee@gmail.com> Signed-off-by:
-
Marios Makassikis authored
Returning TreeID=0 is valid behaviour according to [MS-SMB2] 2.2.1.2: TreeId (4 bytes): Uniquely identifies the tree connect for the command. This MUST be 0 for the SMB2 TREE_CONNECT Request. The TreeId can be any unsigned 32-bit integer that is received from a previous SMB2 TREE_CONNECT Response. TreeId SHOULD be set to 0 for the following commands: [...] However, some client implementations reject it as invalid. Windows10 assigns ids starting from 1, and samba4 returns a random uint32_t which suggests there may be other clients that consider it is invalid behaviour. Signed-off-by:
Marios Makassikis <mmakassikis@freebox.fr> Signed-off-by:
-
- 14 May, 2021 1 commit
-
-
Namjae Jeon authored
If lock length in smb2 lock request from client is over flock max length size, lock length is changed to flock max length and don't return error response. Signed-off-by:
-
- 12 May, 2021 1 commit
-
-
kernel test robot authored
fs/cifsd/smb2pdu.c:8098:8-9: WARNING: return of 0/1 in function 'smb2_is_sign_req' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
- 11 May, 2021 10 commits
-
-
Namjae Jeon authored
build break from asn1 happened on some environment. CHECK /home/smfrench/smb3-kernel/fs/cifsd/smb2misc.c CC [M] /home/smfrench/smb3-kernel/fs/cifsd/asn1.o /home/smfrench/smb3-kernel/fs/cifsd/asn1.c:21:10: fatal error: spnego_negtokeninit.asn1.h: No such file or directory 21 | #include "spnego_negtokeninit.asn1.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.build:271: /home/smfrench/smb3-kernel/fs/cifsd/asn1.o] Error 1 make: *** [Makefile:1857: /home/smfrench/smb3-kernel/fs/cifsd] Error 2 make: Leaving directory '/usr/src/linux-headers-5.12.0-051200rc8-generic' This patch fix that asn1 compiler build *.asn1 file before compiling asn.c Signed-off-by: -
Namjae Jeon authored
WARNING: Too many leading tabs - consider code refactoring 3066: FILE: fs/cifsd/smb2pdu.c:2733: + if (fattr.cf_dacls) Fix a warning from checkpatch.pl. Signed-off-by:
-
Namjae Jeon authored
WARNING: Possible unnecessary 'out of memory' message 902: FILE: fs/cifsd/smb2pdu.c:569: + if (!work->response_buf) { + ksmbd_err("Failed to allocate %zu bytes buffer\n", sz); Fix a warning from checkpatch.pl. Signed-off-by: -
Hyunchul Lee authored
Decode gss token of SMB2_SESSSION_SETUP using lib/asn1_decoder.c Signed-off-by:
-
Namjae Jeon authored
Add missing fp initialzation to prevent invalid memory access in smb2_write(). Reported-by:
Coverity Scan <scan-admin@coverity.com> Signed-off-by:
-
Namjae Jeon authored
Now that 256 bit encryption can be negotiated, update names of the nonces to match the updated official protocol documentation (e.g. AES_GCM_NONCE instead of AES_128GCM_NONCE) since they apply to both 128 bit and 256 bit encryption. update smb encryption code to set 32 byte key length and to set gcm256/ccm256 when requested on mount. Signed-off-by:
-
Marios Makassikis authored
The user field in the session structure is allocated when the client is authenticated. If the client explicitly logs off, the user field is freed, but the session is kept around in case the user reconnects. If the TCP connection hasn't been closed and the client sends a session setup with a PreviousSessionId set, destroy_previous_session() will be called to check if the session needs to be cleaned up. Signed-off-by:
-
Marios Makassikis authored
When processing a SMB2 QUERY_DIRECTORY request, smb2_populate_readdir_entry() is called first to fill the dot/dotdot entries. This moves the d_info->wptr pointer but out_buf_len remains unchanged. As a result, reserve_populate_dentry() may end up writing past the end of the buffer since the bounds checking is done on invalid values. Signed-off-by:
-
Marios Makassikis authored
Currently, a SMB2 client does not receive an error message if ksmbd_session_rpc_open() fails when opening a pipe. Fix this by responding with STATUS_NO_MEMORY or STATUS_INVALID_PARAMETER depending on the error that occurred. Signed-off-by:
-
Marios Makassikis authored
Call smb2_set_err_rsp() in smb2_read/smb2_write error path. Signed-off-by:
-
