1. 22 Nov, 2016 2 commits
  2. 21 Nov, 2016 1 commit
    • Borislav Petkov's avatar
      x86/MCE/AMD: Fix thinko about thresholding_en · 254fe9c7
      Borislav Petkov authored
      So adding thresholding_en et al was a good thing for removing the
      per-CPU thresholding callback, i.e., threshold_cpu_callback.
      
      But, in order for it to work and especially that test in
      mce_threshold_create_device() so that all thresholding banks get
      properly created and not the whole thing to fail with a NULL ptr
      dereference at mce_cpu_pre_down() when we offline the CPUs, we need to
      set the thresholding_en flag *before* we start creating the devices.
      
      Yap, it failed because thresholding_en wasn't set at the time
      we were creating the banks so we didn't create any and then at
      mce_cpu_pre_down() -> mce_threshold_remove_device() time, we would blow
      up.
      
      And the fix is actually easy: we have thresholding on the system when we
      have managed to set the thresholding vector to amd_threshold_interrupt()
      earlier in mce_amd_feature_init() while we were picking apart the
      thresholding banks and what is set and what not.
      
      So let's do that.
      Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>
      Fixes: 4d7b02d5 ("x86/mcheck: Split threshold_cpu_callback into two callbacks")
      Link: http://lkml.kernel.org/r/20161119103402.5227-1-bp@alien8.deSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
      254fe9c7
  3. 17 Nov, 2016 1 commit
  4. 16 Nov, 2016 7 commits
  5. 09 Nov, 2016 17 commits
  6. 05 Nov, 2016 12 commits