Skip to content

L
linux
An error occurred fetching the project authors.
Switch branch/tag
  1. 14 Dec, 2009 1 commit
  3. 28 Sep, 2009 1 commit
    • J. Bruce Fields's avatar
      nfsd4: fix error return when pseudoroot missing · f39bde24
      J. Bruce Fields authored 
      We really shouldn't hit this case at all, and forthcoming kernel and
nfs-utils changes should eliminate this case; if it does happen,
consider it a bug rather than reporting an error that doesn't really
make sense for the operation (since there's no reason for a server to be
accepting v4 traffic yet have no root filehandle).

Also move some exp_pseudoroot code into a helper function while we're
here.
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      f39bde24
  5. 23 Sep, 2009 1 commit
  7. 03 Sep, 2009 1 commit
  9. 09 Aug, 2009 1 commit
  11. 12 Jun, 2009 4 commits
  13. 23 Apr, 2009 1 commit
  15. 23 Oct, 2008 2 commits
  17. 22 Oct, 2008 2 commits
  19. 30 Jul, 2008 1 commit
    • Julia Lawall's avatar
      fs/nfsd/export.c: Adjust error handling code involving auth_domain_put · 53e6d8d1
      Julia Lawall authored 
      Once clp is assigned, it never becomes NULL, so we can make a label for it
in the error handling code.  Because the call to path_lookup follows the
call to auth_domain_find, its error handling code should jump to this new
label.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r@
expression x,E;
statement S;
position p1,p2,p3;
@@

(
if ((x = auth_domain_find@p1(...)) == NULL || ...) S
|
x = auth_domain_find@p1(...)
... when != x
if (x == NULL || ...) S
)
<...
if@p3 (...) { ... when != auth_domain_put(x)
                  when != if (x) { ... auth_domain_put(x); ...}
    return@p2 ...;
}
...>
(
return x;
|
return 0;
|
x = E
|
E = x
|
auth_domain_put(x)
)

@exists@
position r.p1,r.p2,r.p3;
expression x;
int ret != 0;
statement S;
@@

* x = auth_domain_find@p1(...)
  <...
* if@p3 (...)
  S
  ...>
* return@p2 \(NULL\|ret\);
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      53e6d8d1
  21. 23 Apr, 2008 1 commit
  23. 15 Feb, 2008 6 commits
  25. 07 Feb, 2008 1 commit
  27. 01 Feb, 2008 3 commits
    • J. Bruce Fields's avatar
      knfsd: don't bother mapping putrootfh enoent to eperm · f7b8066f
      J. Bruce Fields authored 
      Neither EPERM and ENOENT map to valid errors for PUTROOTFH according to
rfc 3530, and, if anything, ENOENT is likely to be slightly more
informative; so don't bother mapping ENOENT to EPERM.  (Probably this
was originally done because one likely cause was that there is an fsid=0
export but that it isn't permitted to this particular client.  Now that
we allow WRONGSEC returns, this is somewhat less likely.)

In the long term we should work to make this situation less likely,
perhaps by turning off nfsv4 service entirely in the absence of the
pseudofs root, or constructing a pseudofilesystem root ourselves in the
kernel as necessary.

Thanks to Benny Halevy <bhalevy@panasas.com> for pointing out this
problem.
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
Cc: Benny Halevy <bhalevy@panasas.com>
      f7b8066f
    • J. Bruce Fields's avatar
      knfsd: allow cache_register to return error on failure · dbf847ec
      J. Bruce Fields authored 
      Newer server features such as nfsv4 and gss depend on proc to work, so a
failure to initialize the proc files they need should be treated as
fatal.

Thanks to Andrew Morton for style fix and compile fix in case where
CONFIG_NFSD_V4 is undefined.

Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      dbf847ec
    • J. Bruce Fields's avatar
      knfsd: cache unregistration needn't return error · df95a9d4
      J. Bruce Fields authored 
      There's really nothing much the caller can do if cache unregistration
fails.  And indeed, all any caller does in this case is print an error
and continue.  So just return void and move the printk's inside
cache_unregister.
Acked-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      df95a9d4
  29. 22 Oct, 2007 1 commit
    • Christoph Hellwig's avatar
      exportfs: remove old methods · cfaea787
      Christoph Hellwig authored 
      Now that all filesystems are converted remove support for the old methods.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: Neil Brown <neilb@suse.de>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: <linux-ext4@vger.kernel.org>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: Anton Altaparmakov <aia21@cantab.net>
Cc: David Chinner <dgc@sgi.com>
Cc: Timothy Shimmin <tes@sgi.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Hugh Dickins <hugh@veritas.com>
Cc: Chris Mason <mason@suse.com>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: "Vladimir V. Saveliev" <vs@namesys.com>
Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: Mark Fasheh <mark.fasheh@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      cfaea787
  31. 16 Oct, 2007 1 commit
  33. 31 Jul, 2007 1 commit
  35. 22 Jul, 2007 1 commit
  37. 19 Jul, 2007 1 commit
  39. 17 Jul, 2007 9 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7