- 04 Jul, 2014 3 commits
-
-
Hans Verkuil authored
When the audio encoding is changed the driver calls hdpvr_set_audio with the current opt->audio_input value. However, that should have been opt->audio_input + 1. So changing the audio encoding inadvertently changes the input as well. This bug has always been there. The second bug was introduced in kernel 3.10 and that broke the default_audio_input module option handling: the audio encoding was never switched to AC3 if default_audio_input was set to 2 (SPDIF input). In addition, since starting with 3.10 the audio encoding is always set at the start the first bug now always happens when the driver is loaded. In the past this bug would only surface if the user would change the audio encoding after the driver was loaded. Also fixes a small trivial typo (bufffer -> buffer). Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Reported-by:
Scott Doty <scott@corp.sonic.net> Cc: stable@vger.kernel.org # for v3.10 and up Signed-off-by:
Mauro Carvalho Chehab <m.chehab@samsung.com>
-
Dan Carpenter authored
We recently changed some locking around so we need some new unlocks on the error paths. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Antti Palosaari authored
Tuner ID set into EEPROM is wrong in some cases, which causes driver to select wrong tuner profile. That leads device non-working. Fix issue by overriding known bad tuner IDs with suitable default value. Thanks to MX-NET Telekomunikace s.r.o. for providing non-working DTV stick, that I could fix the bug! Cc: stable@vger.kernel.org # v3.15+ Signed-off-by:
Antti Palosaari <crope@iki.fi> Signed-off-by:
-
- 19 Jun, 2014 6 commits
-
-
Hans Verkuil authored
The saa7134 driver uses core-locking, so there is no longer any need to use the ioctl op instead of the unlocked_ioctl op. This change was forgotten for the saa7134-empress.c, so fix this. Signed-off-by:
-
Rickard Strandqvist authored
Wrong value used in same cases for the aspect ratio. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Acked-by:
Lad, Prabhakar <prabhakar.csengg@gmail.com> Cc: stable@vger.kernel.org # for v3.12 and up Signed-off-by:
-
Antti Palosaari authored
First 8 bytes belonging to firmware image were hard-coded and uploaded by the driver mistakenly. Introduce new corrected firmware file and remove those 8 bytes from the driver. New firmware image could be extracted from the PCTV 292e driver CD using following command: $ dd if=/TVC 6.4.8/Driver/PCTV Empia/emOEM.sys ibs=1 skip=1089408 count=2728 of=dvb-demod-si2168-02.fw $ md5sum dvb-demod-si2168-02.fw d8da7ff67cd56cd8aa4e101aea45e052 dvb-demod-si2168-02.fw $ sudo cp dvb-demod-si2168-02.fw /lib/firmware/ Signed-off-by:
-
Antti Palosaari authored
Fix following warnings: si2157_cmd_execute() warn: add some parenthesis here? si2157_cmd_execute() warn: maybe use && instead of & Reported-by:
-
Antti Palosaari authored
Fix following warnings: si2168_cmd_execute() warn: add some parenthesis here? si2168_cmd_execute() warn: maybe use && instead of & Reported-by:
-
Arnd Bergmann authored
The OMAP4 camera support depends on I2C and VIDEO_V4L2, both of which can be loadable modules. This causes build failures if we want the camera driver to be built-in. This can be solved by turning the option into "tristate", which unfortunately causes another problem, because the driver incorrectly calls a platform-internal interface for omap4_ctrl_pad_readl/omap4_ctrl_pad_writel. Instead, this patch just forbids the invalid configurations and ensures that the driver can only be built if all its dependencies are built-in. Cc: stable@vger.kernel.org Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
- 04 Jun, 2014 1 commit
-
-
Mauro Carvalho Chehab authored
A previous patch mistakenly changed the file permission to 755. Restore it to 644. Signed-off-by:
-
- 25 May, 2014 30 commits
-
-
Mauro Carvalho Chehab authored
Some drivers, like au0828 are very sensitive to tuner sleep and may break if the sleep happens too fast. Also, by keeping the tuner alive for a while could speedup tuning process during channel scan. So, change the logic to delay the actual sleep to 5 seconds after its command. Signed-off-by: -
Mauro Carvalho Chehab authored
WARNING: please, no space before tabs +#define XC_PRODUCT_ID_FW_LOADED ^I0x1388$ WARNING: please, no space before tabs +#define DK_SECAM_A2LDK3 ^I13$ WARNING: please, no space before tabs +#define DK_SECAM_A2MONO ^I14$ WARNING: please, no space before tabs +#define FM_RADIO_INPUT2 ^I21$ WARNING: please, no space before tabs +#define FM_RADIO_INPUT1 ^I22$ Signed-off-by: -
Mauro Carvalho Chehab authored
There are several CamelCase non-codingstyle compliances here. Fix them. Signed-off-by: -
Mauro Carvalho Chehab authored
There's absolutely no reason to wrap msleep() call here. Just rename all occurences of xc_wait() with msleep() and remove the wrapper function. Signed-off-by: -
Mauro Carvalho Chehab authored
Errors should also be negative and should follow the Kernel standards. Signed-off-by: -
Mauro Carvalho Chehab authored
As reported by Trevor, doing several opening/streaming/closing operations to the demux causes it to fail. I was able to simulate this bug too. I also noticed that, sometimes, changing channels with au0828, the same thing happens. Most of the issues seem to be due to some hardware bug, that causes the device to not fill all the URBs allocated. When the bug happens, the only known fix is to either replug the device, or to send an USB reset to it. There's also a hack a the au0828 driver that starts a thread that tries to reset the device when a package doesn't start with a sync. One of the culpits for this bad hardware behavior seem to be caused by the lack of stopping and restarting the stream every time a new channel is set. This patch warrants that the stream will be properly reset every time the set_frontend callback is called, partially solving the problem. A complete fix, however, would also need to check the PM conditions for the tuner and demux. Reported-by:
Trevor Graffa <tlgraffa@gmail.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
Sometimes, it helps to know how much data was received by urb_completion. Add that information to the optional debug log. Signed-off-by: -
Changbing Xiong authored
If the tuner is already disconnected, It is meaningless to go on doing the stream-restart operation, It is better to cancel this operation. Signed-off-by:
Changbing Xiong <cb.xiong@samsung.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
The RC support o Nova-TD is broken, as the RC endpoint there is an interrupt endpoint. That produces an ugly calltrace at the Kernel logs: WARNING: CPU: 2 PID: 56 at drivers/usb/core/urb.c:450 usb_submit_urb+0x1fd/0x5c0() usb 1-1.2: BOGUS urb xfer, pipe 3 != type 1 Modules linked in: rc_dib0700_rc5(OF) dvb_usb_dib0700(OF) dib9000(OF) dib8000(OF) dib7000m(OF) dib0090(OF) dib0070(OF) dib7000p(OF) dib3000mc(OF) dibx000_common(OF) dvb_usb(OF) rc_core(OF) snd_usb_audio snd_usbmidi_lib snd_hwdep snd_rawmidi snd_seq snd_seq_device snd_pcm snd_timer snd soundcore bnep bluetooth 6lowpan_iphc rfkill au0828(OF) xc5000(OF) au8522_dig(OF) au8522_common(OF) tveeprom(OF) dvb_core(OF) nouveau i915 mxm_wmi ttm i2c_algo_bit drm_kms_helper drm r8169 mii i2c_core video wmi [last unloaded: au0828] CPU: 2 PID: 56 Comm: khubd Tainted: GF O 3.14.2-200.fc20.x86_64 #1 Hardware name: SAMSUNG ELECTRONICS CO., LTD. 550P5C/550P7C/SAMSUNG_NP1234567890, BIOS P05ABI.016.130917.dg 09/17/2013 0000000000000000 00000000610866bc ffff880223703860 ffffffff816eec92 ffff8802237038a8 ffff880223703898 ffffffff8108a1bd ffff8800916a2180 ffff8801d5b16000 0000000000000003 0000000000000003 0000000000000020 Call Trace: [<ffffffff816eec92>] dump_stack+0x45/0x56 [<ffffffff8108a1bd>] warn_slowpath_common+0x7d/0xa0 [<ffffffff8108a23c>] warn_slowpath_fmt+0x5c/0x80 [<ffffffff814e3ebd>] usb_submit_urb+0x1fd/0x5c0 [<ffffffffa0445925>] dib0700_rc_setup+0xb5/0x120 [dvb_usb_dib0700] [<ffffffffa0445a58>] dib0700_probe+0xc8/0x130 [dvb_usb_dib0700] ... Fix it by detecting if the endpoint is bulk or interrupt. Tested with both Hauppauge Nova-TD model 52009 (interrupt) and with a Prolink Pixelview SBTVD model PV-D231U (bulk). Signed-off-by: -
Peter Senna Tschudin authored
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by:
Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by:
-
Kamil Debski authored
The 'Code' column in the documentation should provide the real fourcc code that is used. Changed the documentation to provide the fourcc defined in videodev2.h Signed-off-by:
Kamil Debski <k.debski@samsung.com> Acked-by:
Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by:
-
Laurent Pinchart authored
The include/media/s5p_fimc.h header has been removed in commit 49b2f4c5 ("exynos4-is: Remove support for non-dt platforms"). This broke compilation of the m5mols driver. Include the include/media/exynos-fimc.h header instead, which contains the S5P_FIMC_TX_END_NOTIFY definition required by the driver. Signed-off-by:
-
Tuomas Tynkkynen authored
Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. While at it, also use u32 in place of __u32. Signed-off-by:
Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> Reviewed-by:
-
Matt DeVillier authored
Change the I/O endpoint handling of the mceusb driver to respect the endpoint type reported by device (bulk/interrupt), rather than treating all endpoints as type interrupt, which breaks devices using bulk endpoints when connected to a xhci controller. Accordingly, change the function calls to initialize an endpoint's transfer pipe and urb handlers to use the correct function based on the endpoint type. [m.chehab@samsung.com: Fix merge conflicts and compilation breakage] Signed-off-by:
Matt DeVillier <matt.devillier@gmail.com> Tested-by:
Sean Young <sean@mess.org> Signed-off-by:
-
Manuel Schönlaub authored
There is another clone of AZ6027. This patch adds the relevant PID. Signed-off-by:
Manuel Schönlaub <manuel.schoenlaub@gmail.com> Signed-off-by:
-
Hans Verkuil authored
The reference to v4l2-event-source-change should have been v4l2-event-src-change. This caused a failure when building the spec. Fixed. Signed-off-by:
-
Lars-Peter Clausen authored
The file is using u8 which is defined in linux/types.h. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Signed-off-by:
-
Laurent Pinchart authored
The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both fields in the core code instead of duplicating validation in all drivers. Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by:
-
Laurent Pinchart authored
Validate the pad field in the core code whenever specified. Signed-off-by:
-
Laurent Pinchart authored
Wrapping the #define's at a 80 columns boundary just obfuscates the code. Don't do that. Signed-off-by:
-
Laurent Pinchart authored
The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by:
-
Laurent Pinchart authored
The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by:
-
Laurent Pinchart authored
The video enum_dv_timings operation is deprecated and unused. Remove it. Signed-off-by:
-
Laurent Pinchart authored
The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by:
-
Laurent Pinchart authored
The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by:
-
Laurent Pinchart authored
The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by:
-
Laurent Pinchart authored
The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by:
-
Laurent Pinchart authored
The video-level enum_dv_timings and dv_timings_cap operations are deprecated in favor of the pad-level versions. All subdev drivers implement the pad-level versions, switch to them. Signed-off-by:
-
Laurent Pinchart authored
The video-level enum_dv_timings and dv_timings_cap operations are deprecated in favor of the pad-level versions. All subdev drivers implement the pad-level versions, switch to them. Signed-off-by:
-
Laurent Pinchart authored
The video-level enum_dv_timings and dv_timings_cap operations are deprecated in favor of the pad-level versions. All subdev drivers implement the pad-level versions, switch to them. Signed-off-by:
-
