Commits · 37af81c5998f4b0f23fb452cffa4b8a1c00ce95b · Kirill Smelkov / linux

10 Jun, 2021 8 commits

ALSA: core: Abstract memory alloc helpers · 37af81c5

Takashi Iwai authored Jun 09, 2021

This patch introduces the ops table to each memory allocation type
(SNDRV_DMA_TYPE_XXX) and abstract the handling for the better code
management.  Then we get separate the page allocation, release and
other tasks for each type, especially for the SG buffer.

Each buffer type has now callbacks in the struct snd_malloc_ops, and
the common helper functions call those ops accordingly.  The former
inline code that is specific to SG-buffer is moved into the local
sgbuf.c, and we can simplify the PCM code without details of memory
handling.

Link: https://lore.kernel.org/r/20210609162551.7842-4-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

37af81c5

ALSA: core: Drop snd_sgbuf_get_ptr() · 84a03740

Takashi Iwai authored Jun 09, 2021

snd_sgbuf_get_ptr() and its sibling snd_pcm_sgbuf_get_ptr() are no
longer used by any drivers. Let's drop them.

Link: https://lore.kernel.org/r/20210609162551.7842-3-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

84a03740

ALSA: trident: Drop shadow TLB pointer table · 74fb9831

Takashi Iwai authored Jun 09, 2021

The shadow TLB pointer table is allocated and set up, but never really
used any longer by the driver. Let's drop it.

Since this is the only user of snd_pcm_sgbuf_get_ptr(), we can clean
up the API after this change.

Link: https://lore.kernel.org/r/20210609162551.7842-2-tiwai@suse.deSigned-off-by: Takashi Iwai <tiwai@suse.de>

74fb9831

ALSA: doc: Fix spelling mistakes · 25c794cd

huangjianghui authored Jun 10, 2021

correct Reatek to Realtek
Signed-off-by: huangjianghui <huangjianghui@uniontech.com>
Link: https://lore.kernel.org/r/20210610062036.30300-1-huangjianghui@uniontech.comSigned-off-by: Takashi Iwai <tiwai@suse.de>

25c794cd

ALSA: arm: Remove unnecessary variables · f4a85e00

zuoqilin authored Jun 10, 2021

There is no need to define the variable "ret" to receive.
Signed-off-by: zuoqilin <zuoqilin@yulong.com>
Link: https://lore.kernel.org/r/20210610024053.1217-1-zuoqilin1@163.comSigned-off-by: Takashi Iwai <tiwai@suse.de>

f4a85e00

ALSA: firewire-lib: obsolete workqueue for period update · b5b51996

Takashi Sakamoto authored Jun 10, 2021

The workqueue to notify PCM period elapse is not used anymore.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210610031733.56297-4-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

b5b51996

ALSA: firewire-lib: operate for period elapse event in process context · 7ba5ca32

Takashi Sakamoto authored Jun 10, 2021

All of drivers in ALSA firewire stack processes two chances to process
isochronous packets in any isochronous context; in software IRQ context
for 1394 OHCI, and in process context of ALSA PCM application.

In the process context, callbacks of .pointer and .ack are utilized. The
callbacks are done by ALSA PCM core under acquiring lock of PCM substream,

In design of ALSA PCM core, call of snd_pcm_period_elapsed() is used for
drivers to awaken user processes from waiting for available frames. The
function voluntarily acquires lock of PCM substream, therefore it is not
called in the process context since it causes dead lock.

As a workaround to avoid the dead lock, all of drivers in ALSA firewire
stack uses workqueue to delegate the call. A variant of
snd_pcm_period_elapsed() without lock acquisition can obsolete the
workqueue.

An extra care is needed for the callback of .pointer since it's called
from snd_pcm_period_elapsed(). The isochronous context in Linux FireWire
subsystem is safe mostly for nested call except in software IRQ context.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210610031733.56297-3-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

7ba5ca32

ALSA: pcm: add snd_pcm_period_elapsed() variant without acquiring lock of PCM substream · 47271b1b

Takashi Sakamoto authored Jun 10, 2021

Current implementation of ALSA PCM core has a kernel API,
snd_pcm_period_elapsed(), for drivers to queue event to awaken processes
from waiting for available frames. The function voluntarily acquires lock
of PCM substream, therefore it is not called in process context for any
PCM operation since the lock is already acquired.

It is convenient for packet-oriented driver, at least for drivers to audio
and music unit in IEEE 1394 bus. The drivers are allowed by Linux
FireWire subsystem to process isochronous packets queued till recent
isochronous cycle in process context in any time.

This commit adds snd_pcm_period_elapsed() variant,
snd_pcm_period_elapsed_without_lock(), for drivers to queue the event in
the process context.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210610031733.56297-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Iwai <tiwai@suse.de>

47271b1b

09 Jun, 2021 32 commits

ALSA: parisc: Fix assignment in if condition · 6ea9a2b8

Takashi Iwai authored Jun 08, 2021

PARISC harmony driver code contains an assignment in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.