1. 25 Apr, 2013 1 commit
  2. 23 Apr, 2013 4 commits
    • Kevin Baradon's avatar
      [media] media/rc/imon.c: kill urb when send_packet() is interrupted · 5f3f254f
      Kevin Baradon authored
      This avoids:
      Apr 12 23:52:16 homeserver kernel: imon:send_packet: task interrupted
      Apr 12 23:52:16 homeserver kernel: ------------[ cut here ]------------
      Apr 12 23:52:16 homeserver kernel: WARNING: at drivers/usb/core/urb.c:327 usb_submit_urb+0x353/0x370()
      Apr 12 23:52:16 homeserver kernel: Hardware name: Unknow
      Apr 12 23:52:16 homeserver kernel: URB f64b6f00 submitted while active
      Apr 12 23:52:16 homeserver kernel: Modules linked in:
      Apr 12 23:52:16 homeserver kernel: Pid: 3154, comm: LCDd Not tainted 3.8.6-htpc-00005-g9e6fc5e #26
      Apr 12 23:52:16 homeserver kernel: Call Trace:
      Apr 12 23:52:16 homeserver kernel: [<c012d778>] ? warn_slowpath_common+0x78/0xb0
      Apr 12 23:52:16 homeserver kernel: [<c04136c3>] ? usb_submit_urb+0x353/0x370
      Apr 12 23:52:16 homeserver kernel: [<c04136c3>] ? usb_submit_urb+0x353/0x370
      Apr 12 23:52:16 homeserver kernel: [<c0447010>] ? imon_ir_change_protocol+0x150/0x150
      Apr 12 23:52:16 homeserver kernel: [<c012d843>] ? warn_slowpath_fmt+0x33/0x40
      Apr 12 23:52:16 homeserver kernel: [<c04136c3>] ? usb_submit_urb+0x353/0x370
      Apr 12 23:52:16 homeserver kernel: [<c0446c67>] ? send_packet+0x97/0x270
      Apr 12 23:52:16 homeserver kernel: [<c0446cfe>] ? send_packet+0x12e/0x270
      Apr 12 23:52:16 homeserver kernel: [<c05c5743>] ? do_nanosleep+0xa3/0xd0
      Apr 12 23:52:16 homeserver kernel: [<c044760e>] ? vfd_write+0xae/0x250
      Apr 12 23:52:16 homeserver kernel: [<c0447560>] ? lcd_write+0x180/0x180
      Apr 12 23:52:16 homeserver kernel: [<c01b2b19>] ? vfs_write+0x89/0x140
      Apr 12 23:52:16 homeserver kernel: [<c01b2dda>] ? sys_write+0x4a/0x90
      Apr 12 23:52:16 homeserver kernel: [<c05c7c45>] ? sysenter_do_call+0x12/0x26
      Apr 12 23:52:16 homeserver kernel: ---[ end trace a0b6f0fcfd2f9a1d ]---
      Apr 12 23:52:16 homeserver kernel: imon:send_packet: error submitting urb(-16)
      Apr 12 23:52:16 homeserver kernel: imon:vfd_write: send packet #3 failed
      Apr 12 23:52:16 homeserver kernel: imon:send_packet: error submitting urb(-16)
      Apr 12 23:52:16 homeserver kernel: imon:vfd_write: send packet #0 failed
      Signed-off-by: default avatarKevin Baradon <kevin.baradon@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      5f3f254f
    • Kevin Baradon's avatar
      [media] media/rc/imon.c: do not try to register 2nd intf if 1st intf failed · 7d54ba0e
      Kevin Baradon authored
      This bug could be triggered if 1st interface configuration fails:
      Apr  8 18:20:30 homeserver kernel: usb 5-1: new low-speed USB device number 2 using ohci_hcd
      Apr  8 18:20:30 homeserver kernel: input: iMON Panel, Knob and Mouse(15c2:0036) as /devices/pci0000:00/0000:00:13.0/usb5/5-1/5-1:1.0/input/input2
      Apr  8 18:20:30 homeserver kernel: Registered IR keymap rc-imon-pad
      Apr  8 18:20:30 homeserver kernel: input: iMON Remote (15c2:0036) as /devices/pci0000:00/0000:00:13.0/usb5/5-1/5-1:1.0/rc/rc0/input3
      Apr  8 18:20:30 homeserver kernel: rc0: iMON Remote (15c2:0036) as /devices/pci0000:00/0000:00:13.0/usb5/5-1/5-1:1.0/rc/rc0
      Apr  8 18:20:30 homeserver kernel: imon:send_packet: packet tx failed (-32)
      Apr  8 18:20:30 homeserver kernel: imon 5-1:1.0: remote input dev register failed
      Apr  8 18:20:30 homeserver kernel: imon 5-1:1.0: imon_init_intf0: rc device setup failed
      Apr  8 18:20:30 homeserver kernel: imon 5-1:1.0: unable to initialize intf0, err 0
      Apr  8 18:20:30 homeserver kernel: imon:imon_probe: failed to initialize context!
      Apr  8 18:20:30 homeserver kernel: imon 5-1:1.0: unable to register, err -19
      Apr  8 18:20:30 homeserver kernel: BUG: unable to handle kernel NULL pointer dereference at 00000014
      Apr  8 18:20:30 homeserver kernel: IP: [<c05c4e4c>] mutex_lock+0xc/0x30
      Apr  8 18:20:30 homeserver kernel: *pde = 00000000
      Apr  8 18:20:30 homeserver kernel: Oops: 0002 [#1] PREEMPT SMP
      Apr  8 18:20:30 homeserver kernel: Modules linked in:
      Apr  8 18:20:30 homeserver kernel: Pid: 367, comm: khubd Not tainted 3.8.3-htpc-00002-g79b1403 #23 Unknow Unknow/RS780-SB700
      Apr  8 18:20:30 homeserver kernel: EIP: 0060:[<c05c4e4c>] EFLAGS: 00010296 CPU: 1
      Apr  8 18:20:30 homeserver kernel: EIP is at mutex_lock+0xc/0x30
      Apr  8 18:20:30 homeserver kernel: EAX: 00000014 EBX: 00000014 ECX: 00000000 EDX: f590e480
      Apr  8 18:20:30 homeserver kernel: ESI: f5deac00 EDI: f590e480 EBP: f5f3ee00 ESP: f6577c28
      Apr  8 18:20:30 homeserver kernel: DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
      Apr  8 18:20:30 homeserver kernel: CR0: 8005003b CR2: 00000014 CR3: 0081b000 CR4: 000007d0
      Apr  8 18:20:30 homeserver kernel: DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
      Apr  8 18:20:30 homeserver kernel: DR6: ffff0ff0 DR7: 00000400
      Apr  8 18:20:30 homeserver kernel: Process khubd (pid: 367, ti=f6576000 task=f649ea00 task.ti=f6576000)
      Apr  8 18:20:30 homeserver kernel: Stack:
      Apr  8 18:20:30 homeserver kernel: 00000000 f5deac00 c0448de4 f59714c0 f5deac64 c03b8ad2 f6577c90 00000004
      Apr  8 18:20:30 homeserver kernel: f649ea00 c0205142 f6779820 a1ff7f08 f5deac00 00000001 f5f3ee1c 00000014
      Apr  8 18:20:30 homeserver kernel: 00000004 00000202 15c20036 c07a03e8 fffee0ca f6795c00 f5f3ee1c f5deac00
      Apr  8 18:20:30 homeserver kernel: Call Trace:
      Apr  8 18:20:30 homeserver kernel: [<c0448de4>] ? imon_probe+0x494/0xde0
      Apr  8 18:20:30 homeserver kernel: [<c03b8ad2>] ? rpm_resume+0xb2/0x4f0
      Apr  8 18:20:30 homeserver kernel: [<c0205142>] ? sysfs_addrm_finish+0x12/0x90
      Apr  8 18:20:30 homeserver kernel: [<c04170e9>] ? usb_probe_interface+0x169/0x240
      Apr  8 18:20:30 homeserver kernel: [<c03b0ca0>] ? __driver_attach+0x80/0x80
      Apr  8 18:20:30 homeserver kernel: [<c03b0ca0>] ? __driver_attach+0x80/0x80
      Apr  8 18:20:30 homeserver kernel: [<c03b0a94>] ? driver_probe_device+0x54/0x1e0
      Apr  8 18:20:30 homeserver kernel: [<c0416abe>] ? usb_device_match+0x4e/0x80
      Apr  8 18:20:30 homeserver kernel: [<c03af314>] ? bus_for_each_drv+0x34/0x70
      Apr  8 18:20:30 homeserver kernel: [<c03b0a0b>] ? device_attach+0x7b/0x90
      Apr  8 18:20:30 homeserver kernel: [<c03b0ca0>] ? __driver_attach+0x80/0x80
      Apr  8 18:20:30 homeserver kernel: [<c03b00ff>] ? bus_probe_device+0x5f/0x80
      Apr  8 18:20:30 homeserver kernel: [<c03aeab7>] ? device_add+0x567/0x610
      Apr  8 18:20:30 homeserver kernel: [<c041a7bc>] ? usb_create_ep_devs+0x7c/0xd0
      Apr  8 18:20:30 homeserver kernel: [<c0413837>] ? create_intf_ep_devs+0x47/0x70
      Apr  8 18:20:30 homeserver kernel: [<c04156c4>] ? usb_set_configuration+0x454/0x750
      Apr  8 18:20:30 homeserver kernel: [<c03b0ca0>] ? __driver_attach+0x80/0x80
      Apr  8 18:20:30 homeserver kernel: [<c041de8a>] ? generic_probe+0x2a/0x80
      Apr  8 18:20:30 homeserver kernel: [<c03b0ca0>] ? __driver_attach+0x80/0x80
      Apr  8 18:20:30 homeserver kernel: [<c0205aff>] ? sysfs_create_link+0xf/0x20
      Apr  8 18:20:30 homeserver kernel: [<c04171db>] ? usb_probe_device+0x1b/0x40
      Apr  8 18:20:30 homeserver kernel: [<c03b0a94>] ? driver_probe_device+0x54/0x1e0
      Apr  8 18:20:30 homeserver kernel: [<c03af314>] ? bus_for_each_drv+0x34/0x70
      Apr  8 18:20:30 homeserver kernel: [<c03b0a0b>] ? device_attach+0x7b/0x90
      Apr  8 18:20:30 homeserver kernel: [<c03b0ca0>] ? __driver_attach+0x80/0x80
      Apr  8 18:20:30 homeserver kernel: [<c03b00ff>] ? bus_probe_device+0x5f/0x80
      Apr  8 18:20:30 homeserver kernel: [<c03aeab7>] ? device_add+0x567/0x610
      Apr  8 18:20:30 homeserver kernel: [<c040e6df>] ? usb_new_device+0x12f/0x1e0
      Apr  8 18:20:30 homeserver kernel: [<c040f4d8>] ? hub_thread+0x458/0x1230
      Apr  8 18:20:30 homeserver kernel: [<c015554f>] ? dequeue_task_fair+0x9f/0xc0
      Apr  8 18:20:30 homeserver kernel: [<c0131312>] ? release_task+0x1d2/0x330
      Apr  8 18:20:30 homeserver kernel: [<c01477b0>] ? abort_exclusive_wait+0x90/0x90
      Apr  8 18:20:30 homeserver kernel: [<c040f080>] ? usb_remote_wakeup+0x40/0x40
      Apr  8 18:20:30 homeserver kernel: [<c0146ed2>] ? kthread+0x92/0xa0
      Apr  8 18:20:30 homeserver kernel: [<c05c7877>] ? ret_from_kernel_thread+0x1b/0x28
      Apr  8 18:20:30 homeserver kernel: [<c0146e40>] ? kthread_freezable_should_stop+0x50/0x50
      Apr  8 18:20:30 homeserver kernel: Code: 89 04 24 89 f0 e8 05 ff ff ff 8b 5c 24 24 8b 74 24 28 8b 7c 24 2c 8b 6c 24 30 83 c4 34 c3 00 83 ec 08 89 1c 24 89 74 24 04 89 c3 <f0> ff 08 79 05 e8 ca 03 00 00 64 a1 70 d6 80 c0 8b 74 24 04 89
      Apr  8 18:20:30 homeserver kernel: EIP: [<c05c4e4c>] mutex_lock+0xc/0x30 SS:ESP 0068:f6577c28
      Apr  8 18:20:30 homeserver kernel: CR2: 0000000000000014
      Apr  8 18:20:30 homeserver kernel: ---[ end trace df134132c967205c ]---
      Signed-off-by: default avatarKevin Baradon <kevin.baradon@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      7d54ba0e
    • Kevin Baradon's avatar
      [media] imon: Use large delays earlier · f7d141b3
      Kevin Baradon authored
      send_packet() is used during initialization, before send_packet_delay
      is set. So, move ictx->send_packet_delay to happen earlier.
      
      [mchehab@redhat.com: fold two patches into one to make git history clearer]
      Signed-off-by: default avatarKevin Baradon <kevin.baradon@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      f7d141b3
    • Dan Carpenter's avatar
      [media] media: info leak in media_device_enum_entities() · c06ca8f9
      Dan Carpenter authored
      The last part of the "u_ent.name" buffer isn't cleared so it still has
      uninitialized stack memory.
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      c06ca8f9
  3. 22 Apr, 2013 12 commits
  4. 17 Apr, 2013 3 commits
  5. 16 Apr, 2013 6 commits
    • Mauro Carvalho Chehab's avatar
      [media] sta2x11_vip: Fix compilation if I2C is not set · 098af4bd
      Mauro Carvalho Chehab authored
      From Fengguang Wu <fengguang.wu@intel.com>:
      
      > drivers/media/pci/sta2x11/sta2x11_vip.c: In function 'sta2x11_vip_init_one':
      > drivers/media/pci/sta2x11/sta2x11_vip.c:1314:2: error: implicit declaration of function 'i2c_get_adapter' [-Werror=implicit-function-declaration]
      > drivers/media/pci/sta2x11/sta2x11_vip.c:1314:15: warning: assignment makes pointer from integer without a cast [enabled by default]
      > drivers/media/pci/sta2x11/sta2x11_vip.c:1330:2: error: implicit declaration of function 'i2c_put_adapter' [-Werror=implicit-function-declaration]
      
      And also:
      
      > warning: (STA2X11_VIP) selects VIDEO_ADV7180 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_V4L2 && I2C)
      > drivers/media/i2c/adv7180.c: In function '__adv7180_status':
      > drivers/media/i2c/adv7180.c:194:2: error: implicit declaration of function 'i2c_smbus_read_byte_data' [-Werror=implicit-function-declaration]
      > drivers/media/i2c/adv7180.c: In function 'adv7180_s_routing':
      > drivers/media/i2c/adv7180.c:251:2: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration]
      > drivers/media/i2c/adv7180.c: In function 'adv7180_probe':
      > drivers/media/i2c/adv7180.c:551:2: error: implicit declaration of function 'i2c_check_functionality' [-Werror=implicit-function-declaration]
      > drivers/media/i2c/adv7180.c:554:2: error: implicit declaration of function 'i2c_adapter_id' [-Werror=implicit-function-declaration]
      > drivers/media/i2c/adv7180.c: At top level:
      > drivers/media/i2c/adv7180.c:663:1: warning: data definition has no type or storage class [enabled by default]
      > drivers/media/i2c/adv7180.c:663:1: warning: type defaults to 'int' in declaration of 'module_i2c_driver' [-Wimplicit-int]
      > drivers/media/i2c/adv7180.c:663:1: warning: parameter names (without types) in function declaration [enabled by default]
      > drivers/media/i2c/adv7180.c:649:26: warning: 'adv7180_driver' defined but not used [-Wunused-variable]
      
      This is due to the lack of I2C support:
      
      ...
      > CONFIG_I2C is not set
      ...
      
      So, Make sure that sta2x11_vip depends on I2C.
      Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      098af4bd
    • Mauro Carvalho Chehab's avatar
      [media] it913x: rename its tuner driver to tuner_it913x · 99ca5557
      Mauro Carvalho Chehab authored
      There are three drivers with *it913x name on it, and they all
      belong to the same device:
      	a tuner, at it913x.c;
      	a frontend: it913x-fe.c;
      	a bridge: it913x.c, renamed to dvb_usb_it913x by the
      building system.
      
      This is confusing. Even more confusing are the two .c files with
      the same name under different directories, with different contents
      and different functions. So, prepend the tuner one.
      
      This also breaks the out-of-tree compilation system.
      Reported-by: default avatarFrederic Fays <frederic.fays@gmail.com>
      Acked-by: default avatarAntti Palosaari <crope@iki.fi>
      Reviewed-by: default avatarAntti Palosaari <crope@iki.fi>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      99ca5557
    • William Steidtmann's avatar
      [media] mceusb: add some missing cmd sizes · 76dea4cf
      William Steidtmann authored
      Fix mceusb_cmdsize() which returns incorrect datasize=0 for
      sub-commands MCE_RSP_GETPORTSTATUS, MCE_RSP_GETWAKESOURCE,
      MCE_RSP_EQDEVDETAILS, MCE_RSP_EQEMVER, and MCE_RSP_EQIRNUMPORTS.
      
      While here, change mceusb_cmdsize() name to reflect that it returns
      data size not cmd size.
      Signed-off-by: default avatarWilliam Steidtmann <billstei@hbci.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      76dea4cf
    • David Howells's avatar
      [media] zoran: Don't print proc_dir_entry data in debug [RFC] · bebe3c69
      David Howells authored
      Don't print proc_dir_entry data in debug as we're soon to have no direct
      access to the contents of the PDE.  Print what was put in there instead.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      bebe3c69
    • Randy Dunlap's avatar
      [media] staging/media: fix go7007 dependencies and build · 16b196e5
      Randy Dunlap authored
      VIDEO_GO7007 uses usb interfaces so it should depend on USB.
      It also selects CYPRESS_FIRMWARE, which depends on USB.
      Fixes build errors and a kconfig warning:
      go7007-loader.c:(.text+0xcc7d0): undefined reference to `usb_get_dev'
      go7007-loader.c:(.init.text+0x49f0): undefined reference to `usb_register_driver'
      go7007-loader.c:(.exit.text+0x17ce): undefined reference to `usb_deregister'
      warning: (DVB_USB_AZ6007 && VIDEO_GO7007) selects CYPRESS_FIRMWARE which has unmet direct dependencies (MEDIA_SUPPORT && USB)
      Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      16b196e5
    • Michal Marek's avatar
      [media] em28xx: Put remaining .vidioc_g_chip_info instance under ADV_DEBUG · 430c73fa
      Michal Marek authored
      Commit cd634f1b ("[media] v4l2: put VIDIOC_DBG_G_CHIP_NAME under
      ADV_DEBUG") missed the initializer of radio_ioctl_ops:
      drivers/media/usb/em28xx/em28xx-video.c:1830:2: error: unknown field 'vidioc_g_chip_info' specified in initializer
      drivers/media/usb/em28xx/em28xx-video.c:1830:26: error: 'vidioc_g_chip_info' undeclared here (not in a function)
      Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      430c73fa
  6. 15 Apr, 2013 12 commits
  7. 14 Apr, 2013 2 commits