- 07 Dec, 2020 1 commit
-
-
Furquan Shaikh authored
Raydium device does not like splitting of tx transactions into multiple messages - one for the register address and one for the actual data. This results in incorrect behavior on the device side. This change updates raydium_i2c_read and raydium_i2c_write to create i2c_msg arrays separately and passes those arrays into raydium_i2c_xfer which decides based on the address whether the bank switch command should be sent. The bank switch header is still added by raydium_i2c_read and raydium_i2c_write to ensure that all these operations are performed as part of a single I2C transfer. It guarantees that no other transactions are initiated to any other device on the same bus after the bank switch command is sent. Signed-off-by:
Furquan Shaikh <furquan@google.com> Link: https://lore.kernel.org/r/20201205005941.1427643-1-furquan@google.comSigned-off-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 01 Dec, 2020 3 commits
-
-
Linus Walleij authored
After commit 74d905d2 devices requiring the workaround for edge triggered interrupts stopped working. The hardware needs the quirk to be used before even proceeding to check if the quirk is needed because mxt_acquire_irq() is called before mxt_check_retrigen() is called and at this point pending IRQs need to be checked, and if the workaround is not active, all interrupts will be lost from this point. Solve this by switching the calls around. Reported-by:
Andre Müller <andre.muller@web.de> Tested-by:
Linus Walleij <linus.walleij@linaro.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20201201123026.1416743-1-linus.walleij@linaro.orgSigned-off-by:
-
Sanjay Govind authored
This commit adds support for Ardwiino Controllers Signed-off-by:
Sanjay Govind <sanjay.govind9@gmail.com> Link: https://lore.kernel.org/r/20201201071922.131666-1-sanjay.govind9@gmail.com Cc: stable@vger.kernel.org Signed-off-by:
-
Po-Hsu Lin authored
It looks like the C15B laptop got another vendor: ByteSpeed LLC. Avoid AUX loopback on this touchpad as well, thus input subsystem will be able to recognize a Synaptics touchpad in the AUX port. BugLink: https://bugs.launchpad.net/bugs/1906128Signed-off-by:
Po-Hsu Lin <po-hsu.lin@canonical.com> Link: https://lore.kernel.org/r/20201201054723.5939-1-po-hsu.lin@canonical.com Cc: stable@vger.kernel.org Signed-off-by:
-
- 25 Nov, 2020 2 commits
-
-
Luo Meng authored
Fix to return a negative error code from the error handling case instead of 0 in function i8042_setup_aux(), as done elsewhere in this function. Fixes: f8113416 ("Input: i8042 - use platform_driver_probe") Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
Luo Meng <luomeng12@huawei.com> Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20201123133420.4071187-1-luomeng12@huawei.comSigned-off-by:
-
Dmitry Torokhov authored
This fixes the following build errors: CC [M] drivers/input/misc/soc_button_array.o drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function 'irq_set_irq_type' [-Werror,-Wimplicit-function-declaration] irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); ^ drivers/input/misc/soc_button_array.c:156:26: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_LOW' irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); ^ 2 errors generated. Fixes: 78a5b53e ("Input: soc_button_array - work around DSDTs which modify the irqflags") Reported-by:kernel test robot <lkp@intel.com> Reviewed-by:
-
- 12 Nov, 2020 2 commits
-
-
jingle.wu authored
The argument to iap page type command depends on the firmware page size. Fixes: bfd9b92b ("Input: elan_i2c - handle firmware updated on newer ICs") Signed-off-by:
Jingle Wu <jingle.wu@emc.com.tw> Signed-off-by:
-
Necip Fazil Yildiran authored
When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for IIO_BUFFER_CB Depends on [n]: IIO [=y] && IIO_BUFFER [=n] Selected by [y]: - TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y] The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This can also fail building the kernel. Honor the kconfig dependency to remove unmet direct dependency warnings and avoid any potential build failures. Fixes: aa132ffb ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen") Signed-off-by:
Necip Fazil Yildiran <fazilyildiran@gmail.com> Acked-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Link: https://lore.kernel.org/r/20201102221504.541279-1-fazilyildiran@gmail.comSigned-off-by:
-
- 09 Nov, 2020 1 commit
-
-
Dmitry Torokhov authored
We need to make sure we cancel the reinit work before we tear down the driver structures. Reported-by:
Bodong Zhao <nopitydays@gmail.com> Tested-by:
-
- 27 Oct, 2020 2 commits
-
-
Hans de Goede authored
The i8042 module exports several symbols which may be used by other modules. Before this commit it would refuse to load (when built as a module itself) on systems without an i8042 controller. This is a problem specifically for the asus-nb-wmi module. Many Asus laptops support the Asus WMI interface. Some of them have an i8042 controller and need to use i8042_install_filter() to filter some kbd events. Other models do not have an i8042 controller (e.g. they use an USB attached kbd). Before this commit the asus-nb-wmi driver could not be loaded on Asus models without an i8042 controller, when the i8042 code was built as a module (as Arch Linux does) because the module_init function of the i8042 module would fail with -ENODEV and thus the i8042_install_filter symbol could not be loaded. This commit fixes this by exiting from module_init with a return code of 0 if no controller is found. It also adds a i8042_present bool to make the module_exit function a no-op in this case and also adds a check for i8042_present to the exported i8042_command function. The latter i8042_present check should not really be necessary because when builtin that function can already be used on systems without an i8042 controller, but better safe then sorry. Reported-and-tested-by:
Marius Iacob <themariusus@gmail.com> Signed-off-by:
-
Dan Carpenter authored
The "revid" is used to store negative error codes so it should be an int type. Fixes: e27c7292 ("Input: add driver for ADXL345/346 Digital Accelerometers") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
Michael Hennerich <michael.hennerich@analog.com> Link: https://lore.kernel.org/r/20201026072824.GA1620546@mwandaSigned-off-by:
-
- 19 Oct, 2020 1 commit
-
-
Dmitry Torokhov authored
Prepare input updates for 5.10 merge window.
-
- 07 Oct, 2020 2 commits
-
-
Mika Penttilä authored
I am the author of this SiS touch driver, and willing to maintain and develop it further. Signed-off-by:
Mika Penttilä <mika.penttila@nextfour.com> Link: https://lore.kernel.org/r/20201007035108.58636-1-mika.penttila@nextfour.comSigned-off-by:
-
Kenny Levinsen authored
All evdev clients share a common waitgroup. On new input events, all clients waiting on this waitgroup are woken up, even those filtering out the events, possibly more than once per event. This leads to duplicated and unwanted wakeups. Split the shared waitgroup into per-client waitgroups for more fine-grained wakeups. Signed-off-by:
Kenny Levinsen <kl@kl.wtf> Link: https://lore.kernel.org/r/20200429184126.2155-1-kl@kl.wtfSigned-off-by:
-
- 05 Oct, 2020 5 commits
-
-
Hans de Goede authored
With the new RMI4 F3A support, we're now able to enable full RMI4 support for this model. Signed-off-by:
-
Jason A. Donenfeld authored
With the new RMI4 F3A support, we're now able to enable full RMI4 support for this model. We also tidy up the comments a bit, as the X1E is essentially the same computer as the P1. Acked-by:
Lyude Paul <lyude@redhat.com> Signed-off-by:
Jason A. Donenfeld <Jason@zx2c4.com> Link: https://lore.kernel.org/r/20200930225046.173190-3-Jason@zx2c4.comSigned-off-by:
-
Jason A. Donenfeld authored
With the recent addition of the F3A support, we can now accept bootloader v8, which will help support recent Thinkpads. Acked-by:
-
Vincent Huang authored
RMI4 F3A supports the touchpad GPIO function, it's designed to support more GPIOs and used on newer touchpads. This patch adds support of the touchpad buttons. Signed-off-by:
Vincent Huang <vincent.huang@tw.synaptics.com> Reviewed-by:
Andrew Duggan <aduggan@synaptics.com> Link: https://lore.kernel.org/r/20200930094147.635556-3-vincent.huang@tw.synaptics.comSigned-off-by:
-
Vincent Huang authored
f30_data in rmi_device_platform_data could be also referenced by RMI function 3A, so rename it and the structure name to avoid confusion. Signed-off-by:
-
- 04 Oct, 2020 2 commits
-
-
Michael Srba authored
Add support for the bt541 touchscreen IC from zinitix, loosely based on downstream driver. The driver currently supports multitouch (5 touch points). The bt541 seems to support touch keys, but the support was not added because that functionality is not being utilized by the touchscreen used for testing. Based on the similartities between downstream drivers, it seems likely that other similar touchscreen ICs can be supported with this driver in the future. Signed-off-by:
Michael Srba <Michael.Srba@seznam.cz> Link: https://lore.kernel.org/r/20201001122949.16846-1-michael.srba@seznam.czSigned-off-by:
-
Michael Srba authored
This patch adds dts bindings for the zinitix bt541 touchscreen. Signed-off-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201001122949.16846-2-michael.srba@seznam.czSigned-off-by:
-
- 28 Sep, 2020 4 commits
-
-
Artur Rojek authored
Add a driver for joystick devices connected to ADC controllers supporting the Industrial I/O subsystem. Signed-off-by:
Artur Rojek <contact@artur-rojek.eu> Tested-by:
Paul Cercueil <paul@crapouillou.net> Tested-by:
Heiko Stuebner <heiko@sntech.de> Link: https://lore.kernel.org/r/20200927123302.31062-2-contact@artur-rojek.euSigned-off-by:
-
Artur Rojek authored
Add documentation for the adc-joystick driver, used to provide support for joysticks connected over ADC. Signed-off-by:
-
Jiri Kosina authored
Touchpad on this laptop is not detected properly during boot, as PNP enumerates (wrongly) AUX port as disabled on this machine. Fix that by adding this board (with admittedly quite funny DMI identifiers) to nopnp quirk list. Reported-by:
Andrés Barrantes Silman <andresbs2000@protonmail.com> Signed-off-by:
Jiri Kosina <jkosina@suse.cz> Link: https://lore.kernel.org/r/nycvar.YFH.7.76.2009252337340.3336@cbobk.fhfr.pm Cc: stable@vger.kernel.org Signed-off-by:
-
Vincent Huang authored
Add Synaptics IDs in trackpoint_start_protocol() to mark them as valid. Signed-off-by:
Harry Cutts <hcutts@chromium.org> Tested-by:
-
- 16 Sep, 2020 8 commits
-
-
Krzysztof Kozlowski authored
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: e443631d ("Input: serio - add support for Alwinner A10/A20 PS/2 controller") Signed-off-by:
Krzysztof Kozlowski <krzk@kernel.org> Acked-by:
Chen-Yu Tsai <wens@csie.org> Link: https://lore.kernel.org/r/20200828145744.3636-4-krzk@kernel.orgSigned-off-by:
-
Krzysztof Kozlowski authored
platform_get_irq() returns -ERRNO on error. In such case casting to unsigned and comparing to 0 would pass the check. Fixes: 7abf38d6 ("Input: twl4030-keypad - add device tree support") Reported-by:
-
Krzysztof Kozlowski authored
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: f3a1ba60 ("Input: omap4-keypad - use platform device helpers") Signed-off-by:
-
Krzysztof Kozlowski authored
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: 60214f05 ("Input: ep93xx_keypad - update driver to new core support") Signed-off-by:
-
YueHaibing authored
In stmfts_sysfs_hover_enable_write(), we should check value and sdata->hover_enabled is all true. Fixes: 78bcac7b ("Input: add support for the STMicroelectronics FingerTip touchscreen") Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Link: https://lore.kernel.org/r/20200916141941.16684-1-yuehaibing@huawei.comSigned-off-by:
-
Dmitry Torokhov authored
Open/close and resume/suspend paths are very similar, let's factor out common parts. Signed-off-by: -
Dan Carpenter authored
If imx6ul_tsc_init() fails then we need to clean up the clocks. I reversed the "if (input_dev->users) {" condition to make the code a bit simpler. Fixes: 6cc527b0 ("Input: imx6ul_tsc - propagate the errors") Signed-off-by: -
Johnny Chuang authored
Fixed typo for command from 0xE0 to 0xD0. Fixes: cf520c64 ("Input: elants_i2c - provide an attribute to show calibration count") Signed-off-by:
Johnny Chuang <johnny.chuang.emc@gmail.com> Link: https://lore.kernel.org/r/1600238783-32303-1-git-send-email-johnny.chuang.emc@gmail.comSigned-off-by:
-
- 14 Sep, 2020 6 commits
-
-
Vincent Huang authored
Add trackpoint variant IDs to allow supported control on Synaptics trackpoints. Signed-off-by:
-
Johnny Chuang authored
This patch adds a new behavior to report touch major resolution based on information provided by firmware. In initial process, driver acquires touch information from touch ic. It contains one byte about the resolution value of ABS_MT_TOUCH_MAJOR. Touch driver will report touch major resolution by this information. Signed-off-by:
-
Furquan Shaikh authored
On an AMD chromebook, where the same I2C bus is shared by both Raydium touchscreen and a trackpad device, it is observed that interleaving of I2C messages when `raydium_i2c_read_message()` is called leads to the Raydium touch IC reporting incorrect information. This is the sequence that was observed to result in the above issue: * I2C write to Raydium device for RM_CMD_BANK_SWITCH * I2C write to trackpad device * I2C read from trackpad device * I2C write to Raydium device for setting address * I2C read from Raydium device >>>> This provides incorrect information This change adds a new helper function `raydium_i2c_xfer()` that performs I2C transactions to the Raydium device. It uses the register address to decide if RM_CMD_BANK_SWITCH header needs to be sent to the device (i.e. if register address is greater than 255, then bank switch header is sent before the rest of the transaction). Additionally, it ensures that all the I2C operations performed as part of `raydium_i2c_xfer()` are done as a single i2c_transfer. This guarantees that no other transactions are initiated to any other device on the same bus in between. Additionally, `raydium_i2c_{send|read}*` functions are refactored to use this new helper function. Verified with the patch across multiple reboots (>100) that the information reported by the Raydium touchscreen device during probe is correct. Signed-off-by: -
Hans de Goede authored
Some 2-in-1s which use the soc_button_array driver have this ugly issue in their DSDT where the _LID method modifies the irq-type settings of the GPIOs used for the power and home buttons. The intend of this AML code is to disable these buttons when the lid is closed. The AML does this by directly poking the GPIO controllers registers. This is problematic because when re-enabling the irq, which happens whenever _LID gets called with the lid open (e.g. on boot and on resume), it sets the irq-type to IRQ_TYPE_LEVEL_LOW. Where as the gpio-keys driver programs the type to, and expects it to be, IRQ_TYPE_EDGE_BOTH. This commit adds a workaround for this which (on affected devices) does not set gpio_keys_button.gpio on these 2-in-1s, instead it gets the irq for the GPIO, configures it as IRQ_TYPE_LEVEL_LOW (to match how the _LID AML code configures it) and passes the irq in gpio_keys_button.irq. Signed-off-by:
-
Hans de Goede authored
According to the Microsoft documentation for Windows 8 convertible devices, these devices should implement a PNP0C60 "laptop/slate mode state indicator" ACPI device. This device can work in 2 ways, if there is a GPIO which directly indicates the device is in tablet-mode or not then the direct-gpio mode should be used. If there is no such GPIO, but instead the events are coming from e.g. the embedded-controller, then there should still be a PNP0C60 ACPI device and event-injection should be used to send the events. The drivers/platform/x86/intel-vbtn.c code is an example from a standardized manner of doing the latter. On various 2-in-1s with either a detachable keyboard, or with 360° hinges, the direct GPIO mode is indicated by an ACPI device with a HID of INT33D3, which contains a single GpioInt in its ACPI resource table, which directly indicates if the device is in tablet-mode or not. This commit adds support for this to the soc_button_array code, as well as for the alternative ID9001 HID which some devices use instead of the INT33D3 HID. Signed-off-by:
-
Hans de Goede authored
This is a preparation patch for adding support for Intel INT33D3 ACPI devices. These INT33D3 devices follow yet another Intel defined (but not documented) ACPI GPIO button standard. Unlike the ACPI GPIO button devices supported so far, the GPIO used in the INT33D3 devices is active-high, rather then active-low. This commit makes setting the gpio_keys_button.active_low flag configurable through the soc_button_info struct and enables it for all currently supported devices. Signed-off-by:
-
- 08 Sep, 2020 1 commit
-
-
Hans de Goede authored
The keyboard drops keypresses early during boot unless both the nomux and reset quirks are set. Add DMI table entries for this. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1806085Signed-off-by:
-
