- 28 Jun, 2019 1 commit
-
-
Colin Ian King authored
Shifting the integer value 1 is evaluated using 32-bit arithmetic and then used in an expression that expects a 64-bit value, so there is potentially an integer overflow. Fix this by using the BIT_ULL macro to perform the shift. [ Note: as of the time being, no actual integer overflow hits because all values are less than 32bit, not including the extended 3-byte or DSD formats. But this is the right fix for future usage, of course. -- tiwai ] Addresses-Coverity: ("Unintentional integer overflow") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 24 Jun, 2019 3 commits
-
-
Takashi Iwai authored
The recent USB core code performs sanity checks for the given pipe and EP types, and it can be hit by manipulated USB descriptors by syzbot. For making syzbot happier, this patch introduces a local helper for a sanity check in the driver side and calls it at each place before the message handling, so that we can avoid the WARNING splats. Reported-by: syzbot+d952e5e28f5fb7718d23@syzkaller.appspotmail.com Signed-off-by: -
Takashi Sakamoto authored
In ALSA firewire-motu driver, some tracepoints are supported to probe vendor-specific data fields for SPH and status/control messages in payload of isochronous packet. At present, the events of tracepoints are unique each of direction, however the pair of events has the same structure and print format. It's possible to unify the pair. This commit unifies the pair. From userspace, direction is specified by filtering for src/dst fields in the structure. Signed-off-by:
Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by:
-
Takashi Sakamoto authored
This reverts commit e703965a. When creating this patch, I compared the value of src field to the value of first byte of cip_header field (SID) in tracing event. But in this test I used a device which has a quirk to transfer isochronous packet with invalid SID. The original change is valid. Fixes: e703965a ("ALSA: firewire-lib: fix inverted node IDs for amdtp_packet events") Signed-off-by:
-
- 21 Jun, 2019 8 commits
-
-
Takashi Sakamoto authored
When stopping packet streaming in reserve function for duplex streams, isochronous resources should be released. Fixes: 7bc93821 ("ALSA: firewire-lib: split allocation of isochronous resources from establishment of connection") Signed-off-by:
-
Takashi Sakamoto authored
When stopping packet streaming in reserve function for duplex streams, isochronous resources should be released. Fixes: 7bc93821 ("ALSA: firewire-lib: split allocation of isochronous resources from establishment of connection") Signed-off-by:
-
Takashi Sakamoto authored
When stopping packet streaming in reserve function for duplex streams, isochronous resources should be released. Fixes: 7bc93821 ("ALSA: firewire-lib: split allocation of isochronous resources from establishment of connection") Signed-off-by:
-
Takashi Sakamoto authored
>From callbacks for pcm and rawmidi interfaces, the functions to stop and release duplex streams are called at the same time. This commit merges the two functions. Signed-off-by:
-
Takashi Sakamoto authored
>From callbacks for pcm and rawmidi interfaces, the functions to stop and release duplex streams are called at the same time. This commit merges the two functions. Signed-off-by:
-
Takashi Sakamoto authored
>From callbacks for pcm and rawmidi interfaces, the functions to stop and release duplex streams are called at the same time. This commit merges the two functions. Signed-off-by:
-
Takashi Sakamoto authored
>From callbacks for pcm and rawmidi interfaces, the functions to stop and release duplex streams are called at the same time. This commit merges the two functions. Signed-off-by:
-
Takashi Sakamoto authored
>From callbacks for pcm and rawmidi interfaces, the functions to stop and release duplex streams are called at the same time. This commit merges the two functions. Signed-off-by:
-
- 18 Jun, 2019 10 commits
-
-
Takashi Sakamoto authored
The pairs of pcm.hw_params callbacks and .hw_free callbacks for both direction have no differences. This commit unifies the pairs. Signed-off-by:
-
Takashi Sakamoto authored
After bus reset, isochronous resource manager releases all of allocated isochronous resources. The nodes to transfer isochronous packet should request reallocation of the resources. However, between the bus-reset and invocation of 'struct fw_driver.update' handler, ALSA PCM application can detect this situation by XRUN because the target device cancelled to transmit packets once bus-reset occurs. Due to the above mechanism, ALSA fireface driver just stops packet streaming in the update handler, thus pcm.prepare handler should request the reallocation. This commit requests the reallocation in pcm.prepare callback when bus generation is changed. Signed-off-by:
-
Takashi Sakamoto authored
Once allocated, isochronous resources are available for packet streaming, even if the streaming is cancelled. For this reason, current implementation handles allocation of the resources and starting packet streaming at the same time. However, this brings complicated procedure to start packet streaming. This commit separates the allocation and starting. The allocation is done in pcm.hw_params callback and available till pcm.hw_free callback. Even if any XRUN occurs, pcm.prepare callback is done to restart packet streaming without releasing/allocating the resources. There are two points to stop packet streaming; in pcm.hw_params and pcm.prepare callbacks. The former point is a case that packet streaming is already started for any MIDI substream then packet streaming is requested with different sampling transfer frequency for any PCM substream. The latter point is cases of any XRUN or packet queueing error. Signed-off-by:
-
Takashi Sakamoto authored
The operation to finish packet streaming includes stopping isochronous contexts. This commit merges it to the helper function. Signed-off-by:
-
Takashi Sakamoto authored
The helper function to stop isochronous context is superfluous. This commit removes it with simpler codes. Signed-off-by:
-
Takashi Sakamoto authored
Like the other drivers in ALSA firewire stack, this commit renames functions to begin/finish packet streaming. Signed-off-by:
-
Takashi Sakamoto authored
In snd_motu_stream_start_duplex() function, there're two points to stop packet streaming, however they can be merged. This commit merges them. Signed-off-by:
-
Takashi Sakamoto authored
This commit is a part of preparation to perform allocation/release of isochronous resources in pcm.hw_params/hw_free callbacks. This commit adds a helper function to allocate isochronous resources. Signed-off-by:
-
Takashi Sakamoto authored
Two sets of callbacks for rawmidi.open/close but they have the same codes. This commit unifies each of the callbacks. Signed-off-by:
-
Takashi Sakamoto authored
Two counters are used to maintain isochronous packet streaming for both directions. However, like the other drivers, they can be replaced with one counter. This commit unifies them. Signed-off-by:
-
- 17 Jun, 2019 6 commits
-
-
Takashi Sakamoto authored
In current implementation, establishment connection corresponds to allocation of isochronous resources. Although this is an ideal implementation of CMP described in IEC 61883-1, it's not enough efficient to recover PCM substream multiplexed in packet streaming. The packet streaming can always restart on the same allocated isochronous resources even if the previous packet streaming corrupted. This commit splits allocation of isochronous resources from establishment of connection so that CMP runs with allocated isochronous resources. Signed-off-by:
-
Takashi Sakamoto authored
The operation of duplex streams should be in critical section. Signed-off-by:
-
Takashi Sakamoto authored
This commit removes useless procedures to stop packet streaming. Signed-off-by:
-
Takashi Sakamoto authored
The operation of duplex streams should be in critical section. Signed-off-by:
-
Takashi Sakamoto authored
The pairs of rawmidi.hw_params callback functions and .hw_free callback functions for both direction have no differences. This commit unifies the pairs. Signed-off-by:
-
Takashi Sakamoto authored
The pairs of pcm.hw_params callback functions and .hw_free callback functions for both direction have no differences. This commit unifies the pairs. Signed-off-by:
-
- 13 Jun, 2019 5 commits
-
-
Wolfram Sang authored
Checking a variable which is always '1' has no use. Signed-off-by:
Wolfram Sang <wsa@the-dreams.de> Signed-off-by:
-
Jaroslav Kysela authored
In the commit 7f641e26 (ALSA: hda/hdmi - Consider eld_valid when reporting jack event) the eld_valid check was added for the jack event reports. Do the same in sync_eld_via_acomp() function. Apparently, it is required for the NVIDIA proprietary driver (monitor presence reported first, but ELD is available later). Signed-off-by:
Jaroslav Kysela <perex@perex.cz> Signed-off-by:
-
Guennadi Liakhovetski authored
The .jacks field in struct hda_codec is unused and seems to be a duplicate of .jacktbl, remove it. Signed-off-by:
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Signed-off-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
-
Lai, Poey Seng authored
Add HD Audio Device PCI ID for the Intel Elkhart Lake platform. Signed-off-by:
Lai, Poey Seng <poey.seng.lai@intel.com> Signed-off-by:
-
Takashi Sakamoto authored
This commit fixes the warning due to returning uninitialized value from start_streams() helper function. sound/firewire/dice/dice-stream.c: In function 'start_streams.isra.0': >> sound/firewire/dice/dice-stream.c:350:6: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] int err; ^~~ Reported-by:kbuild test robot <lkp@intel.com> Fixes: 3cd2c2d7 ("ALSA: dice: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks") Signed-off-by:
-
- 12 Jun, 2019 7 commits
-
-
Takashi Sakamoto authored
This commit is a part of preparation to perform allocation/release of isochronous resources in pcm.hw_params/hw_free callbacks. This commit splits out an operation to configure stream parameters into pcm.hw_params callback. In pcm.prepare callback, establishing connections and start isochronous contexts. Signed-off-by:
-
Takashi Sakamoto authored
This commit is a part of preparation to perform allocation/release of isochronous resources in pcm.hw_params/hw_free callbacks. At present, several operations are done in pcm.prepare callback. To reduce load of the callback, This commit splits out an operation to set packet format in pcm.hw_params callback. Signed-off-by:
-
Takashi Sakamoto authored
In former commits, two isochronous contexts are handles at the same time. This commit unifies stream counters to obsolete them. Signed-off-by:
-
Takashi Sakamoto authored
In former commits, ALSA oxfw driver handles two isochronous contexts at the same time, except for some devices which supports one endpoint of isochronous packet stream. This commit renames some helper functions so that they handles duplex streams. Signed-off-by:
-
Takashi Sakamoto authored
The helper function stop packet streaming is not enough useful. This commit obsoletes it and expands its code. Signed-off-by:
-
Takashi Sakamoto authored
In most cases, recovery from bus reset is not successful. This commit aborts packet streaming in bus reset handler. Signed-off-by:
-
Takashi Sakamoto authored
It's inconvenient to handle two isochronous context separately each other. This commit unifies the counters to handle the two at the same time. Signed-off-by:
-
