- 19 Jun, 2023 11 commits
-
-
Yogesh Hegde authored
Rename variable SetWirelessMode to set_wireless_mode to avoid CamelCase which is not accepted by checkpatch. Signed-off-by:
Yogesh Hegde <yogi.kernel@gmail.com> Link: https://lore.kernel.org/r/c0a65d217d272bf457917c89462c49e67bbfedb2.1687183827.git.yogi.kernel@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Rename RTLLIB_LINKED_SCANNING to MAC80211_LINKED_SCANNING to align with rtlwifi driver. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/25b97cd436c636e750c50f0c03386fcc46e56610.1687007788.git.philipp.g.hortmann@gmail.comSigned-off-by:
-
Philipp Hortmann authored
Rename RTLLIB_LINKED to MAC80211_LINKED to align with rtlwifi driver. Signed-off-by:
-
Philipp Hortmann authored
Rename RTLLIB_NOLINK to MAC80211_NOLINK to align with rtlwifi driver. Signed-off-by:
-
Philipp Hortmann authored
Rename state to link_state to align with rtlwifi driver and to increase readability as state is to general. Signed-off-by:
-
Philipp Hortmann authored
Rename rtllib_state to rtl_link_state to align with rtlwifi driver and to increase readability as state is to general. Signed-off-by:
-
Philipp Hortmann authored
Remove unused enum led_ctl_mode to shorten code. Signed-off-by:
-
Philipp Hortmann authored
Rename constant IEEE_B to WIRELESS_MODE_B, IEEE_G -> WIRELESS_MODE_G and IEEE_N_24G -> WIRELESS_MODE_N_24G to align with rtlwifi driver as requested in TODO. Signed-off-by:
-
Philipp Hortmann authored
Remove unsupported modes IEEE_N_5G and IEEE_A as those are not supported by hardware and are not offered by user software. Remove resulting dead code and unused defines. Signed-off-by:
-
Philipp Hortmann authored
stats->freq is initialized with 1 and then unchanged. All evaluations will result accordingly. Remove resulting dead code and unused defines. Signed-off-by:
-
Philipp Hortmann authored
Add missing entry CFG80211 in Kconfig to ensure that CFG80211 is available when selecting hardware rtl8192e. Fixes: d88b46ce ("staging: rtl8192e: Add cfg80211.h and remove defined variables") Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202306180620.Ew55XtKJ-lkp@intel.com/Signed-off-by:
-
- 17 Jun, 2023 1 commit
-
-
Prathu Baronia authored
This dev_info() statement is not needed since drivers need to be quiet under normal operation and its not a good idea to print addresses in kernel log. Signed-off-by:
Prathu Baronia <prathubaronia2011@gmail.com> Message-ID: <20230616152602.33232-2-prathubaronia2011@gmail.com> Signed-off-by:
-
- 15 Jun, 2023 5 commits
-
-
Philipp Hortmann authored
Use ieee80211_channel_to_freq_khz() to calculate channel to frequency to omit proprietary code. Signed-off-by:
-
Philipp Hortmann authored
Use ieee80211_freq_khz_to_channel() to calculate frequency to channel to omit proprietary code. Signed-off-by:
-
Philipp Hortmann authored
Add cfg80211 and remove defined variables rfc1042_header and bridge_tunnel_header as they are then already defined. Usage of cfg80211 is required to merge driver into wireless subsystem. Signed-off-by:
-
Michael Straube authored
Remove unnecessary blank lines reported by checkpatch. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Tested-by:
-
Deepanshu Kartikey authored
Removed new line in else and else if, this warning was given by checkpatch.pl Signed-off-by:
Deepanshu Kartikey <kartikey406@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@linaro.org> Message-ID: <20230530135120.37637-1-kartikey406@gmail.com> Signed-off-by:
-
- 28 May, 2023 20 commits
-
-
David Tadokoro authored
Clean a checkpatch.pl warning of type "braces {} are not necessary for single statement blocks" on r8192E_phy.c file. Signed-off-by:David Tadokoro <davidbtadokoro@usp.br> Link: https://lore.kernel.org/r/20230528154010.3068-1-davidbtadokoro@usp.brSigned-off-by:
-
Andy Shevchenko authored
There is no gpiod_export() and gpiod_unexport() looks pretty much stray. If user space tools somehow belong to that, they should be fixed, the gpiod_export() and gpiod_unexport() shouldn't be used in a new code, GPIO sysfs is deprecated. That said, and taking into account staging state of the driver, simply drop the stray call. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230528140147.32427-1-andriy.shevchenko@linux.intel.comSigned-off-by:
-
Uwe Kleine-König authored
After commit b8a1a4cd ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f4 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by:
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230524151646.486847-6-u.kleine-koenig@pengutronix.deSigned-off-by:
-
Uwe Kleine-König authored
After commit b8a1a4cd ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f4 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by:
-
Bagas Sanjaya authored
Remove the license boilerplate as there is already SPDX license identifier added in b2441318 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") which fulfills the same intention as the boilerplate. Cc: Dan Carpenter <error27@gmail.com> Cc: Kate Stewart <kstewart@linuxfoundation.org> Cc: Philippe Ombredanne <pombredanne@nexb.com> Cc: Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Simon Horman <simon.horman@corigine.com> Signed-off-by:
Bagas Sanjaya <bagasdotme@gmail.com> Link: https://lore.kernel.org/r/20230517090418.1093091-4-bagasdotme@gmail.comSigned-off-by:
-
Arnd Bergmann authored
This function has no callers from other files, and the declaration was removed a while ago, causing a W=1 warning: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for 'vchiq_platform_init' Marking it static solves this problem but introduces a new warning since gcc determines that 'g_fragments_base' is never initialized in some kernel configurations: In file included from include/linux/string.h:254, from include/linux/bitmap.h:11, from include/linux/cpumask.h:12, from include/linux/mm_types_task.h:14, from include/linux/mm_types.h:5, from include/linux/buildid.h:5, from include/linux/module.h:14, from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:8: In function 'memcpy_to_page', inlined from 'free_pagelist' at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:433:4: include/linux/fortify-string.h:57:33: error: argument 2 null where non-null expected [-Werror=nonnull] include/linux/highmem.h:427:9: note: in expansion of macro 'memcpy' 427 | memcpy(to + offset, from, len); | ^~~~~~ Add a NULL pointer check for this in addition to the static annotation to avoid both. Fixes: 89cc4218 ("staging: vchiq_arm: drop unnecessary declarations") Signed-off-by:Arnd Bergmann <arnd@arndb.de> Reviewed-by:
Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by:
Umang Jain <umang.jain@ideasonboard.com> Link: https://lore.kernel.org/r/20230516202603.560554-1-arnd@kernel.orgSigned-off-by:
-
Michael Straube authored
Add missing spaces around operators to improve readability and clear checkpatch issues. Signed-off-by:
-
Philipp Hortmann authored
On start of rtllib_wx_set_scan lock was taken with mutex_lock(&ieee->wx_mutex). Unlocking was done at the end of schedule_work(&ieee->wx_sync_scan_wq) which lead to the error "lock held when returning to user space!". Pushing lock to beginning of ieee->wx_sync_scan_wq to improve overview. Removed lock from rtllib_wx_set_scan as ieee->state, ieee->iw_mode and ieee->proto_started are not protected in many other places. Signed-off-by:
-
Philipp Hortmann authored
Exclude scan_mutex from cancel_delayed_work_sync(&ieee->softmac_scan_wq) as ieee->softmac_scan_wq takes scan_mutex as well. Signed-off-by:
-
Atin Bainada authored
replace the ternary operator used for assignment of pHalData->ant_path with an if-else block for better readability Signed-off-by:
Atin Bainada <hi@atinb.me> Link: https://lore.kernel.org/r/20230513214338.79833-1-hi@atinb.meSigned-off-by:
-
Philipp Hortmann authored
Remove function LedControlHandler as it is not defined. Remove resulting unused local variables bLedBlinking, type, fc and LedAction. Signed-off-by:
-
Philipp Hortmann authored
Remove function UpdateBeaconInterruptHandler as it is not defined. Signed-off-by:
-
Philipp Hortmann authored
Remove function SetFwCmdHandler as it is not defined. Signed-off-by:
-
Philipp Hortmann authored
Remove function set_security as it is not defined. Signed-off-by:
-
Philipp Hortmann authored
Remove function hard_start_xmit as it is not defined. Equation !ieee->hard_start_xmit always evaluates to true. When (*ieee->hard_start_xmit)(txb, dev) == 0 is called the my computer is freezing. Signed-off-by:
-
Philipp Hortmann authored
Remove function reset_port as it is not defined. Signed-off-by:
-
Philipp Hortmann authored
Remove functions rtllib_start_hw_scan and rtllib_stop_hw_scan as they are not defined. Signed-off-by:
-
Philipp Hortmann authored
Remove function data_hard_resume as it is not defined. Signed-off-by:
-
Philipp Hortmann authored
Remove function data_hard_stop as it is not defined. Signed-off-by:
-
Niklas Schnelle authored
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by:
Arnd Bergmann <arnd@kernel.org> Signed-off-by:
Niklas Schnelle <schnelle@linux.ibm.com> Link: https://lore.kernel.org/r/20230522105049.1467313-35-schnelle@linux.ibm.comSigned-off-by:
-
- 13 May, 2023 3 commits
-
-
Yogesh Hegde authored
Refactor tmp_ofdm_index variable assignment to avoid multiple assignments which is not accepted by checkpatch. Signed-off-by:
-
Yogesh Hegde authored
Rename variable tmpCCK20Mindex to tmp_cck_20m_index and tmpCCK40Mindex to tmp_cck_40m_index to avoid CamelCase which is not accepted by checkpatch. Signed-off-by:
-
Yogesh Hegde authored
Rename variable tmpOFDMindex to tmp_ofdm_index and tmpCCKindex to tmp_cck_index to avoid CamelCase which is not accepted by checkpatch. Signed-off-by:
-
