Skip to content

L
linux
An error occurred fetching the project authors.
Switch branch/tag
  1. 30 Mar, 2015 1 commit
  3. 10 Feb, 2015 1 commit
  5. 01 Dec, 2014 1 commit
  7. 27 May, 2014 1 commit
  9. 24 Apr, 2014 1 commit
  11. 14 Apr, 2014 1 commit
  13. 28 Feb, 2014 1 commit
  15. 23 Feb, 2014 1 commit
  17. 18 Dec, 2013 1 commit
    • Shawn Guo's avatar
      ASoC: sgtl5000: clean up sgtl5000_enable_regulators() · 11db0da8
      Shawn Guo authored 
      Function sgtl5000_enable_regulators() is somehow odd in handling the
optional external VDDD supply.  The driver can only enable this supply
on SGTL5000 chip before revision 0x11, and of course when this external
VDDD is present.  It currently does something like below.

1. Check if regulator_bulk_get() on VDDA, VDDIO and VDDD will fail.  If
   it fails, VDDD must be absent and it falls on internal LDO by calling
   sgtl5000_replace_vddd_with_ldo().  Otherwise, VDDD is used.  And in
   either case, regulator_bulk_enable() will be called to enable
   3 supplies.

2. In case that SGTL5000 revision is later than 0x11, even if external
   VDDD is present, it has to roll back the 'enable' and 'get' calls
   with regulator_bulk_disable() and regulator_bulk_free(), and starts
   over again by calling sgtl5000_replace_vddd_with_ldo() and
   regulator_bulk_enable().

Such back and forth calls sequence is complicated and unnecessary.
Also, since commit 4ddfebd3 (regulator: core: Provide a dummy regulator
with full constraints), regulator_bulk_get() will always succeeds
because of the dummy regulator.  Thus the VDDD detection is broken.

The patch changes the flow to something like the following, which should
be more reasonable and clear, and also fix the VDDD detection breakage.

1. Check if we're running a chip before revision 0x11, on which an
   external VDDD can possibly be an option.

2. If it is an early revision, call regulator_get_optional() to detect
   whether an external VDDD supply is available.

3. If external VDDD is present, call sgtl5000_replace_vddd_with_ldo() to
   update sgtl5000->supplies info.

4. Drop regulator_bulk_get() call in sgtl5000_replace_vddd_with_ldo(),
   and call it in sgtl5000_enable_regulators() no matter it's an
   external VDDD or internal LDO.

5. Call regulator_bulk_enable() to enable these 3 regulators.
Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
      11db0da8
  19. 16 Dec, 2013 1 commit
  21. 05 Aug, 2013 1 commit
  23. 01 Aug, 2013 2 commits
  25. 16 Jul, 2013 1 commit
    • Shawn Guo's avatar
      ASoC: sgtl5000: defer the probe if clock is not found · 46a5905e
      Shawn Guo authored 
      It's not always the case that clock is already available when sgtl5000
get probed at the first time, e.g. the clock is provided by CPU DAI
which may be probed after sgtl5000.  So let's defer the probe when
devm_clk_get() call fails and give it chance to try later.

It fixes the regression on imx28 since commit 9e13f345 (ASoC: sgtl5000:
Let the codec acquire its clock).

[    1.927637] sgtl5000 0-000a: Failed to get mclock: -2
[    1.934280] sgtl5000: probe of 0-000a failed with error -2
[    1.945906] mxs-sgtl5000 sound.13: ASoC: CODEC (null) not registered
[    1.953787] mxs-sgtl5000 sound.13: snd_soc_register_card failed (-517)
[    1.960865] platform sound.13: Driver mxs-sgtl5000 requests probe deferral
Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
      46a5905e
  27. 15 Jul, 2013 1 commit
  29. 05 Jul, 2013 1 commit
  31. 12 Jun, 2013 1 commit
  33. 10 Jun, 2013 1 commit
    • Fabio Estevam's avatar
      ASoC: sgtl5000: Let the codec acquire its clock · 9e13f345
      Fabio Estevam authored 
      On a mx6qsabrelite board the following error happens on probe:

sgtl5000: probe of 0-000a failed with error -5
imx-sgtl5000 sound.13: ASoC: CODEC (null) not registered
imx-sgtl5000 sound.13: snd_soc_register_card failed (-517)
platform sound.13: Driver imx-sgtl5000 requests probe defer

Prior to reading the codec ID we need to turn the SYS_MCLK clock, so let's
enable the codec clock inside sgtl5000_i2c_probe().

Also remove the codec clock enable/disable functions from the machine driver.
Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
      9e13f345
  35. 05 Jun, 2013 1 commit
  37. 04 Jun, 2013 1 commit
    • Marek Vasut's avatar
      ASoC: sgtl5000: Fix VAG_POWER enabling/disabling order · dd4d2d6d
      Marek Vasut authored 
      The VAG_POWER must be enabled after all other bits in CHIP_ANA_POWER
and disabled before any other bit in CHIP_ANA_POWER. See the SGTL5000
datasheet (Table 31, BIT 7, page 42-43). Failing to follow this order
will result in ugly loud "POP" noise at the end of playback.

To achieve such order, use the _PRE and _POST DAPM widgets to trigger
the power_vag_event, where the event type check has to be fixed
accordingly as well.
Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
      dd4d2d6d
  39. 12 May, 2013 3 commits
  41. 24 Dec, 2012 1 commit
  43. 09 Dec, 2012 1 commit
  45. 31 Jul, 2012 1 commit
  47. 24 Jul, 2012 1 commit
    • Dong Aisheng's avatar
      ASoC: sgtl5000: remove unneeded snd_soc_dapm_new_widgets in probe · a07e8d49
      Dong Aisheng authored 
      There's a driver bug that sgtl5000 dapm widget kcontrols do not work.
e.g. can not select capture mux with amixer tool(no error info prompted).

The root cause is that we still call snd_soc_dapm_new_widgets in
codec driver probe function afer converting to table based widgets.
This will cause the card dapm widgets are instantiated before the
dapm_routes are registered.
Then, no available dapm widget pathes can be found during instantiation
which finally will cause soc_dapm_mux_update_power to fail(can not find
correct path with kcontrol) in snd_soc_dapm_put_enum_double function.

Here we remove the unneeded snd_soc_dapm_new_widgets in codec probe
and let the soc core to handle the register sequence properly.
Then we can fix above issue.
Signed-off-by: default avatarDong Aisheng <dong.aisheng@linaro.org>
Acked-by: default avatarShawn Guo <shawn.guo@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      a07e8d49
  49. 09 Apr, 2012 1 commit
    • Mark Brown's avatar
      regulator: core: Use a struct to pass in regulator runtime configuration · c172708d
      Mark Brown authored 
      Rather than adding new arguments to regulator_register() every time we
want to add a new bit of dynamic information at runtime change the function
to take these via a struct. By doing this we avoid needing to do further
changes like the recent addition of device tree support which required each
regulator driver to be updated to take an additional parameter.

The regulator_desc which should (mostly) be static data is still passed
separately as most drivers are able to configure this statically at build
time.
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      c172708d
  51. 04 Apr, 2012 2 commits
  53. 03 Apr, 2012 1 commit
  55. 02 Apr, 2012 1 commit
  57. 01 Apr, 2012 1 commit
  59. 23 Jan, 2012 1 commit
  61. 22 Jan, 2012 1 commit
  63. 20 Jan, 2012 2 commits
  65. 16 Jan, 2012 1 commit
  67. 28 Dec, 2011 2 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7