- 09 May, 2012 40 commits
-
-
Mat Martineau authored
Adding Code Aurora Forum copyright information due to significant additions of code. Acked-by:
Marcel Holtmann <marcel@holtmann.org> Signed-off-by:
Mat Martineau <mathewm@codeaurora.org> Signed-off-by:
Gustavo Padovan <gustavo@padovan.org>
-
Mat Martineau authored
L2CAP sockets contain a pointer to l2cap_chan that needs to be reference counted in order to prevent a possible dangling pointer when the channel is freed. There were a few other cases where an l2cap_chan pointer on the stack was dereferenced after a call to l2cap_chan_del. Those pointers are also now reference counted. Signed-off-by:
-
Mat Martineau authored
l2cap_get_chan_by_ident was not used, but didn't generate a compiler warning because it was an inline function. Signed-off-by:
-
Mat Martineau authored
Structure members used by ERTM or streaming mode need to be initialized when an ERTM or streaming mode link is configured. Some duplicate code is also eliminated by moving in to the ERTM init function. Signed-off-by:
-
Mat Martineau authored
Moving these functions simplifies future patches by eliminating forward declarations, makes future patches easier to review, and better preserves 'git blame' information. Signed-off-by:
-
Mat Martineau authored
These values are now in the nested l2cap_ctrl struct. Signed-off-by:
-
Mat Martineau authored
Instead of using modular division, the offset can be calculated using only addition and subtraction. The previous calculation did not work as intended and was more difficult to understand, involving unsigned integer underflow and a check for a negative value where one was not possible. Signed-off-by:
-
Amitkumar Karwar authored
Currently debugfs commands "hscfgcmd" and "gpiogap" are provided for host sleep configuration. But if user doesn't configure host sleep parameters using these commands, host sleep activation is failed during suspend (support for suspend and resume handlers is added in next patch). Default host sleep configuration is done during driver initialisation in this patch. Signed-off-by:
Amitkumar Karwar <akarwar@marvell.com> Signed-off-by:
Bing Zhao <bzhao@marvell.com> Signed-off-by:
-
Andre Guedes authored
User-space pass the remote device address type to kernel through struct sockaddr_l2 what makes the advertising useless. This patch removes all advertising cache code. Signed-off-by:
Andre Guedes <andre.guedes@openbossa.org> Acked-by:
Johan Hedberg <johan.hedberg@intel.com> Signed-off-by:
-
Andre Guedes authored
In order to establish a LE connection we need the address type information. User-space already pass this information to kernel through struct sockaddr_l2. This patch adds the dst_type parameter to l2cap_chan_connect so we are able to pass the address type info from user-space down to hci_conn layer. Signed-off-by:
-
Andre Guedes authored
This patch adds the dst_type parameter to hci_connect function. Instead of searching the address type in advertising cache, we use the dst_type parameter to establish LE connections. The dst_type is ignored for BR/EDR connection establishment. Signed-off-by:
-
Andre Guedes authored
This patch moves the helper function bdaddr_to_le to hci_core, so it can be used in mgmt.c and hci_conn.c. Signed-off-by:
-
Andre Guedes authored
Since address type macros are not only related to Management Interface anymore, it makes sense to rename the helper function mgmt_to_le to bdaddr_to_le. Signed-off-by:
-
Andre Guedes authored
This patch adds the address type info to struct sockaddr_l2 so user-space can inform the remote device address type required to establish LE connections. Soon, instead of looking the advertising cache up to discover the address type, we'll use this address type info to establish LE connections. Signed-off-by:
-
Andre Guedes authored
Since address type macros are not only related to Management Interface anymore, it makes sense to rename the helper function link_to_mgmt to link_to_bdaddr. Signed-off-by:
-
Andre Guedes authored
This patch moves address type macros to bluetooth.h since they will be used by management interface and Bluetooth socket interface. It also replaces the macro prefix MGMT_ADDR_ by BDADDR_. Signed-off-by:
-
Andrei Emeltchenko authored
Signed-off-by:
Andrei Emeltchenko <andrei.emeltchenko@intel.com> Signed-off-by:
-
Andre Guedes authored
This patch removes unneeded variable assignments in hci_connect. 'sec_level' is already assigned to BT_SECURITY_LOW in hci_le_connect and 'pending_sec_level' and 'auth_type' are assigned right after if statement. Signed-off-by:
-
Vinicius Costa Gomes authored
As most LE devices leave advertising mode when they enter the connected state, we may want to "pass" that connection to other users. The first user will be the pairing procedure, the connection is established without an associated socket, after the pairing is complete, userspace may want to discover via GATT what services the newly bonded device has. If userspace establishes the connection while the timeout still hasn't expired, the connection will be re-used. Signed-off-by:
Vinicius Costa Gomes <vinicius.gomes@openbossa.org> Tested-by:
João Paulo Rechi Vita <jprvita@openbossa.org> Signed-off-by:
-
Ido Yariv authored
The cid or psm and the source address might not be enough to uniquely identify a global channel, especially when the source address is our own. For instance, when trying to communicate with two LE devices in master mode, data received from the both devices is sent to the same socket. Fix this by taking the destination address into account when choosing the socket. Signed-off-by:
Ido Yariv <ido@wizery.com> Signed-off-by:
Arik Nemtsov <arik@wizery.com> Tested-by:
-
David Herrmann authored
We allocate memory with kzalloc() so there is no need to call memset(..., 0, ...) or similar. Signed-off-by:
David Herrmann <dh.herrmann@googlemail.com> Signed-off-by:
-
David Herrmann authored
We currently initialize locks, lists, works, etc. in hci_register_dev() (hci_alloc_dev() was added later) which is bogus because an hdev is in an invalid state if it is not registered. This patch moves all memory initialization to hci_alloc_dev(). Device registering and registration of sub-modules is still left in hci_register_dev() as it belongs there. The benefit is (despite cleaning up the code-base) we can now always be sure that an hdev is a valid object and can be locked and worked on even though it may not be registered. This patch also reorders the initialization to be easier to understand. First the memory is initialized, then all generic structures and as last step the sub-init functions are called. This guarantees that all dependencies are initialized in the right order and makes it also easier to find a specific line. We previously initialized it in the same order as the "struct hci_dev" is declared which seems pretty random. Signed-off-by:
-
David Herrmann authored
alloc() and register() (and free() and unregister()) are closely related so move them more closely together. This will also allow to move functionality from register() to alloc() without needing forward-declarations. Signed-off-by:
-
Marcel Holtmann authored
The SCO sockets are only identified by its address. So only allow one SCO socket in listening state per address or BDADDR_ANY. Signed-off-by:
-
Marcel Holtmann authored
Checking the source address in SCO bind function will prevent from having an incoming and outgoing SCO socket. However that might be needed in case of multiple SCO connections on a single device. Signed-off-by:
-
Ulisses Furquim authored
When adding HCI devices hci_register_dev assigns the same name hci1 for subsequently added AMP devices. ... [ 6958.381886] sysfs: cannot create duplicate filename '/devices/virtual/bluetooth/hci1 ... We assume id starts with the number we'll try to add the new device and keep iterating until we find the proper place. The only difference is we start with 0 for BR/EDR device and 1 for AMP devices (thus AMP devices will never receive register as index 0). Then every hdev->id in the _ordered_ list <= to the id we want we increment id and move the variable head. In the end we'll have id as the first available one and head is where you need to add hdev after to keep the list ordered. Reported-by:Ulisses Furquim <ulisses@profusion.mobi> Signed-off-by:
-
Lukasz Rymanowski authored
Sco_conn_add is called from two places and always with status = 0. Signed-off-by:
Lukasz Rymanowski <lukasz.rymanowski@tieto.com> Signed-off-by:
-
Marcel Holtmann authored
Split the checks for sk->sk_state and sk->sk_type for SCO listen sockets. This makes the code more readable. Signed-off-by:
-
Marcel Holtmann authored
Split the checks for sk->sk_state and sk->sk_type for L2CAP listen sockets. This makes the code more readable. Signed-off-by:
-
Hemant Gupta authored
SMP Keys should only be distributeed when encryption is successful. Signed-off-by:
Hemant Gupta <hemant.gupta@stericsson.com> Signed-off-by:
-
Mikel Astiz authored
The alternate setting must be dynamically set according to the number of active SCO links, and the bit depth of the audio. The possible values for the alternate setting are described in the Bluetooth Core Specification, Volume 4, Part B, section 2.1.1. Signed-off-by:
Mikel Astiz <mikel.astiz.oss@gmail.com> Acked-by:
-
Andrei Emeltchenko authored
It does make sense to print hdev name after allocation. Signed-off-by:
-
Syam Sidhardhan authored
No one is using strtoba() in the bluetooth subsystem. Signed-off-by:
Syam Sidhardhan <s.syam@samsung.com> Signed-off-by:
-
Syam Sidhardhan authored
hci_del_off_timer() doesn't exist anymore. Signed-off-by:
-
Hemant Gupta authored
This patch fixes the address type while loading long term keys when BT is switched on. Without this fix pairing is reinitated even though LTK exists for remote device because of mismatch of address type. Signed-off-by:
-
Syam Sidhardhan authored
Remove goto statements that do nothing else than jump to the next line of code. Signed-off-by:
-
Gustavo Padovan authored
By some reason this is not needed anymore. Signed-off-by: -
Mikel Astiz authored
The function already fails if the given size is greater than the MTU, so there is no need to consider that case afterwards. Signed-off-by:
-
Mikel Astiz authored
The involved values are all unsigned and thus unsigned int should be used instead of signed int. Assigning ~0 to a signed int results in -1, which is confusing and error-prone, while the code is trying to set the maximum value possible. The code still works because the C standard defines that unsigned comparison will be performed in these cases, when comparing an unsigned int and a signed int. Signed-off-by:
-
Jesper Juhl authored
release_firmware() deals gracefullt with NULL pointers so there's no reason to test for one prior to calling the function. Signed-off-by:
Jesper Juhl <jj@chaosbits.net> Signed-off-by:
-
