- 02 Feb, 2024 36 commits
-
-
Miri Korenblit authored
All the regulatory tables will be read from UEFI, and only if it doesn't exist - they will be read from ACPI. Read SAR tables (WRDS, EWRD and WGDS) from UEFI. Signed-off-by:
Miri Korenblit <miriam.rachel.korenblit@intel.com> Reviewed-by:
Gregory Greenman <gregory.greenman@intel.com> Link: https://msgid.link/20240131091413.533b687e1efb.Icb316291e593c8d53f41fdea2d083367dc97e3c4@changeidSigned-off-by:
Johannes Berg <johannes.berg@intel.com>
-
Miri Korenblit authored
iwl_geo_tx_power_profiles_cmd::table_revision indicates whether to use South Korea scheme or not. We use South Korea scheme if the revision of WGDS table is 1. We used to read the WGDS table from ACPI inside iwl_sar_geo_fill_table(), so we had to set table_revision only after the call to it. This added an extra if...else for each cmd version. But it has been a while since we moved the BIOS tables reading to INIT stage, and iwl_sar_geo_fill_table() is now only copying the previously stored table to the cmd structure. Set the table_revision before the call to iwl_sar_geo_fill_table() and avoid that extra if...else. Signed-off-by:
-
Miri Korenblit authored
The driver will support reading BIOS tables from UEFI too. Refactor the SAR tables (WRDS, EWRD, WGDS) flows: 1. Move all the SAR logic/definitions that is common to both UEFI and ACPI to a new file - regulatory.h/c. 2. Rename the relevant functions/definitions so it will be clear which is ACPI specific and which is for both ACPI and UEFI 3. Rename the function that copies the stored tables into the different commands structures, so will be clear what these functions do. Signed-off-by:
-
Johannes Berg authored
Before using EMLSR check the AP actually advertises support for it, otherwise reject the link activation. Signed-off-by:
-
Johannes Berg authored
When using MLO, we need to have only a single link active when entering suspend and of course most of the code also needs to be adjusted to not use deflink, apart from older code that's not used with MLO-capable firmware. Implement that. Note that the link selection currently prefers the "best" link, which might really not be the best for D3, but that can be fixed later once we agree. Signed-off-by:
-
Miri Korenblit authored
The driver is supposed to read the PNVM from BIOS only for non-Intel SKUs. For Intel SKUs the OEM ID will be 0. Read BIOS PNVM only when a non-Intel SKU is indicated. Fixes: b99e32cb ("wifi: iwlwifi: Take loading and setting of pnvm image out of parsing part") Signed-off-by:
-
Benjamin Berg authored
Extend the test to pass an RNR appropriate for an NSTR and verify that use_for as well as cannot_use_reasons are set correctly. Signed-off-by:
Benjamin Berg <benjamin.berg@intel.com> Link: https://msgid.link/20240129220918.b00aee4c4c9f.I942fddf51cabaab761de3865b4e06cce831a46ef@changeidSigned-off-by:
-
Benjamin Berg authored
Test a few things around parsing of 6 GHz colocated APs to e.g. ensure that we are not going to scan for a disabled (affiliated) AP. Signed-off-by:
-
Johannes Berg authored
Refactor the check for using a chanctx's def vs. min_def, to have the same in both places and reuse it later. Signed-off-by:
-
Daniel Gabay authored
When we drop frames due to MIC error we want to have something printed in the logger (this won't be printed by default). Signed-off-by:
Daniel Gabay <daniel.gabay@intel.com> Reviewed-by:
-
Johannes Berg authored
If the firmware has the necessary support, enable SPP A-MSDUs. Signed-off-by:
-
Mukesh Sisodiya authored
Add the support for a new PCI device id. Signed-off-by:
Mukesh Sisodiya <mukesh.sisodiya@intel.com> Reviewed-by:
-
Emmanuel Grumbach authored
ADD_STA resets the link quality data inside the firmware. This is not supposed to happen and has been fixed for newer devices. For older devices (AX201 and down), this makes us send frames with rates that are not in the TLC table. Fixes: 5a86dcb4 ("wifi: iwlwifi: mvm: update station's MFP flag after association") Signed-off-by:
Emmanuel Grumbach <emmanuel.grumbach@intel.com> Reviewed-by:
-
Johannes Berg authored
With MLO connections we need to let the firmware pick the rate as we don't know the link the frame might be transmitted on (in some cases we do know, but we'd rather always use the FW and find bugs.) We _did_ end up finding bugs and fixing them, but older devices likely won't get fixed as we don't have a need for this there, they cannot support MLO. Thus, go back to picking a rate on the host for the relevant frames on older (pre-Bz) devices. Fixes: 499d0279 ("wifi: iwlwifi: Use FW rate for non-data frames") Signed-off-by:
-
Johannes Berg authored
The IWL_DEVICE_GL_A macro is no longer used, and couldn't be, so remove it. Signed-off-by:
-
Ilan Peer authored
When secure LTF is used MFP must also be set. Signed-off-by:
Ilan Peer <ilan.peer@intel.com> Reviewed-by:
Avraham Stern <avraham.stern@intel.com> Reviewed-by:
-
Johannes Berg authored
We check this in code that'd be complicated to put under ifdef (CONFIG_ACPI), so just always have 'uats_enabled'. Fixes: 4a9bb5b4 ("wifi: iwlwifi: fw: Add support for UATS table in UHB") Signed-off-by:
-
Johannes Berg authored
This field is reserved in AP mode, don't set any bits in it. Signed-off-by:
-
Colin Ian King authored
There is a spelling mistake in a WARN message. Fix it. Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Reviewed-by:
-
Johannes Berg authored
The IPN is reported by the firmware in 6 bytes little endian, but mac80211 expects big endian so it can do memcmp() on it. We used to store this as a u64 which was filled in the right way, but never used. When implementing that it's used, we changed it to just be 6 bytes, but lost the conversion. Add it back. Fixes: 04f78e24 ("wifi: iwlwifi: mvm: Add support for IGTK in D3 resume flow") Signed-off-by:
-
Ayala Beker authored
Add support for handling TID to link mapping negotiation request and decide whether to accept it or not. Accept the request if all TIDs are mapped to the same link set, otherwise reject it. Signed-off-by:
Ayala Beker <ayala.beker@intel.com> Reviewed-by:
-
Miri Korenblit authored
EWRD ACPI table contains up to 3 additional sar profiles. According to the BIOS spec, the table contains a n_profile variable indicating how many additional profiles exist in the table. Currently we check that n_profiles is not <= 0. But according to the BIOS spec, 0 is a valid value, and it can't be < 0 anyway because we receive that from ACPI as an unsigned integer. Fixes: 39c1a972 ("iwlwifi: refactor the SAR tables from mvm to acpi") Signed-off-by:
-
Miri Korenblit authored
Extract the logic that is common to all variables loading to a function. Signed-off-by:
-
Miri Korenblit authored
All the regulatory tables from BIOS are going to be loaded (preferably) from the UEFI instead of the ACPI. There is a security issue with the fact that anyone can add these UEFI variables. The solution for that is to have a lock for all WIFI GUID UEFI variables, and only if the UEFI variables are locked then we can read it. The status of the lock (unlocked, locked, test mode) is indicated in a ACPI table: Guid Lock ACPI Indicator. Load this table so the driver knows whether to read from UEFI or not Signed-off-by:
-
Johannes Berg authored
When connecting to an AP, we currently initialize the rate control only after associating. Since we now use firmware to assign rates to auth/assoc frames rather than using the data in the station and the firmware doesn't know, they're transmitted using low mandatory rates. However, if the AP advertised only higher supported rates we want to use them to be nicer (it still must receive mandatory rates though), so send the information to the firmware earlier to have it know about it and be able to use it. Fixes: 499d0279 ("wifi: iwlwifi: Use FW rate for non-data frames") Signed-off-by:
-
Emmanuel Grumbach authored
This will allow to reconnect immediately instead of leaving the connection in a limbo state. Signed-off-by:
-
Johannes Berg authored
The code reading the WPFC table needs to take into account the domain type (first element in the package), shouldn't leak the memory if it fails, and has a bad comment. Fix all these issues. Fixes: c4c95454 ("wifi: iwlwifi: implement WPFC ACPI table loading") Reported-by:
-
Johannes Berg authored
This hard-codes the size, but it's not obvious why that's correct. Use sizeof() and cross-check the two structs. Signed-off-by:
-
Johannes Berg authored
The iwl_fw_ini_debug_info_tlv is used as a string, so we must ensure the string is terminated correctly before using it. Fixes: a9248de4 ("iwlwifi: dbg_ini: add TLV allocation new API support") Signed-off-by:
-
Johannes Berg authored
This is effectively the same since we don't even have a multiplication, but better captures what happens with the length. Signed-off-by:
-
Johannes Berg authored
In iwl_dbg_tlv_alloc_trigger() the code makes a copy just to modify it and pass it to another function to make a copy again. Change the API to return the copy so the adjustment can be done without another copy. Signed-off-by:
-
Johannes Berg authored
Add return descriptions, move description contents after (parameter) sections and fix short descriptions. Signed-off-by:
-
Johannes Berg authored
If there was a rekey failure during D3 when firmware is handling the GTK rekeying, and it decided that we should wake up, then there was an issue in the connection and we don't necessarily have the right keys, so we should disconnect. Signed-off-by:
-
Johannes Berg authored
Andrei reports that we just silently drop beacons after we report the key counters, but never report to userspace, so wpa_supplicant cannot send the WNM action frame. Fix that. Fixes: b1fdc250 ("iwlwifi: mvm: advertise BIGTK client support if available") Reported-by:
Andrei Otcheretianski <andrei.otcheretianski@intel.com> Signed-off-by:
-
Ilan Peer authored
When removing a PASN station, the TK must be removed before the station is removed as otherwise the FW would assert. To handle this, store the key configuration, and use it to remove the key when the station is removed. Signed-off-by:
-
Miri Korenblit authored
eSR should be disabled when BT Coex is active and: - LB link is the primary link. - LB link is the secondary link and the predicted BT penalty (the wifi loss rate caused by BT interference) is higher than a given threshold. If one of the conditions above is no longer true then re-enable eSR. In order to implement this, add support for version 5 of BT_PROFILE_NOTIFICATION, in which the bt penalty is provided by FW. Signed-off-by:
-
- 01 Feb, 2024 4 commits
-
-
Dan Carpenter authored
The first parameter of WARN_ONCE() is a condition so this code will end up printing the function name instead of the proper message. Fixes: 3ff7a059 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces") Signed-off-by:
Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by:
Ping-Ke Shih <pkshih@realtek.com> Signed-off-by:
Kalle Valo <kvalo@kernel.org> Link: https://msgid.link/7b144531-a8da-4725-8911-9b614a525a35@moroto.mountain
-
Po-Hao Huang authored
To support multi-links beacon, it needs more fields. But currently we still only support legacy AP mode. Only update struct to fit expected size of firmware. Signed-off-by:
Po-Hao Huang <phhuang@realtek.com> Signed-off-by:
-
Chin-Yen Lee authored
The ps_state register is used for driver to check if the WiFi chip leave power save mode successfully. The register is changed for new generation, so update it. Signed-off-by:
Chin-Yen Lee <timlee@realtek.com> Signed-off-by:
-
Chin-Yen Lee authored
Because 802.11be chip support MLO mode, driver needs to send new H2C to pass more connected channel information to firmware, to ensure PS mode work fine. Signed-off-by:
-
