1. 16 Jun, 2024 12 commits
    • Linus Torvalds's avatar
      Merge tag 'i2c-for-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · 4301487e
      Linus Torvalds authored
      Pull i2c fixes from Wolfram Sang:
       "Two fixes to correctly report i2c functionality, ensuring that
        I2C_FUNC_SLAVE is reported when a device operates solely as a slave
        interface"
      
      * tag 'i2c-for-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
        i2c: designware: Fix the functionality flags of the slave-only interface
        i2c: at91: Fix the functionality flags of the slave-only interface
      4301487e
    • Linus Torvalds's avatar
      Merge tag 'usb-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb · b5beaa44
      Linus Torvalds authored
      Pull USB / Thunderbolt fixes from Greg KH:
       "Here are some small USB and Thunderbolt driver fixes for 6.10-rc4.
        Included in here are:
      
         - thunderbolt debugfs bugfix
      
         - USB typec bugfixes
      
         - kcov usb bugfix
      
         - xhci bugfixes
      
         - usb-storage bugfix
      
         - dt-bindings bugfix
      
         - cdc-wdm log message spam bugfix
      
        All of these, except for the last cdc-wdm log level change, have been
        in linux-next for a while with no reported problems. The cdc-wdm
        bugfix has been tested by syzbot and proved to fix the reported cpu
        lockup issues when the log is constantly spammed by a broken device"
      
      * tag 'usb-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb:
        USB: class: cdc-wdm: Fix CPU lockup caused by excessive log messages
        xhci: Handle TD clearing for multiple streams case
        xhci: Apply broken streams quirk to Etron EJ188 xHCI host
        xhci: Apply reset resume quirk to Etron EJ188 xHCI host
        xhci: Set correct transferred length for cancelled bulk transfers
        usb-storage: alauda: Check whether the media is initialized
        usb: typec: ucsi: Ack also failed Get Error commands
        kcov, usb: disable interrupts in kcov_remote_start_usb_softirq
        dt-bindings: usb: realtek,rts5411: Add missing "additionalProperties" on child nodes
        usb: typec: tcpm: Ignore received Hard Reset in TOGGLING state
        usb: typec: tcpm: fix use-after-free case in tcpm_register_source_caps
        USB: xen-hcd: Traverse host/ when CONFIG_USB_XEN_HCD is selected
        usb: typec: ucsi: glink: increase max ports for x1e80100
        Revert "usb: chipidea: move ci_ulpi_init after the phy initialization"
        thunderbolt: debugfs: Fix margin debugfs node creation condition
      b5beaa44
    • Linus Torvalds's avatar
      Merge tag 'tty-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty · 6efc63a8
      Linus Torvalds authored
      Pull tty/serial driver fixes from Greg KH:
       "Here are some small tty and serial driver fixes that resolve som
        reported problems. Included in here are:
      
         - n_tty lookahead buffer bugfix
      
         - WARN_ON() removal where it was not needed
      
         - 8250_dw driver bugfixes
      
         - 8250_pxa bugfix
      
         - sc16is7xx Kconfig fixes for reported build issues
      
        All of these have been in linux-next for over a week with no reported
        problems"
      
      * tag 'tty-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty:
        serial: drop debugging WARN_ON_ONCE() from uart_write()
        serial: sc16is7xx: re-add Kconfig SPI or I2C dependency
        serial: sc16is7xx: rename Kconfig CONFIG_SERIAL_SC16IS7XX_CORE
        serial: port: Don't block system suspend even if bytes are left to xmit
        serial: 8250_pxa: Configure tx_loadsz to match FIFO IRQ level
        serial: 8250_dw: Revert "Move definitions to the shared header"
        serial: 8250_dw: Don't use struct dw8250_data outside of 8250_dw
        tty: n_tty: Fix buffer offsets when lookahead is used
      6efc63a8
    • Linus Torvalds's avatar
      Merge tag 'staging-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging · d3e6dc4f
      Linus Torvalds authored
      Pull staging driver fix from Greg KH:
       "Here is a single staging driver fix, for the vc04 driver. It resolves
        a reported problem that showed up in the merge window set of changes.
      
        It's been in linux-next for over a week with no reported problems"
      
      * tag 'staging-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging:
        staging: vchiq_debugfs: Fix NPD in vchiq_dump_state
      d3e6dc4f
    • Linus Torvalds's avatar
      Merge tag 'driver-core-6.10-rc4' of... · e12fa4dd
      Linus Torvalds authored
      Merge tag 'driver-core-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
      
      Pull driver core and sysfs fixes from Greg KH:
       "Here are three small changes for 6.10-rc4 that resolve reported
        problems, and finally drop an unused api call. These are:
      
         - removal of devm_device_add_groups(), all the callers of this are
           finally gone after the 6.10-rc1 merge (changes came in through
           different trees), so it's safe to remove.
      
         - much reported sysfs build error fixed up for systems that did not
           have sysfs enabled
      
         - driver core sync issue fix for a many reported issue over the years
           that no one really paid much attention to, until Dirk finally
           tracked down the real issue and made the "obviously correct and
           simple" fix for it.
      
        All of these have been in linux-next for over a week with no reported
        problems"
      
      * tag 'driver-core-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core:
        drivers: core: synchronize really_probe() and dev_uevent()
        sysfs: Unbreak the build around sysfs_bin_attr_simple_read()
        driver core: remove devm_device_add_groups()
      e12fa4dd
    • Linus Torvalds's avatar
      Merge tag 'char-misc-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc · 33f855cb
      Linus Torvalds authored
      Pull char/misc driver fixes from Greg KH:
       "Here are a number of small char/misc and iio driver fixes for
        6.10-rc4. Included in here are the following:
      
         - iio driver fixes for a bunch of reported problems.
      
         - mei driver fixes for a number of reported issues.
      
         - amiga parport driver build fix.
      
         - .editorconfig fix that was causing lots of unintended whitespace
           changes to happen to files when they were being edited. Unless we
           want to sweep the whole tree and remove all trailing whitespace at
           once, this is needed for the .editorconfig file to be able to be
           used at all. This change is required because the original
           submitters never touched older files in the tree.
      
         - jfs bugfix for a buffer overflow
      
        The jfs bugfix is in here as I didn't know where else to put it, and
        it's been ignored for a while as the filesystem seems to be abandoned
        and I'm tired of seeing the same issue reported in multiple places.
      
        All of these have been in linux-next with no reported issues"
      
      * tag 'char-misc-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (25 commits)
        .editorconfig: remove trim_trailing_whitespace option
        jfs: xattr: fix buffer overflow for invalid xattr
        misc: microchip: pci1xxxx: Fix a memory leak in the error handling of gp_aux_bus_probe()
        misc: microchip: pci1xxxx: fix double free in the error handling of gp_aux_bus_probe()
        parport: amiga: Mark driver struct with __refdata to prevent section mismatch
        mei: vsc: Fix wrong invocation of ACPI SID method
        mei: vsc: Don't stop/restart mei device during system suspend/resume
        mei: me: release irq in mei_me_pci_resume error path
        mei: demote client disconnect warning on suspend to debug
        iio: inkern: fix channel read regression
        iio: imu: inv_mpu6050: stabilized timestamping in interrupt
        iio: adc: ad7173: Fix sampling frequency setting
        iio: adc: ad7173: Clear append status bit
        iio: imu: inv_icm42600: delete unneeded update watermark call
        iio: imu: inv_icm42600: stabilized timestamp in interrupt
        iio: invensense: fix odr switching to same value
        iio: adc: ad7173: Remove index from temp channel
        iio: adc: ad7173: Add ad7173_device_info names
        iio: adc: ad7173: fix buffers enablement for ad7176-2
        iio: temperature: mlx90635: Fix ERR_PTR dereference in mlx90635_probe()
        ...
      33f855cb
    • Linus Torvalds's avatar
      Merge tag 'ata-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux · e8b0264d
      Linus Torvalds authored
      Pull ata fix from Niklas Cassel:
       "Fix a bug where the SCSI Removable Media Bit (RMB) was incorrectly set
        for hot-plug capable (and eSATA) ports.
      
        The RMB bit means that the media is removable (e.g. floppy or CD-ROM),
        not that the device server is removable. If the RMB bit is set, SCSI
        will set the removable media sysfs attribute.
      
        If the removable media sysfs attribute is set on a device,
        GNOME/udisks will automatically mount the device on boot.
      
        We only want to set the SCSI RMB bit (and thus the removable media
        sysfs attribute) for devices where the ATA removable media device bit
        is set"
      
      * tag 'ata-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux:
        ata: libata-scsi: Set the RMB bit only for removable media devices
      e8b0264d
    • Linus Torvalds's avatar
      Merge tag 'edac_urgent_for_v6.10_rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras · e39388e4
      Linus Torvalds authored
      Pull EDAC fixes from Borislav Petkov:
      
       - Fix two issues with MI300 address translation logic
      
      * tag 'edac_urgent_for_v6.10_rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras:
        RAS/AMD/ATL: Use system settings for MI300 DRAM to normalized address translation
        RAS/AMD/ATL: Fix MI300 bank hash
      e39388e4
    • Linus Torvalds's avatar
      Merge tag 'firewire-fixes-6.10-rc4' of... · be2fa886
      Linus Torvalds authored
      Merge tag 'firewire-fixes-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394
      
      Pull firewire fixes from Takashi Sakamoto:
      
       - Update tracepoints events introduced in v6.10-rc1 so that it includes
         the numeric identifier of host card in which the event happens
      
       - replace wiki URL with the current website URL in Kconfig
      
      * tag 'firewire-fixes-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394:
        firewire: core: record card index in bus_reset_handle tracepoints event
        firewire: core: record card index in tracepoinrts events derived from bus_reset_arrange_template
        firewire: core: record card index in async_phy_inbound tracepoints event
        firewire: core: record card index in async_phy_outbound_complete tracepoints event
        firewire: core: record card index in async_phy_outbound_initiate tracepoints event
        firewire: core: record card index in tracepoinrts events derived from async_inbound_template
        firewire: core: record card index in tracepoinrts events derived from async_outbound_initiate_template
        firewire: core: record card index in tracepoinrts events derived from async_outbound_complete_template
        firewire: fix website URL in Kconfig
      be2fa886
    • Hans de Goede's avatar
      leds: class: Revert: "If no default trigger is given, make hw_control trigger the default trigger" · fcf2a997
      Hans de Goede authored
      Commit 66601a29 ("leds: class: If no default trigger is given, make
      hw_control trigger the default trigger") causes ledtrig-netdev to get
      set as default trigger on various network LEDs.
      
      This causes users to hit a pre-existing AB-BA deadlock issue in
      ledtrig-netdev between the LED-trigger locks and the rtnl mutex,
      resulting in hung tasks in kernels >= 6.9.
      
      Solving the deadlock is non trivial, so for now revert the change to
      set the hw_control trigger as default trigger, so that ledtrig-netdev
      no longer gets activated automatically for various network LEDs.
      
      The netdev trigger is not needed because the network LEDs are usually under
      hw-control and the netdev trigger tries to leave things that way so setting
      it as the active trigger for the LED class device is a no-op.
      
      Fixes: 66601a29 ("leds: class: If no default trigger is given, make hw_control trigger the default trigger")
      Reported-by: default avatarGenes Lists <lists@sapience.com>
      Closes: https://lore.kernel.org/all/9d189ec329cfe68ed68699f314e191a10d4b5eda.camel@sapience.com/Reported-by: default avatarJohannes Wüller <johanneswueller@gmail.com>
      Closes: https://lore.kernel.org/lkml/e441605c-eaf2-4c2d-872b-d8e541f4cf60@gmail.com/
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Acked-by: default avatarLee Jones <lee@kernel.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      fcf2a997
    • Wolfram Sang's avatar
      Merge tag 'i2c-host-fixes-6.10-rc4' of... · 7e9bb0cb
      Wolfram Sang authored
      Merge tag 'i2c-host-fixes-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux into i2c/for-current
      
      Two fixes from Jean aim to correctly report i2c functionality,
      specifically ensuring that I2C_FUNC_SLAVE is reported when a
      device operates solely as a slave interface.
      7e9bb0cb
    • Yazen Ghannam's avatar
      RAS/AMD/ATL: Use system settings for MI300 DRAM to normalized address translation · ba437905
      Yazen Ghannam authored
      The currently used normalized address format is not applicable to all
      MI300 systems. This leads to incorrect results during address
      translation.
      
      Drop the fixed layout and construct the normalized address from system
      settings.
      
      Fixes: 87a61237 ("RAS/AMD/ATL: Add MI300 DRAM to normalized address translation support")
      Signed-off-by: default avatarYazen Ghannam <yazen.ghannam@amd.com>
      Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
      Cc: <stable@kernel.org>
      Link: https://lore.kernel.org/r/20240607-mi300-dram-xl-fix-v1-2-2f11547a178c@amd.com
      ba437905
  2. 15 Jun, 2024 16 commits
  3. 14 Jun, 2024 12 commits
    • Dave Airlie's avatar
      Merge tag 'drm-misc-fixes-2024-06-14' of... · 9f0a8649
      Dave Airlie authored
      Merge tag 'drm-misc-fixes-2024-06-14' of https://gitlab.freedesktop.org/drm/misc/kernel into drm-fixes
      
      drm-misc-fixes for v6.10-rc4:
      - Kconfig fix for WERROR.
      - Add panel quirk for Aya Neo KUN
      - Small bugfixes in komeda, bridge/panel, amdgpu, nouveau.
      - Remove unused nouveau struct.
      - Call drm_atomic_helper_shutdown for shmobile and mediatek on shutdown.
      - Remove DEBUGFS ifdefs from komeda.
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/941c0552-3614-4af1-b04a-0a62c99fd7fb@linux.intel.com
      9f0a8649
    • Linus Torvalds's avatar
      Merge tag 'block-6.10-20240614' of git://git.kernel.dk/linux · c286c21f
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - NVMe pull request via Keith:
           - Discard double free on error conditions (Chunguang)
           - Target Fixes (Daniel)
           - Namespace detachment regression fix (Keith)
      
       - Fix for an issue with flush requests and queuelist reuse (Chengming)
      
       - nbd sparse annotation fixes (Christoph)
      
       - unmap and free bio mapped data via submitter (Anuj)
      
       - loop discard/fallocate unsupported fix (Cyril)
      
       - Fix for the zoned write plugging added in this release (Damien)
      
       - sed-opal wrong address fix (Su)
      
      * tag 'block-6.10-20240614' of git://git.kernel.dk/linux:
        loop: Disable fallocate() zero and discard if not supported
        nvme: fix namespace removal list
        nbd: Remove __force casts
        nvmet: always initialize cqe.result
        nvmet-passthru: propagate status from id override functions
        nvme: avoid double free special payload
        block: unmap and free user mapped integrity via submitter
        block: fix request.queuelist usage in flush
        block: Optimize disk zone resource cleanup
        block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()
      c286c21f
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.10-20240614' of git://git.kernel.dk/linux · ac3cb72a
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
       "Two fixes from Pavel headed to stable:
      
         - Ensure that the task state is correct before attempting to grab a
           mutex
      
         - Split cancel sequence flag into a separate variable, as it can get
           set by someone not owning the request (but holding the ctx lock)"
      
      * tag 'io_uring-6.10-20240614' of git://git.kernel.dk/linux:
        io_uring: fix cancellation overwriting req->flags
        io_uring/rsrc: don't lock while !TASK_RUNNING
      ac3cb72a
    • Linus Torvalds's avatar
      Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 0b320c86
      Linus Torvalds authored
      Pull SCSI fixes from James Bottomley:
       "Three obvious driver fixes and two core fixes.
      
        The two core fixes are to disable Command Duration Limits by default
        to fix an inconsistency in SATA and some USB devices. The other is to
        change the default read size for block zero to follow the device
        preference (some USB bridges preferring 16 byte commands don't have a
        translation for READ(10) and thus don't scan properly)"
      
      * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: mpi3mr: Fix ATA NCQ priority support
        scsi: ufs: core: Quiesce request queues before checking pending cmds
        scsi: core: Disable CDL by default
        scsi: mpt3sas: Avoid test/set_bit() operating in non-allocated memory
        scsi: sd: Use READ(16) when reading block zero on large capacity disks
      0b320c86
    • Linus Torvalds's avatar
      Merge tag 'iommu-fix-v6.10-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu · 11100273
      Linus Torvalds authored
      Pull iommu fix from Joerg Roedel:
       "A single patch that fixes a regression which several people reported:
      
         - AMD-Vi: Fix regression causing panics"
      
      * tag 'iommu-fix-v6.10-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu:
        iommu/amd: Fix panic accessing amd_iommu_enable_faulting
      11100273
    • Linus Torvalds's avatar
      Merge tag 'pm-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 0cac73eb
      Linus Torvalds authored
      Pull power management fix from Rafael Wysocki:
       "Restore the behavior of the no_turbo sysfs attribute in the
        intel_pstate driver which allowed users to make the driver start using
        turbo P-states if they have been enabled on the fly by the firmware
        after OS initialization (Rafael Wysocki)"
      
      * tag 'pm-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        cpufreq: intel_pstate: Check turbo_is_disabled() in store_no_turbo()
      0cac73eb
    • Linus Torvalds's avatar
      Merge tag 'acpi-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 94df82fe
      Linus Torvalds authored
      Pull ACPI fixes from Rafael Wysocki:
       "These fix a recent regression in the ACPI EC driver and make system
        suspend work on multiple platforms where StorageD3Enable _DSD is
        missing in the ACPI tables.
      
        Specifics:
      
         - Make the ACPI EC driver directly evaluate an "orphan" _REG method
           under the EC device, if present, which stopped being evaluated
           after the driver had started to install its EC address space
           handler at the root of the ACPI namespace (Rafael Wysocki)
      
         - Make more devices put NVMe storage devices into D3 at suspend to
           work around missing StorageD3Enable _DSD in the BIOS (Mario
           Limonciello)"
      
      * tag 'acpi-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        ACPI: EC: Evaluate orphan _REG under EC device
        ACPI: x86: Force StorageD3Enable on more products
      94df82fe
    • Linus Torvalds's avatar
      Merge tag 'thermal-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · cee84c0b
      Linus Torvalds authored
      Pull thermal control fixes from Rafael Wysocki:
       "These fix three issues introduced recently, two related to defects in
        ACPI tables supplied by the platform firmware and one cause by a
        thermal core change that went too far:
      
         - Prevent the thermal core from failing the registration of a cooling
           device if its .get_cur_state() reports an incorrect state to start
           with which may happen for fans handled through firmware-supplied
           AML in ACPI tables (Rafael Wysocki)
      
         - Make the ACPI thermal zone driver initialize all trip points with
           temperature of 0 centigrade and below as invalid because such trip
           point temperatures do not make sense on systems with ACPI thermal
           control and they cause performance regressions due to permanent
           thermal mitigations to occur (Rafael Wysocki)
      
         - Restore passive polling management in the Step-Wise thermal
           governor that uses it to ensure that all cooling devices used for
           thermal mitigation will go back to their initial states eventually
           (Rafael Wysocki)"
      
      * tag 'thermal-6.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        thermal: gov_step_wise: Restore passive polling management
        thermal: ACPI: Invalidate trip points with temperature of 0 or below
        thermal: core: Do not fail cdev registration because of invalid initial state
      cee84c0b
    • Rafael J. Wysocki's avatar
      Merge branch acpi-x86 · 04f82fbb
      Rafael J. Wysocki authored
      Merge a fix for a suspend issue related to storage handling on multiple
      systems based on AMD hardware:
      
       - Make more devices put NVMe storage devices into D3 at suspend to work
         around missing StorageD3Enable _DSD in the BIOS (Mario Limonciello).
      
      * branch acpi-x86:
        ACPI: x86: Force StorageD3Enable on more products
      04f82fbb
    • Cyril Hrubis's avatar
      loop: Disable fallocate() zero and discard if not supported · 5f75e081
      Cyril Hrubis authored
      If fallcate is implemented but zero and discard operations are not
      supported by the filesystem the backing file is on we continue to fill
      dmesg with errors from the blk_mq_end_request() since each time we call
      fallocate() on the loop device the EOPNOTSUPP error from lo_fallocate()
      ends up propagated into the block layer. In the end syscall succeeds
      since the blkdev_issue_zeroout() falls back to writing zeroes which
      makes the errors even more misleading and confusing.
      
      How to reproduce:
      
      1. make sure /tmp is mounted as tmpfs
      2. dd if=/dev/zero of=/tmp/disk.img bs=1M count=100
      3. losetup /dev/loop0 /tmp/disk.img
      4. mkfs.ext2 /dev/loop0
      5. dmesg |tail
      
      [710690.898214] operation not supported error, dev loop0, sector 204672 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.898279] operation not supported error, dev loop0, sector 522 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.898603] operation not supported error, dev loop0, sector 16906 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.898917] operation not supported error, dev loop0, sector 32774 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.899218] operation not supported error, dev loop0, sector 49674 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.899484] operation not supported error, dev loop0, sector 65542 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.899743] operation not supported error, dev loop0, sector 82442 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.900015] operation not supported error, dev loop0, sector 98310 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.900276] operation not supported error, dev loop0, sector 115210 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      [710690.900546] operation not supported error, dev loop0, sector 131078 op 0x9:(WRITE_ZEROES) flags 0x8000800 phys_seg 0 prio class 0
      
      This patch changes the lo_fallocate() to clear the flags for zero and
      discard operations if we get EOPNOTSUPP from the backing file fallocate
      callback, that way we at least stop spewing errors after the first
      unsuccessful try.
      
      CC: Jan Kara <jack@suse.cz>
      Signed-off-by: default avatarCyril Hrubis <chrubis@suse.cz>
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarJan Kara <jack@suse.cz>
      Link: https://lore.kernel.org/r/20240613163817.22640-1-chrubis@suse.czSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      5f75e081
    • Damien Le Moal's avatar
      ata: libata-scsi: Set the RMB bit only for removable media devices · a6a75edc
      Damien Le Moal authored
      The SCSI Removable Media Bit (RMB) should only be set for removable media,
      where the device stays and the media changes, e.g. CD-ROM or floppy.
      
      The ATA removable media device bit is obsoleted since ATA-8 ACS (2006),
      but before that it was used to indicate that the device can have its media
      removed (while the device stays).
      
      Commit 8a3e33cf ("ata: ahci: find eSATA ports and flag them as
      removable") introduced a change to set the RMB bit if the port has either
      the eSATA bit or the hot-plug capable bit set. The reasoning was that the
      author wanted his eSATA ports to get treated like a USB stick.
      
      This is however wrong. See "20-082r23SPC-6: Removable Medium Bit
      Expectations" which has since been integrated to SPC, which states that:
      
      """
      Reports have been received that some USB Memory Stick device servers set
      the removable medium (RMB) bit to one. The rub comes when the medium is
      actually removed, because... The device server is removed concurrently
      with the medium removal. If there is no device server, then there is no
      device server that is waiting to have removable medium inserted.
      
      Sufficient numbers of SCSI analysts see such a device:
      - not as a device that supports removable medium;
      but
      - as a removable, hot pluggable device.
      """
      
      The definition of the RMB bit in the SPC specification has since been
      clarified to match this.
      
      Thus, a USB stick should not have the RMB bit set (and neither shall an
      eSATA nor a hot-plug capable port).
      
      Commit dc8b4afc ("ata: ahci: don't mark HotPlugCapable Ports as
      external/removable") then changed so that the RMB bit is only set for the
      eSATA bit (and not for the hot-plug capable bit), because of a lot of bug
      reports of SATA devices were being automounted by udisks. However,
      treating eSATA and hot-plug capable ports differently is not correct.
      
      From the AHCI 1.3.1 spec:
      Hot Plug Capable Port (HPCP): When set to '1', indicates that this port's
      signal and power connectors are externally accessible via a joint signal
      and power connector for blindmate device hot plug.
      
      So a hot-plug capable port is an external port, just like commit
      45b96d65 ("ata: ahci: a hotplug capable port is an external port")
      claims.
      
      In order to not violate the SPC specification, modify the SCSI INQUIRY
      data to only set the RMB bit if the ATA device can have its media removed.
      
      This fixes a reported problem where GNOME/udisks was automounting devices
      connected to hot-plug capable ports.
      
      Fixes: 45b96d65 ("ata: ahci: a hotplug capable port is an external port")
      Cc: stable@vger.kernel.org
      Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
      Reviewed-by: default avatarThomas Weißschuh <linux@weissschuh.net>
      Tested-by: default avatarThomas Weißschuh <linux@weissschuh.net>
      Reported-by: default avatarThomas Weißschuh <linux@weissschuh.net>
      Closes: https://lore.kernel.org/linux-ide/c0de8262-dc4b-4c22-9fac-33432e5bddd3@t-8ch.de/Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      [cassel: wrote commit message]
      Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
      a6a75edc
    • Maxime Ripard's avatar
      Merge drm/drm-fixes into drm-misc-fixes · 14731a64
      Maxime Ripard authored
      Roll -rc3 and current drm/fixes in.
      
      This will also unstuck our for-next branch.
      Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
      14731a64