- 03 Jan, 2014 40 commits
-
-
Jingoo Han authored
Use devm_kzalloc() to make cleanup paths simpler. Also, checking return value of devm_kzalloc() is added in order to check if the allocation succeded. Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Acked-by:
John Crispin <blogic@openwrt.org> Signed-off-by:
Brian Norris <computersforpeace@gmail.com>
-
Jingoo Han authored
Use devm_*() functions to make cleanup paths simpler. Signed-off-by:
-
Ezequiel Garcia authored
In order to avoid code duplication, let's consolidate the ECC setting for all SoC variants. Such decision is based on page size and ECC strength requirements. Also, provide a default value for the case where such ECC information is not provided (non-ONFI devices). Tested-by:
Arnaud Ebalard <arno@natisbad.org> Signed-off-by:
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> Signed-off-by:
-
Ezequiel Garcia authored
Currently, we have two different cmdfunc's implementations: one for PXA3xx SoC variant and one for Armada 370/XP SoC variant. The former is the legacy one, typically constrained to devices with page sizes smaller or equal to the controller's FIFO buffer. On the other side, the latter _only_ supports the so-called extended command semantics, which allow to handle devices with larger page sizes (4 KiB, 8 KiB, ...). This means we currently don't support devices with smaller pages on the A370/XP SoC. Fix it by first renaming the cmdfuncs variants, and then make the choice based on device page size (and SoC variant), rather than SoC variant alone. While at it, add a check for page size, to make sure we don't allow larger pages sizes on the PXA3xx variant. Tested-by:
-
Ezequiel Garcia authored
Currently the driver assumes all commands will eventually trigger a RnB transition, and thus a "device is ready" IRQ. This assumption means that on every issued command, the dev_ready completion handler is init'ed and the need_wait flag is set. However this is incorrect: some commands (such as NAND_CMD_STATUS) don't make the device 'busy' and thus a RnB transition never occurs. Given, the NAND core never calls waitfunc() after such commands, this is not a problem. Therefore, it's possible to only clear the need_wait flag on every command that is started. This fixes a current bug that can be reproduced on PXA boards by writing blank (all 0xff'ed) to a page: 1. The kernel issues NAND_CMD_STATUS and sets need_wait=1. The flag won't be cleared for this command since no RnB transition is involved. 2. NAND_CMD_PAGEPROG is issued but since the data is blank, the driver decides not to execute the command (and no IRQ activity is involved). 3. The NAND core calls waitfunc() and waits for the dev_ready completion, which will never end since the device _is_ already ready. Tested-by: -
Rashika Kheria authored
This patch marks the function is_erased() as static in denali.c because it is not used outside this file. This patch elimiates the following warning in nand/denali.c: drivers/mtd/nand/denali.c:900:6: warning: no previous prototype for ‘is_erased’ [-Wmissing-prototypes] Signed-off-by:
Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
-
Rashika Kheria authored
This patch marks the functions do_write_buffer() and do_erase_oneblock() as static because because they are not used outside this file. It also removes the unused function word_program() in lpddr/lpddr_cmds.c. Thus, it also removes the following warnings in lpddr/lpddr_cmds.c: drivers/mtd/lpddr/lpddr_cmds.c:391:5: warning: no previous prototype for ‘do_write_buffer’ [-Wmissing-prototypes] drivers/mtd/lpddr/lpddr_cmds.c:472:5: warning: no previous prototype for ‘do_erase_oneblock’ [-Wmissing-prototypes] drivers/mtd/lpddr/lpddr_cmds.c:751:5: warning: no previous prototype for ‘word_program’ [-Wmissing-prototypes] Signed-off-by:
-
Brian Norris authored
This driver doesn't need its own custom chip->write_page callback; the only "custom" requirement is that this driver does not support subpage writes, which we can avoid using the NAND_NO_SUBPAGE_WRITE flag. With NAND_NO_SUBPAGE_WRITE, the default routine (nand_write_page()) should perform the equivalent operations. Signed-off-by:
Roland Stigge <stigge@antcom.de> Tested-by:
-
Ivan Khoronzhuk authored
The TI AEMIF driver registers are used to setup timings for each chip select. The same registers range is used to setup NAND settings. The AEMIF and NAND drivers not use the same registers in this range. In case with TI AEMIF driver, the memory address range is requested already by AEMIF, so we cannot request it twice, just ioremap. Acked-by:
Santosh Shilimkar <santosh.shilimkar@ti.com> Reviewed-by:
Grygorii Strashko <grygorii.strashko@ti.com> Reviewed-by:
Taras Kondratiuk <taras@ti.com> Signed-off-by:
Ivan Khoronzhuk <ivan.khoronzhuk@ti.com> Signed-off-by:
-
Ivan Khoronzhuk authored
The Keystone arch has compatible nand device, so reuse it. In case with Keystone it depends on TI_AEMIF because AEMIF driver is responsible to set timings. See http://www.ti.com/lit/ug/sprugz3a/sprugz3a.pdfReviewed-by:
-
Ivan Khoronzhuk authored
The properties davinci-ecc-mode, davinci-nand-use-bbt, davinci-nand-buswidth are MTD generic. Correct names for them are: nand-ecc-mode, nand-on-flash-bbt, nand-bus-width accordingly. So rename them in dts and documentation. Reviewed-by:
-
Ivan Khoronzhuk authored
Extend bindings for davinci_nand driver to be more clear. This is clarification only, without semantic changes. Reviewed-by:
-
Ivan Khoronzhuk authored
Move bindings under mtd. Do this in order to make davinci-nand driver usable by keystone architecture. Acked-by:
-
Ivan Khoronzhuk authored
There is not needed to use a lot of names for err handling. It complicates code support and reading. Acked-by:
-
Ivan Khoronzhuk authored
The property "ti,davinci-chipselect" is required. So we have to check if it is set. Reviewed-by:
-
Ivan Khoronzhuk authored
In case when memory allocation is failed the driver should return ENOMEM instead of ENODEV. Reviewed-by:
-
Ivan Khoronzhuk authored
When kernel is booted using DT, there is no guarantee that Davinci NAND device has been created already at the time when driver init function is executed. Therefore, platform_driver_probe() can't be used because this may result the Davinci NAND driver will never be probed. The driver probing has to be made with core mechanism. Acked-by:
-
Wei Yongjun authored
Add missing platform_set_drvdata() in au1550nd_probe(), otherwise calling platform_get_drvdata() in remove returns NULL. Signed-off-by:
Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by:
-
Wei Yongjun authored
clock source is prepared and enabled by clk_prepare_enable() in mxcnd_probe() function, but no disable/unprepare in mxcnd_remove(). Signed-off-by:
-
Ezequiel Garcia authored
Since the of_mtd header provides dummy stubs for !CONFIG_OF, it's safe to remove the #ifdef CONFIG_OF. Build tested only. Signed-off-by:
-
Ezequiel Garcia authored
Add the pxa3xx-nand driver which supports PXA3xx and Armada 370/XP SoC family to MAINTAINERS to ensure I get proper Cc on patches. Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by:
-
Brian Norris authored
While we're at it, change the git URL to remove the version legacy. It's been a symlink to linux-mtd.git for a while now anyway. Signed-off-by:
-
Jingoo Han authored
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by:
-
Laurent Pinchart authored
This simplifies error and cleanup code paths. Cc: David Woodhouse <dwmw2@infradead.org> Cc: linux-mtd@lists.infradead.org Signed-off-by:
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by:
-
Laurent Pinchart authored
Cast pointers to uintptr_t instead of unsigned int. This fixes warnings on platforms where pointers have a different size than int. Cc: David Woodhouse <dwmw2@infradead.org> Cc: linux-mtd@lists.infradead.org Signed-off-by:
-
Laurent Pinchart authored
This helps increasing build testing coverage. Cc: David Woodhouse <dwmw2@infradead.org> Cc: linux-mtd@lists.infradead.org Signed-off-by:
Simon Horman <horms@verge.net.au> Signed-off-by:
-
Axel Lin authored
register_mtd_parser never fails; hence make it return void. Signed-off-by:
Axel Lin <axel.lin@ingics.com> Signed-off-by:
-
Axel Lin authored
deregister_mtd_parser never fails; hence make it return void. Signed-off-by:
-
Zhouyi Zhou authored
NULL return of kmem_cache_zalloc should be handled in jffs2_alloc_xattr_datum and jff2_alloc_xattr_ref. Signed-off-by:
Zhouyi Zhou <yizhouzhou@ict.ac.cn> Signed-off-by:
-
Ezequiel Garcia authored
Add a nice "nand:" prefix to all pr_xxx() messages. This allows to get rid of the "NAND" words in messages, given the context is already given by the prefix. Remove the __func__ report from messages where it's not needed and refactor the device detection messages to show itself in several lines. Signed-off-by:
-
Fabio Estevam authored
Using the IS_ENABLED() macro can make the code shorter and simpler. Signed-off-by:
Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by:
-
Axel Lin authored
Use new ATTRIBUTE_GROUPS macro to declare attribute groups. Signed-off-by:
-
Igor Grinberg authored
Add support for Micron m25px16 spi flash chip. Signed-off-by:
Igor Grinberg <grinberg@compulab.co.il> Signed-off-by:
-
Fabio Estevam authored
clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by:
-
Michael Grzeschik authored
The ecc_stats.corrected count variable will already be incremented in the above framework-layer just after this callback. Cc: stable@vger.kernel.org # 2.6.36+ Signed-off-by:
Michael Grzeschik <m.grzeschik@pengutronix.de> Signed-off-by:
-
Philipp Rosenberger authored
It seems the include guard was copied from of_net.h. Signed-off-by:
Philipp Rosenberger <philipp.rosenberger@xse.de> Signed-off-by:
-
Brian Norris authored
s/strenght/strength/ This field isn't used anywhere, so this rename is safe. Signed-off-by: -
Jingoo Han authored
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by:
-
Wei Yongjun authored
The devm_request_irq function allocates irq that is released when a driver detaches. Thus, there is no reason to explicitly call devm_free_irq in probe or remove functions. Signed-off-by:
-
Huang Shijie authored
change all the pr_debug to dev_dbg. Signed-off-by:
Huang Shijie <b32955@freescale.com> Signed-off-by:
-
