- 02 Aug, 2018 37 commits
-
-
John Whitmore authored
Rename the structure octet_string's member variables Octet to octet and Length to length. This change clears the checkpatch issue with CamelCase naming of variables. This is purely a coding style change which should have no impact on runtime code execution. Signed-off-by:
John Whitmore <johnfwhitmore@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
John Whitmore authored
Rename the structure OCTET_STRING to octet_string. This is to comply with the coding style of using lowercase for types. In addition the typedef directive is removed to clear the checkpatch issue with defining new types. These are coding style changes which should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
Move the union QOS_TCLAS from the header file rtl819x_Qos.h to header file rtl819x_TS.h, where the structure is actually used, as the member of another structure. This is a coding style change, which should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
A number of structures have been commented out of code. Obviously they are not used and as a result have been removed from the code. This is a coding style change which should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
The member variables of the tspec_body have been renamed to clear the checkpatch issue with CamelCase naming. As these member variables are never used in the code the changes are combined into this single patch. These changes are coding style changes which should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
Rename TSInfo, the memeber variable of struct tspec_body to ts_info. This change clears the checkpatch issue with CamelCase naming. This is a coding style change which should not impact runtime code execution. Signed-off-by:
-
John Whitmore authored
The union TSPEC_BODY is never used as a union. The union comprises an array of bytes and a bitfield structure, both of which are 55 bytes in length, but the byte array is never used. As a result the union has been truncated to the bitfield struct, which is actually used. Additionally the typedef has been removed from the structure to clear the checkpatch issue with defining new types. Additionally the name has been changed to lowercase to comply with coding style. These changes are all coding style changes which should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
The member variables of struct qos_tsinfo all cause checkpatch issues with CamelCase naming. As the variables are used in so few places the changes are combined into this single patch. Additionally the member variable usReserved is never used in code so has been removed. These are all coding style changes which should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
The union is never used as a union but only as a bitfield struct. One side of the union (u8 charData[3];) Only seems to be present to ensure that the structures size is 3 bytes in length. That length, of the structure is dictated by the largest element of the union, so the byte array only dictates size if it's the largest element of the union. The byte array and union add nothing. The union has therefore been removed and the structure and access to the structure simplified. Additionally since one of the bitfield variables (ucAccessPolicy) spans a byte boundary the base type of the bitfield has been changed from u8 to u16. Compilers have probably moved on from having an issue with this, call it OCD. The changes are coding style in nature and should not impact runtime code execution. Signed-off-by:
-
John Whitmore authored
The union aci_aifsn is not used as a union, but only as a struct. The union seems to have been used to ensure that the size of the structure was only a single byte. That size is set by the bitfield structure, adding a union with an unused byte adds nothing. The union has been removed. This is a coding style change and should not impact runtime code execution. Signed-off-by:
-
John Whitmore authored
The only useful piece of information in the header comment of this static function was the name of the function and parameters. That is not useful information, given that they are in the C Source of the function declaration, a few lines below the comment. The block comment has been removed. This is a coding style change, there should be no impact on runtime code execution. Signed-off-by:
-
Michael Straube authored
Rename source and header file to avoid CamelCase. odm_RTL8188E.c -> odm_rtl8188e.c odm_RTL8188E.h -> odm_rtl8188e.h Signed-off-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
Michael Straube authored
The function rtw_remove_bcn_ie() is never used, so remove it. Discovered by cppcheck. Signed-off-by:
-
Michael Straube authored
The function rtw_add_bcn_ie() is never used, so remove it. Discovered by cppcheck. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses to improve readability. Signed-off-by:
-
Michael Straube authored
Use x instead of x != NULL. Use !x instead of x == NULL. Signed-off-by:
-
Michael Straube authored
Fix indentation to clear checkpatch warnings. WARNING: suspect code indent for conditional statements Signed-off-by:
-
Michael Straube authored
Use is_broadcast_ether_addr instead of checking each byte of the address array for 0xff. Shortens the code and improves readability. As required by is_broadcast_ether_addr, the address array sta_addr is properly aligned in all uses. Thanks to Joe Perches. Signed-off-by:
-
Michael Straube authored
Use is_multicast_ether_addr instead of custom IS_MCAST. The variable for the result of IS_MCAST was only used in the if conditional. So remove the extra variable and move the call to is_multicast_ether_addr into the conditional. Signed-off-by:
-
Ioana Radulescu authored
File net.h contains definitions that are exclusively used by the key generator/classification API. Merge its contents with dpkg.h in order to reduce the number of private headers. Signed-off-by:
Ioana Radulescu <ruxandra.radulescu@nxp.com> Signed-off-by:
-
Ioana Radulescu authored
File net.h has several bitmask defines that could be implemented more clearly using the BIT() macro. Signed-off-by:
-
Ioana Radulescu authored
File net.h contains unused defines, so remove them. Signed-off-by:
-
Ioana Radulescu authored
Comments in file net.h are too fancy for their own good, so convert them to the regular format. Signed-off-by:
-
Ioana Ciornei authored
The DPAA2 Ethernet driver files use a GPL-2.0+ OR BSD-3-Clause license. Add SPDX tags and delete the full license text, keeping the existing licenses for each file. Add a GPL-2.0 tag for the Makefile. Signed-off-by:
Ioana Ciornei <ioana.ciornei@nxp.com> Signed-off-by:
-
Ioana Ciornei authored
Convert the DPAA2 Ethernet driver documentation to .rst format and rename the file accordingly. Also add a SPDX tag to the new rst file. Signed-off-by:
-
Ajay Singh authored
This patch fixes the sparse warnings by making use of le32_to_cpus() & cpu_to_le32s() conversion API's. Remove the unnecessary byte-order conversion in wilc_wlan_parse_response_frame() as the data is copied using individual byte operation. Also added the byte-order conversion for 'header' in wilc_wfi_monitor_rx() & wilc_wfi_p2p_rx() as received in LE byte-order. The link [1] contains the details of discussion related to this patch. [1]. https://patchwork.kernel.org/patch/10436791/Signed-off-by:
Ajay Singh <ajay.kathat@microchip.com> Signed-off-by:
-
Ajay Singh authored
Cleanup patch to use the correct data type 'u16' for keeping the WID value in 'wilc_cfg_word' & 'wilc_cfg_str' structure. Signed-off-by:
-
Ajay Singh authored
Refactor wilc_wlan_handle_isr_ext() to avoid the use of the goto label. Also avoid the unnecessary NULL check for 'wilc->rx_buffer' and calling wilc_wlan_handle_rxq() only after wilc_wlan_rxq_add() call. The link [1] contains details for discussion related to this changes. [1]. https://patchwork.kernel.org/patch/10533601/Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Ajay Singh authored
Cleanup patch to use shorter name for 'rcvd_ch_cnt' to 'ch_cnt' to avoid line over 80 character issue reported by checkpatch. Signed-off-by:
-
Ajay Singh authored
Added comments for 'hif_cs' mutex to avoid checkpatch.pl reported issues. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to update the debug logs message to provide correct information. Also added the function name tag for same description log to help identify the place from where log was captured. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove the unnecessary comments and commented code. Also updated description for few of comments. Signed-off-by:
-
Ajay Singh authored
Changes to compile module component along with SPI and SDIO module. Previously 'wilc1000.ko' used to generate along with wilc-spi.ko or wilc1000-sdio.ko module. After these changes only wilc1000-spi.ko or wilc1000-sdio.ko modules are required for SPI and SDIO respectively. These changes are done to address below TODO item. - make SPI and SDIO components coexist in one build Signed-off-by:
-
Steve Longerbeam authored
Adds crtc page-flip support by passing the new requested framebuffer to vbox_crtc_do_set_base(). Note there is no attempt to support vblank interrupts, it's not not known how to do this in VBOX or if it is even possible. Since this page-flip implementation does not try to sync the page-flip to vertical blanking, tearing effects are possible. Signed-off-by:
Steve Longerbeam <steve_longerbeam@mentor.com> Signed-off-by:
-
Steve Longerbeam authored
This modifies vbox_crtc_do_set_base() to take a new framebuffer to be activated, instead of the existing framebuffer attached to the crtc. This change allows the function to be given the new framebuffer from a page-flip request. Signed-off-by:
-
Ivan Bornyakov authored
Add handling of possible allocation failure. Reported by smatch: drivers/staging/gasket/gasket_sysfs.c:105 put_mapping() error: potential null dereference 'files_to_remove'. (kcalloc returns null) Signed-off-by:
Ivan Bornyakov <brnkv.i1@gmail.com> Signed-off-by:
-
Greg Kroah-Hartman authored
Merge tag 'iio-for-4.19c' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next Jonathan writes: Third set of IIO new device support, cleanups and features for the 4.19 cycle. This is a somewhat sneaky late pull request given Linus has announced a likely 1 week delay. If it is too late I'll resend after the merge window. I merged in the fixes branch as those are primarily around things queued for the merge window. Particulary good to see the output of our Himanshu Jha, a GSOC student who developed the bme680 driver. New device support: * bme680 gas sensor (with temperature, humidity and pressure) - new driver to support this device * vcn4000 - support vcnl4200 (lots of rework to allow this) - ids added for VCNL4010 and VCNL4020 sensors New features: * ad9523 - support the various external signal options via gpios. Cleanups and fixes * ad_sigma_delta - unsigned long for a timeout. * ad9523 - fix a wrong return value that was indicating successful write failed and might lead to an infinite loop. * si1133 - fix an impossible test. - fix an uninitialsed variable by reading from the device in all paths. * xilinx xadc - check for return values in clk related functions - limit the pcap clock frequency to supported ranges. - stash the irq to avoid calling platform_get_irq from the remove path. - ensure the irq is actually requested before we enable the hardware to output it.
-
- 01 Aug, 2018 3 commits
-
-
Todd Poynor authored
The include guard symbol for gasket_page_table.h is out-of-date. Signed-off-by:
Todd Poynor <toddpoynor@google.com> Signed-off-by:
-
Todd Poynor authored
gasket_free_dev() is called only from driver PCI probe and remove function. It is guaranteed that that pci_dev structure is not going anywhere during that time; there is no need to take this additional reference. This reverts commit dd9d1502. Reported-by:
Dmitry Torokhov <dtor@chromium.org> Signed-off-by:
-
Todd Poynor authored
When gasket core was converted from using capable() to use ns_capable() instead, the type of the variable holding the result should have been converted from int to bool. Reported-by:
-
