- 08 Dec, 2011 24 commits
-
-
Jonathan Cameron authored
No obvious usecase and complicates in kernel interface work. Signed-off-by:
Jonathan Cameron <jic23@kernel.org> Acked-by:
Lars-Peter Clausen <lars@metafoo.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Jonathan Cameron authored
Legacy of having multiple chrdevs that never got cleaned up. Signed-off-by:
-
Jonathan Cameron authored
Obviously drivers should only use this for pushing to buffers. They need buffer->scan_mask for pulling from them post demux. Signed-off-by:
Jonathan Cameron <jic23@cam.ac.uk> Acked-by:
-
Jonathan Cameron authored
These callbacks should not be buffer instance specific. Hence move them out of the buffer. Signed-off-by:
-
Jonathan Cameron authored
There are no known reasons why userspace should want this value. It can be established from the buffer description anyway. Signed-off-by:
-
Jonathan Cameron authored
Has no remaining users. Signed-off-by:
-
Jonathan Cameron authored
Kind of obvious for this device but useful for testing purposes. Signed-off-by:
-
Jonathan Cameron authored
This allows for matching against the name given on a datasheet, however silly/inconsistent it might be. Useful for in kernel interfaces. Signed-off-by:
-
Jonathan Cameron authored
Also, the differential channels should always have been signed. Signed-off-by:
-
Jonathan Cameron authored
Signed-off-by:
-
Jonathan Cameron authored
This gives you only what you ask for which is handy for some devices with weird scan combinations. Routes all data flow through a core utility function. That and this demuxing support will be needed to do demuxing to multiple destinations in kernel. Signed-off-by:
-
Jonathan Cameron authored
Also introduces active_scan_mask storage to tell the core what is really being currently captured from the device (different from what is desired as often has bonus channels). Signed-off-by:
-
Jonathan Cameron authored
Signed-off-by:
-
Jonathan Cameron authored
Basically avoids looking it up lots of times. Signed-off-by:
-
Jonathan Cameron authored
Useful for getting to the channel based on scan mask alone. Signed-off-by:
-
Lars-Peter Clausen authored
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver() so we can drop the manual assignment. The patch was generated using the following coccinelle semantic patch: // <smpl> @@ identifier _driver; @@ struct spi_driver _driver = { .driver = { - .bus = &spi_bus_type, }, }; // </smpl> Signed-off-by: -
Lars-Peter Clausen authored
This patch adds support for the Analog Devices D5380, AD5381, AD5382, AD5383, AD5384, AD5390, AD5391, AD5392 multi-channel Digital to Analog Converters. Signed-off-by:
-
Lars-Peter Clausen authored
This patch adds support for the Analog Devices AD5764, AD5764R, AD5744, AD5744R quad channel analog-to-digital converter. Signed-off-by:
-
Jonathan Cameron authored
Previously timestamps were always on in this driver. Signed-off-by:
-
Jonathan Cameron authored
Signed-off-by:
-
Jonathan Cameron authored
Eating the endian description for now. Signed-off-by:
-
Bryan Freed authored
When illuminance0_calibbias gets 4000 (for a 4x multiplier), we see lux granularity of 4. Reversing the order of the right shift and multiplication retains the precision of the unadjusted lux value. Signed-off-by:
Bryan Freed <bfreed@chromium.org> Acked-by:
-
Andreas Ruprecht authored
In sca3000_store_measurement_mode() we use val to and it with a mask. This mask is only two bits long (as we are only interested in the lowest two bits), so a value bigger than 3 was silently ignored so far. Now this function will return -EINVAL, if val is bigger than 3. Signed-off-by:
Andreas Ruprecht <rupran@einserver.de> Acked-by:
-
Andreas Ruprecht authored
In sca3000_store_measurement_mode() we parse a value from a string buffer via kstrtou8, and store the parsed value into a u8 after and-ing it with mask. As we are only interested in the lowest two bits here and mask is initialized with a fixed value 0x03, mask may as well be a u8. Signed-off-by:
-
- 01 Dec, 2011 16 commits
-
-
Greg Kroah-Hartman authored
Hank is no longer at Microsoft, so remove his email address as it bounces. Cc: KY Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
This removes the hv_mouse driver as it's now in Jiri's HID tree in the "proper" place. Cc: KY Srinivasan <kys@microsoft.com> Cc: Jiri Kosina <jikos@jikos.cz> Signed-off-by: -
Martyn Welch authored
The use of typedefs is discouraged, remove them. Signed-off-by:
Martyn Welch <martyn.welch@ge.com> Signed-off-by:
-
K. Y. Srinivasan authored
The current code implemented a per-HBA memory pool mechanism. For IDE disks managed by this driver, there is a one to one correspondance between the block device and the associated virtual HBA and since currently only IDE devices can be the boot device, this addressed the deadlock issues that were raised during the review process. This patch implements a per-lun memory pool mechanism. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
-
K. Y. Srinivasan authored
Fix a bug in copy_from_bounce_buffer(). Signed-off-by:
-
K. Y. Srinivasan authored
Fix a bug in storvsc_command_completion() that leaks memory when scatter/gather lists are used on the "write" side. Signed-off-by:
-
K. Y. Srinivasan authored
The code in storvsc_device_alloc() is not needed as this would be done by default. Get rid of it. We still keep the function as we use this hook to allocate per-LUN memory pools in a later patch. Signed-off-by:
-
K. Y. Srinivasan authored
Disable clustering, since the host side on Hyper-V requires that each I/O element not exceed the page size. As part of this cleanup, get rid of the function to merge bvecs, as the primary reason for this function was to avoid having an element exceed the page size. Signed-off-by:
-
Haiyang Zhang authored
Add code to accept promiscuous mode setting, and pass it to RNDIS filter. Signed-off-by:
-
Haiyang Zhang authored
Signed-off-by:
-
Dan Carpenter authored
"line6" hasn't been set at this point and we should be using &interface->dev instead. Gcc would have complained about this if it weren't for the fact that we initialized line6 to NULL. I removed the initialization. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Stefan Hajnoczi <stefanha@gmail.com> Signed-off-by:
-
K. Y. Srinivasan authored
We need to properly add the hid device to correctly initialize the sysfs state. While this patch is against the staging tree; Jiri, please pick up this patch as you merge the Hyper-V mouse driver. Signed-off-by:
Fuzhou Chen <fuzhouch@microsoft.com> Signed-off-by:
-
Mathieu Desnoyers authored
* Dan Carpenter <dan.carpenter@oracle.com> wrote: > Sparse complains that these signed bitfields look "dubious". The > problem is that instead of being either 0 or 1 like people would expect, > signed one bit variables like this are either 0 or -1. It doesn't cause > a problem in this case but it's ugly so lets fix them. * walter harms (wharms@bfs.de) wrote: > hi, > This patch looks ok to me but this design is ugly by itself. > It should be replaced by an uchar uint whatever or use a > real bool (obviously not preferred by this programmes). bool :1, uchar :1 or uint :1 could make sense. uchar:1/bool:1 won't save any space here, because the surrounding fields are either uint or pointers, so alignment will just add padding. I try to use int/uint whenever possible because x86 CPUs tend to get less register false-dependencies when using instructions modifying the whole register (generated by using int/uint types) rather than only part of it (uchar/char/bool). I only use char/uchar/bool when there is a clear wanted space gain. The reason why I never use the bool type within a structure when I want a compact representation is that bool takes a whole byte just to represent one bit: struct usebitfield { int a; unsigned int f:1, g:1, h:1, i:1, j:1; int b; }; struct usebool { int a; bool f, g, h, i, j; int b; }; struct useboolbf { int a; bool f:1, g:1, h:1, i:1, j:1; int b; }; int main() { printf("bitfield %d bytes, bool %d bytes, boolbitfield %d bytes\n", sizeof(struct usebitfield), sizeof(struct usebool), sizeof(struct useboolbf)); } result: bitfield 12 bytes, bool 16 bytes, boolbitfield 12 bytes This is because each bool takes one byte, while the bitfields are put in units of "unsigned int" (or bool for the 3rd struct). So in this example, we need 5 bytes + 3 bytes alignment for the bool, but only 4 bytes to hold the "unsigned int" unit for the bitfields. The choice between bool and bitfields must also take into account the frequency of access to the variable, because bitfields require mask operations to access the selected bit(s). You will notice that none of these bitfields are accessed on the tracing fast-path: only in slow-paths. Therefore, space gain is more important than speed here. One might argue that I have so few of these fields here that it does not make an actual difference to go for bitfield or bool. I am just trying to choose types best suited for their intended purpose, ensuring they are future-proof and will allow simply adding more fields using the same type, as needed. So I guess I'll go for uint :1. Reported-by:Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Acked-by:
-
Mathieu Desnoyers authored
Needed to keep bissectability. Signed-off-by:
-
Mathieu Desnoyers authored
* Dan Carpenter <dan.carpenter@oracle.com> wrote: > The patch c844b2f5: "lttng lib: ring buffer" from Nov 28, 2011, > leads to the following Smatch complaint: > > drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c +86 > +lib_ring_buffer_mmap_buf() > warn: variable dereferenced before check 'buf' (see line 79) > > drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c > 78 unsigned long length = vma->vm_end - vma->vm_start; > 79 struct channel *chan = buf->backend.chan; > ^^^^^^^^^^^^^^^^^ > Dereference. > > 80 const struct lib_ring_buffer_config *config = chan->backend.config; > 81 unsigned long mmap_buf_len; > 82 > 83 if (config->output != RING_BUFFER_MMAP) > 84 return -EINVAL; > 85 > 86 if (!buf) > ^^^^ > Check. > > 87 return -EBADF; > 88 Let's move the NULL buf check to the file "open", where it belongs. The "open" file operation is the actual interface between lib ring buffer and the modules using it. Reported-by:
-
Mathieu Desnoyers authored
* Dan Carpenter <dan.carpenter@oracle.com> wrote: > The patch c844b2f5: "lttng lib: ring buffer" from Nov 28, 2011, > leads to the following Smatch complaint: > > drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c +33 > +lib_ring_buffer_fault() > warn: variable dereferenced before check 'buf' (see line 26) > > drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c > 25 struct lib_ring_buffer *buf = vma->vm_private_data; > 26 struct channel *chan = buf->backend.chan; > ^^^^^^^^^^^^^^^^^ > Dereference. > > 27 const struct lib_ring_buffer_config *config = chan->backend.config; > 28 pgoff_t pgoff = vmf->pgoff; > 29 struct page **page; > 30 void **virt; > 31 unsigned long offset, sb_bindex; > 32 > 33 if (!buf) > ^^^^ > Check. > > 34 return VM_FAULT_OOM; > 35 This check is performed at mapping setup time in lib_ring_buffer_mmap_buf() already, so we can safely remove this duplicata. Reported-by:
-
