- 29 Jun, 2017 7 commits
-
-
Gilad Ben-Yossef authored
Fix mismatched braces between if and else. Signed-off-by:
Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Gilad Ben-Yossef authored
Fix several cases of needless braces around single statement blocks. Signed-off-by:
-
Gilad Ben-Yossef authored
Remove redundant blank lines in brace blocks Signed-off-by:
-
Gilad Ben-Yossef authored
Fix cases where the else clause was not located correctly after the if brace. Signed-off-by:
-
Gilad Ben-Yossef authored
Fix cases in ccree where explicit comparsion to true/false was made. Signed-off-by:
-
Gilad Ben-Yossef authored
Add and/or remove redundant and/or missing spaces in ccree source Signed-off-by:
-
Dhananjay Balan authored
Start holding the lock for all cases irrespective of number of fb, there could be a deadlock since this number could change in the lifetime of this lock Signed-off-by:
Dhananjay Balan <mail@dbalan.in> Signed-off-by:
-
- 27 Jun, 2017 3 commits
-
-
Okash Khawaja authored
This patch introduces new module parameter, dev, which takes a string representing the device that the external synth is connected to, e.g. ttyS0, ttyUSB0 etc. This is then used to communicate with the synth. That way, speakup can support more than ttyS*. As of this patch, it only supports ttyS*, ttyUSB* and selected synths for lp*. dev parameter is only available for tty-migrated synths. Users will either use dev or ser as both serve same purpose. This patch maintains backward compatility by allowing ser to be specified. When both are specified, whichever is non-default, i.e. not ttyS0, is used. If both are non-default then dev is used. Signed-off-by:
Okash Khawaja <okash.khawaja@gmail.com> Reviewed-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Reviewed-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by:
-
Okash Khawaja authored
This patch adds functionality to validate and convert either a device name or 'ser' memmber of synth into dev_t. Subsequent patch in this set will call it to convert user-specified device into device number. For device name, this patch does some basic sanity checks on the string passed in. It currently supports ttyS*, ttyUSB* and, for selected synths, lp*. The patch also introduces a string member variable named 'dev_name' to struct spk_synth. 'dev_name' represents the device name - ttyUSB0 etc - which needs conversion to dev_t. Signed-off-by:
-
Okash Khawaja authored
The function converts strings like ttyS0 and ttyUSB0 to dev_t like (4, 64) and (188, 0). It does this by scanning tty_drivers list for corresponding device name and index. If the driver is not registered, this function returns -ENODEV. It also acquires tty_mutex. Signed-off-by:
-
- 26 Jun, 2017 14 commits
-
-
Greg Kroah-Hartman authored
This reverts commit bb4a64b7. The whole series is broken, so back it all out. Reported-by:
kbuild test robot <fengguang.wu@intel.com> Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com> Signed-off-by:
-
Greg Kroah-Hartman authored
This reverts commit c6ce019e. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit 48d3cfb3. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit be6faff7. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit 10a8593a. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit b32cdde1. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit 7eba570e. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit af437671. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit b065307f. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit 5776aad3. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit 7d6e221d. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit 9b1aa455. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
This reverts commit 1877e4ba. The whole series is broken, so back it all out. Reported-by:
-
Greg Kroah-Hartman authored
Merge tag 'iio-for-4.13b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next Jonathan writes: Second set of IIO new device support, features and cleanups for the 4.13 cycle. A few reverts here. One was a general failure to notice a device was already supported by another driver. The second is due to a review comment pointing out that the original patch was a bad idea and would break existing systems. Reverts * bma180 - Revert addition of support for the BMA250E it is already supported by the bmc150-accel and better supported at that. Oops. * hi8435 - The fix for cleanup of the reset gpio stuff isn't a good way to go. It breaks systems where an inverting level convertor is used. The right fix is to make the original devicetree correct - even if it involves patching the devicetree in kernel. New Device Support * stm32-adc - STM32H7 support and bindings. Features * core - add a hardware triggered operating mode for systems in which the actual trigger is never seen by the kernel. This is typically only used when a device 'can' use other triggers, but if a particular magic one is enabled the interrupt is effectively handled in hardware and we never see it. * st-lsm6dsx - support active low interrupts. * stm32-adc - Make the core adc clock optional as not all hardware supported requires it. - Make the bus clock optional in the per instance driver as it may be shared by all instances of the ADC and is handled by the core. - Rework to have a data structure representing the device type specific elements. * stm32-trigger (and counter) - Use the INDIO_HARDWARE_TRIGGERED_MODE where appropriate. - Add an attribute to configure device modes for quadrature counting etc. Clean ups and minor fixes * IIO core. - use __sysfs_match_string() helper rather than open coding the same. * ad7791 - use sysfs_match_string() helper rather than open coding the same. * aspeed-adc - handle return value of clk_prepare_enable * cpcap - Fix default register values and ensure the battery thermistor is enabled correctly. - Fix the reported die temperature where we can - docs are lacking. - Remove the hung interrupt quirk as no longer happens due to fix in the mfd driver. * hi8435 - Remove &s from hi8435_info definition as unneeded and inconsistent. * hid-sensor-trgger - Add kconfig depends on IIO_BUFFER (fixes patch in previous series) * ina2xx - Make the use of iio_info_mask* elements consistent for all channels. This doesn't have any visible effect, but acts as clear documentation of which channels various resulting attributes apply to. * lpc32xx - handle the return value of clk_prepare_enable. * meson-saradc - NULL instead of 0 for pointer. * mma9551 - use NULL for GPIO connection ID to aid implementation fo ACPI support. Here the connection ID doesn't actually tell us anything and it is much easier to deal with the driver if it's not there. * mpu6050 - Fix lock issues through use of a local mux. - Replace sprintf with scnprintf as appropriate. - Check whoami against all known values. This allows for a small number of boards where we are really fishing for the part not being present at all. It is unfortunately common to have undescribed changes to use newer chips. We paper over this but just emitting a warning for those cases as long as we know about. * mxs-lradc - Fix some non static warnings. * rcar-adc - Part of making the naming for this part consistent across the kernel. * st_accel - drop some spi_device_id entries for variants with no SPI support * st_magn - drop some spi_device_id entries for variants with no SPI support. * sx9500 - Use devm_gpiod_get instead of indexed value with an index of 0 on all occasions. * twl4030 - Drop unused twl4030_get_madc_conversion as callers removed now throughout kernel. - Unexport twl4030_madc_conversion() as no used only within this driver. - Drop twl4030_madc_user_params as not used now. - Drop twl4030_madc_request.func_cb as not used now. - Fold the twl4030-madc.h header into the driver as no longer used anywhere else in the kernel. * xilinx - Handle the return value of clk_prepare_enable
-
- 25 Jun, 2017 15 commits
-
-
Okash Khawaja authored
This patch adds definition of tty_open_by_driver when CONFIG_TTY is not defined. This was supposed to have been included in commit 12e84c71 ("tty: export tty_open_by_driver"). The patch follows convention for other such functions and returns NULL. Signed-off-by:
-
Okash Khawaja authored
synths[] array caches currently loaded synths. synth_add checks synths[] before adding a new one. It however ignores the result of do_synth_init. So when do_synth_init fails, the failed synth is still cached. Since, as a result module loading fails too, synth_remove - which is responsible for removing the cached synth - is never called. Next time the failing synth is added again it succeeds because synth_add finds it cached inside synths[]. This patch fixes this by caching a synth only after do_synth_init succeeds. Signed-off-by:
-
Jaya Durga authored
CHECK: Macro argument reuse 'pframe' - possible side-effects? Convert get_tofr_ds macro to inline functions to fix checkpatch check Signed-off-by:
Jaya Durga <rjdurga@gmail.com> Signed-off-by:
-
Derek Robson authored
Fix checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name" in header files. Signed-off-by:
Derek Robson <robsonde@gmail.com> Signed-off-by:
-
Derek Robson authored
Fixed checkpatch.pl warnings of "function definition argument FOO should also have an identifier name" Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed checkpatch.pl warnings of the form "function definition argument 'foo' should also have an identifier name" in header files. Signed-off-by:
-
Derek Robson authored
Fixed checkpatch warnings "Use #include <linux/FOO> instead of <asm/FOO>" Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of permissions to octal. Found using checkpatch Signed-off-by:
-
Galo Navarro authored
Fix multiple style issues (CHECK spaces preferred around that $operator). Signed-off-by:
Galo Navarro <anglor@varoa.net> Signed-off-by:
-
Gilad Ben-Yossef authored
We were waiting for a completion notification of HW DMA operation using an interruptible wait which can result in data corruption if a signal interrupted us while DMA was not yet completed. Fix this by moving to uninterrupted wait. Fixes: abefd674 ("staging: ccree: introduce CryptoCell HW driver"). Signed-off-by:
-
Gilad Ben-Yossef authored
The ccree driver has build time configurable support to work on top of coherent (e.g. ACP) vs. none coherent bus connections. Turn it to run-time configurable option based on device tree. Signed-off-by:
-
Gilad Ben-Yossef authored
Some SoC which implement CryptoCell have a dedicated clock tied to it, some do not. Implement clock support if exists based on device tree data and tie power management to it. Signed-off-by:
-
Gilad Ben-Yossef authored
The function set_ack_last was not used anywhere. Remove it. Signed-off-by:
-
Gilad Ben-Yossef authored
The original ccree driver was registering a useless setkey method even for non-MAC hash transformations. Somewhere around v4.9 a check was added that failed hash operations if a setkey method was registered but was not called, so during the initial upstream port code was added to only register the setkey method for MAC type hash transform. Unfortunately, the ccree driver also registers non-hash based MAC transforms and the code had a logic error that stopped it registering a setkey callback even for those, thus rendering them useless. This commit fixes the logic mistake, thus correctly registering a setkey method only for MAC transformations, leaving it out for non-MAC ones, whether they are hash based on not. Fixes: 50cfbbb7 ("staging: ccree: add ahash support"). Signed-off-by:
-
Gilad Ben-Yossef authored
Hash import and export was saving and restoring the wrong context and therefore disabled. Fix it by restoring intermediate digest and additional state needed. The hash and mac transform now pass testmgr partial hash tests. Signed-off-by:
-
- 23 Jun, 2017 1 commit
-
-
Suniel Mahesh authored
le16_to_cpu() accepts argument of type __le16 and cpu_to_le16() returns an argument of type __le16. This patch fixes: (a) the type of the variable that end's up getting return from cpu_to_le16(). (b) the member types of struct hfa384x_host_scan_request_data, struct hfa384x_bytestr32 and struct hfa384x_hscan_result_sub. The following type mismatch warnings reported by sparse have been fixed: warning: incorrect type in assignment (different base types) warning: cast to restricted __le16 Signed-off-by:Suniel Mahesh <sunil.m@techveda.org> Signed-off-by:
-
