- 19 Dec, 2011 7 commits
-
-
git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetoothGustavo F. Padovan authored
Conflicts: net/bluetooth/l2cap_core.c
-
Johan Hedberg authored
This patch adds the necessary structs for the Confirm Name command. This ensures that the protocol definitions are up to date with the latest mgmt specification. The actual implementation of the command will follow in a later patch-set. Signed-off-by:
Johan Hedberg <johan.hedberg@intel.com> Signed-off-by:
Gustavo F. Padovan <padovan@profusion.mobi>
-
Johan Hedberg authored
This patch fixes the opcodes of the Block/Unblock device commands to match with what user-space expects and to confirm with the latest mgmt specification. The reason the values were wrong was a missing Confirm Name command definition (which will be added by a subsequent patch). Signed-off-by:
-
Johan Hedberg authored
This patch adds a missing confirm_name field to mgmt_ev_device_found. Support for setting the correct value for this field is not implemented yet, but having it part of the struct definition ensures that user-space gets correct sized device_found events and is thereby able to do at least rudimentary parsing of them. Signed-off-by:
-
Gustavo F. Padovan authored
This reverts commit 4dff523a. It was reported that this patch cause issues when trying to connect to legacy devices so reverting it. Reported-by:
David Fries <david@fries.net> Signed-off-by:
-
Mat Martineau authored
When the last RFCOMM data channel is closed, a timer is normally set up to disconnect the control channel at a later time. If the control channel disconnect command is sent with the timer pending, the timer needs to be cancelled. If the timer is not cancelled in this situation, the reference counting logic for the RFCOMM session does not work correctly when the remote device closes the L2CAP connection. The session is freed at the wrong time, leading to a kernel panic. Signed-off-by:
Mat Martineau <mathewm@codeaurora.org> Acked-by:
Marcel Holtmann <marcel@holtmann.org> Signed-off-by:
-
Mat Martineau authored
When configuring an ERTM or streaming mode connection, remote devices are expected to send an RFC option in a successful config response. A misbehaving remote device might not send an RFC option, and the L2CAP code should not access uninitialized data in this case. Signed-off-by:
-
- 18 Dec, 2011 33 commits
-
-
Mat Martineau authored
Incoming sk_buffs always have bt_cb(skb)->force_active set to 0, so it's misleading to use that value from the control block when calling hci_conn_enter_active_mode() for incoming data. The destination socket is not known in the HCI layer, so the force_active setting for each socket isn't known either. Hard-coding the force_active parameter does not change any behavior, but makes it obvious that incoming ACL data never exits sniff mode. Signed-off-by:
-
Andrei Emeltchenko authored
Simplify function and remove fourth level of indentation. Signed-off-by:
Andrei Emeltchenko <andrei.emeltchenko@intel.com> Acked-by:
-
Andrei Emeltchenko authored
Implement block size read function. Use different variables for packet-based and block-based flow control. Signed-off-by:
-
Johan Hedberg authored
This patch fixes user_confirm_neg_reply to use the appropriate struct for accessing the call parameters. Signed-off-by:
-
Johan Hedberg authored
This patch updates the ordering and opcodes of mgmt messages to match the latest API specification. Signed-off-by:
-
Johan Hedberg authored
We do not want the service cache to be enabled indefinitely after mgmt_read_info is called. To solve this a timer is added which will automatically disable the cache if mgmt_set_dev_class isn't called within 5 seconds of calling mgmt_read_info. Signed-off-by:
-
Johan Hedberg authored
Due to the upcoming addition of a service cache timer the functions to update the EIR and CoD need to be higher up in mgmt.c in order to avoid unnecessary forward-declarations. This patch simply moves code around without any other changes in order to make subsequent patches more readable. Signed-off-by:
-
Johan Hedberg authored
Instead of having an explicit service cache command we can make the mgmt API simpler by implicitly enabling the cache when mgmt_read_info is called for the first time and disabling it when mgmt_set_dev_class is called. Signed-off-by:
-
Johan Hedberg authored
Fast connectable is logically after the connectable property so that's where it should show up in the code as well (it's also after connectable in the settings bitfield). Signed-off-by:
-
Johan Hedberg authored
This patch updates the mgmt_read_info and related messages to the latest management API which uses a bitfield of settings instead of individual boolean values. Signed-off-by:
-
Gustavo F. Padovan authored
Add ProFUSION's copyright to some files I've been touching recently. Signed-off-by: -
Gustavo F. Padovan authored
hdev->workqueue should be only for rx/tx, so move this one out. Acked-by:
-
Gustavo F. Padovan authored
As we run in process context now we don't need worqueue to add e del from sysfs. Acked-by:
-
Gustavo F. Padovan authored
Update hdev workqueue API usage to use the new interface, this new interface also allow us to mark this workqueue as WQ_HIGHPRI, so now rx and tx work gets higher priority when running. Acked-by:
-
Gustavo F. Padovan authored
hdev->workqueue will be only for for rx/tx/cmd processing, all other small works should go to the system workqueue for now. Acked-by:
-
Gustavo F. Padovan authored
This list has much more reads than writes, so RCU makes senses here, also it avoid deadlock against the socket lock. Acked-by:
-
Gustavo F. Padovan authored
This move some checking code that was in l2cap_sock_connect() to l2cap_chan_connect(). Thus we can invert the lock calls, i.e., call lock_sock() before hci_dev_lock() to avoid a deadlock scenario. Acked-by:
-
Gustavo F. Padovan authored
Another step of remove interrupt context from Bluetooth Core. Use the system workqueue. Acked-by:
-
Gustavo F. Padovan authored
This should simplify Bluetooth core processing a lot. Acked-by:
-
Gustavo F. Padovan authored
As part of the moving on all the Bluetooth processing to Process context. Acked-by:
-
Gustavo F. Padovan authored
It's pointless, we aren't protecting anything since btusb_notify() schedules a work to run, then all it operation happens without protection. If protection is really needed here, we will fix it further. Acked-by:
-
Gustavo F. Padovan authored
Handling hci_conn_hash with RCU make us avoid some locking and disable tasklets. Acked-by:
-
Gustavo F. Padovan authored
Instead of using tasklet_disable() to prevent acess to the channel use, we can use RCU and improve the performance of our code. Acked-by:
-
Gustavo F. Padovan authored
spin lock doesn't fit ok anymore on the new code based on workqueues. Acked-by:
-
Gustavo F. Padovan authored
Now we can sleep in any path inside Bluetooth core, so mutex can make sense here. Acked-by:
-
Gustavo F. Padovan authored
We run everything in the same lock now. The backlog queue is useless now Acked-by:
-
Gustavo F. Padovan authored
We now run everything in process context, so the mutex lock is the best option. But in some places we still need the bh_lock_sock() Acked-by:
-
Gustavo F. Padovan authored
L2CAP timers also need to run in process context. As the works in l2cap are small we are using the system worqueue. Acked-by:
-
Gustavo F. Padovan authored
It doesn't really touch any sensitive information about hdev. So no need to lock here. Acked-by:
-
Gustavo F. Padovan authored
As HCI rx path is now done in process context it makes sense to do all the timer in process context as well. Acked-by:
-
Gustavo F. Padovan authored
Bluetooth rx task runs now in a workqueue, so it a good approach run any timer that share locking with process context code also in a workqueue. Acked-by:
-
Gustavo F. Padovan authored
Now we run everything in HCI in process context, so it's a better idea use mutex instead spin_lock. The macro remains hci_dev_lock() (and I got rid of hci_dev_lock_bh()), of course. Acked-by:
-
Marcel Holtmann authored
Run recv process in workqueue helps a lot with our processing as the recv path will also be in the process context, i.e., now all our tx and rx are in process context. Signed-off-by:
-
