- 19 May, 2021 21 commits
-
-
Colin Ian King authored
The variable 'field' is being assigned a value this is never read, it is being updated in all the following if/else combinations. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-
Deepak R Varma authored
pr_info() messages to log function entry / exit tracing spams the log. Such basic tracing is not necessary and be removed. Signed-off-by:
Deepak R Varma <drv@mailo.com> Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Deepak R Varma authored
It is recommended to use driver model diagnostic macros dev_*() instead of raw printk() or pr_*() since the former ensures that the log messages are always associated with the corresponding device and driver. This also addresses the checkpatch complain for not using KERN_<LEVEL> facility in printk() call. Suggested-by:
Fabio Aiuto <fabioaiuto83@gmail.com> Signed-off-by:
-
Deepak R Varma authored
Mixed case variable names are discouraged and they result in checkpatch script "Avoid CamelCase" warnings. Replace such CamelCase variable names by lower case strings according to the coding style guidelines. Signed-off-by:
-
Deepak R Varma authored
Reformat code comment blocks according to the coding style guidelines. This resolves different checkpatch script WARNINGs around block comments. [hverkuil: fixed up one missed '/* text' comment as reported by Fabio] Suggested-by:
-
Deepak R Varma authored
According to the coding style guidelines, if...else blocks with single instructions do not need enclosing braces. This resolves checkpatch WARNING / CHECK complaints. Signed-off-by:
-
Deepak R Varma authored
Balance braces around the if else blocks as per the code style guidelines. Add braces to branches where it is missing. Resolves checkpatch script CHECK / WARNING feedback messages. Signed-off-by:
-
Martiros Shakhzadyan authored
Fix line split issues and resolve adjacent extra parens. Signed-off-by:
Martiros Shakhzadyan <vrzh@vrzh.net> Signed-off-by:
-
Martiros Shakhzadyan authored
Move the support check to the beginning of the function. Change the logic to avoid multiple nesting blocks. Move 'err' variable assignment outside of the if statement. Remove an unnecessary check whether 'j' is zero. Signed-off-by:
-
Martiros Shakhzadyan authored
Fix alignment style issues and adjacent line length issues in sh_css.c Signed-off-by:
-
Martiros Shakhzadyan authored
Use the ternary operator for conditional variable assignment in create_host_video_pipeline(). Signed-off-by:
-
Martiros Shakhzadyan authored
Remove a superfluous else clause in ia_css_pipe_check_format() Signed-off-by:
-
Martiros Shakhzadyan authored
Remove the remainder of assert() in places where the condition is already handled. Signed-off-by:
-
Martiros Shakhzadyan authored
Fix the remainder of brace coding style issues. Signed-off-by:
-
Martiros Shakhzadyan authored
Remove assert() in places where the condition is already handled. Signed-off-by:
-
Martiros Shakhzadyan authored
Fix brace coding style issues. Signed-off-by:
-
Aline Santana Cordeiro authored
media: staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c Align line break to match with the open parenthesis. Issue detected by checkpatch.pl. Signed-off-by:
Aline Santana Cordeiro <alinesantanacordeiro@gmail.com> Signed-off-by:
-
Aline Santana Cordeiro authored
media: staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_v4l2.c Balance braces around conditional statements. Issue detected by checkpatch.pl. It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code. Signed-off-by:
-
Aline Santana Cordeiro authored
media: staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_subdev.c Balance braces around conditional statements. Issue detected by checkpatch.pl. It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code. Signed-off-by:
-
Aline Santana Cordeiro authored
media: staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_compat_css20.c Balance braces around conditional statements. Issue detected by checkpatch.pl. It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code. Signed-off-by:
-
Aline Santana Cordeiro authored
media: staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_cmd.c Balance braces around conditional statements. Issue detected by checkpatch.pl. It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code. Signed-off-by:
-
- 18 May, 2021 1 commit
-
-
Mauro Carvalho Chehab authored
The right thing to do is to add a new object to the building system when a certain config option is selected, and *not* override them. So, fix obj-$(config) logic at sti makefiles, using "+=", instead of ":=". Signed-off-by:
-
- 11 May, 2021 1 commit
-
-
Mauro Carvalho Chehab authored
The usage of pm_runtime_resume_and_get() removed the need of a temporary integer. So, drop it. Fixes: 59f96244 ("media: exynos4-is: fix pm_runtime_get_sync() usage count") Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
- 10 May, 2021 17 commits
-
-
Aline Santana Cordeiro authored
media: staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.h Format all comments according to the coding-style. Issue detected by checkpatch.pl. Signed-off-by:
-
Aline Santana Cordeiro authored
media: staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_acc.c Format all comments according to the coding-style. Issue detected by checkpatch.pl. Signed-off-by:
-
Aline Santana Cordeiro authored
media: staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp_acc.c Correct identation in block of conditional statements. The conditional statement depends on the results of the macro function "list_for_each_entry()". Signed-off-by:
-
Aline Santana Cordeiro authored
media: staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp_v4l2.c Correct identation in block of conditional statements. The function "v4l2_device_unregister_subdev()" depends on the results of the macro function "list_for_each_entry_safe()". Signed-off-by:
-
Aline Santana Cordeiro authored
Remove unused macro function "v4l2_dev_to_iss_device(dev)". Signed-off-by:
-
Martiros Shakhzadyan authored
Fixed line continuation and parenthesis alignment issues. Signed-off-by:
-
Mitali Borkar authored
Added spaces around '<<' operator to improve readability and meet linux kernel coding style. Reported by checkpatch Signed-off-by:
Mitali Borkar <mitaliborkar810@gmail.com> Signed-off-by:
-
Mitali Borkar authored
Fixed the issue of line should not end with '[' by moving argument from next line to line ending with '[' and made it under 80 characters. Reported by checkpatch. Signed-off-by:
-
Mitali Borkar authored
Removed unnecessary space before tabs to adhere to linux kernel coding style. Reported by checkpatch. Signed-off-by:
-
Mitali Borkar authored
Reduced length of line as it was exceeding 100 characters by removing comments from same line and adding it to previous line. This makes code neater, and meets linux kernel coding style. Reported by checkpatch. Signed-off-by:
-
Mitali Borkar authored
Removed an unnecessary blank line to meet linux kernel coding style. Reported by checkpatch.pl Signed-off-by:
-
Beatriz Martins de Carvalho authored
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch in file atomisp-gc2235.c Signed-off-by:
Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> Acked-by:
-
Martiros Shakhzadyan authored
Fixed a coding style issue. Signed-off-by:
-
Aline Santana Cordeiro authored
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by:
-
Aline Santana Cordeiro authored
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by:
-
Aline Santana Cordeiro authored
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by:
-
Mauro Carvalho Chehab authored
The pm_runtime_get_sync() internally increments the dev->power.usage_count without decrementing it, even on errors. Replace it by the new pm_runtime_resume_and_get(), introduced by: commit dd8088d5 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") in order to properly decrement the usage counter, avoiding a potential PM usage counter leak. As a bonus, as pm_runtime_get_sync() always return 0 on success, the logic can be simplified. Reviewed-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by:
Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by:
-
