- 21 Nov, 2013 3 commits
-
-
Amir Shehata authored
The core of the issue is that the selftest module doesn't sanitize its own API, but it depends on lst utility to do such checks. As a result this issue manifests itself in this particular LU through an assert on an empty group. If the NID is misspelled then an empty group is added. An error output is provided, but if that's never checked in a batch script, as is the case with this issue, then the script will try to add an empty group to a test to run in a batch, and that will cause an assert The fix is two fold. Ensure that lst utility checks that a group is added with at least one node. If not the group is subsequently deleted. And the add_test command would fail, since the group no longer exists. The second fix is to ensure that the kernel module itself sanitizes its own API in this particular case, so that if a different utility is used other than lst to communicate with the selftest kernel module then this error would be caught. This fix looks up the batch and the groups, src and dst, in the ioctl handle and sanitizes that input at this point. If the group looked up either doesn't exist or doesn't have at least one ACTIVE node, then the command fails. NOTE:there are many other cases in the code where the selftest kernel module doesn't check for sanity of the input, but depends totally on the lst module to do such checks. Particularly around length of strings passed in. Thus it is possible to crash the selftest module if someone tries to create another userspace app to communicate with the selftest kernel module without ensuring sanity of the params sent to the kernel module. In effect, it's always assumed that lst is the front end for selftest and no other front end is to be used. Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3093 Lustre-change: http://review.whamcloud.com/6092Signed-off-by:
Amir Shehata <amir.shehata@intel.com> Reviewed-by:
Isaac Huang <he.huang@intel.com> Reviewed-by:
Liang Zhen <liang.zhen@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> [coding style fix of the original patch is splitted into a new one -- PengTao] Signed-off-by:
Peng Tao <bergwolf@gmail.com> Signed-off-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Andreas Dilger authored
In ll_md_blocking_ast() the FID/resource comparison is incorrectly checking for fid_ver() stored in res_id.name[2] instead of name[1] changed since http://review.whamcloud.com/2271 (commit 4f91d5161d00) landed. This does not impact current clients, since name[2] and fid_ver() are always zero, but it could cause problems in the future. In ldlm_cli_enqueue_fini() use ldlm_res_eq() instead of comparing each of the resource fields separately. Use DLDLMRES/PLDLMRES when printing resource names everywhere. Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2901 Lustre-change: http://review.whamcloud.com/6592Signed-off-by:
Lai Siyao <lai.siyao@intel.com> Reviewed-by:
Johann Lombardi <johann.lombardi@intel.com> Signed-off-by:
-
JC Lafoucriere authored
When a client accesses data in a released file, or truncate it, client must trig a restore request. During this restore, the client must not glimpse and must use size from MDT. To bring the "restore is running" information on the client we add a new t_state bit field to mdt_info which will be used to carry transient file state. To memorise this information in the inode we add a new flag LLIF_FILE_RESTORING. Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3432 Lustre-change: http://review.whamcloud.com/6537Signed-off-by:
JC Lafoucriere <jacques-charles.lafoucriere@cea.fr> Reviewed-by:
-
- 20 Nov, 2013 12 commits
-
-
Aldo Iljazi authored
Fixed a few styling issues, particularly: Lines 36,42: Inserted a space before the open paranthesis. Line 50: Removed space between function name and open parenthesis. Lines 56,57: Removed trailing whitespace. lines: 130, 133: Replaced spaces with tabs for identation. Signed-off-by:
Aldo Iljazi <mail@aldo.io> Signed-off-by:
-
Geert Uytterhoeven authored
As of commit 03e361b2 ("mfd: Stop setting refcounting pointers in original mfd_cell arrays"), the "cell" parameter of mfd_add_devices() is "const" again. Hence make all cell data passed to mfd_add_devices() const where possible. Signed-off-by:
Geert Uytterhoeven <geert@linux-m68k.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: devel@driverdev.osuosl.org Signed-off-by:
-
Nandini Hanumanthagowda authored
as per linux coding style trailing statments should not be there at the end of line, instead it should be placed in next line. hence removed that error by moving trailing statement to next line Signed-off-by:
Nandini Hanumanthagowda <nandu.hgowda@gmail.com> Signed-off-by:
-
Nandini Hanumanthagowda authored
as per coding style a space is required after ',' operator in function calls, hence added the missing space after ',' operator in a function call Signed-off-by:
-
Nandini Hanumanthagowda authored
removed all whitespace errors from the code like no space at the start of line and indent the code wherever possible Signed-off-by:
-
Nandini Hanumanthagowda authored
parenthesis is not required in return statement since its not a fucntion, hence remove parentheses to comply with linux coding style Signed-off-by:
-
Nandini Hanumanthagowda authored
indented the code under all functions to remove unnecessary space at start of a line and indent code wherver possible errors thrown from checkpatch script Signed-off-by:
-
Nandini Hanumanthagowda authored
indented all if-else statement blocks to remove checkpatch warnings and errors like indent code wherever possible and no spaces at the start of line Signed-off-by:
-
Nandini Hanumanthagowda authored
aligned the case statements of 'switch' so that the switch and case are on same indentation level to fix the following error. ERROR: switch and case should be at the same indent Signed-off-by:
-
Nandini Hanumanthagowda authored
removed the "unnecessary whitespace before quoted new line" warning reported by checkpatch script Signed-off-by:
-
Nandini Hanumanthagowda authored
fixed following checkpatch error: ERROR: else should follow close brace '}' Signed-off-by:
-
Nandini Hanumanthagowda authored
fixed the following checkpatch error: ERROR: that open brace { should be on the previous line Signed-off-by:
-
- 19 Nov, 2013 25 commits
-
-
Nandini Hanumanthagowda authored
removed unnecessary braces around if-else statement whenever the if-else construct was followed by just single line of code to comply with linux coding style Signed-off-by:
-
Ana Rey authored
Removed innecessary spaces and indentation errors in function definition (including some curly braces wrongly placed and broke up at 80-chars per line). I still see some errors if I run the checkpatch.pl script, but those are not my fault. I'll address them in follow up patches. Signed-off-by:
Ana Rey <anarey@gmail.com> Acked-by:
Pablo Neira Ayuso <pablo@gnumonks.org> Signed-off-by:
-
Eric Skoglund authored
This patch fixes whitespace coding style errors: func () --> func() Signed-of-by:
Eric Skoglund <eric@pagefault.se> Signed-off-by:
-
Eric Skoglund authored
This patch fixes a brace coding style issue. Signed-off-by:
-
Eric Skoglund authored
This patch converts spaces to tabs to conform to the coding style standards. Signed-off-by:
-
SeongJae Park authored
Signed-off-by:
SeongJae Park <sj38.park@gmail.com> Signed-off-by:
-
SeongJae Park authored
Signed-off-by:
-
SeongJae Park authored
Signed-off-by:
-
Eddie Kovsky authored
Reduced checkpatch.pl warnings from 46 to 17 Long strings on lines over 80 characters remain untouched Signed-off-by:
Eddie Kovsky <ewk@edkovsky.org> Acked-by:
Pavel Machek <pavel@ucw.cz> Signed-off-by:
-
Geert Uytterhoeven authored
platform_device.name is "const char *" Signed-off-by:
-
Geert Uytterhoeven authored
usb_driver.name is "const char *" Signed-off-by:
-
Geert Uytterhoeven authored
device_driver.name is "const char *" Signed-off-by:
-
Peng Tao authored
legacy code used to support kernel where struct ctl_table has strategy member. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
legacy code used to support kernel where struct ctl_table has ctl_name member. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
No more references to it. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
It is dead code because we defined CFS_SYSFS_MODULE_PARM. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
we have #define CFS_SYSFS_MODULE_PARM 1 so it is indeed dead code. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
It is only used by server. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
It is only used by user space. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
It is only used by user space. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
