- 09 Jan, 2014 40 commits
-
-
Dan LaManna authored
This is a patch to the r8180_wx.c which fixes various whitespace issues, brace issues, casting/declaration syntax issues, and increases clarity in multi-line return statement. Signed-off-by:
Dan LaManna <dan.lamanna@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Andreas Frembs authored
Staging rtl8192e: Correcting wrong usage of macro in r8192E_phy.c and removing corresponding warning in rtllib_debug.h We fixed in rtllib_debug.h the following checkpatch warning: WARNING: do {} while (0) macros should not be semicolon terminated. After deleting this semicolon we also had to fix the wrong use of this macro in rtl8192e/r8192E_phy.c Signed-off-by:Andreas Frembs <andreas.frembs@studium.uni-erlangen.de> Signed-off-by:
Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de> Signed-off-by:
-
Andreas Frembs authored
In rtllib_debug.h we fixed the following checkpatch error: ERROR: Macros with complex values should be enclosed in parenthesis We fixed this with a do {} while (0), because otherwise the compiler complained. Signed-off-by: -
Andreas Frembs authored
In rtllib_crypt_tkip.c we fixed the following checkpatch error: ERROR: space required after that ',' Signed-off-by:
-
Tim Jester-Pfadt authored
Fixed all space before tab warnings and space before close parenthesis errors on rtl8188e_spec.h Signed-off-by:
Tim Jester-Pfadt <t.jp@gmx.de> Signed-off-by:
-
Tim Jester-Pfadt authored
Fixed indentation coding style issues on rtw_io.c Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Tim Jester-Pfadt authored
Fixed required and prohibited spaces to make rtw_io.h checkpatch.pl clean Signed-off-by:
-
Matthias Schoepe authored
We fixed checkpatch errors of the following type: ERROR: "foo * bar" should be "foo *bar" The error was fixed in the following files of the rtl8192e staging driver: rtllib_softmac.c rtllib_rx.c rtllib_crypt.c rtllib.h There are no functional changes in this patch. Signed-off-by:
-
Masanari Iida authored
This patch fixed "ERROR: trailing whitespace found by checkpatch.pl in r8180_hw.h and r8180_wx.c Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Masanari Iida authored
This patch fixed "Warning: space prohibited before semicolon" found by checkpatch.pl in r8180_core.c and r8180.h Signed-off-by:
-
Wei Yongjun authored
Fixes the following sparse warnings: drivers/staging/silicom/bypasslib/bypass.c:528:12: warning: symbol 'init_lib_module' was not declared. Should it be static? drivers/staging/silicom/bypasslib/bypass.c:534:13: warning: symbol 'cleanup_lib_module' was not declared. Should it be static? Signed-off-by:
Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by:
-
Josh Triplett authored
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __DATE__ and __TIME__, which make the build non-deterministic. Signed-off-by:
Josh Triplett <josh@joshtriplett.org> Acked-by:
-
Greg Kroah-Hartman authored
These files aren't being built into anything, so remove them. Signed-off-by: -
Greg Kroah-Hartman authored
Also move the variable definition into the .h file, so it doesn't have to be declared in each .c file individually, which is crazy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor stuff, just formatting. Signed-off-by: -
Greg Kroah-Hartman authored
These two calls were not needed, they were just debugging stuff. Signed-off-by: -
Greg Kroah-Hartman authored
Just use KBUILD_MODNAME, don't try to hand-roll the same thing with odd logic. Signed-off-by: -
Greg Kroah-Hartman authored
It was just a call to printk() so make that instead. Signed-off-by: -
Greg Kroah-Hartman authored
It didn't do anything, and no one called it, so remove it. Signed-off-by: -
Greg Kroah-Hartman authored
It didn't do anything, so just remove it, it's useless. Signed-off-by: -
Greg Kroah-Hartman authored
We have an in-kernel tracing function, use that instead if you really need to figure out when functions are called and exited. Signed-off-by: -
Greg Kroah-Hartman authored
We have an in-kernel tracing function, please use that instead of custom macros. Signed-off-by: -
Greg Kroah-Hartman authored
DBG_FUNC() didn't even do anything, so no need for it to be present in the code at all. Signed-off-by: -
Greg Kroah-Hartman authored
These macros were commented out, so just delete them as they are not used anywhere. Signed-off-by: -
Greg Kroah-Hartman authored
This string makes no sense now that the driver is in the kernel, so remove it. Signed-off-by: -
Josh Triplett authored
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __TIME__, which makes the build non-deterministic. (And, without __DATE__, __TIME__ provided little useful information to begin with.) Signed-off-by:
-
Josh Triplett authored
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __DATE__ and __TIME__, which make the build non-deterministic. Signed-off-by:
-
Valentina Manea authored
As of Matt Mooney's major refactoring in 2011, usbip port option was left out. Add support for this option in a manner similar to the old implementation. Sample output: Imported USB devices ==================== Port 00: <Port in Use> at Full Speed(12Mbps) unknown vendor : unknown product (1687:6211) 2-1 -> usbip://192.168.122.152:3240/1-1 -> remote bus/dev 001/002 Signed-off-by:Valentina Manea <valentina.manea.m@gmail.com> Reviewed-by:
Ilija Hadzic <ihadzic@research.bell-labs.com> Signed-off-by:
-
Larry Finger authored
Sparse lists the following: CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101: expected unsigned int *ipxNetAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101: got restricted __be32 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123: expected unsigned short *ipxSocketAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99: expected unsigned int *ipxNetAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99: got restricted __be32 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101: expected unsigned int *ipxNetAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101: got restricted __be32 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121: expected unsigned short *ipxSocketAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99: expected unsigned int *ipxNetAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99: got restricted __be32 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83: expected unsigned short *network drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83: expected unsigned short *network drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83: expected unsigned short *network drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83: expected unsigned short *network drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57: warning: incorrect type in assignment (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57: expected unsigned short [unsigned] [short] <noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57: got restricted __be16 [usertype] <noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:92:23: warning: restricted __be16 degrades to integer drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95: expected unsigned short *sid drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112: expected unsigned short *sid drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84: expected unsigned int [unsigned] [usertype] len drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84: got restricted __be16 [usertype] payload_len drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110: expected int [signed] len drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110: got restricted __be16 [usertype] payload_len drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1148:70: warning: restricted __be16 degrades to integer drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70: warning: invalid assignment: |= drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70: left side has type unsigned short drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70: right side has type restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16 Signed-off-by:
-
Larry Finger authored
Sparse reports the following warning: CHECK drivers/staging/rtl8188eu/core/rtw_xmit.c drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23: warning: incorrect type in initializer (different base types) drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23: expected unsigned short [usertype] *fctrl drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23: got restricted __le16 *<noident> Signed-off-by:
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8188eu/core/rtw_pwrctrl.c drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:525:6: warning: symbol 'rtw_free_pwrctrl_priv' was not declared. Should it be static? That routine is not used and has been deleted. Signed-off-by:
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8188eu/core/rtw_sta_mgt.c drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:152:6: warning: symbol 'rtw_mfree_all_stainfo' was not declared. Should it be static? Signed-off-by:
-
Larry Finger authored
There are two different enum statements that have been combined. Signed-off-by:
-
Larry Finger authored
This driver only handles RTL8188EU with USB interface, thus several hardware defines and macros can be removed. Signed-off-by:
-
Larry Finger authored
This driver only works with the USB bus. Accordingly, enum odm_interface_def can be removed along with all code that uses ODM_ITRF_XXX, where XXX is not USB. In enum odm_ic_type, only ODM_RTL8188E is used. Remove the enum, all references to the others, and define the needed value. Signed-off-by:
-
Larry Finger authored
This header contains a number of routines that do not to be available globally. Once this change was made, a number of the routines were not used, and could be removed. Signed-off-by:
-
Larry Finger authored
This member of struct odm_dm_struct is always set to ODM_RTL8188E for this driver. Accordingly, the code can be simplified. A number of routines now are no longer needed and are deleted. Signed-off-by:
-
Larry Finger authored
This member of struct odm_dm_struct is always set to ODM_CE in this driver. As a result, a number of switch and if statements can be simplified. In addition, a number of routines are no longer used and can be removed. Signed-off-by:
-
Larry Finger authored
This patch removes the following: odm_DynamicTxPowerAP odm_RSSIMonitorCheckMP odm_RSSIMonitorCheckAP odm_TXPowerTrackingCheckMP odm_TXPowerTrackingCheckAP odm_SwAntDivInit ODM_SwAntDivChkPerPktRssi odm_SwAntDivChkAntSwitch ODM_SwAntDivRestAfterLink dm_GlobalAdapterCheck odm_dtc Signed-off-by:
-
Larry Finger authored
This batch includes ODM_StartWorkItem ODM_StopWorkItem ODM_FreeWorkItem ODM_AcquireSpinLoc ODM_ReleaseSpinLock ODM_ReleaseTimer ODM_ReleaseAllTimers Signed-off-by:
-
