Skip to content

L
linux
Switch branch/tag
  1. 29 Oct, 2007 8 commits
    • Tejun Heo's avatar
      libata: no need to speed down if already at PIO0 · 4fb4615b
      Tejun Heo authored 
      After reset, transfer mode is always PIO0 regardless of
dev->xfer_mask.  Check dev->pio_mode before trying to slow down after
configuration failure.  This prevents bogus speed down before device
is actually configured.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      4fb4615b
    • Tejun Heo's avatar
      libata: relocate forcing PIO0 on reset · cdeab114
      Tejun Heo authored 
      Forcing PIO0 on reset was done inside ata_bus_softreset(), which is a
bit out of place as it should be applied to all resets - hard, soft
and implementation which don't use ata_bus_softreset().  Relocate it
such that...

* For new EH, it's done in ata_eh_reset() before calling prereset.

* For old EH, it's done before calling ap->ops->phy_reset() in
  ata_bus_probe().

This makes PIO0 forced after all resets.  Another difference is that
reset itself is done after PIO0 is forced.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      cdeab114
    • Frank Lichtenheld's avatar
      pata_ns87415: define SUPERIO_IDE_MAX_RETRIES · a9efacba
      Frank Lichtenheld authored 
      Code copied from drivers/ide/pci/ns87415.c uses this, so copy the
definition from there as well.

Fixes the following build error:
  CC [M]  drivers/ata/pata_ns87415.o
drivers/ata/pata_ns87415.c: In function ‘ns87560_read_buggy’:
drivers/ata/pata_ns87415.c:228: error: ‘SUPERIO_IDE_MAX_RETRIES’ undeclared (first use in this function)
drivers/ata/pata_ns87415.c:228: error: (Each undeclared identifier is reported only once
drivers/ata/pata_ns87415.c:228: error: for each function it appears in.)
Signed-off-by: default avatarFrank Lichtenheld <frank@lichtenheld.de>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      a9efacba
    • Jeff Garzik's avatar
      [libata] Address some checkpatch-spotted issues · 5796d1c4
      Jeff Garzik authored 
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      5796d1c4
    • Jeff Garzik's avatar
      [libata] fix 'if(' and similar areas that lack whitespace · b447916e
      Jeff Garzik authored 
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      b447916e
    • Tejun Heo's avatar
      libata: implement ata_wait_after_reset() · 88ff6eaf
      Tejun Heo authored 
      On certain device/controller combination, 0xff status is asserted
after reset and doesn't get cleared during 150ms post-reset wait.  As
0xff status is interpreted as no device (for good reasons), this can
lead to misdetection on such cases.

This patch implements ata_wait_after_reset() which replaces the 150ms
sleep and waits upto ATA_TMOUT_FF_WAIT if status is 0xff.
ATA_TMOUT_FF_WAIT is currently 800ms which is enough for
HHD424020F7SV00 to get detected but not enough for Quantum GoVault
drive which is known to take upto 2s.

Without parallel probing, spending 2s on 0xff port would incur too
much delay on ata_piix's which use 0xff to indicate empty port and
doesn't have SCR register, so GoVault needs to wait till parallel
probing.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      88ff6eaf
    • Tejun Heo's avatar
      libata: track SLEEP state and issue SRST to wake it up · 054a5fba
      Tejun Heo authored 
      ATA devices in SLEEP mode don't respond to any commands.  SRST is
necessary to wake it up.  Till now, when a command is issued to a
device in SLEEP mode, the command times out, which makes EH reset the
device and retry the command after that, causing a long delay.

This patch makes libata track SLEEP state and issue SRST automatically
if a command is about to be issued to a device in SLEEP.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Cc: Bruce Allen <ballen@gravity.phys.uwm.edu>
Cc: Andrew Paprocki <andrew@ishiboo.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      054a5fba
    • Tejun Heo's avatar
      libata: relocate and fix post-command processing · 4dbfa39b
      Tejun Heo authored 
      Some commands need post-processing after successful completion.  This
was done in ata_scsi_qc_complete() till now but this has the following
problems.

* Post-command processing gets executed when qc is completed from EH.
  Some qc's are retried from EH with zero err_mask and thus triggers
  unnecessary/incorrect post-command processing.

* Command post processing doesn't belong to SAT layer.

* Link-wide revalidation was scheduled where device revalidation
  suffices.

This patch moves post-command processing to success completion path of
ata_qc_complete() which is travelled iff the command is going to be
completed without passing through EH and updates post-command
processing such that device-specific action is used.  While at it,
restructure code a bit for readability.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      4dbfa39b
  3. 28 Oct, 2007 8 commits
  5. 27 Oct, 2007 24 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7