- 14 Dec, 2005 18 commits
-
-
Olaf Rempel authored
[BRIDGE]: recompute features when adding a new device We must recompute bridge features everytime the list of underlying devices changes, or we might end up with features that are not supported by all devices (eg. NETIF_F_TSO) This patch adds the missing recompute when adding a device to the bridge. Signed-off-by:
Olaf Rempel <razzor@kopf-tisch.de> Signed-off-by:
David S. Miller <davem@davemloft.net> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Jay Vosburgh authored
This should resolve http://bugzilla.kernel.org/show_bug.cgi?id=5519 The current feature computation loses bits that it doesn't know about, resulting in an inability to add VLANs and possibly other havoc. Rewrote function to preserve bits it doesn't know about, remove an unneeded state variable, and simplify the code. Signed-off-by:
Jay Vosburgh <fubar@us.ibm.com> Signed-off-by:
John W. Linville <linville@tuxdriver.com> Signed-off-by:
-
Dave Jones authored
[AGPGART] Fix serverworks TLB flush. Go back to what 2.4 kernels used to do here, as if this hits, the kernel just hangs indefinitly. Actually an improvement over 2.4 - we now break; out of the loop instead of just printing messages on timeouts. Signed-off-by:
Dave Jones <davej@redhat.com> Signed-off-by:
-
Igor Popik authored
The i82365 driver does not release all the resources when the device is not found. This can cause an oops when reading /proc/ioports after module unload (e.g. bug #5657). Signed-off-by:
Igor Popik <igor.popik@gmail.com> Signed-off-by:
Dominik Brodowski <linux@dominikbrodowski.net> Signed-off-by:
-
John W. Linville authored
Modules: NM256 driver The current snd-nm256 driver can cause Dell Latitude CSx laptops to lock-up during module (un)load. I have isolated this to the writes to the control port register at offset 0x6cc which were not already protected by the existing reset_workaround. I tried grouping these writes with the existing reset_workaround clause, but that caused the driver to have (un)load problems on the Dell Latitude LS laptops. So, I have implemented a reset_workaround_2 clause (please feel free to suggest a better name!) to cover this situation and added a quirk entry for the CSx laptops. Signed-off-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
-
Michael Krufky authored
- Enable tda9887 on the following cx88 boards: pcHDTV 3000 FusionHDTV3 Gold-T - This ensures that analog NTSC video will function properly, without this patch, the tuner may appear to be broken. Signed-off-by:
Michael Krufky <mkrufky@m1k.net> Signed-off-by:
Mauro Carvalho Chehab <mchehab@brturbo.com.br> Signed-off-by:
-
Ricardo Cerqueira authored
- The Pinnacle PCTV Stereo needs tda9887 port2 set to 1 - Without this patch, mt20xx tuner is not detected and the board doesn't tune. Signed-off-by:
Ricardo Cerqueira <v4l@cerqueira.org> Signed-off-by:
-
Oleg Drokin authored
Fix a 32 bit integer overflow in invalidate_inode_pages2_range. Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org> Signed-off-by:
-
Thomas Renninger authored
[ACPI] fix HP nx8220 boot hang regression This patch reverts the acpi_bus_find_driver() return value check that came in via the PCI tree via 3fb02738 [PATCH] acpi bridge hotadd: Allow ACPI .add and .start operations to be done independently This particular change broke booting of some HP/Compaq laptops unless acpi=noirq is used. http://bugzilla.kernel.org/show_bug.cgi?id=5221 https://bugzilla.novell.com/show_bug.cgi?id=116763Signed-off-by:
Thomas Renninger <trenn@suse.de> Cc: Rajesh Shah <rajesh.shah@intel.com> Signed-off-by:
Len Brown <len.brown@intel.com> Signed-off-by:
-
Carlos Silva authored
BUDGET_CI card depends on STV0297 demodulator. This patch solves a DVB driver compile error introduced in 2.6.14 Signed-off-by:
Johannes Stezenbach <js@linuxtv.org> Signed-off-by:
-
Daniel Drake authored
Commit f549d6c1 introduced a generic fallback for security xattrs, but appears to include a subtle bug. Gentoo users with kernels with selinux compiled in, and coreutils compiled with acl support, noticed that they could not copy files on tmpfs using 'cp'. cp (compiled with acl support) copies the file, lists the extended attributes on the old file, copies them all to the new file, and then exits. However the listxattr() calls were failing with this odd behaviour: llistxattr("a.out", (nil), 0) = 17 llistxattr("a.out", 0x7fffff8c6cb0, 17) = -1 ERANGE (Numerical result out of range) I believe this is a simple problem in the logic used to check the buffer sizes; if the user sends a buffer the exact size of the data, then its ok :) This change solves the problem. More info can be found at http://bugs.gentoo.org/113138Signed-off-by:
Daniel Drake <dsd@gentoo.org> Acked-by:
James Morris <jmorris@namei.org> Acked-by:
Stephen Smalley <sds@tycho.nsa.gov> Signed-off-by:
-
Thomas Graf authored
The receive path for fib_lookup netlink messages is lacking sanity checks for header and payload and is thus vulnerable to malformed netlink messages causing illegal memory references. Signed-off-by:
Thomas Graf <tgraf@suug.ch> Signed-off-by:
-
Daniel Drake authored
This patch combines commit 0b360adb (make setkeys root-only) and commit e3f17f0f (only disallow setting by users) Because people can play games reprogramming keys and leaving traps for the next user of the console. Signed-off-by:
-
Oliver Neukum authored
the scsi layer now uses very short sg lists. This breaks the microtek driver. Here is a patch fixes this and some other issues. Signed-off-by:
Oliver Neukum <oliver@neukum.name> Signed-off-by:
-
David Gibson authored
set_page_dirty() will not cope with being handed a page * which is part of a compound page, but not the master page in that compound page. This case can occur via access_process_vm() if you attemp to write to another process's hugepage memory area using ptrace() (causing an oops or hang). This patch fixes the bug by only calling set_page_dirty() from access_process_vm() if the page is not a compound page. We already use a similar fix in bio_set_pages_dirty() for the case of direct io to hugepages. Signed-off-by:
David Gibson <david@gibson.dropbear.id.au> Acked-by:
William Irwin <wli@holomorphy.com> Signed-off-by:
Chris Wright <chrisw@osdl.org> Signed-off-by:
-
Adrian Bunk authored
The Coverity checker spotted this obvious use-after-free caused by a wrong order of the cleanups. Signed-off-by:
Adrian Bunk <bunk@stusta.de> Acked-by:
Roland Dreier <rolandd@cisco.com> Signed-off-by:
-
Adrian Bunk authored
The Coverity checker spotted this obvious use-after-free Signed-off-by:
Markus Lidel <Markus.Lidel@shadowconnect.com> Signed-off-by:
-
Adrian Bunk authored
The Coverity checker spotted this obvious use-after-free Signed-off-by:
Mark Salyzyn <mark_salyzyn@adaptec.com> Signed-off-by:
-
- 24 Nov, 2005 22 commits
-
-
Chris Wright authored
-
Jean Delvare authored
Fix a bug where setting the low fan speed limits will not work if no data was ever read through the sysfs interface and the fan clock dividers have not been explicitely set yet either. The reason is that data->fan_div[nr] may currently be used before it is initialized from the chip register values. The fix is to explicitely initialize data->fan_div[nr] before using it. Bug reported, and fix tested, by Nicolas Mailhot. Signed-off-by:
Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
Jean Delvare authored
Fix the lm78 VID reading, which I accidentally broke while making this driver use the common vid_from_reg function rather than reimplementing its own in 2.6.14-rc1. I'm not proud of it, trust me. Signed-off-by:
-
Yuan Mu authored
Add SENSORS_LIMIT in store VCore limit functions. This fixes a potential u8 overflow on out-of-range user input. Signed-off-by:
-
Adrian Bunk authored
It's not good if caller and callee disagree regarding the type of the arguments. In this case, this could cause problems on 64bit architectures. Signed-off-by:
Armin Schindler <armin@melware.de> Signed-off-by:
-
Andi Kleen authored
Force correct address space size for MTRR on some 64bit Intel Xeons They report 40bit, but only have 36bits of physical address space. This caused problems with setting up the correct masks for MTRR, resulting in incorrect MTRRs. CPUID workaround for steppings 0F33h(supporting x86) and 0F34h(supporting x86 and EM64T). Detail info can be found at: http://download.intel.com/design/Xeon/specupdt/30240216.pdf http://download.intel.com/design/Pentium4/specupdt/30235221.pdf Signed-off-by: Shaohua Li<shaohua.li@intel.com> Signed-off-by:
Andi Kleen <ak@suse.de> Signed-off-by:
-
YOSHIFUJI Hideaki authored
Based on suggestion from Masahide Nakamura <nakam@linux-ipv6.org>. Signed-off-by:
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by:
-
Ville Nuorvala authored
Signed-off-by:
-
YOSHIFUJI Hideaki authored
Signed-off-by:
-
Harald Welte authored
Since we've converted the ftp/irc/tftp helpers to use the new module_parm_array() some time ago, we ware accidentially using signed data types - thus preventing those modules from being used on ports >= 32768. This patch fixes it by using 'ushort' module parameters. Thanks to Jan Nijs for reporting this bug. Signed-off-by:
Harald Welte <laforge@netfilter.org> Signed-off-by:
-
Vlad Drukker authored
Some devices (e.g. Qlogic iSCSI HBA hardware like QLA4010 up to firmware 3.0.0.4) initiates TCP with SYN and PUSH flags set. The Linux TCP/IP stack deals fine with that, but the connection tracking code doesn't. This patch alters TCP connection tracking to accept SYN+PUSH as a valid flag combination. Signed-off-by:
Vlad Drukker <vlad@storewiz.com> Signed-off-by:
-
Krzysztof Piotr Oledzki authored
This patch fixes an userspace triggered oops. If there is no ICMP_ID info the reference to attr will be NULL. Signed-off-by:
Krzysztof Piotr Oledzki <ole@ans.pl> Signed-off-by:
Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by:
-
Philip Craig authored
The reply tuple of the PNS->PAC expectation was using the wrong call id. So we had the following situation: - PNS behind NAT firewall - PNS call id requires NATing - PNS->PAC gre packet arrives first then the PNS->PAC expectation is matched, and the other expectation is deleted, but the PAC->PNS gre packets do not match the gre conntrack because the call id is wrong. We also cannot use ip_nat_follow_master(). Signed-off-by:
Philip Craig <philipc@snapgear.com> Signed-off-by:
-
Harald Welte authored
This fixes an oops triggered from userspace. If we don't pass information about the private protocol info, the reference to attr will be NULL. This is likely to happen in update messages. Signed-off-by:
-
Yasuyuki Kozakai authored
Signed-off-by:
Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp> Signed-off-by:
-
Harald Welte authored
With the new nf_queue generalization in 2.6.14, we've introduced a bug that causes an oops as soon as a packet is queued but no queue handler registered. This patch fixes it. Signed-off-by:
-
Rusty Rusty authored
The unknown protocol is used as a fallback when a protocol isn't known. Hence we cannot handle it failing, so don't set ".me". It's OK, since we only grab a reference from within the same module (iptable_nat.ko), so we never take the module refcount from 0 to 1. Also, remove the "protocol is NULL" test: it's never NULL. Signed-off-by:
Rusty Rusty <rusty@rustcorp.com.au> Signed-off-by:
-
Harald Welte authored
This endianness bug slipped through while changing the 'gre.key' field in the conntrack tuple from 32bit to 16bit. None of my tests caught the problem, since the linux pptp client always has '0' as call id / gre key. Only windows clients actually trigger the bug. Signed-off-by:
-
Krzysztof Halasa authored
As we are currently unable to fix the problem with carrier and protocol state signaling in net core I've to disable netif_carrier_off() calls used by WAN protocol drivers. The attached patch should make them working again. The remaining netif_carrier_*() calls in hdlc_fr.c are fine as they don't touch the physical device. Signed-off-by:
Krzysztof Halasa <khc@pm.waw.pl> Signed-off-by:
-
J. Bruce Fields authored
The patch http://linux.bkbits.net:8080/linux-2.6/diffs/fs/locks.c@1.70??nav=index.html introduced a pretty nasty memory leak in the lease code. When freeing the lease, the code in locks_delete_lock() will correctly clean up the fasync queue, but when we return to fcntl_setlease(), the freed fasync entry will be reinstated. This patch ensures that we skip the call to fasync_helper() when we're freeing up the lease. Signed-off-by:
J. Bruce Fields <bfields@fieldses.org> Signed-off-by:
Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by:
-
Peter Osterlund authored
There is an old bug in the pkt_count_states() function that causes stack corruption. When compiling with gcc 3.x or 2.x it is harmless, but gcc 4 allocates local variables differently, which makes the bug visible. Signed-off-by:
Peter Osterlund <petero2@telia.com> Cc: <stable@kernel.org> Signed-off-by:
-
Takashi Iwai authored
Fixed the soft lockup of ALSA rtc-timer due to the wrong irq handling in rtc_control(). The call of rtc_control() can be atomic. Signed-off-by:
-
