Commits · 51ba08b26d1e14d7ce332141e244b34b896d98f3 · Kirill Smelkov / linux

27 Jun, 2004 40 commits

[PATCH] anon_vma list locking bug · 51ba08b2

Hugh Dickins authored Jun 26, 2004

Vladimir Saveliev reported anon_vma_unlink list_del BUG (LKML 24 June). 
His testing is still in progress, but we believe it comes from a nasty
locking deficiency I introduced in 2.6.7's anon_vma_prepare.

Andrea's original anon_vma_prepare was fine, it needed no anon_vma lock
because it was always linking a freshly allocated structure; but my
find_mergeable enhancement let it adopt a neighbouring anon_vma, which of
course needs locking against a racing linkage from another mm - which the
earlier adjust_vma fix seems to have made more likely.

Does anon_vma->lock nest inside or outside page_table_lock?  Inside, but
that's not obvious without a lock ordering list: instead of listing the
order here, update the list in filemap.c; but a separate patch because
that's less urgent and more likely to get wrong or provoke controversy.

(Could do it with anon_vma lock after dropping page_table_lock, but a long
comment explaining why some code is safe suggests it's not.)
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

51ba08b2

[PATCH] drivers/char/ipmi/ipmi_si_intf.c warnings · f233215c

Luiz Capitulino authored Jun 26, 2004

drivers/char/ipmi/ipmi_si_intf.c: In function `acpi_gpe_irq_setup':
drivers/char/ipmi/ipmi_si_intf.c:1173: warning: passing arg 4 of `acpi_install_gpe_handler' from incompatible pointer type
drivers/char/ipmi/ipmi_si_intf.c: In function `acpi_gpe_irq_cleanup':
drivers/char/ipmi/ipmi_si_intf.c:1193: warning: passing arg 3 of `acpi_remove_gpe_handler' from incompatible pointer type
Signed-off-by: Luiz Capitulino <lcapitulino@prefeitura.sp.gov.br>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

f233215c

[PATCH] swsusp.S: meaningful assembly labels · 90f2a140

Pavel Machek authored Jun 26, 2004

This introduces meaningfull labels instead of .L1234, meaning code is
readable, kills alignment where unneccessary, and kills TLB flush that was
only pure paranoia (and slows it down a lot on emulated systems).
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

90f2a140

[PATCH] Laptop mode control script improvements · 203492fb

Bart Samwel authored Jun 26, 2004

From: Herve Eychenne <rv@eychenne.org>

Clean up the script. This also makes it two times faster. (Thanks to
Herve Eychenne.)

- moved variable definitions to the top, for easier configuration
- the script contains bashisms, so make it /bin/bash
- use sed -e'...' -e '...' instead of sed | sed 
- avoid subshells: () changed to {}
- various other minor optimizations and improvements
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

203492fb

[PATCH] inodes_stat.nr_unused fix · 33270282

Andrew Morton authored Jun 26, 2004

__sync_single_inode() is forgetting to increment inodes_stat.nr_unused when
moving a previously-dirty inode onto the inode_unused list.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

33270282

[PATCH] laptop-mode documentation update · a45e3c5c

Bart Samwel authored Jun 26, 2004

The laptop mode docs don't say that no kernel configuration changes are
needed to use laptop mode. That's caused some people to look for the
option. This patch makes the doc explicitly mention the lack of an option.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

a45e3c5c

[PATCH] ppp_generic.c get_filter made conditional · 9f763dbd

Paul Fulghum authored Jun 26, 2004

Add #ifdef CONFIG_PPP_FILTER around get_filter implementation which is only
used when this option is enabled.  This prevents compiler warning (unused
function) when CONFIG_PPP_FILTER is not defined.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

9f763dbd

[PATCH] missing semicolon in 2.6.7 VIODASD driver · dc2b051f

David Howells authored Jun 26, 2004

There appears to be a missing semicolon in the VIODASD driver in 2.6.7.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

dc2b051f

[PATCH] fix NUMA boundaray between ZONE_NORMAL and HIGHMEM · 9278aa39

Martin J. Bligh authored Jun 26, 2004

From: Andy Whitcroft <apw@shadowen.org>

This patch eliminates the false hole which can form between ZONE_NORMAL and
ZONE_HIGHMEM.  This is most easily seen when 4g/4g split is enabled, but
it's always broken, and we just happen not to hit it most of the time.
Basically, the patch changes the allocation of the numa remaps regions (the
source of the holes) such that they officially fall within VMALLOC space,
where they belong.

Tested in -mjb for a couple of months, and again against 2.6.7-mm1.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Martin J. Bligh <mbligh@aracnet.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

9278aa39

[PATCH] Fix direct I/O into hugetlb page · 4736ba03

Kenneth W. Chen authored Jun 26, 2004

Hit a kernel oops on 2.6.7 kernel when doing direct I/O to hugetlb page.

The destructor of compound page was moved into page->mapping since 2.6.6.
It got interfered with set_page_dirty() for hugetlb page: an O_DIRECT read
into first tail page of the compound page will fool set_page_dirty() to
deference page->mapping->a_ops and then kernel oops. Patch to fix the
oops. We do just like what bio_set_pages_dirty() does.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

4736ba03

[PATCH] crc: use it in AX.25 drivers · 081681b6

Andrey Panin authored Jun 26, 2004

This patch makes AX.25 drivers use common crc16 code.
Signed-off-by: Andrey Panin <pazke@donpac.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

081681b6

[PATCH] crc: use it in ISDN drivers · fadd23d8

Andrey Panin authored Jun 26, 2004

This patch makes various ISDN drivers use common crc16 code.
Signed-off-by: Andrey Panin <pazke@donpac.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

fadd23d8

[PATCH] crc: use it in IRDA drivers · a0c09d01

Andrey Panin authored Jun 26, 2004

This patch makes IRDA subsystem use common crc16 code.
Signed-off-by: Andrey Panin <pazke@donpac.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

a0c09d01

[PATCH] crc: use it in async PPP driver · b71671f8

Andrey Panin authored Jun 26, 2004

This patch makes async PPP driver use common crc16 code.
Signed-off-by: Andrey Panin <pazke@donpac.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

b71671f8

[PATCH] crc: add common CRC16 module · 153a716d

Andrey Panin authored Jun 26, 2004

Currently we have 8 copies of CRC16 calculation table in different device
drivers, this patch creates common crc16.c module to replace them.
Signed-off-by: Andrey Panin <pazke@donpac.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

153a716d

[PATCH] Permit root to choose vfat policy to UTF8 · 9f829691

Arjan van de Ven authored Jun 26, 2004

Right now the kernel detects the sysadmin trying to set the iocharset of
vfat to UTF8 and prevents this with an error.  While I can see that this is
not recommended, enforcing this is policy that probably doesn't belong in
the kernel.  The patch below makes this situation a warning and a
recommendation instead of a strong blockage.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=126641

is an example of a sysadmin disliking this policy enforcement.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

9f829691

[PATCH] tidy up the identify_cpu() output · 874244f7

Jesper Juhl authored Jun 26, 2004

Here's a patch to line up the "CPU: After * identify, caps:" messages
produced by printk's in arch/i386/kernel/cpu/common.c
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

874244f7

[PATCH] SELinux: fix build with CONFIG_SECURITY_NETWORK=n · e903c6f9

Stephen D. Smalley authored Jun 26, 2004

SELinux should just drop out the socket and netfilter hooks when that is
disabled.

The problem was introduced because of the fine-grained netlink patches,
which made the selinux_netlink_send/recv hook functions depend on
CONFIG_SECURITY_NETWORK but the netlink_send/recv hooks themselves are not
dependent on it.

Need to move selinux_netlink_send/recv back out of the conditional block,
and provide a static inline stub for selinux_nlmsg_perm if
CONFIG_SECURITY_NETWORK is not defined.
Signed-off-by: Stephen Smalley <sds@epoch.ncsc.mil>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

e903c6f9

[PATCH] i386: uninline memmove · ec3c438e

Andrew Morton authored Jun 26, 2004

Using current gcc CVS I hit a piece of code in which the compiler was emitting
a memmove() call.  The kernel link failed.

Uninline it.

Also, move the memcpy and memset exports into memcpy.c.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

ec3c438e